All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: Markus Armbruster <armbru@redhat.com>
Cc: agraf@suse.de, mst@redhat.com, qemu-devel@nongnu.org,
	lcapitulino@redhat.com, blauwirbel@gmail.com, michael@walle.cc,
	qemu-ppc@nongnu.org, andreas.faerber@web.de
Subject: Re: [Qemu-devel] [PATCH 2/6] Remove monitor.c dependency on CONFIG_I8259
Date: Wed, 1 Apr 2015 11:40:13 +1100	[thread overview]
Message-ID: <20150401004013.GA23677@voom.redhat.com> (raw)
In-Reply-To: <87k2xxa3qv.fsf@blackfin.pond.sub.org>

[-- Attachment #1: Type: text/plain, Size: 1886 bytes --]

On Tue, Mar 31, 2015 at 11:57:28AM +0200, Markus Armbruster wrote:
> David Gibson <david@gibson.dropbear.id.au> writes:
> 
> > On Mon, Mar 30, 2015 at 10:37:45AM +0200, Markus Armbruster wrote:
> [...]
> >> This adds "info irq" and "info pic" to the targets that didn't have them
> >> before, implemented by i8259.c's hmp_info_pic() and hmp_info_irq().
> >> They do nothing unless the machine has an "isa-i8259" device.
> >> 
> >> Cases:
> >> 
> >> 1. If the machine has one, and it's the only interrupt controller, the
> >> commands work as advertized.
> >> 
> >> 2. If the machine doesn't have one, the commands are empty promises.
> >> 
> >> 3. If the machine has one, but it's not the only interrupt controller,
> >> the commands confidently claim the i8259 is all there is.
> >> Misinformation.
> >> 
> >> Cases 2 and 3 are common, case 1 is rare.
> >> 
> >> We can:
> >> 
> >> A. Fix the commands to cover all interrupt controllers.
> >> 
> >> B. Fix them to warn the user about missing interrupt controllers.
> >> 
> >>    We can approximate this by warning always, because it's almost never
> >>    the only interrupt controller anyway :)
> >> 
> >> C. Rip 'em both out and be done with it.
> >> 
> >> D. Do nothing.
> >> 
> >> E. Provide them as is on all targets.
> >> 
> >>    Spread the badness fairly.
> >> 
> >> I vote for C or B.  A seems not worthwhile.
> >
> > I'd love to do C, if we can get confirmation that no-one's really
> > using the existing HMP commands.  That would make a bunch of things
> > simpler.
> 
> I gave it a shot, let's see how people react.

Heh, you beat me to it.

Thanks for the detailed analysis.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2015-04-01  1:51 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-06  4:18 [Qemu-devel] [PATCH 0/6] Clean up ISA dependencies so we make ISA optional to build David Gibson
2015-03-06  4:18 ` [Qemu-devel] [PATCH 1/6] Split serial-isa into its own config option David Gibson
2015-03-30  7:28   ` Markus Armbruster
2015-03-31  5:36     ` David Gibson
2015-03-06  4:18 ` [Qemu-devel] [PATCH 2/6] Remove monitor.c dependency on CONFIG_I8259 David Gibson
2015-03-30  7:49   ` Markus Armbruster
2015-03-30  8:37     ` Markus Armbruster
2015-03-31  0:05       ` David Gibson
2015-03-31  9:57         ` Markus Armbruster
2015-04-01  0:40           ` David Gibson [this message]
2015-03-30 21:41   ` Andreas Färber
2015-03-31 10:07   ` Peter Maydell
2015-03-06  4:18 ` [Qemu-devel] [PATCH 3/6] pc: Use MachineClass callbacks for "irq" and "pic" hmp commands David Gibson
2015-03-30 21:47   ` Andreas Färber
2015-03-06  4:18 ` [Qemu-devel] [PATCH 4/6] target-ppc: Convert PReP to machine class David Gibson
2015-03-30 21:33   ` Andreas Färber
2015-03-31  5:40     ` David Gibson
2015-03-06  4:18 ` [Qemu-devel] [PATCH 5/6] prep: Use MachineClass callbacks for "irq" and "pic" hmp commands David Gibson
2015-03-30 21:25   ` Andreas Färber
2015-03-06  4:18 ` [Qemu-devel] [PATCH 6/6] Allow ISA bus to be configured out David Gibson
2015-03-06 11:41 ` [Qemu-devel] [PATCH 0/6] Clean up ISA dependencies so we make ISA optional to build Alexander Graf
2015-03-10 14:20 ` Michael S. Tsirkin
2015-03-10 14:56   ` Luiz Capitulino
2015-03-30  2:41     ` David Gibson
2015-03-30  8:48       ` Markus Armbruster
2015-03-30 17:45       ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150401004013.GA23677@voom.redhat.com \
    --to=david@gibson.dropbear.id.au \
    --cc=agraf@suse.de \
    --cc=andreas.faerber@web.de \
    --cc=armbru@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=lcapitulino@redhat.com \
    --cc=michael@walle.cc \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.