Re: [Qemu-devel] [PATCH 4/6] target-ppc: Convert PReP to machine class

From: "Andreas Färber" <andreas.faerber@web.de>
To: David Gibson <david@gibson.dropbear.id.au>,
	agraf@suse.de, mst@redhat.com, lcapitulino@redhat.com
Cc: blauwirbel@gmail.com, michael@walle.cc, qemu-ppc@nongnu.org,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 4/6] target-ppc: Convert PReP to machine class
Date: Mon, 30 Mar 2015 23:33:43 +0200	[thread overview]
Message-ID: <5519C137.3070107@web.de> (raw)
In-Reply-To: <1425615506-1829-5-git-send-email-david@gibson.dropbear.id.au>

Am 06.03.2015 um 05:18 schrieb David Gibson:
> The more commonly used ppc machine types: spapr, and newworld Mac have
> already been converted to the newer MachineClass representation, but some
> others still use QEMUMachine.
> 
> This patch cleans things up slightly, by converting the "prep" machine
> type to the new style.
> 
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> ---
>  hw/ppc/prep.c | 30 +++++++++++++++++++++---------
>  1 file changed, 21 insertions(+), 9 deletions(-)
> 
> diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c
> index 15df7f3..dfc8689 100644
> --- a/hw/ppc/prep.c
> +++ b/hw/ppc/prep.c
> @@ -44,6 +44,8 @@
>  #include "exec/address-spaces.h"
>  #include "elf.h"
>  
> +#define TYPE_PREP_MACHINE "PReP-machine"
[snip]

qemu_register_machine() generated the type name by concatenating
QEMUMachine::name with "-machine", so this should be "prep-machine".

Otherwise looks great.

Thanks,
Andreas