Re: [Qemu-devel] [PATCH 5/6] prep: Use MachineClass callbacks for "irq" and "pic" hmp commands

From: "Andreas Färber" <andreas.faerber@web.de>
To: David Gibson <david@gibson.dropbear.id.au>,
	agraf@suse.de, mst@redhat.com, andreas.faerber@web.de,
	lcapitulino@redhat.com
Cc: blauwirbel@gmail.com, michael@walle.cc, qemu-ppc@nongnu.org,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 5/6] prep: Use MachineClass callbacks for "irq" and "pic" hmp commands
Date: Mon, 30 Mar 2015 23:25:38 +0200	[thread overview]
Message-ID: <5519BF52.7000409@web.de> (raw)
In-Reply-To: <1425615506-1829-6-git-send-email-david@gibson.dropbear.id.au>

Am 06.03.2015 um 05:18 schrieb David Gibson:
> Currently all ppc targets rely on fallback code in monitor.c to implement
> the "irq" and "pic" hmp commands, by calling into the i8259 code.  For the
> PReP machine type, which does usually have an ISA bridge and legacy IO,
> including an i8259, this patch correctly sets the MachineClass callbacks
> to implement those commands properly without the fallback.
> 
> In fact PReP is the only ppc machine for which the i8259 implementation
> of those hmp commands makes sense.  The other machine types won't typically
> have an i8259 at all.  So we can remove the fallback case from the monitor
> meaning that other ppc targets will correctly implement those commands
> as no-ops.
> 
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> ---
>  hw/ppc/prep.c | 2 ++
>  monitor.c     | 4 ++--
>  2 files changed, 4 insertions(+), 2 deletions(-)

Reviewed-by: Andreas Färber <andreas.faerber@web.de>

Thanks,
Andreas