All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: jiri@resnulli.us
Cc: netdev@vger.kernel.org, jhs@mojatatu.com, tgraf@suug.ch,
	jesse@nicira.com
Subject: Re: [patch net-next v3] tc: introduce OpenFlow classifier
Date: Thu, 09 Apr 2015 17:34:23 -0400 (EDT)	[thread overview]
Message-ID: <20150409.173423.2258417584616634411.davem@davemloft.net> (raw)
In-Reply-To: <1428584287-8197-1-git-send-email-jiri@resnulli.us>

From: Jiri Pirko <jiri@resnulli.us>
Date: Thu,  9 Apr 2015 14:58:07 +0200

> This patch introduces OpenFlow-based filter. So far, the very essential
> packet fields are supported (according to OpenFlow v1.4 spec).
> 
> This patch is only the first step. There is a lot of potential performance
> improvements possible to implement. Also a lot of features are missing
> now. They will be addressed in follow-up patches.
> 
> To the name of this classifier, I believe that "cls_openflow" is pretty
> accurate. It is actually a OpenFlow classifier.
> 
> Signed-off-by: Jiri Pirko <jiri@resnulli.us>

I'm not so sure what my opinion is about whether we should
even have an openflow classifier or not (I find major aspects
of OpenFLOW extremely distasteful, it's basically pushing the
SDK agenda of several major chip vendors).

However I am sure that I majorly object to having yet another flow
parsing engine.  Therefore, at least adjust this code to use our flow
dissector and datastructures.  Adjust the flow dissector to fit your
needs, if necessary.

  parent reply	other threads:[~2015-04-09 21:34 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-09 12:58 [patch net-next v3] tc: introduce OpenFlow classifier Jiri Pirko
2015-04-09 13:00 ` [patch iproute2 v3] tc: add support for " Jiri Pirko
2015-04-09 21:34 ` David Miller [this message]
2015-04-10  9:12   ` [patch net-next v3] tc: introduce " Jiri Pirko
2015-04-10  9:30     ` Daniel Borkmann
2015-04-10 11:46       ` Jiri Pirko
2015-04-10 13:48         ` Jamal Hadi Salim
2015-04-10 10:03     ` Thomas Graf
2015-04-10 12:23     ` David Miller
2015-04-10 12:45       ` Jiri Pirko
2015-04-11 16:12         ` Alexei Starovoitov
2015-04-12  7:53           ` Jiri Pirko
2015-04-12 23:44             ` David Miller
2015-04-13  0:12               ` Alexei Starovoitov
2015-04-13  0:36                 ` David Miller
2015-04-13  1:03                   ` Alexei Starovoitov
2015-04-13  8:26                     ` Thomas Graf
2015-04-13 14:34                       ` Jiri Pirko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150409.173423.2258417584616634411.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=jesse@nicira.com \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=tgraf@suug.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.