All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: jiri@resnulli.us
Cc: netdev@vger.kernel.org, jhs@mojatatu.com, tgraf@suug.ch,
	jesse@nicira.com
Subject: Re: [patch net-next v3] tc: introduce OpenFlow classifier
Date: Fri, 10 Apr 2015 08:23:59 -0400 (EDT)	[thread overview]
Message-ID: <20150410.082359.964457460073432676.davem@davemloft.net> (raw)
In-Reply-To: <20150410091203.GA2021@nanopsycho.orion>

From: Jiri Pirko <jiri@resnulli.us>
Date: Fri, 10 Apr 2015 11:12:03 +0200

> Thu, Apr 09, 2015 at 11:34:23PM CEST, davem@davemloft.net wrote:
>>However I am sure that I majorly object to having yet another flow
>>parsing engine.  Therefore, at least adjust this code to use our flow
>>dissector and datastructures.  Adjust the flow dissector to fit your
>>needs, if necessary.
> 
> Yep, Thomas already suggested the merge. The thing is, cls_flow uses
> linked list for doing lookups. That is not scalable. in cls_openflow I
> use rhashtable. Using rhashtable in cls_flow would break the existing
> assumption that first inrested filter would be first hit.

I'm talking about using net/core/flow_dissect.c's interfaces instead
of your by-hand header parsing.  This has nothing to do with cls_flow

  parent reply	other threads:[~2015-04-10 12:24 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-09 12:58 [patch net-next v3] tc: introduce OpenFlow classifier Jiri Pirko
2015-04-09 13:00 ` [patch iproute2 v3] tc: add support for " Jiri Pirko
2015-04-09 21:34 ` [patch net-next v3] tc: introduce " David Miller
2015-04-10  9:12   ` Jiri Pirko
2015-04-10  9:30     ` Daniel Borkmann
2015-04-10 11:46       ` Jiri Pirko
2015-04-10 13:48         ` Jamal Hadi Salim
2015-04-10 10:03     ` Thomas Graf
2015-04-10 12:23     ` David Miller [this message]
2015-04-10 12:45       ` Jiri Pirko
2015-04-11 16:12         ` Alexei Starovoitov
2015-04-12  7:53           ` Jiri Pirko
2015-04-12 23:44             ` David Miller
2015-04-13  0:12               ` Alexei Starovoitov
2015-04-13  0:36                 ` David Miller
2015-04-13  1:03                   ` Alexei Starovoitov
2015-04-13  8:26                     ` Thomas Graf
2015-04-13 14:34                       ` Jiri Pirko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150410.082359.964457460073432676.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=jesse@nicira.com \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=tgraf@suug.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.