All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: David Miller <davem@davemloft.net>,
	netdev@vger.kernel.org, jhs@mojatatu.com, tgraf@suug.ch,
	jesse@nicira.com
Subject: Re: [patch net-next v3] tc: introduce OpenFlow classifier
Date: Sat, 11 Apr 2015 09:12:25 -0700	[thread overview]
Message-ID: <20150411161223.GA802@Alexeis-MBP.westell.com> (raw)
In-Reply-To: <20150410124517.GC2021@nanopsycho.orion>

On Fri, Apr 10, 2015 at 02:45:17PM +0200, Jiri Pirko wrote:
> Okay. That was misunderstanding. I was thinking about using existing
> flow_dissect. There are couple things which I'm scared of:
> - there are eventually many fields to be added to dissection function and to
>   the structure as well. Not sure how acceptable that would be for
>   performance reasons when flow_dissect is used by different users...

I share the same concern. I think flow_dissect is too performance
critical to reuse by expanding 'struct flow_keys'.
I think it would be better to generalize ovs's key_extract() into
common piece of code that TC classifier and ovs datapath can use.
It uses kernel internal 'struct sw_flow_key' which we can tweak to
accommodate more users. It's already gigantic at 392 bytes, so
split and a bit of diet would help too.

  reply	other threads:[~2015-04-11 16:12 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-09 12:58 [patch net-next v3] tc: introduce OpenFlow classifier Jiri Pirko
2015-04-09 13:00 ` [patch iproute2 v3] tc: add support for " Jiri Pirko
2015-04-09 21:34 ` [patch net-next v3] tc: introduce " David Miller
2015-04-10  9:12   ` Jiri Pirko
2015-04-10  9:30     ` Daniel Borkmann
2015-04-10 11:46       ` Jiri Pirko
2015-04-10 13:48         ` Jamal Hadi Salim
2015-04-10 10:03     ` Thomas Graf
2015-04-10 12:23     ` David Miller
2015-04-10 12:45       ` Jiri Pirko
2015-04-11 16:12         ` Alexei Starovoitov [this message]
2015-04-12  7:53           ` Jiri Pirko
2015-04-12 23:44             ` David Miller
2015-04-13  0:12               ` Alexei Starovoitov
2015-04-13  0:36                 ` David Miller
2015-04-13  1:03                   ` Alexei Starovoitov
2015-04-13  8:26                     ` Thomas Graf
2015-04-13 14:34                       ` Jiri Pirko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150411161223.GA802@Alexeis-MBP.westell.com \
    --to=alexei.starovoitov@gmail.com \
    --cc=davem@davemloft.net \
    --cc=jesse@nicira.com \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=tgraf@suug.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.