* [lm-sensors] [PATCH 01/22] hwmon: (it87) Fix in7 voltage display
@ 2015-04-04 21:54 Guenter Roeck
2015-04-09 11:31 ` Jean Delvare
2015-04-09 13:38 ` Guenter Roeck
0 siblings, 2 replies; 3+ messages in thread
From: Guenter Roeck @ 2015-04-04 21:54 UTC (permalink / raw)
To: lm-sensors
Commit a6ebb8b09421 ("hwmon: (it87) Introduce feature flag to reflect internal
in7 sensor") actually caused in7 to never be recognized as internal.
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
drivers/hwmon/it87.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c
index 4763d1157a5e..32180aaa4ac6 100644
--- a/drivers/hwmon/it87.c
+++ b/drivers/hwmon/it87.c
@@ -1910,7 +1910,7 @@ static int __init it87_find(unsigned short *address,
sio_data->internal |= (1 << 1);
/* in8 (Vbat) is always internal */
- sio_data->internal = (1 << 2);
+ sio_data->internal |= (1 << 2);
/* Only the IT8603E has in9 */
if (sio_data->type != it8603)
--
2.1.0
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [lm-sensors] [PATCH 01/22] hwmon: (it87) Fix in7 voltage display
2015-04-04 21:54 [lm-sensors] [PATCH 01/22] hwmon: (it87) Fix in7 voltage display Guenter Roeck
@ 2015-04-09 11:31 ` Jean Delvare
2015-04-09 13:38 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Jean Delvare @ 2015-04-09 11:31 UTC (permalink / raw)
To: lm-sensors
Hi Guenter,
On Sat, 4 Apr 2015 14:54:52 -0700, Guenter Roeck wrote:
> Commit a6ebb8b09421 ("hwmon: (it87) Introduce feature flag to reflect internal
> in7 sensor") actually caused in7 to never be recognized as internal.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/hwmon/it87.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c
> index 4763d1157a5e..32180aaa4ac6 100644
> --- a/drivers/hwmon/it87.c
> +++ b/drivers/hwmon/it87.c
> @@ -1910,7 +1910,7 @@ static int __init it87_find(unsigned short *address,
> sio_data->internal |= (1 << 1);
>
> /* in8 (Vbat) is always internal */
> - sio_data->internal = (1 << 2);
> + sio_data->internal |= (1 << 2);
>
> /* Only the IT8603E has in9 */
> if (sio_data->type != it8603)
Meanwhile you merged that fix in patch "hwmon: (it87) Introduce feature
flag to reflect internal in7 sensor" so this patch is no longer
relevant, right?
--
Jean Delvare
SUSE L3 Support
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [lm-sensors] [PATCH 01/22] hwmon: (it87) Fix in7 voltage display
2015-04-04 21:54 [lm-sensors] [PATCH 01/22] hwmon: (it87) Fix in7 voltage display Guenter Roeck
2015-04-09 11:31 ` Jean Delvare
@ 2015-04-09 13:38 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2015-04-09 13:38 UTC (permalink / raw)
To: lm-sensors
On 04/09/2015 04:31 AM, Jean Delvare wrote:
> Hi Guenter,
>
> On Sat, 4 Apr 2015 14:54:52 -0700, Guenter Roeck wrote:
>> Commit a6ebb8b09421 ("hwmon: (it87) Introduce feature flag to reflect internal
>> in7 sensor") actually caused in7 to never be recognized as internal.
>>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>> ---
>> drivers/hwmon/it87.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c
>> index 4763d1157a5e..32180aaa4ac6 100644
>> --- a/drivers/hwmon/it87.c
>> +++ b/drivers/hwmon/it87.c
>> @@ -1910,7 +1910,7 @@ static int __init it87_find(unsigned short *address,
>> sio_data->internal |= (1 << 1);
>>
>> /* in8 (Vbat) is always internal */
>> - sio_data->internal = (1 << 2);
>> + sio_data->internal |= (1 << 2);
>>
>> /* Only the IT8603E has in9 */
>> if (sio_data->type != it8603)
>
> Meanwhile you merged that fix in patch "hwmon: (it87) Introduce feature
> flag to reflect internal in7 sensor" so this patch is no longer
> relevant, right?
>
Yes.
Thanks,
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-04-09 13:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-04 21:54 [lm-sensors] [PATCH 01/22] hwmon: (it87) Fix in7 voltage display Guenter Roeck
2015-04-09 11:31 ` Jean Delvare
2015-04-09 13:38 ` Guenter Roeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.