From: Simon Guinot <simon.guinot@sequanux.org> To: Dan Carpenter <dan.carpenter@oracle.com> Cc: Bryan Wu <cooloney@gmail.com>, Richard Purdie <rpurdie@rpsys.net>, linux-leds@vger.kernel.org, kernel-janitors@vger.kernel.org, Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>, Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>, Gregory Clement <gregory.clement@free-electrons.com> Subject: Re: [patch 2/2 v2] leds: netxbig: silence a static checker warning Date: Fri, 10 Apr 2015 16:30:54 +0200 [thread overview] Message-ID: <20150410143054.GH1509@kw.sim.vm.gnt> (raw) In-Reply-To: <20150410083040.GA2189@mwanda> [-- Attachment #1: Type: text/plain, Size: 1904 bytes --] On Fri, Apr 10, 2015 at 11:30:41AM +0300, Dan Carpenter wrote: > Static checkers complain that "timers[i].delay_on" is an unsigned long > but we're writing to only 32 bits of it. The code works on 32 bit > systems and little endian 64 bit systems so it doesn't cause a problem > in practise but it's still better to silence the warning. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Simon Guinot <simon.guinot@sequanux.org> Note that your patch applies on the top of a patch "leds: netxbig: add device tree binding" which has not been merged yet by Bryan. For now, this patch only sits in the mvebu/for-next branch for testing purpose. And it is still not clear to me in which tree the patch will go. That's why I think you should resend your patch to the mvebu maintainers (added in Cc) on the LAKML. Probably they will be interested in merging your clean-up patch in the mvebu/for-next branch as well. Regards, Simon > --- > v2: use a temporary variable > > diff --git a/drivers/leds/leds-netxbig.c b/drivers/leds/leds-netxbig.c > index 028686f2..6cb4537 100644 > --- a/drivers/leds/leds-netxbig.c > +++ b/drivers/leds/leds-netxbig.c > @@ -444,12 +444,17 @@ static int netxbig_leds_get_of_pdata(struct device *dev, > if (!timers) > return -ENOMEM; > for (i = 0; i < num_timers; i++) { > + u32 delay_on = 0; > + u32 delay_off = 0; > + > of_property_read_u32_index(np, "timers", 3 * i, > &timers[i].mode); > of_property_read_u32_index(np, "timers", 3 * i + 1, > - (u32 *) &timers[i].delay_on); > + &delay_on); > of_property_read_u32_index(np, "timers", 3 * i + 2, > - (u32 *) &timers[i].delay_off); > + &delay_off); > + timers[i].delay_on = delay_on; > + timers[i].delay_off = delay_off; > } > pdata->timer = timers; > pdata->num_timer = num_timers; [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 181 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Simon Guinot <simon.guinot@sequanux.org> To: Dan Carpenter <dan.carpenter@oracle.com> Cc: Bryan Wu <cooloney@gmail.com>, Richard Purdie <rpurdie@rpsys.net>, linux-leds@vger.kernel.org, kernel-janitors@vger.kernel.org, Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>, Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>, Gregory Clement <gregory.clement@free-electrons.com> Subject: Re: [patch 2/2 v2] leds: netxbig: silence a static checker warning Date: Fri, 10 Apr 2015 14:30:54 +0000 [thread overview] Message-ID: <20150410143054.GH1509@kw.sim.vm.gnt> (raw) In-Reply-To: <20150410083040.GA2189@mwanda> [-- Attachment #1: Type: text/plain, Size: 1904 bytes --] On Fri, Apr 10, 2015 at 11:30:41AM +0300, Dan Carpenter wrote: > Static checkers complain that "timers[i].delay_on" is an unsigned long > but we're writing to only 32 bits of it. The code works on 32 bit > systems and little endian 64 bit systems so it doesn't cause a problem > in practise but it's still better to silence the warning. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Simon Guinot <simon.guinot@sequanux.org> Note that your patch applies on the top of a patch "leds: netxbig: add device tree binding" which has not been merged yet by Bryan. For now, this patch only sits in the mvebu/for-next branch for testing purpose. And it is still not clear to me in which tree the patch will go. That's why I think you should resend your patch to the mvebu maintainers (added in Cc) on the LAKML. Probably they will be interested in merging your clean-up patch in the mvebu/for-next branch as well. Regards, Simon > --- > v2: use a temporary variable > > diff --git a/drivers/leds/leds-netxbig.c b/drivers/leds/leds-netxbig.c > index 028686f2..6cb4537 100644 > --- a/drivers/leds/leds-netxbig.c > +++ b/drivers/leds/leds-netxbig.c > @@ -444,12 +444,17 @@ static int netxbig_leds_get_of_pdata(struct device *dev, > if (!timers) > return -ENOMEM; > for (i = 0; i < num_timers; i++) { > + u32 delay_on = 0; > + u32 delay_off = 0; > + > of_property_read_u32_index(np, "timers", 3 * i, > &timers[i].mode); > of_property_read_u32_index(np, "timers", 3 * i + 1, > - (u32 *) &timers[i].delay_on); > + &delay_on); > of_property_read_u32_index(np, "timers", 3 * i + 2, > - (u32 *) &timers[i].delay_off); > + &delay_off); > + timers[i].delay_on = delay_on; > + timers[i].delay_off = delay_off; > } > pdata->timer = timers; > pdata->num_timer = num_timers; [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2015-04-10 14:30 UTC|newest] Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-04-09 9:07 [patch 2/2] leds: netxbig: clean up a data type issue Dan Carpenter 2015-04-09 9:07 ` Dan Carpenter 2015-04-09 19:25 ` Simon Guinot 2015-04-09 19:25 ` Simon Guinot 2015-04-09 19:25 ` Simon Guinot 2015-04-09 19:54 ` Dan Carpenter 2015-04-09 19:54 ` Dan Carpenter 2015-04-09 19:54 ` Dan Carpenter 2015-04-10 0:25 ` Simon Guinot 2015-04-10 0:25 ` Simon Guinot 2015-04-10 0:25 ` Simon Guinot 2015-04-10 8:30 ` [patch 2/2 v2] leds: netxbig: silence a static checker warning Dan Carpenter 2015-04-10 8:30 ` Dan Carpenter 2015-04-10 14:18 ` Jacek Anaszewski 2015-04-10 14:18 ` Jacek Anaszewski 2015-04-10 14:30 ` Dan Carpenter 2015-04-10 14:30 ` Dan Carpenter 2015-04-10 14:41 ` Simon Guinot 2015-04-10 14:41 ` Simon Guinot 2015-04-10 15:50 ` Dan Carpenter 2015-04-10 15:50 ` Dan Carpenter 2015-04-10 19:52 ` Simon Guinot 2015-04-10 19:52 ` Simon Guinot 2015-04-13 7:35 ` Jacek Anaszewski 2015-04-13 7:35 ` Jacek Anaszewski 2015-04-13 10:16 ` Simon Guinot 2015-04-13 10:16 ` Simon Guinot 2015-04-13 10:54 ` Jacek Anaszewski 2015-04-13 10:54 ` Jacek Anaszewski 2015-04-13 10:16 ` Dan Carpenter 2015-04-13 10:16 ` Dan Carpenter 2015-04-10 14:30 ` Simon Guinot [this message] 2015-04-10 14:30 ` Simon Guinot 2015-04-13 8:25 ` Gregory CLEMENT 2015-04-13 8:25 ` Gregory CLEMENT 2015-04-13 9:20 ` Simon Guinot 2015-04-13 9:20 ` Simon Guinot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20150410143054.GH1509@kw.sim.vm.gnt \ --to=simon.guinot@sequanux.org \ --cc=andrew@lunn.ch \ --cc=cooloney@gmail.com \ --cc=dan.carpenter@oracle.com \ --cc=gregory.clement@free-electrons.com \ --cc=jason@lakedaemon.net \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-leds@vger.kernel.org \ --cc=rpurdie@rpsys.net \ --cc=sebastian.hesselbarth@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.