Re: [patch 2/2 v2] leds: netxbig: silence a static checker warning

[Simon Guinot <simon.guinot@sequanux.org>]

[-- Attachment #1: Type: text/plain, Size: 1141 bytes --]

On Fri, Apr 10, 2015 at 06:50:34PM +0300, Dan Carpenter wrote:
> I've looked at this some more.  Most of the places which call
> of_property_read_u32_index() check the return code.  The ones that don't
> mostly initialize their values going in.  The remainder introduce static
> checker warnings like:
> 
> 	drivers/clk/ti/divider.c:472 ti_clk_get_div_table()
> 	error: potentially using uninitialized 'val'.
> 
> These warnings cause me pain.  It calls of_get_property() earlier so
> it won't return -EINVAL.  I don't know if it can return -ENODATA or
> -EOVERFLOW?
> 
> I guess not.

I think it can't. Above, we are calling of_property_count_u32_elems() to
count the number of u32 elements in the "timers" property. After we are
ensuring that there is three u32 elements available per timer. That's
why the return codes for the three of_property_read_u32_index() calls
are not checked.

Regards,

Simon

> 
> Honestly, I hate ambigous code like this.  If it were just a clear bug
> then I could fix it but I invest more time in ambiguous code and end
> up not writing a patch.
> 
> regards,
> dan carpenter

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]