* [PATCH net-next] net/macb: sqe_test_errors are TX errors, not RX errors
@ 2015-04-10 9:42 Wolfgang Steinwender
2015-04-10 14:12 ` Nicolas Ferre
2015-04-13 0:43 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Wolfgang Steinwender @ 2015-04-10 9:42 UTC (permalink / raw)
To: Nicolas Ferre; +Cc: netdev, Wolfgang Steinwender
The statistics are grouped by TX and RX errors.
The SQE Test Errors Register indicates problems with TX.
Signed-off-by: Wolfgang Steinwender <wsteinwender@pcs.com>
---
drivers/net/ethernet/cadence/macb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
index 448a323..9f53872 100644
--- a/drivers/net/ethernet/cadence/macb.c
+++ b/drivers/net/ethernet/cadence/macb.c
@@ -1956,12 +1956,12 @@ static struct net_device_stats *macb_get_stats(struct net_device *dev)
hwstat->rx_oversize_pkts +
hwstat->rx_jabbers +
hwstat->rx_undersize_pkts +
- hwstat->sqe_test_errors +
hwstat->rx_length_mismatch);
nstat->tx_errors = (hwstat->tx_late_cols +
hwstat->tx_excessive_cols +
hwstat->tx_underruns +
- hwstat->tx_carrier_errors);
+ hwstat->tx_carrier_errors +
+ hwstat->sqe_test_errors);
nstat->collisions = (hwstat->tx_single_cols +
hwstat->tx_multiple_cols +
hwstat->tx_excessive_cols);
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net/macb: sqe_test_errors are TX errors, not RX errors
2015-04-10 9:42 [PATCH net-next] net/macb: sqe_test_errors are TX errors, not RX errors Wolfgang Steinwender
@ 2015-04-10 14:12 ` Nicolas Ferre
2015-04-13 0:43 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Nicolas Ferre @ 2015-04-10 14:12 UTC (permalink / raw)
To: Wolfgang Steinwender, netdev, David Miller
Le 10/04/2015 11:42, Wolfgang Steinwender a écrit :
> The statistics are grouped by TX and RX errors.
> The SQE Test Errors Register indicates problems with TX.
>
> Signed-off-by: Wolfgang Steinwender <wsteinwender@pcs.com>
seems okay:
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
> drivers/net/ethernet/cadence/macb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
> index 448a323..9f53872 100644
> --- a/drivers/net/ethernet/cadence/macb.c
> +++ b/drivers/net/ethernet/cadence/macb.c
> @@ -1956,12 +1956,12 @@ static struct net_device_stats *macb_get_stats(struct net_device *dev)
> hwstat->rx_oversize_pkts +
> hwstat->rx_jabbers +
> hwstat->rx_undersize_pkts +
> - hwstat->sqe_test_errors +
> hwstat->rx_length_mismatch);
> nstat->tx_errors = (hwstat->tx_late_cols +
> hwstat->tx_excessive_cols +
> hwstat->tx_underruns +
> - hwstat->tx_carrier_errors);
> + hwstat->tx_carrier_errors +
> + hwstat->sqe_test_errors);
> nstat->collisions = (hwstat->tx_single_cols +
> hwstat->tx_multiple_cols +
> hwstat->tx_excessive_cols);
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net/macb: sqe_test_errors are TX errors, not RX errors
2015-04-10 9:42 [PATCH net-next] net/macb: sqe_test_errors are TX errors, not RX errors Wolfgang Steinwender
2015-04-10 14:12 ` Nicolas Ferre
@ 2015-04-13 0:43 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2015-04-13 0:43 UTC (permalink / raw)
To: wsteinwender; +Cc: nicolas.ferre, netdev
From: Wolfgang Steinwender <wsteinwender@pcs.com>
Date: Fri, 10 Apr 2015 11:42:56 +0200
> The statistics are grouped by TX and RX errors.
> The SQE Test Errors Register indicates problems with TX.
>
> Signed-off-by: Wolfgang Steinwender <wsteinwender@pcs.com>
Applied, thank you!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-04-13 0:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-10 9:42 [PATCH net-next] net/macb: sqe_test_errors are TX errors, not RX errors Wolfgang Steinwender
2015-04-10 14:12 ` Nicolas Ferre
2015-04-13 0:43 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.