All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>,
	Ingo Molnar <mingo@kernel.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	mingo@redhat.com, Arnaldo Carvalho de Melo <acme@kernel.org>,
	peterz@infradead.org, namhyung@kernel.org,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	Pekka Enberg <penberg@iki.fi>,
	Arnaldo Carvalho de Melo <acme@infradead.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Thomas Gleixner <tglx@linutronix.de>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Borislav Petkov <bp@alien8.de>
Subject: Re: 'perf upgrade' (was: Re: [PATCH v9 00/11] Add support for JSON event files.)
Date: Sat, 18 Apr 2015 15:05:36 +0200	[thread overview]
Message-ID: <20150418130536.GA1514@krava.brq.redhat.com> (raw)
In-Reply-To: <20150417200954.GA7056@tassilo.jf.intel.com>

On Fri, Apr 17, 2015 at 01:09:54PM -0700, Andi Kleen wrote:
> On Fri, Apr 17, 2015 at 05:31:26PM +0200, Jiri Olsa wrote:
> > On Wed, Apr 15, 2015 at 01:50:42PM -0700, Sukadev Bhattiprolu wrote:
> > 
> > SNIP
> > 
> > > | 
> > > |  - to blindly follow some poorly constructed vendor format with no 
> > > |    high level structure, that IMHO didn't work very well when OProfile 
> > > |    was written, and misrepresenting it as 'symbolic event names'.
> > > | 
> > > |    Take a look at:
> > > | 
> > > |      https://download.01.org/perfmon/HSW/Haswell_core_V17.json
> > > | 
> > > |    and weep.
> > > 
> > > Evil vendor formats, but to be fair, here is what _we_ have today:
> > > 
> > > 	perf stat -e r10068,r20036,r40060,r40ac sleep 1
> > 
> > hum, you could also use the 'cpu/event=.../' syntax right?
> 
> That's even worse -- same hex numbers, just more redundancy.

no, it's far more readable then the rXXXX format,
you can just put in whatevent is in the spec..
event,umask,any etc and dont bother with making
rXXXX value

but I mentioned it just to give the whole picture,
I agree that we need the symbolic names support

jirka

WARNING: multiple messages have this Message-ID (diff)
From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@infradead.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	peterz@infradead.org, linux-kernel@vger.kernel.org,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Pekka Enberg <penberg@iki.fi>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	mingo@redhat.com, Borislav Petkov <bp@alien8.de>,
	namhyung@kernel.org, Thomas Gleixner <tglx@linutronix.de>,
	Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>,
	linuxppc-dev@lists.ozlabs.org, Ingo Molnar <mingo@kernel.org>
Subject: Re: 'perf upgrade' (was: Re: [PATCH v9 00/11] Add support for JSON event files.)
Date: Sat, 18 Apr 2015 15:05:36 +0200	[thread overview]
Message-ID: <20150418130536.GA1514@krava.brq.redhat.com> (raw)
In-Reply-To: <20150417200954.GA7056@tassilo.jf.intel.com>

On Fri, Apr 17, 2015 at 01:09:54PM -0700, Andi Kleen wrote:
> On Fri, Apr 17, 2015 at 05:31:26PM +0200, Jiri Olsa wrote:
> > On Wed, Apr 15, 2015 at 01:50:42PM -0700, Sukadev Bhattiprolu wrote:
> > 
> > SNIP
> > 
> > > | 
> > > |  - to blindly follow some poorly constructed vendor format with no 
> > > |    high level structure, that IMHO didn't work very well when OProfile 
> > > |    was written, and misrepresenting it as 'symbolic event names'.
> > > | 
> > > |    Take a look at:
> > > | 
> > > |      https://download.01.org/perfmon/HSW/Haswell_core_V17.json
> > > | 
> > > |    and weep.
> > > 
> > > Evil vendor formats, but to be fair, here is what _we_ have today:
> > > 
> > > 	perf stat -e r10068,r20036,r40060,r40ac sleep 1
> > 
> > hum, you could also use the 'cpu/event=.../' syntax right?
> 
> That's even worse -- same hex numbers, just more redundancy.

no, it's far more readable then the rXXXX format,
you can just put in whatevent is in the spec..
event,umask,any etc and dont bother with making
rXXXX value

but I mentioned it just to give the whole picture,
I agree that we need the symbolic names support

jirka

  reply	other threads:[~2015-04-18 13:06 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-14  6:40 [PATCH v9 00/11] Add support for JSON event files Sukadev Bhattiprolu
2015-04-14  6:40 ` Sukadev Bhattiprolu
2015-04-14  6:40 ` [PATCH v9 01/11] perf, tools: Add jsmn `jasmine' JSON parser Sukadev Bhattiprolu
2015-04-14  6:40   ` Sukadev Bhattiprolu
2015-04-14  6:40 ` [PATCH v9 02/11] perf, tools: Add support for text descriptions of events and alias add Sukadev Bhattiprolu
2015-04-14  6:40   ` Sukadev Bhattiprolu
2015-04-14  6:40 ` [PATCH v9 03/11] perf, tools, list: Update perf list to output descriptions Sukadev Bhattiprolu
2015-04-14  6:40   ` Sukadev Bhattiprolu
2015-04-14  6:40 ` [PATCH v9 04/11] perf, tools: Add support for reading JSON event files Sukadev Bhattiprolu
2015-04-14  6:40   ` Sukadev Bhattiprolu
2015-04-14  6:40 ` [PATCH v9 05/11] perf, tools: Automatically look for event file name for cpu Sukadev Bhattiprolu
2015-04-14  6:40   ` Sukadev Bhattiprolu
2015-04-14  6:40 ` [PATCH v9 06/11] powerpc/perf: Implement get_cpu_str() Sukadev Bhattiprolu
2015-04-14  6:40   ` Sukadev Bhattiprolu
2015-04-14  6:41 ` [PATCH v9 07/11] perf, tools: Query terminal width and use in perf list Sukadev Bhattiprolu
2015-04-14  6:41   ` Sukadev Bhattiprolu
2015-04-14  6:41 ` [PATCH v9 08/11] perf, tools: Add a new pmu interface to iterate over all events Sukadev Bhattiprolu
2015-04-14  6:41   ` Sukadev Bhattiprolu
2015-04-14  6:41 ` [PATCH v9 09/11] perf, tools, test: Add test case for alias and JSON parsing Sukadev Bhattiprolu
2015-04-14  6:41   ` Sukadev Bhattiprolu
2015-04-14  6:41 ` [PATCH v9 10/11] perf, tools: Add a --no-desc flag to perf list Sukadev Bhattiprolu
2015-04-14  6:41   ` Sukadev Bhattiprolu
2015-04-14  6:41 ` [PATCH v9 11/11] perf-download: Download the events json file Sukadev Bhattiprolu
2015-04-14  6:41   ` Sukadev Bhattiprolu
2015-04-14  8:55 ` 'perf upgrade' (was: Re: [PATCH v9 00/11] Add support for JSON event files.) Ingo Molnar
2015-04-14  8:55   ` Ingo Molnar
2015-04-14 11:21   ` Michael Ellerman
2015-04-14 11:21     ` Michael Ellerman
2015-04-14 12:58     ` Ingo Molnar
2015-04-14 12:58       ` Ingo Molnar
2015-04-14 18:03       ` Sukadev Bhattiprolu
2015-04-14 18:03         ` Sukadev Bhattiprolu
2015-04-14 22:53       ` Michael Ellerman
2015-04-14 22:53         ` Michael Ellerman
2015-04-15  9:25         ` Ingo Molnar
2015-04-15  9:25           ` Ingo Molnar
2015-04-15 19:17           ` Andi Kleen
2015-04-15 19:17             ` Andi Kleen
2015-04-15 20:50           ` Sukadev Bhattiprolu
2015-04-15 20:50             ` Sukadev Bhattiprolu
2015-04-17 15:31             ` Jiri Olsa
2015-04-17 15:31               ` Jiri Olsa
2015-04-17 20:09               ` Andi Kleen
2015-04-17 20:09                 ` Andi Kleen
2015-04-18 13:05                 ` Jiri Olsa [this message]
2015-04-18 13:05                   ` Jiri Olsa
2015-04-18 13:12             ` Jiri Olsa
2015-04-18 13:12               ` Jiri Olsa
2015-04-14 20:16   ` Andi Kleen
2015-04-14 20:16     ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150418130536.GA1514@krava.brq.redhat.com \
    --to=jolsa@redhat.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@infradead.org \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=mpe@ellerman.id.au \
    --cc=namhyung@kernel.org \
    --cc=penberg@iki.fi \
    --cc=peterz@infradead.org \
    --cc=sukadev@linux.vnet.ibm.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.