From: Mark Brown <broonie@kernel.org>
To: Koro Chen <koro.chen@mediatek.com>
Cc: robh+dt@kernel.org, matthias.bgg@gmail.com, perex@perex.cz,
tiwai@suse.de, srv_heupstream@mediatek.com,
linux-mediatek@lists.infradead.org, s.hauer@pengutronix.de,
galak@codeaurora.org, lgirdwood@gmail.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [RESEND RFC PATCH 1/3] ASoC: mediatek: Add binding support for AFE driver
Date: Sat, 18 Apr 2015 18:34:07 +0100 [thread overview]
Message-ID: <20150418173407.GE26185@sirena.org.uk> (raw)
In-Reply-To: <1428653649-38200-2-git-send-email-koro.chen@mediatek.com>
[-- Attachment #1: Type: text/plain, Size: 1306 bytes --]
On Fri, Apr 10, 2015 at 04:14:07PM +0800, Koro Chen wrote:
> +Each external interface (called "IO" in this driver) is presented as a
> +DAI to ASoC. An IO must be connected via the interconnect to a memif.
> +The connection paths are configured through the device tree.
Why are these connection paths configured via device tree? I would
expect that either there would be runtime configurability of these
things (particularly if loopback configurations within the hardware are
possible) or we'd just allocate memory interfaces to DAIs automatically
as DAIs come into use.
> +- mem-interface-playback:
> + mem-interface-capture: property of memif, format is: <memif irq use_sram>;
> + memif: which memif to be used
> + (defined in include/dt-bindings/sound/mtk-afe.h)
> + irq: which irq to be used
> + (defined in include/dt-bindings/sound/mtk-afe.h)
> + use_sram: 1 is yes, 0 is no
Again, this looks like stuff we should be able to figure out at runtime
- the use of SRAM in particular looks like something we might want to
change depending on use case. Assuming it adds buffering then for a
VoIP application we might not want to use SRAM to minimize latency but
during music playback we might want to enable SRAM to minimize power
consumption.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND RFC PATCH 1/3] ASoC: mediatek: Add binding support for AFE driver
Date: Sat, 18 Apr 2015 18:34:07 +0100 [thread overview]
Message-ID: <20150418173407.GE26185@sirena.org.uk> (raw)
In-Reply-To: <1428653649-38200-2-git-send-email-koro.chen@mediatek.com>
On Fri, Apr 10, 2015 at 04:14:07PM +0800, Koro Chen wrote:
> +Each external interface (called "IO" in this driver) is presented as a
> +DAI to ASoC. An IO must be connected via the interconnect to a memif.
> +The connection paths are configured through the device tree.
Why are these connection paths configured via device tree? I would
expect that either there would be runtime configurability of these
things (particularly if loopback configurations within the hardware are
possible) or we'd just allocate memory interfaces to DAIs automatically
as DAIs come into use.
> +- mem-interface-playback:
> + mem-interface-capture: property of memif, format is: <memif irq use_sram>;
> + memif: which memif to be used
> + (defined in include/dt-bindings/sound/mtk-afe.h)
> + irq: which irq to be used
> + (defined in include/dt-bindings/sound/mtk-afe.h)
> + use_sram: 1 is yes, 0 is no
Again, this looks like stuff we should be able to figure out at runtime
- the use of SRAM in particular looks like something we might want to
change depending on use case. Assuming it adds buffering then for a
VoIP application we might not want to use SRAM to minimize latency but
during music playback we might want to enable SRAM to minimize power
consumption.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150418/f9a9b312/attachment.sig>
next prev parent reply other threads:[~2015-04-18 17:34 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-10 8:14 [RESEND RFC PATCH 0/3] ASoC: Mediatek: Add support for MT8173 SOC Koro Chen
2015-04-10 8:14 ` [RESEND RFC PATCH 1/3] ASoC: mediatek: Add binding support for AFE driver Koro Chen
2015-04-18 17:34 ` Mark Brown [this message]
2015-04-18 17:34 ` Mark Brown
2015-04-20 4:37 ` Sascha Hauer
2015-04-20 4:37 ` Sascha Hauer
2015-04-20 4:37 ` Sascha Hauer
2015-04-20 20:48 ` Mark Brown
2015-04-20 20:48 ` Mark Brown
2015-04-20 20:48 ` Mark Brown
2015-04-21 9:49 ` Sascha Hauer
2015-04-21 9:49 ` Sascha Hauer
2015-04-21 9:49 ` Sascha Hauer
2015-04-21 10:14 ` Mark Brown
2015-04-21 10:14 ` Mark Brown
2015-04-21 10:15 ` Koro Chen
2015-04-21 10:15 ` Koro Chen
2015-04-21 10:15 ` Koro Chen
2015-04-21 10:56 ` Mark Brown
2015-04-21 10:56 ` Mark Brown
2015-04-22 3:17 ` Koro Chen
2015-04-22 3:17 ` Koro Chen
2015-04-22 3:17 ` Koro Chen
2015-04-30 20:12 ` Mark Brown
2015-04-30 20:12 ` Mark Brown
2015-04-30 20:12 ` Mark Brown
2015-05-04 1:57 ` Koro Chen
2015-05-04 1:57 ` Koro Chen
2015-05-04 1:57 ` Koro Chen
2015-04-10 8:14 ` [RESEND RFC PATCH 2/3] ASoC: mediatek: Add AFE connection control Koro Chen
2015-04-18 17:37 ` Mark Brown
2015-04-18 17:37 ` Mark Brown
2015-04-18 17:37 ` Mark Brown
2015-04-20 4:50 ` Sascha Hauer
2015-04-20 4:50 ` Sascha Hauer
2015-04-20 4:50 ` Sascha Hauer
2015-04-20 20:52 ` Mark Brown
2015-04-20 20:52 ` Mark Brown
2015-04-20 20:52 ` Mark Brown
2015-04-21 5:50 ` Sascha Hauer
2015-04-21 5:50 ` Sascha Hauer
2015-04-21 5:50 ` Sascha Hauer
2015-04-21 10:15 ` Mark Brown
2015-04-21 10:15 ` Mark Brown
2015-04-21 10:15 ` Mark Brown
2015-04-10 8:14 ` [RESEND RFC PATCH 3/3] ASoC: mediatek: Add AFE platform driver Koro Chen
2015-04-18 17:51 ` Mark Brown
2015-04-18 17:51 ` Mark Brown
2015-04-20 6:22 ` Koro Chen
2015-04-20 6:22 ` Koro Chen
2015-04-20 6:22 ` Koro Chen
2015-04-20 20:55 ` Mark Brown
2015-04-20 20:55 ` Mark Brown
2015-04-20 20:55 ` Mark Brown
2015-04-21 2:27 ` Koro Chen
2015-04-21 2:27 ` Koro Chen
2015-04-21 2:27 ` Koro Chen
2015-04-21 10:05 ` Mark Brown
2015-04-21 10:05 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150418173407.GE26185@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=koro.chen@mediatek.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=srv_heupstream@mediatek.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.