From: Mark Brown <broonie@kernel.org>
To: Koro Chen <koro.chen@mediatek.com>
Cc: robh+dt@kernel.org, matthias.bgg@gmail.com, perex@perex.cz,
tiwai@suse.de, srv_heupstream@mediatek.com,
linux-mediatek@lists.infradead.org, s.hauer@pengutronix.de,
galak@codeaurora.org, lgirdwood@gmail.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [RESEND RFC PATCH 2/3] ASoC: mediatek: Add AFE connection control
Date: Sat, 18 Apr 2015 18:37:40 +0100 [thread overview]
Message-ID: <20150418173740.GF26185@sirena.org.uk> (raw)
In-Reply-To: <1428653649-38200-3-git-send-email-koro.chen@mediatek.com>
[-- Attachment #1: Type: text/plain, Size: 925 bytes --]
On Fri, Apr 10, 2015 at 04:14:08PM +0800, Koro Chen wrote:
> +/*
> + * The MTK AFE unit has a audio interconnect with MTK_AFE_INTERCONN_NUM_INPUT
> + * inputs and MTK_AFE_INTERCONN_NUM_OUTPUT outputs. Below table holds the
> + * register/bits to set to connect an input with an output.
> + */
> +static const struct mtk_afe_connection
> + connections[MTK_AFE_INTERCONN_NUM_INPUT][MTK_AFE_INTERCONN_NUM_OUTPUT] = {
> + [0][0] = { .creg = 0x020, .cshift = 0, .sreg = 0x020, .sshift = 10},
> + [0][1] = { .creg = 0x020, .cshift = 16, .sreg = 0x020, .sshift = 26},
What are the constraints on using this - is it one input to one output
only or can we do mixing or duplication? The register interface
definitely does look like something asking for runtime configuration.
It'd also be nice to have less magic numbers in the table, at least for
the indexes (which I guess correspond to some of the defines in the
headers)?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Koro Chen <koro.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
perex-/Fr2/VpizcU@public.gmane.org,
tiwai-l3A5Bk7waGM@public.gmane.org,
srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org
Subject: Re: [RESEND RFC PATCH 2/3] ASoC: mediatek: Add AFE connection control
Date: Sat, 18 Apr 2015 18:37:40 +0100 [thread overview]
Message-ID: <20150418173740.GF26185@sirena.org.uk> (raw)
In-Reply-To: <1428653649-38200-3-git-send-email-koro.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 925 bytes --]
On Fri, Apr 10, 2015 at 04:14:08PM +0800, Koro Chen wrote:
> +/*
> + * The MTK AFE unit has a audio interconnect with MTK_AFE_INTERCONN_NUM_INPUT
> + * inputs and MTK_AFE_INTERCONN_NUM_OUTPUT outputs. Below table holds the
> + * register/bits to set to connect an input with an output.
> + */
> +static const struct mtk_afe_connection
> + connections[MTK_AFE_INTERCONN_NUM_INPUT][MTK_AFE_INTERCONN_NUM_OUTPUT] = {
> + [0][0] = { .creg = 0x020, .cshift = 0, .sreg = 0x020, .sshift = 10},
> + [0][1] = { .creg = 0x020, .cshift = 16, .sreg = 0x020, .sshift = 26},
What are the constraints on using this - is it one input to one output
only or can we do mixing or duplication? The register interface
definitely does look like something asking for runtime configuration.
It'd also be nice to have less magic numbers in the table, at least for
the indexes (which I guess correspond to some of the defines in the
headers)?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND RFC PATCH 2/3] ASoC: mediatek: Add AFE connection control
Date: Sat, 18 Apr 2015 18:37:40 +0100 [thread overview]
Message-ID: <20150418173740.GF26185@sirena.org.uk> (raw)
In-Reply-To: <1428653649-38200-3-git-send-email-koro.chen@mediatek.com>
On Fri, Apr 10, 2015 at 04:14:08PM +0800, Koro Chen wrote:
> +/*
> + * The MTK AFE unit has a audio interconnect with MTK_AFE_INTERCONN_NUM_INPUT
> + * inputs and MTK_AFE_INTERCONN_NUM_OUTPUT outputs. Below table holds the
> + * register/bits to set to connect an input with an output.
> + */
> +static const struct mtk_afe_connection
> + connections[MTK_AFE_INTERCONN_NUM_INPUT][MTK_AFE_INTERCONN_NUM_OUTPUT] = {
> + [0][0] = { .creg = 0x020, .cshift = 0, .sreg = 0x020, .sshift = 10},
> + [0][1] = { .creg = 0x020, .cshift = 16, .sreg = 0x020, .sshift = 26},
What are the constraints on using this - is it one input to one output
only or can we do mixing or duplication? The register interface
definitely does look like something asking for runtime configuration.
It'd also be nice to have less magic numbers in the table, at least for
the indexes (which I guess correspond to some of the defines in the
headers)?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150418/28fcacb5/attachment.sig>
next prev parent reply other threads:[~2015-04-18 17:37 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-10 8:14 [RESEND RFC PATCH 0/3] ASoC: Mediatek: Add support for MT8173 SOC Koro Chen
2015-04-10 8:14 ` [RESEND RFC PATCH 1/3] ASoC: mediatek: Add binding support for AFE driver Koro Chen
2015-04-18 17:34 ` Mark Brown
2015-04-18 17:34 ` Mark Brown
2015-04-20 4:37 ` Sascha Hauer
2015-04-20 4:37 ` Sascha Hauer
2015-04-20 4:37 ` Sascha Hauer
2015-04-20 20:48 ` Mark Brown
2015-04-20 20:48 ` Mark Brown
2015-04-20 20:48 ` Mark Brown
2015-04-21 9:49 ` Sascha Hauer
2015-04-21 9:49 ` Sascha Hauer
2015-04-21 9:49 ` Sascha Hauer
2015-04-21 10:14 ` Mark Brown
2015-04-21 10:14 ` Mark Brown
2015-04-21 10:15 ` Koro Chen
2015-04-21 10:15 ` Koro Chen
2015-04-21 10:15 ` Koro Chen
2015-04-21 10:56 ` Mark Brown
2015-04-21 10:56 ` Mark Brown
2015-04-22 3:17 ` Koro Chen
2015-04-22 3:17 ` Koro Chen
2015-04-22 3:17 ` Koro Chen
2015-04-30 20:12 ` Mark Brown
2015-04-30 20:12 ` Mark Brown
2015-04-30 20:12 ` Mark Brown
2015-05-04 1:57 ` Koro Chen
2015-05-04 1:57 ` Koro Chen
2015-05-04 1:57 ` Koro Chen
2015-04-10 8:14 ` [RESEND RFC PATCH 2/3] ASoC: mediatek: Add AFE connection control Koro Chen
2015-04-18 17:37 ` Mark Brown [this message]
2015-04-18 17:37 ` Mark Brown
2015-04-18 17:37 ` Mark Brown
2015-04-20 4:50 ` Sascha Hauer
2015-04-20 4:50 ` Sascha Hauer
2015-04-20 4:50 ` Sascha Hauer
2015-04-20 20:52 ` Mark Brown
2015-04-20 20:52 ` Mark Brown
2015-04-20 20:52 ` Mark Brown
2015-04-21 5:50 ` Sascha Hauer
2015-04-21 5:50 ` Sascha Hauer
2015-04-21 5:50 ` Sascha Hauer
2015-04-21 10:15 ` Mark Brown
2015-04-21 10:15 ` Mark Brown
2015-04-21 10:15 ` Mark Brown
2015-04-10 8:14 ` [RESEND RFC PATCH 3/3] ASoC: mediatek: Add AFE platform driver Koro Chen
2015-04-18 17:51 ` Mark Brown
2015-04-18 17:51 ` Mark Brown
2015-04-20 6:22 ` Koro Chen
2015-04-20 6:22 ` Koro Chen
2015-04-20 6:22 ` Koro Chen
2015-04-20 20:55 ` Mark Brown
2015-04-20 20:55 ` Mark Brown
2015-04-20 20:55 ` Mark Brown
2015-04-21 2:27 ` Koro Chen
2015-04-21 2:27 ` Koro Chen
2015-04-21 2:27 ` Koro Chen
2015-04-21 10:05 ` Mark Brown
2015-04-21 10:05 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150418173740.GF26185@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=koro.chen@mediatek.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=srv_heupstream@mediatek.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.