All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
	Jens Wiklander <jens.wiklander@linaro.org>,
	valentin.manea@huawei.com, devicetree@vger.kernel.org,
	javier@javigon.com, emmanuel.michel@st.com,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org, jean-michel.delorme@st.com,
	tpmdd-devel@lists.sourceforge.net,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [tpmdd-devel] [RFC PATCH 1/2] tee: generic TEE subsystem
Date: Mon, 20 Apr 2015 09:56:48 -0600	[thread overview]
Message-ID: <20150420155648.GA7676@obsidianresearch.com> (raw)
In-Reply-To: <20150420145432.GD7261@kroah.com>

On Mon, Apr 20, 2015 at 04:54:32PM +0200, Greg Kroah-Hartman wrote:
> On Sun, Apr 19, 2015 at 11:08:00PM -0600, Jason Gunthorpe wrote:
> > I still suspect the expected way to write a new mid layer is to create
> > your own struct device and not rely on misc_device,
> 
> Yes, that is the way.  You can not use misc_device for anything other
> than creating the char node that your driver can use through the fileops
> you pass to it.
> 
> Do not use a misc_device to create sysfs files for, or anything else, it
> will be wrong and racy, as you have pointed out.

Thanks!

Can you quickly comment on when a misc device should be used compared to
alloc_chrdev_region & cdev_add ?

Jason

WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Greg Kroah-Hartman
	<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
Cc: Russell King - ARM Linux
	<linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
	Jens Wiklander
	<jens.wiklander-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	valentin.manea-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	javier-5MUHepqpBA1BDgjK7y7TUQ@public.gmane.org,
	emmanuel.michel-qxv4g6HH51o@public.gmane.org,
	Herbert Xu
	<herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>,
	Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	jean-michel.delorme-qxv4g6HH51o@public.gmane.org,
	tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [tpmdd-devel] [RFC PATCH 1/2] tee: generic TEE subsystem
Date: Mon, 20 Apr 2015 09:56:48 -0600	[thread overview]
Message-ID: <20150420155648.GA7676@obsidianresearch.com> (raw)
In-Reply-To: <20150420145432.GD7261-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>

On Mon, Apr 20, 2015 at 04:54:32PM +0200, Greg Kroah-Hartman wrote:
> On Sun, Apr 19, 2015 at 11:08:00PM -0600, Jason Gunthorpe wrote:
> > I still suspect the expected way to write a new mid layer is to create
> > your own struct device and not rely on misc_device,
> 
> Yes, that is the way.  You can not use misc_device for anything other
> than creating the char node that your driver can use through the fileops
> you pass to it.
> 
> Do not use a misc_device to create sysfs files for, or anything else, it
> will be wrong and racy, as you have pointed out.

Thanks!

Can you quickly comment on when a misc device should be used compared to
alloc_chrdev_region & cdev_add ?

Jason
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: jgunthorpe@obsidianresearch.com (Jason Gunthorpe)
To: linux-arm-kernel@lists.infradead.org
Subject: [tpmdd-devel] [RFC PATCH 1/2] tee: generic TEE subsystem
Date: Mon, 20 Apr 2015 09:56:48 -0600	[thread overview]
Message-ID: <20150420155648.GA7676@obsidianresearch.com> (raw)
In-Reply-To: <20150420145432.GD7261@kroah.com>

On Mon, Apr 20, 2015 at 04:54:32PM +0200, Greg Kroah-Hartman wrote:
> On Sun, Apr 19, 2015 at 11:08:00PM -0600, Jason Gunthorpe wrote:
> > I still suspect the expected way to write a new mid layer is to create
> > your own struct device and not rely on misc_device,
> 
> Yes, that is the way.  You can not use misc_device for anything other
> than creating the char node that your driver can use through the fileops
> you pass to it.
> 
> Do not use a misc_device to create sysfs files for, or anything else, it
> will be wrong and racy, as you have pointed out.

Thanks!

Can you quickly comment on when a misc device should be used compared to
alloc_chrdev_region & cdev_add ?

Jason

  reply	other threads:[~2015-04-20 15:57 UTC|newest]

Thread overview: 85+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-17  7:50 [RFC PATCH 0/2] generic TEE subsystem Jens Wiklander
2015-04-17  7:50 ` Jens Wiklander
2015-04-17  7:50 ` Jens Wiklander
2015-04-17  7:50 ` [RFC PATCH 1/2] tee: " Jens Wiklander
2015-04-17  7:50   ` Jens Wiklander
2015-04-17  7:50   ` Jens Wiklander
2015-04-17 16:30   ` [tpmdd-devel] " Jason Gunthorpe
2015-04-17 16:30     ` Jason Gunthorpe
2015-04-18  9:01     ` Russell King - ARM Linux
2015-04-18  9:01       ` Russell King - ARM Linux
2015-04-18  9:01       ` Russell King - ARM Linux
2015-04-18 17:29       ` Jason Gunthorpe
2015-04-18 17:29         ` Jason Gunthorpe
2015-04-18 17:29         ` Jason Gunthorpe
2015-04-18 21:57         ` Russell King - ARM Linux
2015-04-18 21:57           ` Russell King - ARM Linux
2015-04-18 21:57           ` Russell King - ARM Linux
2015-04-20  5:08           ` Jason Gunthorpe
2015-04-20  5:08             ` Jason Gunthorpe
2015-04-20 14:54             ` Greg Kroah-Hartman
2015-04-20 14:54               ` Greg Kroah-Hartman
2015-04-20 15:56               ` Jason Gunthorpe [this message]
2015-04-20 15:56                 ` Jason Gunthorpe
2015-04-20 15:56                 ` Jason Gunthorpe
2015-04-20 16:05                 ` Greg Kroah-Hartman
2015-04-20 16:05                   ` Greg Kroah-Hartman
2015-04-20 16:05                   ` Greg Kroah-Hartman
2015-04-20 13:02         ` Jens Wiklander
2015-04-20 13:02           ` Jens Wiklander
2015-04-20 13:02           ` Jens Wiklander
2015-04-20 17:55           ` Jason Gunthorpe
2015-04-20 17:55             ` Jason Gunthorpe
2015-04-20 17:55             ` Jason Gunthorpe
2015-04-21  5:59             ` Jens Wiklander
2015-04-21  5:59               ` Jens Wiklander
2015-04-17 20:07   ` Arnd Bergmann
2015-04-17 20:07     ` Arnd Bergmann
2015-04-18  7:20     ` Paul Bolle
2015-04-18  7:20       ` Paul Bolle
2015-04-18  7:20       ` Paul Bolle
2015-04-20  6:20     ` Jens Wiklander
2015-04-20  6:20       ` Jens Wiklander
2015-04-20 18:20       ` [tpmdd-devel] " Jason Gunthorpe
2015-04-20 18:20         ` Jason Gunthorpe
2015-04-21 10:45         ` Jens Wiklander
2015-04-21 10:45           ` Jens Wiklander
2015-04-18  8:55   ` Greg Kroah-Hartman
2015-04-18  8:55     ` Greg Kroah-Hartman
2015-04-18  8:57   ` Greg Kroah-Hartman
2015-04-18  8:57     ` Greg Kroah-Hartman
2015-04-18  9:04     ` Russell King - ARM Linux
2015-04-18  9:04       ` Russell King - ARM Linux
2015-04-18  9:04       ` Russell King - ARM Linux
2015-04-18 18:47       ` Greg Kroah-Hartman
2015-04-18 18:47         ` Greg Kroah-Hartman
2015-04-18 19:02         ` Russell King - ARM Linux
2015-04-18 19:02           ` Russell King - ARM Linux
2015-04-18 20:37           ` Greg Kroah-Hartman
2015-04-18 20:37             ` Greg Kroah-Hartman
2015-04-18 20:50             ` Russell King - ARM Linux
2015-04-18 20:50               ` Russell King - ARM Linux
2015-04-19  7:00               ` Greg Kroah-Hartman
2015-04-19  7:00                 ` Greg Kroah-Hartman
2015-04-17  7:50 ` [RFC PATCH 2/2] tee: add OP-TEE driver Jens Wiklander
2015-04-17  7:50   ` Jens Wiklander
2015-04-17  7:50   ` Jens Wiklander
2015-04-18  8:57   ` Greg Kroah-Hartman
2015-04-18  8:57     ` Greg Kroah-Hartman
2015-04-18  9:36     ` Javier González
2015-04-18  9:36       ` Javier González
2015-04-18  9:36       ` Javier González
2015-04-18 18:49       ` Greg Kroah-Hartman
2015-04-18 18:49         ` Greg Kroah-Hartman
2015-04-18 19:01         ` Arnd Bergmann
2015-04-18 19:01           ` Arnd Bergmann
2015-04-19 11:17           ` Javier González
2015-04-19 11:17             ` Javier González
2015-04-19 19:47             ` Arnd Bergmann
2015-04-19 19:47               ` Arnd Bergmann
2015-04-20  7:05               ` Javier González
2015-04-20  7:05                 ` Javier González
2015-04-20  7:05                 ` Javier González
2015-04-20  6:42     ` Jens Wiklander
2015-04-20  6:42       ` Jens Wiklander
2015-04-20  6:42       ` Jens Wiklander

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150420155648.GA7676@obsidianresearch.com \
    --to=jgunthorpe@obsidianresearch.com \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=emmanuel.michel@st.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=javier@javigon.com \
    --cc=jean-michel.delorme@st.com \
    --cc=jens.wiklander@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=tpmdd-devel@lists.sourceforge.net \
    --cc=valentin.manea@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.