From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jens Wiklander <jens.wiklander@linaro.org>,
valentin.manea@huawei.com, devicetree@vger.kernel.org,
javier@javigon.com, emmanuel.michel@st.com,
Herbert Xu <herbert@gondor.apana.org.au>,
Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org, jean-michel.delorme@st.com,
tpmdd-devel@lists.sourceforge.net,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH 1/2] tee: generic TEE subsystem
Date: Sat, 18 Apr 2015 10:04:20 +0100 [thread overview]
Message-ID: <20150418090420.GG12732@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20150418085712.GB29858@kroah.com>
On Sat, Apr 18, 2015 at 10:57:12AM +0200, Greg Kroah-Hartman wrote:
> On Fri, Apr 17, 2015 at 09:50:56AM +0200, Jens Wiklander wrote:
> > +struct tee_device {
> > + char name[TEE_MAX_DEV_NAME_LEN];
> > + const struct tee_desc *desc;
> > + struct device *dev;
>
> No, please embed the device in your structure, don't have a pointer to
> it.
Greg, "dev" here is not a locally allocated device, but the parent device.
It's actually the same as struct tee_device.miscdev.parent, which could be
used instead and this member deleted.
--
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
To: Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
Cc: Jens Wiklander
<jens.wiklander-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
valentin.manea-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
javier-5MUHepqpBA1BDgjK7y7TUQ@public.gmane.org,
emmanuel.michel-qxv4g6HH51o@public.gmane.org,
Herbert Xu
<herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
jean-michel.delorme-qxv4g6HH51o@public.gmane.org,
tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [RFC PATCH 1/2] tee: generic TEE subsystem
Date: Sat, 18 Apr 2015 10:04:20 +0100 [thread overview]
Message-ID: <20150418090420.GG12732@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20150418085712.GB29858-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
On Sat, Apr 18, 2015 at 10:57:12AM +0200, Greg Kroah-Hartman wrote:
> On Fri, Apr 17, 2015 at 09:50:56AM +0200, Jens Wiklander wrote:
> > +struct tee_device {
> > + char name[TEE_MAX_DEV_NAME_LEN];
> > + const struct tee_desc *desc;
> > + struct device *dev;
>
> No, please embed the device in your structure, don't have a pointer to
> it.
Greg, "dev" here is not a locally allocated device, but the parent device.
It's actually the same as struct tee_device.miscdev.parent, which could be
used instead and this member deleted.
--
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 1/2] tee: generic TEE subsystem
Date: Sat, 18 Apr 2015 10:04:20 +0100 [thread overview]
Message-ID: <20150418090420.GG12732@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20150418085712.GB29858@kroah.com>
On Sat, Apr 18, 2015 at 10:57:12AM +0200, Greg Kroah-Hartman wrote:
> On Fri, Apr 17, 2015 at 09:50:56AM +0200, Jens Wiklander wrote:
> > +struct tee_device {
> > + char name[TEE_MAX_DEV_NAME_LEN];
> > + const struct tee_desc *desc;
> > + struct device *dev;
>
> No, please embed the device in your structure, don't have a pointer to
> it.
Greg, "dev" here is not a locally allocated device, but the parent device.
It's actually the same as struct tee_device.miscdev.parent, which could be
used instead and this member deleted.
--
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2015-04-18 9:04 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-17 7:50 [RFC PATCH 0/2] generic TEE subsystem Jens Wiklander
2015-04-17 7:50 ` Jens Wiklander
2015-04-17 7:50 ` Jens Wiklander
2015-04-17 7:50 ` [RFC PATCH 1/2] tee: " Jens Wiklander
2015-04-17 7:50 ` Jens Wiklander
2015-04-17 7:50 ` Jens Wiklander
2015-04-17 16:30 ` [tpmdd-devel] " Jason Gunthorpe
2015-04-17 16:30 ` Jason Gunthorpe
2015-04-18 9:01 ` Russell King - ARM Linux
2015-04-18 9:01 ` Russell King - ARM Linux
2015-04-18 9:01 ` Russell King - ARM Linux
2015-04-18 17:29 ` Jason Gunthorpe
2015-04-18 17:29 ` Jason Gunthorpe
2015-04-18 17:29 ` Jason Gunthorpe
2015-04-18 21:57 ` Russell King - ARM Linux
2015-04-18 21:57 ` Russell King - ARM Linux
2015-04-18 21:57 ` Russell King - ARM Linux
2015-04-20 5:08 ` Jason Gunthorpe
2015-04-20 5:08 ` Jason Gunthorpe
2015-04-20 14:54 ` Greg Kroah-Hartman
2015-04-20 14:54 ` Greg Kroah-Hartman
2015-04-20 15:56 ` Jason Gunthorpe
2015-04-20 15:56 ` Jason Gunthorpe
2015-04-20 15:56 ` Jason Gunthorpe
2015-04-20 16:05 ` Greg Kroah-Hartman
2015-04-20 16:05 ` Greg Kroah-Hartman
2015-04-20 16:05 ` Greg Kroah-Hartman
2015-04-20 13:02 ` Jens Wiklander
2015-04-20 13:02 ` Jens Wiklander
2015-04-20 13:02 ` Jens Wiklander
2015-04-20 17:55 ` Jason Gunthorpe
2015-04-20 17:55 ` Jason Gunthorpe
2015-04-20 17:55 ` Jason Gunthorpe
2015-04-21 5:59 ` Jens Wiklander
2015-04-21 5:59 ` Jens Wiklander
2015-04-17 20:07 ` Arnd Bergmann
2015-04-17 20:07 ` Arnd Bergmann
2015-04-18 7:20 ` Paul Bolle
2015-04-18 7:20 ` Paul Bolle
2015-04-18 7:20 ` Paul Bolle
2015-04-20 6:20 ` Jens Wiklander
2015-04-20 6:20 ` Jens Wiklander
2015-04-20 18:20 ` [tpmdd-devel] " Jason Gunthorpe
2015-04-20 18:20 ` Jason Gunthorpe
2015-04-21 10:45 ` Jens Wiklander
2015-04-21 10:45 ` Jens Wiklander
2015-04-18 8:55 ` Greg Kroah-Hartman
2015-04-18 8:55 ` Greg Kroah-Hartman
2015-04-18 8:57 ` Greg Kroah-Hartman
2015-04-18 8:57 ` Greg Kroah-Hartman
2015-04-18 9:04 ` Russell King - ARM Linux [this message]
2015-04-18 9:04 ` Russell King - ARM Linux
2015-04-18 9:04 ` Russell King - ARM Linux
2015-04-18 18:47 ` Greg Kroah-Hartman
2015-04-18 18:47 ` Greg Kroah-Hartman
2015-04-18 19:02 ` Russell King - ARM Linux
2015-04-18 19:02 ` Russell King - ARM Linux
2015-04-18 20:37 ` Greg Kroah-Hartman
2015-04-18 20:37 ` Greg Kroah-Hartman
2015-04-18 20:50 ` Russell King - ARM Linux
2015-04-18 20:50 ` Russell King - ARM Linux
2015-04-19 7:00 ` Greg Kroah-Hartman
2015-04-19 7:00 ` Greg Kroah-Hartman
2015-04-17 7:50 ` [RFC PATCH 2/2] tee: add OP-TEE driver Jens Wiklander
2015-04-17 7:50 ` Jens Wiklander
2015-04-17 7:50 ` Jens Wiklander
2015-04-18 8:57 ` Greg Kroah-Hartman
2015-04-18 8:57 ` Greg Kroah-Hartman
2015-04-18 9:36 ` Javier González
2015-04-18 9:36 ` Javier González
2015-04-18 9:36 ` Javier González
2015-04-18 18:49 ` Greg Kroah-Hartman
2015-04-18 18:49 ` Greg Kroah-Hartman
2015-04-18 19:01 ` Arnd Bergmann
2015-04-18 19:01 ` Arnd Bergmann
2015-04-19 11:17 ` Javier González
2015-04-19 11:17 ` Javier González
2015-04-19 19:47 ` Arnd Bergmann
2015-04-19 19:47 ` Arnd Bergmann
2015-04-20 7:05 ` Javier González
2015-04-20 7:05 ` Javier González
2015-04-20 7:05 ` Javier González
2015-04-20 6:42 ` Jens Wiklander
2015-04-20 6:42 ` Jens Wiklander
2015-04-20 6:42 ` Jens Wiklander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150418090420.GG12732@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=emmanuel.michel@st.com \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=javier@javigon.com \
--cc=jean-michel.delorme@st.com \
--cc=jens.wiklander@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=valentin.manea@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.