From: Vinod Koul <vinod.koul@intel.com> To: Nicholas Mc Guire <hofrat@osadl.org> Cc: David Woodhouse <dwmw2@infradead.org>, Brian Norris <computersforpeace@gmail.com>, Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>, Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>, Wolfram Sang <wsa@the-dreams.de>, Arnd Bergmann <arnd@arndb.de>, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] mtd: sh_flctl: fix wrapped condition alignment Date: Mon, 4 May 2015 10:51:38 +0530 [thread overview] Message-ID: <20150504052138.GX3521@localhost> (raw) In-Reply-To: <1430553430-21396-4-git-send-email-hofrat@osadl.org> On Sat, May 02, 2015 at 09:57:10AM +0200, Nicholas Mc Guire wrote: > CodingStyle fix only - align function parameters to opening (. > This doesnt look any better to me... -- ~Vinod > Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org> > --- > > Patch was compile tested with ap325rxa_defconfig (implies > CONFIG_MTD_NAND_SH_FLCTL=y) > > Patch is against 4.1-rc1 (localversion-next is -next-20150501) > > drivers/mtd/nand/sh_flctl.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/mtd/nand/sh_flctl.c b/drivers/mtd/nand/sh_flctl.c > index ffda530..2078c4d 100644 > --- a/drivers/mtd/nand/sh_flctl.c > +++ b/drivers/mtd/nand/sh_flctl.c > @@ -428,8 +428,8 @@ static void read_fiforeg(struct sh_flctl *flctl, int rlen, int offset) > > /* initiate DMA transfer */ > if (flctl->chan_fifo0_rx && rlen >= 32 && > - flctl_dma_fifo0_transfer(flctl, buf, rlen, DMA_DEV_TO_MEM) == 0) > - goto convert; /* DMA success */ > + flctl_dma_fifo0_transfer(flctl, buf, rlen, DMA_DEV_TO_MEM) == 0) > + goto convert; /* DMA success */ > > /* do polling transfer */ > for (i = 0; i < len_4align; i++) { > @@ -487,8 +487,8 @@ static void write_ec_fiforeg(struct sh_flctl *flctl, int rlen, > > /* initiate DMA transfer */ > if (flctl->chan_fifo0_tx && rlen >= 32 && > - flctl_dma_fifo0_transfer(flctl, buf, rlen, DMA_MEM_TO_DEV) == 0) > - return; /* DMA success */ > + flctl_dma_fifo0_transfer(flctl, buf, rlen, DMA_MEM_TO_DEV) == 0) > + return; /* DMA success */ > > /* do polling transfer */ > for (i = 0; i < len_4align; i++) { > -- > 1.7.10.4 > --
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@intel.com> To: Nicholas Mc Guire <hofrat@osadl.org> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>, Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>, Arnd Bergmann <arnd@arndb.de>, Wolfram Sang <wsa@the-dreams.de>, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, Brian Norris <computersforpeace@gmail.com>, David Woodhouse <dwmw2@infradead.org> Subject: Re: [PATCH 4/4] mtd: sh_flctl: fix wrapped condition alignment Date: Mon, 4 May 2015 10:51:38 +0530 [thread overview] Message-ID: <20150504052138.GX3521@localhost> (raw) In-Reply-To: <1430553430-21396-4-git-send-email-hofrat@osadl.org> On Sat, May 02, 2015 at 09:57:10AM +0200, Nicholas Mc Guire wrote: > CodingStyle fix only - align function parameters to opening (. > This doesnt look any better to me... -- ~Vinod > Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org> > --- > > Patch was compile tested with ap325rxa_defconfig (implies > CONFIG_MTD_NAND_SH_FLCTL=y) > > Patch is against 4.1-rc1 (localversion-next is -next-20150501) > > drivers/mtd/nand/sh_flctl.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/mtd/nand/sh_flctl.c b/drivers/mtd/nand/sh_flctl.c > index ffda530..2078c4d 100644 > --- a/drivers/mtd/nand/sh_flctl.c > +++ b/drivers/mtd/nand/sh_flctl.c > @@ -428,8 +428,8 @@ static void read_fiforeg(struct sh_flctl *flctl, int rlen, int offset) > > /* initiate DMA transfer */ > if (flctl->chan_fifo0_rx && rlen >= 32 && > - flctl_dma_fifo0_transfer(flctl, buf, rlen, DMA_DEV_TO_MEM) == 0) > - goto convert; /* DMA success */ > + flctl_dma_fifo0_transfer(flctl, buf, rlen, DMA_DEV_TO_MEM) == 0) > + goto convert; /* DMA success */ > > /* do polling transfer */ > for (i = 0; i < len_4align; i++) { > @@ -487,8 +487,8 @@ static void write_ec_fiforeg(struct sh_flctl *flctl, int rlen, > > /* initiate DMA transfer */ > if (flctl->chan_fifo0_tx && rlen >= 32 && > - flctl_dma_fifo0_transfer(flctl, buf, rlen, DMA_MEM_TO_DEV) == 0) > - return; /* DMA success */ > + flctl_dma_fifo0_transfer(flctl, buf, rlen, DMA_MEM_TO_DEV) == 0) > + return; /* DMA success */ > > /* do polling transfer */ > for (i = 0; i < len_4align; i++) { > -- > 1.7.10.4 > --
next prev parent reply other threads:[~2015-05-04 5:21 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-05-02 7:57 [PATCH 1/4] mtd: sh_flctl: let flctl_dma_fifo0_transfer return 0 on success Nicholas Mc Guire 2015-05-02 7:57 ` Nicholas Mc Guire 2015-05-02 7:57 ` [PATCH 2/4] mtd: sh_flctl: drop unused variable Nicholas Mc Guire 2015-05-02 7:57 ` Nicholas Mc Guire 2015-05-03 19:33 ` Laurent Pinchart 2015-05-03 19:33 ` Laurent Pinchart 2015-05-04 5:17 ` Vinod Koul 2015-05-04 5:17 ` Vinod Koul 2015-05-04 6:03 ` Nicholas Mc Guire 2015-05-04 6:03 ` Nicholas Mc Guire 2015-05-04 7:53 ` Laurent Pinchart 2015-05-04 7:53 ` Laurent Pinchart 2015-05-10 13:49 ` Nicholas Mc Guire 2015-05-10 13:49 ` Nicholas Mc Guire 2015-05-02 7:57 ` [PATCH 3/4] mtd: sh_flctl: fix function parameter alignment Nicholas Mc Guire 2015-05-02 7:57 ` Nicholas Mc Guire 2015-05-02 7:57 ` [PATCH 4/4] mtd: sh_flctl: fix wrapped condition alignment Nicholas Mc Guire 2015-05-02 7:57 ` Nicholas Mc Guire 2015-05-04 5:21 ` Vinod Koul [this message] 2015-05-04 5:21 ` Vinod Koul 2015-05-04 5:43 ` Nicholas Mc Guire 2015-05-04 5:43 ` Nicholas Mc Guire 2015-05-04 7:05 ` Joe Perches 2015-05-04 7:05 ` Joe Perches 2015-05-03 19:35 ` [PATCH 1/4] mtd: sh_flctl: let flctl_dma_fifo0_transfer return 0 on success Laurent Pinchart 2015-05-03 19:35 ` Laurent Pinchart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20150504052138.GX3521@localhost \ --to=vinod.koul@intel.com \ --cc=arnd@arndb.de \ --cc=computersforpeace@gmail.com \ --cc=dwmw2@infradead.org \ --cc=hofrat@osadl.org \ --cc=kuninori.morimoto.gx@renesas.com \ --cc=laurent.pinchart+renesas@ideasonboard.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=wsa@the-dreams.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.