From: Christoph Hellwig <hch@infradead.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org
Subject: Re: fix queue_lock usage in blk-mq and nvme
Date: Mon, 18 May 2015 23:37:09 -0700 [thread overview]
Message-ID: <20150519063709.GA22313@infradead.org> (raw)
In-Reply-To: <1430984294-25859-1-git-send-email-hch@lst.de>
ping?
On Thu, May 07, 2015 at 09:38:12AM +0200, Christoph Hellwig wrote:
> Historically we always take queue_lock with irqs disabled. Blk-mq doesn't really
> use the queue_lock much, but when it does it needs to follow this rules to make
> lockdep happy.
>
> The first patch removes a queue_lock usage instead of fixing things properly,
> and the second is a bad-aid for nvme. In the long run I'd prefer to remove
> other users of the queue_lock from blk-mq and blk-mq based driver entirely,
> but that will require a bit more work.
>
>
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme
---end quoted text---
WARNING: multiple messages have this Message-ID (diff)
From: hch@infradead.org (Christoph Hellwig)
Subject: fix queue_lock usage in blk-mq and nvme
Date: Mon, 18 May 2015 23:37:09 -0700 [thread overview]
Message-ID: <20150519063709.GA22313@infradead.org> (raw)
In-Reply-To: <1430984294-25859-1-git-send-email-hch@lst.de>
ping?
On Thu, May 07, 2015@09:38:12AM +0200, Christoph Hellwig wrote:
> Historically we always take queue_lock with irqs disabled. Blk-mq doesn't really
> use the queue_lock much, but when it does it needs to follow this rules to make
> lockdep happy.
>
> The first patch removes a queue_lock usage instead of fixing things properly,
> and the second is a bad-aid for nvme. In the long run I'd prefer to remove
> other users of the queue_lock from blk-mq and blk-mq based driver entirely,
> but that will require a bit more work.
>
>
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme
---end quoted text---
next prev parent reply other threads:[~2015-05-19 6:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 7:38 fix queue_lock usage in blk-mq and nvme Christoph Hellwig
2015-05-07 7:38 ` Christoph Hellwig
2015-05-07 7:38 ` [PATCH 1/2] block: use an atomic_t for mq_freeze_depth Christoph Hellwig
2015-05-07 7:38 ` Christoph Hellwig
2015-05-07 7:38 ` [PATCH 2/2] nvme: disable irqs in nvme_freeze_queues Christoph Hellwig
2015-05-07 7:38 ` Christoph Hellwig
2015-05-19 6:37 ` Christoph Hellwig [this message]
2015-05-19 6:37 ` fix queue_lock usage in blk-mq and nvme Christoph Hellwig
2015-05-19 15:14 ` Jens Axboe
2015-05-19 15:14 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150519063709.GA22313@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.