From: Dmitry Torokhov <dmitry.torokhov@gmail.com> To: Felipe Balbi <balbi@ti.com> Cc: Maxime Ripard <maxime.ripard@free-electrons.com>, Pavel Machek <pavel@ucw.cz>, Sebastian Reichel <sre@kernel.org>, kernel list <linux-kernel@vger.kernel.org>, pali.rohar@gmail.com, sre@debian.org, sre@ring0.de, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org, aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com, patrikbachan@gmail.com Subject: Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900 Date: Fri, 29 May 2015 13:29:54 -0700 [thread overview] Message-ID: <20150529202954.GA26494@localhost> (raw) In-Reply-To: <20150529202123.GY2026@saruman.tx.rr.com> On Fri, May 29, 2015 at 03:21:23PM -0500, Felipe Balbi wrote: > On Fri, May 29, 2015 at 10:17:45PM +0200, Maxime Ripard wrote: > > On Fri, May 29, 2015 at 09:56:29PM +0200, Pavel Machek wrote: > > > On Fri 2015-05-29 14:49:55, Felipe Balbi wrote: > > > > Hi, > > > > > > > > On Fri, May 29, 2015 at 09:32:11PM +0200, Pavel Machek wrote: > > > > > Fix dts to match what the Linux kernel expects. This works around > > > > > touchscreen problems in 4.1 linux on Nokia n900. > > > > > > > > > > Signed-off-by: Pavel Machek <pavel@ucw.cz> > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/tsc2005.txt b/Documentation/devicetree/bindings/input/touchscreen/tsc2005.txt > > > > > index 4b641c7..09089a6 100644 > > > > > --- a/Documentation/devicetree/bindings/input/touchscreen/tsc2005.txt > > > > > +++ b/Documentation/devicetree/bindings/input/touchscreen/tsc2005.txt > > > > > @@ -32,8 +32,8 @@ Example: > > > > > touchscreen-fuzz-x = <4>; > > > > > touchscreen-fuzz-y = <7>; > > > > > touchscreen-fuzz-pressure = <2>; > > > > > - touchscreen-max-x = <4096>; > > > > > - touchscreen-max-y = <4096>; > > > > > + touchscreen-size-x = <4096>; > > > > > + touchscreen-size-y = <4096>; > > > > > > > > IMHO, the older binding needs to be supported as well. It's fine to > > > > update the DTS for the new binding, but even Documentation says > > > > touchscreen-max-[xy] and if the driver changed that, the driver should > > > > be fixed too. Besides, it seems like this has been in tree since > > > > v3.16: > > > > > > Agreed. In parent email, I have list of two commits that should be > > > reverted. > > > > So, if we sums things up. You introduce in some documentation example > > some property, that you never document, that you still use in one > > it was Documented in DT bindings document for this particular driver. > What are you talking about ? It was documented in "example", not in the documentation that says: - properties defined in touchscreen.txt which says nothing about touchscreen-max-x. And _noone_ has ever parsed this property, so adding support for it does not make any sense. > > > single DT, you don't even use that property in your driver, and now > > that you realise you meant something else, you want the code that > > not Pali, Sebastian. > > > actually parse the *right* property and does the right thing, that all > > other DT agree (and depend on) to be reverted? > > We shouldn't revert, that I agree. But both properties should be parsed. No. If the property is wrong, and nobody parsed it, I do not see any reason to start now. -- Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: dmitry.torokhov@gmail.com (Dmitry Torokhov) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900 Date: Fri, 29 May 2015 13:29:54 -0700 [thread overview] Message-ID: <20150529202954.GA26494@localhost> (raw) In-Reply-To: <20150529202123.GY2026@saruman.tx.rr.com> On Fri, May 29, 2015 at 03:21:23PM -0500, Felipe Balbi wrote: > On Fri, May 29, 2015 at 10:17:45PM +0200, Maxime Ripard wrote: > > On Fri, May 29, 2015 at 09:56:29PM +0200, Pavel Machek wrote: > > > On Fri 2015-05-29 14:49:55, Felipe Balbi wrote: > > > > Hi, > > > > > > > > On Fri, May 29, 2015 at 09:32:11PM +0200, Pavel Machek wrote: > > > > > Fix dts to match what the Linux kernel expects. This works around > > > > > touchscreen problems in 4.1 linux on Nokia n900. > > > > > > > > > > Signed-off-by: Pavel Machek <pavel@ucw.cz> > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/tsc2005.txt b/Documentation/devicetree/bindings/input/touchscreen/tsc2005.txt > > > > > index 4b641c7..09089a6 100644 > > > > > --- a/Documentation/devicetree/bindings/input/touchscreen/tsc2005.txt > > > > > +++ b/Documentation/devicetree/bindings/input/touchscreen/tsc2005.txt > > > > > @@ -32,8 +32,8 @@ Example: > > > > > touchscreen-fuzz-x = <4>; > > > > > touchscreen-fuzz-y = <7>; > > > > > touchscreen-fuzz-pressure = <2>; > > > > > - touchscreen-max-x = <4096>; > > > > > - touchscreen-max-y = <4096>; > > > > > + touchscreen-size-x = <4096>; > > > > > + touchscreen-size-y = <4096>; > > > > > > > > IMHO, the older binding needs to be supported as well. It's fine to > > > > update the DTS for the new binding, but even Documentation says > > > > touchscreen-max-[xy] and if the driver changed that, the driver should > > > > be fixed too. Besides, it seems like this has been in tree since > > > > v3.16: > > > > > > Agreed. In parent email, I have list of two commits that should be > > > reverted. > > > > So, if we sums things up. You introduce in some documentation example > > some property, that you never document, that you still use in one > > it was Documented in DT bindings document for this particular driver. > What are you talking about ? It was documented in "example", not in the documentation that says: - properties defined in touchscreen.txt which says nothing about touchscreen-max-x. And _noone_ has ever parsed this property, so adding support for it does not make any sense. > > > single DT, you don't even use that property in your driver, and now > > that you realise you meant something else, you want the code that > > not Pali, Sebastian. > > > actually parse the *right* property and does the right thing, that all > > other DT agree (and depend on) to be reverted? > > We shouldn't revert, that I agree. But both properties should be parsed. No. If the property is wrong, and nobody parsed it, I do not see any reason to start now. -- Dmitry
next prev parent reply other threads:[~2015-05-29 20:30 UTC|newest] Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <201505241444.41039@pali> [not found] ` <20150527132545.GA23434@amd> [not found] ` <20150527133311.GJ30798@pali> [not found] ` <20150527143722.GA28108@amd> [not found] ` <20150527145837.GA13223@earth> 2015-05-29 19:08 ` 4.1 touchscreen regression on n900 -- pinpointed [was Re: linux-n900 v4.1-rc4] Pavel Machek 2015-05-29 19:25 ` Pavel Machek 2015-05-29 19:32 ` [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900 Pavel Machek 2015-05-29 19:32 ` Pavel Machek 2015-05-29 19:32 ` Pavel Machek 2015-05-29 19:49 ` Felipe Balbi 2015-05-29 19:49 ` Felipe Balbi 2015-05-29 19:49 ` Felipe Balbi 2015-05-29 19:56 ` Pavel Machek 2015-05-29 19:56 ` Pavel Machek 2015-05-29 20:17 ` Maxime Ripard 2015-05-29 20:17 ` Maxime Ripard 2015-05-29 20:21 ` Felipe Balbi 2015-05-29 20:21 ` Felipe Balbi 2015-05-29 20:21 ` Felipe Balbi 2015-05-29 20:29 ` Dmitry Torokhov [this message] 2015-05-29 20:29 ` Dmitry Torokhov 2015-05-29 20:34 ` Pavel Machek 2015-05-29 20:34 ` Pavel Machek 2015-05-29 20:48 ` Dmitry Torokhov 2015-05-29 20:48 ` Dmitry Torokhov 2015-05-29 21:02 ` Pavel Machek 2015-05-29 21:02 ` Pavel Machek 2015-05-29 21:38 ` Dmitry Torokhov 2015-05-29 21:38 ` Dmitry Torokhov 2015-06-01 9:55 ` Maxime Ripard 2015-06-01 9:55 ` Maxime Ripard 2015-06-01 14:06 ` Please revert 3eea8b5d68c801fec788b411582b803463834752 as it breaks touchscreen " Pavel Machek 2015-06-01 14:58 ` Maxime Ripard 2015-06-01 14:58 ` Maxime Ripard 2015-06-01 15:21 ` Pavel Machek 2015-06-01 15:21 ` Pavel Machek 2015-06-01 17:47 ` Dmitry Torokhov 2015-06-01 17:47 ` Dmitry Torokhov 2015-06-01 20:27 ` Pavel Machek 2015-06-01 20:27 ` Pavel Machek 2015-06-01 20:45 ` Dmitry Torokhov 2015-06-01 20:45 ` Dmitry Torokhov 2015-06-01 20:54 ` Tony Lindgren 2015-06-01 20:54 ` Tony Lindgren 2015-06-01 21:22 ` Maxime Ripard 2015-06-01 21:22 ` Maxime Ripard 2015-06-01 21:32 ` Dmitry Torokhov 2015-06-01 21:32 ` Dmitry Torokhov 2015-06-02 8:25 ` Pavel Machek 2015-06-02 8:25 ` Pavel Machek 2015-06-02 9:44 ` Maxime Ripard 2015-06-02 9:44 ` Maxime Ripard 2015-06-02 17:58 ` Dmitry Torokhov 2015-06-02 17:58 ` Dmitry Torokhov 2015-06-02 18:08 ` Dmitry Torokhov 2015-06-02 18:08 ` Dmitry Torokhov 2015-06-25 20:25 ` Pavel Machek 2015-06-25 20:25 ` Pavel Machek 2015-05-29 20:22 ` [PATCH] fix n900 dts file to work around 4.1 touchscreen regression " Dmitry Torokhov 2015-05-29 20:22 ` Dmitry Torokhov 2015-05-29 20:03 ` Maxime Ripard 2015-05-29 20:03 ` Maxime Ripard 2015-05-29 20:18 ` Tony Lindgren 2015-05-29 20:18 ` Tony Lindgren 2015-05-29 20:30 ` Pavel Machek 2015-05-29 20:30 ` Pavel Machek 2015-05-30 10:14 ` Pavel Machek 2015-05-30 10:14 ` Pavel Machek 2015-06-01 9:49 ` Maxime Ripard 2015-06-01 9:49 ` Maxime Ripard 2015-06-01 9:54 ` Pavel Machek 2015-06-01 9:54 ` Pavel Machek 2015-05-30 2:21 ` Sebastian Reichel 2015-05-30 2:21 ` Sebastian Reichel 2015-05-30 2:24 ` [PATCH] Input: of_touchscreen - remove interdependence of max/fuzz values Sebastian Reichel 2015-05-30 6:26 ` Pavel Machek 2015-05-29 19:57 ` 4.1 touchscreen regression on n900 -- pinpointed [was Re: linux-n900 v4.1-rc4] Maxime Ripard 2015-05-29 20:29 ` Pavel Machek 2015-05-29 21:17 ` Pavel Machek 2015-05-29 21:36 ` Dmitry Torokhov 2015-05-29 21:58 ` Pavel Machek
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20150529202954.GA26494@localhost \ --to=dmitry.torokhov@gmail.com \ --cc=aaro.koskinen@iki.fi \ --cc=balbi@ti.com \ --cc=ivo.g.dimitrov.75@gmail.com \ --cc=khilman@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=maxime.ripard@free-electrons.com \ --cc=pali.rohar@gmail.com \ --cc=patrikbachan@gmail.com \ --cc=pavel@ucw.cz \ --cc=sre@debian.org \ --cc=sre@kernel.org \ --cc=sre@ring0.de \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.