From: Pavel Machek <pavel@ucw.cz> To: Dmitry Torokhov <dmitry.torokhov@gmail.com> Cc: Felipe Balbi <balbi@ti.com>, Maxime Ripard <maxime.ripard@free-electrons.com>, Sebastian Reichel <sre@kernel.org>, kernel list <linux-kernel@vger.kernel.org>, pali.rohar@gmail.com, sre@debian.org, sre@ring0.de, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org, aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com, patrikbachan@gmail.com Subject: Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900 Date: Fri, 29 May 2015 23:02:59 +0200 [thread overview] Message-ID: <20150529210259.GA26866@amd> (raw) In-Reply-To: <20150529204847.GA7429@dtor-ws> On Fri 2015-05-29 13:48:47, Dmitry Torokhov wrote: > On Fri, May 29, 2015 at 10:34:56PM +0200, Pavel Machek wrote: > > Hi! > > > > > > > single DT, you don't even use that property in your driver, and now > > > > > that you realise you meant something else, you want the code that > > > > > > > > not Pali, Sebastian. > > > > > > > > > actually parse the *right* property and does the right thing, that all > > > > > other DT agree (and depend on) to be reverted? > > > > > > > > We shouldn't revert, that I agree. But both properties should be parsed. > > > > > > No. If the property is wrong, and nobody parsed it, I do not see any reason to > > > start now. > > > > Agreed. > > > > But that's not what I'm asking. See a changelog of > > 3eea8b5d68c801fec788b411582b803463834752 and compare it with what it > > actually does. > > > > It is buggy. If fuzz is specified but maximum is not, it overwites > > maximum with zero. > > Yes. > > > > > Plus it introduces new failure "if (!test_bit(axis, dev->absbit))". > > That is not a new failure. It actually warns users that they trying to > specify in DT something that will be ignored by the kernel (because > without that absbit kernel will ignore all requests to that event code). What if driver sets the bits after parsing device tree? > > Plus it fails to distinguish between "value not specified in the dt" > > and "zero is specified in the dt". > > Yes. I am not sure if we should care and support all permutations (ah, I > pre-setup fuzz in the driver, but override max on X, and I pre-setup > max on X, but take fuzz from DT). Maybe we should simply document that > specifying one parameter for an axis will change the rest of them to be > 0. Not sure though... Well, the old code did support all permutations. "cleanups" should not change such details... -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
WARNING: multiple messages have this Message-ID (diff)
From: pavel@ucw.cz (Pavel Machek) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900 Date: Fri, 29 May 2015 23:02:59 +0200 [thread overview] Message-ID: <20150529210259.GA26866@amd> (raw) In-Reply-To: <20150529204847.GA7429@dtor-ws> On Fri 2015-05-29 13:48:47, Dmitry Torokhov wrote: > On Fri, May 29, 2015 at 10:34:56PM +0200, Pavel Machek wrote: > > Hi! > > > > > > > single DT, you don't even use that property in your driver, and now > > > > > that you realise you meant something else, you want the code that > > > > > > > > not Pali, Sebastian. > > > > > > > > > actually parse the *right* property and does the right thing, that all > > > > > other DT agree (and depend on) to be reverted? > > > > > > > > We shouldn't revert, that I agree. But both properties should be parsed. > > > > > > No. If the property is wrong, and nobody parsed it, I do not see any reason to > > > start now. > > > > Agreed. > > > > But that's not what I'm asking. See a changelog of > > 3eea8b5d68c801fec788b411582b803463834752 and compare it with what it > > actually does. > > > > It is buggy. If fuzz is specified but maximum is not, it overwites > > maximum with zero. > > Yes. > > > > > Plus it introduces new failure "if (!test_bit(axis, dev->absbit))". > > That is not a new failure. It actually warns users that they trying to > specify in DT something that will be ignored by the kernel (because > without that absbit kernel will ignore all requests to that event code). What if driver sets the bits after parsing device tree? > > Plus it fails to distinguish between "value not specified in the dt" > > and "zero is specified in the dt". > > Yes. I am not sure if we should care and support all permutations (ah, I > pre-setup fuzz in the driver, but override max on X, and I pre-setup > max on X, but take fuzz from DT). Maybe we should simply document that > specifying one parameter for an axis will change the rest of them to be > 0. Not sure though... Well, the old code did support all permutations. "cleanups" should not change such details... -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2015-05-29 21:03 UTC|newest] Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <201505241444.41039@pali> [not found] ` <20150527132545.GA23434@amd> [not found] ` <20150527133311.GJ30798@pali> [not found] ` <20150527143722.GA28108@amd> [not found] ` <20150527145837.GA13223@earth> 2015-05-29 19:08 ` 4.1 touchscreen regression on n900 -- pinpointed [was Re: linux-n900 v4.1-rc4] Pavel Machek 2015-05-29 19:25 ` Pavel Machek 2015-05-29 19:32 ` [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900 Pavel Machek 2015-05-29 19:32 ` Pavel Machek 2015-05-29 19:32 ` Pavel Machek 2015-05-29 19:49 ` Felipe Balbi 2015-05-29 19:49 ` Felipe Balbi 2015-05-29 19:49 ` Felipe Balbi 2015-05-29 19:56 ` Pavel Machek 2015-05-29 19:56 ` Pavel Machek 2015-05-29 20:17 ` Maxime Ripard 2015-05-29 20:17 ` Maxime Ripard 2015-05-29 20:21 ` Felipe Balbi 2015-05-29 20:21 ` Felipe Balbi 2015-05-29 20:21 ` Felipe Balbi 2015-05-29 20:29 ` Dmitry Torokhov 2015-05-29 20:29 ` Dmitry Torokhov 2015-05-29 20:34 ` Pavel Machek 2015-05-29 20:34 ` Pavel Machek 2015-05-29 20:48 ` Dmitry Torokhov 2015-05-29 20:48 ` Dmitry Torokhov 2015-05-29 21:02 ` Pavel Machek [this message] 2015-05-29 21:02 ` Pavel Machek 2015-05-29 21:38 ` Dmitry Torokhov 2015-05-29 21:38 ` Dmitry Torokhov 2015-06-01 9:55 ` Maxime Ripard 2015-06-01 9:55 ` Maxime Ripard 2015-06-01 14:06 ` Please revert 3eea8b5d68c801fec788b411582b803463834752 as it breaks touchscreen " Pavel Machek 2015-06-01 14:58 ` Maxime Ripard 2015-06-01 14:58 ` Maxime Ripard 2015-06-01 15:21 ` Pavel Machek 2015-06-01 15:21 ` Pavel Machek 2015-06-01 17:47 ` Dmitry Torokhov 2015-06-01 17:47 ` Dmitry Torokhov 2015-06-01 20:27 ` Pavel Machek 2015-06-01 20:27 ` Pavel Machek 2015-06-01 20:45 ` Dmitry Torokhov 2015-06-01 20:45 ` Dmitry Torokhov 2015-06-01 20:54 ` Tony Lindgren 2015-06-01 20:54 ` Tony Lindgren 2015-06-01 21:22 ` Maxime Ripard 2015-06-01 21:22 ` Maxime Ripard 2015-06-01 21:32 ` Dmitry Torokhov 2015-06-01 21:32 ` Dmitry Torokhov 2015-06-02 8:25 ` Pavel Machek 2015-06-02 8:25 ` Pavel Machek 2015-06-02 9:44 ` Maxime Ripard 2015-06-02 9:44 ` Maxime Ripard 2015-06-02 17:58 ` Dmitry Torokhov 2015-06-02 17:58 ` Dmitry Torokhov 2015-06-02 18:08 ` Dmitry Torokhov 2015-06-02 18:08 ` Dmitry Torokhov 2015-06-25 20:25 ` Pavel Machek 2015-06-25 20:25 ` Pavel Machek 2015-05-29 20:22 ` [PATCH] fix n900 dts file to work around 4.1 touchscreen regression " Dmitry Torokhov 2015-05-29 20:22 ` Dmitry Torokhov 2015-05-29 20:03 ` Maxime Ripard 2015-05-29 20:03 ` Maxime Ripard 2015-05-29 20:18 ` Tony Lindgren 2015-05-29 20:18 ` Tony Lindgren 2015-05-29 20:30 ` Pavel Machek 2015-05-29 20:30 ` Pavel Machek 2015-05-30 10:14 ` Pavel Machek 2015-05-30 10:14 ` Pavel Machek 2015-06-01 9:49 ` Maxime Ripard 2015-06-01 9:49 ` Maxime Ripard 2015-06-01 9:54 ` Pavel Machek 2015-06-01 9:54 ` Pavel Machek 2015-05-30 2:21 ` Sebastian Reichel 2015-05-30 2:21 ` Sebastian Reichel 2015-05-30 2:24 ` [PATCH] Input: of_touchscreen - remove interdependence of max/fuzz values Sebastian Reichel 2015-05-30 6:26 ` Pavel Machek 2015-05-29 19:57 ` 4.1 touchscreen regression on n900 -- pinpointed [was Re: linux-n900 v4.1-rc4] Maxime Ripard 2015-05-29 20:29 ` Pavel Machek 2015-05-29 21:17 ` Pavel Machek 2015-05-29 21:36 ` Dmitry Torokhov 2015-05-29 21:58 ` Pavel Machek
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20150529210259.GA26866@amd \ --to=pavel@ucw.cz \ --cc=aaro.koskinen@iki.fi \ --cc=balbi@ti.com \ --cc=dmitry.torokhov@gmail.com \ --cc=ivo.g.dimitrov.75@gmail.com \ --cc=khilman@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=maxime.ripard@free-electrons.com \ --cc=pali.rohar@gmail.com \ --cc=patrikbachan@gmail.com \ --cc=sre@debian.org \ --cc=sre@kernel.org \ --cc=sre@ring0.de \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.