From: Dan Williams <dan.j.williams@intel.com> To: linux-nvdimm@lists.01.org Cc: axboe@kernel.dk, sfr@canb.auug.org.au, rafael@kernel.org, neilb@suse.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, mingo@kernel.org, linux-acpi@vger.kernel.org, jmoyer@redhat.com, linux-api@vger.kernel.org, akpm@linux-foundation.org, hch@lst.de Subject: [PATCH v5 10/21] pmem: Dynamically allocate partition numbers Date: Mon, 01 Jun 2015 20:15:03 -0400 [thread overview] Message-ID: <20150602001503.4506.10472.stgit@dwillia2-desk3.amr.corp.intel.com> (raw) In-Reply-To: <20150602001134.4506.45867.stgit@dwillia2-desk3.amr.corp.intel.com> From: Ross Zwisler <ross.zwisler@linux.intel.com> Dynamically allocate minor numbers for partitions instead of statically preallocating them. It gives us a simpler minors scheme, and makes it so we get a consistent major when moving past partition 16. Here's what happens with the current code: pmem0 249:0 0 63.5G 0 rom ├─pmem0p1 249:1 0 1G 0 part ├─pmem0p2 249:2 0 1G 0 part ├─pmem0p3 249:3 0 1G 0 part ├─pmem0p4 249:4 0 1G 0 part ├─pmem0p5 249:5 0 1G 0 part ├─pmem0p6 249:6 0 1G 0 part ├─pmem0p7 249:7 0 1G 0 part ├─pmem0p8 249:8 0 1G 0 part ├─pmem0p9 249:9 0 1G 0 part ├─pmem0p10 249:10 0 1G 0 part ├─pmem0p11 249:11 0 1G 0 part ├─pmem0p12 249:12 0 1G 0 part ├─pmem0p13 249:13 0 1G 0 part ├─pmem0p14 249:14 0 1G 0 part ├─pmem0p15 249:15 0 1G 0 part ├─pmem0p16 259:0 0 1G 0 part ├─pmem0p17 259:1 0 1G 0 part └─pmem0p18 259:2 0 1G 0 part Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com> Signed-off-by: Dan Williams <dan.j.williams@intel.com> --- drivers/nvdimm/pmem.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c index cf5d53eda9e5..0842d27ffc8d 100644 --- a/drivers/nvdimm/pmem.c +++ b/drivers/nvdimm/pmem.c @@ -26,8 +26,6 @@ #include <linux/nd.h> #include "nd.h" -#define PMEM_MINORS 16 - struct pmem_device { struct request_queue *pmem_queue; struct gendisk *pmem_disk; @@ -156,12 +154,12 @@ static struct pmem_device *pmem_alloc(struct device *dev, struct resource *res, blk_queue_max_hw_sectors(pmem->pmem_queue, 1024); blk_queue_bounce_limit(pmem->pmem_queue, BLK_BOUNCE_ANY); - disk = alloc_disk(PMEM_MINORS); + disk = alloc_disk(0); if (!disk) goto out_free_queue; disk->major = pmem_major; - disk->first_minor = PMEM_MINORS * id; + disk->first_minor = 0; disk->fops = &pmem_fops; disk->private_data = pmem; disk->queue = pmem->pmem_queue;
WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dan.j.williams@intel.com> To: linux-nvdimm@ml01.01.org Cc: axboe@kernel.dk, sfr@canb.auug.org.au, rafael@kernel.org, neilb@suse.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, mingo@kernel.org, linux-acpi@vger.kernel.org, jmoyer@redhat.com, linux-api@vger.kernel.org, akpm@linux-foundation.org, hch@lst.de Subject: [PATCH v5 10/21] pmem: Dynamically allocate partition numbers Date: Mon, 01 Jun 2015 20:15:03 -0400 [thread overview] Message-ID: <20150602001503.4506.10472.stgit@dwillia2-desk3.amr.corp.intel.com> (raw) In-Reply-To: <20150602001134.4506.45867.stgit@dwillia2-desk3.amr.corp.intel.com> From: Ross Zwisler <ross.zwisler@linux.intel.com> Dynamically allocate minor numbers for partitions instead of statically preallocating them. It gives us a simpler minors scheme, and makes it so we get a consistent major when moving past partition 16. Here's what happens with the current code: pmem0 249:0 0 63.5G 0 rom ├─pmem0p1 249:1 0 1G 0 part ├─pmem0p2 249:2 0 1G 0 part ├─pmem0p3 249:3 0 1G 0 part ├─pmem0p4 249:4 0 1G 0 part ├─pmem0p5 249:5 0 1G 0 part ├─pmem0p6 249:6 0 1G 0 part ├─pmem0p7 249:7 0 1G 0 part ├─pmem0p8 249:8 0 1G 0 part ├─pmem0p9 249:9 0 1G 0 part ├─pmem0p10 249:10 0 1G 0 part ├─pmem0p11 249:11 0 1G 0 part ├─pmem0p12 249:12 0 1G 0 part ├─pmem0p13 249:13 0 1G 0 part ├─pmem0p14 249:14 0 1G 0 part ├─pmem0p15 249:15 0 1G 0 part ├─pmem0p16 259:0 0 1G 0 part ├─pmem0p17 259:1 0 1G 0 part └─pmem0p18 259:2 0 1G 0 part Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com> Signed-off-by: Dan Williams <dan.j.williams@intel.com> --- drivers/nvdimm/pmem.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c index cf5d53eda9e5..0842d27ffc8d 100644 --- a/drivers/nvdimm/pmem.c +++ b/drivers/nvdimm/pmem.c @@ -26,8 +26,6 @@ #include <linux/nd.h> #include "nd.h" -#define PMEM_MINORS 16 - struct pmem_device { struct request_queue *pmem_queue; struct gendisk *pmem_disk; @@ -156,12 +154,12 @@ static struct pmem_device *pmem_alloc(struct device *dev, struct resource *res, blk_queue_max_hw_sectors(pmem->pmem_queue, 1024); blk_queue_bounce_limit(pmem->pmem_queue, BLK_BOUNCE_ANY); - disk = alloc_disk(PMEM_MINORS); + disk = alloc_disk(0); if (!disk) goto out_free_queue; disk->major = pmem_major; - disk->first_minor = PMEM_MINORS * id; + disk->first_minor = 0; disk->fops = &pmem_fops; disk->private_data = pmem; disk->queue = pmem->pmem_queue;
next prev parent reply other threads:[~2015-06-02 0:15 UTC|newest] Thread overview: 108+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-06-02 0:14 [PATCH v5 00/21] libnvdimm: non-volatile memory devices Dan Williams 2015-06-02 0:14 ` Dan Williams 2015-06-02 0:14 ` [PATCH v5 01/21] e820, efi: add ACPI 6.0 persistent memory types Dan Williams 2015-06-02 0:14 ` Dan Williams 2015-06-02 0:14 ` [PATCH v5 02/21] libnvdimm, nfit: initial libnvdimm infrastructure and NFIT support Dan Williams 2015-06-02 0:14 ` Dan Williams 2015-06-03 14:57 ` Christoph Hellwig 2015-06-03 14:57 ` Christoph Hellwig 2015-06-03 19:24 ` Williams, Dan J 2015-06-03 19:24 ` Williams, Dan J 2015-06-03 19:24 ` Williams, Dan J 2015-06-09 6:33 ` hch 2015-06-09 6:33 ` hch 2015-06-09 6:33 ` hch-jcswGhMUV9g 2015-06-09 22:27 ` Dan Williams 2015-06-09 22:27 ` Dan Williams 2015-06-02 0:14 ` [PATCH v5 03/21] libnvdimm: control character device and libnvdimm bus sysfs attributes Dan Williams 2015-06-02 0:14 ` Dan Williams 2015-06-02 0:14 ` [PATCH v5 04/21] libnvdimm, nfit: dimm/memory-devices Dan Williams 2015-06-02 0:14 ` Dan Williams 2015-06-02 0:14 ` [PATCH v5 05/21] libnvdimm: control (ioctl) messages for libnvdimm bus and dimm devices Dan Williams 2015-06-02 0:14 ` Dan Williams 2015-06-09 6:34 ` Christoph Hellwig 2015-06-09 6:34 ` Christoph Hellwig 2015-06-09 6:34 ` Christoph Hellwig 2015-06-09 6:57 ` Dan Williams 2015-06-09 6:57 ` Dan Williams 2015-06-09 6:57 ` Dan Williams 2015-06-10 7:33 ` Christoph Hellwig 2015-06-10 7:33 ` Christoph Hellwig 2015-06-10 7:33 ` Christoph Hellwig 2015-06-02 0:14 ` [PATCH v5 06/21] libnvdimm, nvdimm: dimm driver and base libnvdimm device-driver infrastructure Dan Williams 2015-06-02 0:14 ` Dan Williams 2015-06-02 0:14 ` Dan Williams 2015-06-02 0:14 ` [PATCH v5 07/21] libnvdimm, nfit: regions (block-data-window, persistent memory, volatile memory) Dan Williams 2015-06-02 0:14 ` Dan Williams 2015-06-02 0:14 ` [PATCH v5 08/21] libnvdimm: support for legacy (non-aliasing) nvdimms Dan Williams 2015-06-02 0:14 ` Dan Williams 2015-06-02 0:14 ` [PATCH v5 09/21] libnvdimm, nd_pmem: add libnvdimm support to the pmem driver Dan Williams 2015-06-02 0:14 ` Dan Williams 2015-06-03 7:44 ` Christoph Hellwig [not found] ` <20150603074424.GA24949-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org> 2015-06-03 19:31 ` Williams, Dan J 2015-06-03 19:31 ` Williams, Dan J [not found] ` <1433359894.21035.33.camel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> 2015-06-09 6:36 ` hch-jcswGhMUV9g 2015-06-09 6:36 ` hch 2015-06-02 0:15 ` Dan Williams [this message] 2015-06-02 0:15 ` [PATCH v5 10/21] pmem: Dynamically allocate partition numbers Dan Williams 2015-06-02 0:15 ` [PATCH v5 11/21] libnvdimm, nfit: add interleave-set state-tracking infrastructure Dan Williams 2015-06-02 0:15 ` Dan Williams 2015-06-02 0:15 ` [PATCH v5 12/21] libnvdimm: namespace indices: read and validate Dan Williams 2015-06-02 0:15 ` Dan Williams 2015-06-09 6:39 ` Christoph Hellwig 2015-06-09 6:39 ` Christoph Hellwig 2015-06-09 6:39 ` Christoph Hellwig 2015-06-10 15:54 ` Dan Williams 2015-06-10 15:54 ` Dan Williams 2015-06-02 0:15 ` [PATCH v5 13/21] libnvdimm: pmem label sets and namespace instantiation Dan Williams 2015-06-02 0:15 ` Dan Williams 2015-06-02 0:15 ` Dan Williams 2015-06-02 0:15 ` [PATCH v5 14/21] libnvdimm: blk labels " Dan Williams 2015-06-02 0:15 ` Dan Williams 2015-06-02 0:15 ` [PATCH v5 15/21] libnvdimm: write pmem label set Dan Williams 2015-06-02 0:15 ` Dan Williams 2015-06-02 0:15 ` Dan Williams 2015-06-02 0:15 ` [PATCH v5 16/21] libnvdimm: write blk " Dan Williams 2015-06-02 0:15 ` Dan Williams 2015-06-02 0:15 ` Dan Williams 2015-06-02 0:15 ` [PATCH v5 17/21] libnvdimm: infrastructure for btt devices Dan Williams 2015-06-02 0:15 ` Dan Williams 2015-06-09 6:42 ` Christoph Hellwig 2015-06-09 6:42 ` Christoph Hellwig 2015-06-10 18:46 ` Matthew Wilcox 2015-06-10 18:46 ` Matthew Wilcox 2015-06-11 7:28 ` Christoph Hellwig 2015-06-11 7:28 ` Christoph Hellwig [not found] ` <20150611072812.GB1905-jcswGhMUV9g@public.gmane.org> 2015-06-17 16:47 ` Jeff Moyer 2015-06-17 16:47 ` Jeff Moyer [not found] ` <x49381qp9ic.fsf-RRHT56Q3PSP4kTEheFKJxxDDeQx5vsVwAInAS/Ez/D0@public.gmane.org> 2015-06-17 16:50 ` Dan Williams 2015-06-17 16:50 ` Dan Williams 2015-06-17 16:57 ` Jeff Moyer 2015-06-17 16:57 ` Jeff Moyer 2015-06-17 17:09 ` Dan Williams 2015-06-02 0:15 ` [PATCH v5 18/21] nd_btt: atomic sector updates Dan Williams 2015-06-02 0:15 ` Dan Williams 2015-06-02 0:15 ` Dan Williams 2015-06-09 6:44 ` Christoph Hellwig 2015-06-09 6:44 ` Christoph Hellwig 2015-06-09 6:44 ` Christoph Hellwig 2015-06-09 18:27 ` Vishal Verma 2015-06-09 18:27 ` Vishal Verma 2015-06-10 7:34 ` Christoph Hellwig 2015-06-10 7:34 ` Christoph Hellwig 2015-06-10 7:34 ` Christoph Hellwig 2015-06-10 18:24 ` Vishal Verma 2015-06-10 18:24 ` Vishal Verma 2015-06-02 0:15 ` [PATCH v5 19/21] libnvdimm, nfit, nd_blk: driver for BLK-mode access persistent memory Dan Williams 2015-06-02 0:15 ` Dan Williams 2015-06-02 0:15 ` Dan Williams 2015-06-02 0:15 ` [PATCH v5 20/21] tools/testing/nvdimm: manufactured NFITs for interface development Dan Williams 2015-06-02 0:15 ` Dan Williams 2015-06-02 0:15 ` Dan Williams 2015-06-09 6:48 ` Christoph Hellwig 2015-06-09 6:48 ` Christoph Hellwig 2015-06-09 6:48 ` Christoph Hellwig 2015-06-11 20:12 ` Dan Williams 2015-06-11 20:12 ` Dan Williams 2015-06-02 0:16 ` [PATCH v5 21/21] libnvdimm: Non-Volatile Devices Dan Williams 2015-06-02 0:16 ` Dan Williams
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20150602001503.4506.10472.stgit@dwillia2-desk3.amr.corp.intel.com \ --to=dan.j.williams@intel.com \ --cc=akpm@linux-foundation.org \ --cc=axboe@kernel.dk \ --cc=gregkh@linuxfoundation.org \ --cc=hch@lst.de \ --cc=jmoyer@redhat.com \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-api@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nvdimm@lists.01.org \ --cc=mingo@kernel.org \ --cc=neilb@suse.de \ --cc=rafael@kernel.org \ --cc=sfr@canb.auug.org.au \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.