All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Varka Bhadram <varkabhadram@gmail.com>
Cc: linux-pwm <linux-pwm@vger.kernel.org>,
	Paul Bolle <pebolle@tiscali.nl>,
	Samuel Ortiz <sameo@linux.intel.com>,
	Alexandre Courbot <gnurou@gmail.com>,
	Jani Nikula <jani.nikula@intel.com>,
	Shobhit Kumar <shobhit.kumar@intel.com>,
	intel-gfx <intel-gfx@lists.freedesktop.org>,
	Paul Gortmaker <paul.gortmaker@windriver.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	linux-gpio <linux-gpio@vger.kernel.org>,
	bloften80@gmail.com, Povilas Staniulis <wdmonster@gmail.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel.vetter@intel.com>,
	Lee Jones <lee.jones@linaro.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Chih-Wei Huang <cwhuang@android-x86.org>
Subject: Re: [v2 4/7] mfd: intel_soc_pmic_core: ADD PWM lookup table for CRC PMIC based PWM
Date: Mon, 22 Jun 2015 16:19:08 +0200	[thread overview]
Message-ID: <20150622141908.GM25769@phenom.ffwll.local> (raw)
In-Reply-To: <5587EB7A.5090402@gmail.com>

On Mon, Jun 22, 2015 at 04:33:22PM +0530, Varka Bhadram wrote:
> Hi Shobhit Kumar,
> 
> On 06/22/2015 04:24 PM, Shobhit Kumar wrote:
> 
> >On some BYT PLatform the PWM is controlled using CRC PMIC. Add a lookup
> >entry for the same to be used by the consumer (Intel GFX)
> >
> >v2: Remove the lookup table on driver unload (Thierry)
> >
> >v3: Correct the subject line (Lee jones)
> 
> This part should only describe what this is about..
> 
> Don't put this patch change history over here.
> Include this change history after
> ...
> Signed-off-by: Author <email>
> ---
> 
> >CC: Samuel Ortiz <sameo@linux.intel.com>
> >Cc: Linus Walleij <linus.walleij@linaro.org>
> >Cc: Alexandre Courbot <gnurou@gmail.com>
> >Cc: Thierry Reding <thierry.reding@gmail.com>
> >Acked-by: Lee Jones <lee.jones@linaro.org>
> >Signed-off-by: Shobhit Kumar <shobhit.kumar@intel.com>
> >---
> 
> Here you add this change history so that after applying this
> will not be the part of your commit description.
> 
> This comment is applicable for all of your patches.

It's honestly a per-maintainer thing and hard to tell who wants what ...
Personally I do want to include the patch changelog in the commit message.
-Daniel
> 
> 
> -- 
> Best regards,
> Varka Bhadram.
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch>
To: Varka Bhadram <varkabhadram@gmail.com>
Cc: Shobhit Kumar <shobhit.kumar@intel.com>,
	linux-pwm <linux-pwm@vger.kernel.org>,
	intel-gfx <intel-gfx@lists.freedesktop.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	linux-gpio <linux-gpio@vger.kernel.org>,
	Alexandre Courbot <gnurou@gmail.com>,
	Paul Bolle <pebolle@tiscali.nl>,
	Samuel Ortiz <sameo@linux.intel.com>,
	Povilas Staniulis <wdmonster@gmail.com>,
	Jani Nikula <jani.nikula@intel.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Paul Gortmaker <paul.gortmaker@windriver.com>,
	bloften80@gmail.com, David Airlie <airlied@linux.ie>,
	Chih-Wei Huang <cwhuang@android-x86.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	Daniel Vetter <daniel.vetter@intel.com>,
	Lee Jones <lee.jones@linaro.org>
Subject: Re: [Intel-gfx] [v2 4/7] mfd: intel_soc_pmic_core: ADD PWM lookup table for CRC PMIC based PWM
Date: Mon, 22 Jun 2015 16:19:08 +0200	[thread overview]
Message-ID: <20150622141908.GM25769@phenom.ffwll.local> (raw)
In-Reply-To: <5587EB7A.5090402@gmail.com>

On Mon, Jun 22, 2015 at 04:33:22PM +0530, Varka Bhadram wrote:
> Hi Shobhit Kumar,
> 
> On 06/22/2015 04:24 PM, Shobhit Kumar wrote:
> 
> >On some BYT PLatform the PWM is controlled using CRC PMIC. Add a lookup
> >entry for the same to be used by the consumer (Intel GFX)
> >
> >v2: Remove the lookup table on driver unload (Thierry)
> >
> >v3: Correct the subject line (Lee jones)
> 
> This part should only describe what this is about..
> 
> Don't put this patch change history over here.
> Include this change history after
> ...
> Signed-off-by: Author <email>
> ---
> 
> >CC: Samuel Ortiz <sameo@linux.intel.com>
> >Cc: Linus Walleij <linus.walleij@linaro.org>
> >Cc: Alexandre Courbot <gnurou@gmail.com>
> >Cc: Thierry Reding <thierry.reding@gmail.com>
> >Acked-by: Lee Jones <lee.jones@linaro.org>
> >Signed-off-by: Shobhit Kumar <shobhit.kumar@intel.com>
> >---
> 
> Here you add this change history so that after applying this
> will not be the part of your commit description.
> 
> This comment is applicable for all of your patches.

It's honestly a per-maintainer thing and hard to tell who wants what ...
Personally I do want to include the patch changelog in the commit message.
-Daniel
> 
> 
> -- 
> Best regards,
> Varka Bhadram.
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

  reply	other threads:[~2015-06-22 14:19 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-22 10:54 [v2 0/7] Crystalcove (CRC) PMIC based panel and pwm control Shobhit Kumar
2015-06-22 10:54 ` Shobhit Kumar
2015-06-22 10:54 ` [v2 1/7] gpiolib: Add support for removing registered consumer lookup table Shobhit Kumar
2015-06-22 10:54   ` Shobhit Kumar
2015-07-15  8:05   ` Linus Walleij
2015-07-15  8:05     ` Linus Walleij
2015-06-22 10:54 ` [v2 2/7] mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO signal Shobhit Kumar
2015-06-22 10:54   ` Shobhit Kumar
2015-06-22 10:54 ` [v2 3/7] mfd: intel_soc_pmic_crc: Add PWM cell device for Crystalcove PMIC Shobhit Kumar
2015-06-22 10:54   ` Shobhit Kumar
2015-06-22 10:54 ` [v2 4/7] mfd: intel_soc_pmic_core: ADD PWM lookup table for CRC PMIC based PWM Shobhit Kumar
2015-06-22 10:54   ` Shobhit Kumar
2015-06-22 11:03   ` Varka Bhadram
2015-06-22 11:03     ` Varka Bhadram
2015-06-22 14:19     ` Daniel Vetter [this message]
2015-06-22 14:19       ` [Intel-gfx] " Daniel Vetter
2015-06-23  7:19       ` Lee Jones
2015-06-23  7:19         ` [Intel-gfx] " Lee Jones
2015-06-25 12:33         ` Shobhit Kumar
2015-06-25 12:33           ` Shobhit Kumar
2015-06-22 10:54 ` [v2 5/7] pwm: crc: Add Crystalcove (CRC) PWM driver Shobhit Kumar
2015-06-22 10:54   ` Shobhit Kumar
2015-06-22 11:16   ` Varka Bhadram
2015-06-22 11:16     ` Varka Bhadram
2015-06-23 12:49     ` [Intel-gfx] " Shobhit Kumar
2015-06-23 12:49       ` Shobhit Kumar
2015-06-22 10:54 ` [v2 6/7] drm/i915: Use the CRC gpio for panel enable/disable Shobhit Kumar
2015-06-22 10:54   ` Shobhit Kumar
2015-06-22 10:54 ` [v2 7/7] drm/i915: Backlight control using CRC PMIC based PWM driver Shobhit Kumar
2015-06-22 10:54   ` Shobhit Kumar
2015-06-25  8:48   ` [Intel-gfx] " Ville Syrjälä
2015-06-25  8:48     ` Ville Syrjälä
2015-06-25 12:08     ` Shobhit Kumar
2015-06-25 12:08       ` Shobhit Kumar
2015-06-25 12:47       ` Ville Syrjälä
2015-06-25 12:47         ` Ville Syrjälä
2015-06-25 13:24         ` Shobhit Kumar
2015-06-25 13:24           ` Shobhit Kumar
2015-06-26  8:31       ` Jani Nikula
2015-06-26  8:31         ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150622141908.GM25769@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=airlied@linux.ie \
    --cc=bloften80@gmail.com \
    --cc=cwhuang@android-x86.org \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gnurou@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=pebolle@tiscali.nl \
    --cc=sameo@linux.intel.com \
    --cc=shobhit.kumar@intel.com \
    --cc=thierry.reding@gmail.com \
    --cc=varkabhadram@gmail.com \
    --cc=wdmonster@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.