Re: [Ksummit-discuss] [CORE TOPIC] Recruitment (Reviewers, Testers, Maintainers, Hobbyists)

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2004 bytes --]

On Thu, Jul 09, 2015 at 11:28:28AM -0700, Frank Rowand wrote:
> On 7/8/2015 9:06 PM, Michael Ellerman wrote:
> > On Wed, 2015-07-08 at 13:08 -0700, Guenter Roeck wrote:
> >> On 07/08/2015 11:53 AM, Steven Rostedt wrote:

> >>> I personally don't trust a Reviewed-by tag much, as I sometimes see
> >>> them appear without any comments.
> 
> I don't expect my Reviewed-by tag with no extra comments to carry much weight
> if I send it to a maintainer who does not know me.

> But if I have a history of good reviews to a specific maintainer, then why
> should I have to add a message that says: Yes, I really, really did review
> the patch.  I truly mean that the patch "has been reviewed and found acceptable
> according to the Reviewer's Statement" as listed in SubmittingPatches.

> And I read Steve's qualification of "don't trust ... _much_" as being
> consistent with what I am saying, so I'm fine with that.  The point I
> want to make is that a Reviewed-by tag without comments should not
> always be assumed to be without meaning or value.

Indeed, and when I'm the one dealing with applying the patches it's
actually helpful to not have extra text that needs reading and
thinking about when applying things if I trust whoever did the review.
Past history as a reviewer is much more important than any verbiage
around the review and review that consists of a simple tag takes seconds
to read.

> >> Seriously, it does happen that I send Reviewed-by: or Acked-by: feedback if
> >> a patch is just fine as-is. What do you expect the reviewer to do in such
> >> a case ?

> > There's almost always something you can say.

> And there is a time to not nit-pick a patch to death.

> If my comment will not result in a significantly better patch, then I am
> wasting the patch submitter's time, and the time of everyone else on the
> mail list that will have to read my comment, and potentially have to read
> and review a new spin of the patch.

Very much so.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]