Re: [Ksummit-discuss] [CORE TOPIC] Recruitment (Reviewers, Testers, Maintainers, Hobbyists)

[Peter Huewe <peterhuewe@gmx.de>]

Hey,


>I'm very luck in IIO in that I have a core set of very good reviewers
>with (I think) a mix of paid and volunteers.  As a volunteer Maintainer
>I couldn't cope with the rate of patches without them! 
>
>One thing that happens fairly often is that I get a very good initial
>review in then the reviewer moves on to other patches.  I suspect this
>is because they are focusing on where they can do the most productive
>work.  Sometimes I go to the effort of chasing them up for an
>ack / reviewed by, but often they get no recognition at all. 
>
>Note I tend to do an additional review (often v3 or later by the
>time I get to them) but these guys have done a lot of the leg work.
>One of my reviewers specializes in very detailed reviews slightly after
>I have applied the patches, but that's another story :) 
>
>So how to give these incredibly helpful people more recognition?
>Do other maintainers add reviewed-by tags sometimes without the
>reviewer
>specifically giving them?  The docs have always said these should
>indicate that the reviewer is happy with the result.  In this case the
>reviewer may not have looked at the result, but contributed earlier
>in the process. 

Actually I do, at least if I have the feeling that it would be in the reviewers intention.
Credit where credit is due.

If I'm unsure I mail the reviewers and ask them (or via IRC)



>Does anyone else actually get these sorts of reviews? 


Yes happens a lot - v1-5 get a lot of reviews , v8 gets none except my own :)
But the important stuff is usually dealt with in v1-3. so I usually add the reviewed-by tags if nothing fundamentally has changed
So the Situation is much likr in iio
(Yes in TPM we usually need v5 or more:)



Peter
-- 
Sent from my mobile