* [PATCH] staging: lustre: mgc: no need to compare bool value
@ 2015-06-23 14:26 Luis de Bethencourt
2015-07-14 2:38 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Luis de Bethencourt @ 2015-06-23 14:26 UTC (permalink / raw)
To: linux-kernel
Cc: Oleg Drokin, Andreas Dilger, Greg Kroah-Hartman, John L. Hammond,
Ryan Haasken, Heena Sirwani, Hatice ERTÜRK, Joe Perches,
Supriya Karanth, Julia Lawall, Bobi Jam, HPDD-discuss, devel
Inverting the value of eof is a more direct way of passing to the debugging
function if eof is false or not.
Signed-off-by: Luis de Bethencourt <luis@debethencourt.com>
---
drivers/staging/lustre/lustre/mgc/mgc_request.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/mgc/mgc_request.c b/drivers/staging/lustre/lustre/mgc/mgc_request.c
index 7947aec..cd3ce40 100644
--- a/drivers/staging/lustre/lustre/mgc/mgc_request.c
+++ b/drivers/staging/lustre/lustre/mgc/mgc_request.c
@@ -1406,7 +1406,7 @@ again:
eof = res->mcr_offset == res->mcr_size;
CDEBUG(D_INFO, "Latest version %lld, more %d.\n",
- res->mcr_offset, eof == false);
+ res->mcr_offset, !eof);
ealen = sptlrpc_cli_unwrap_bulk_read(req, req->rq_bulk, 0);
if (ealen < 0) {
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: lustre: mgc: no need to compare bool value
2015-06-23 14:26 [PATCH] staging: lustre: mgc: no need to compare bool value Luis de Bethencourt
@ 2015-07-14 2:38 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2015-07-14 2:38 UTC (permalink / raw)
To: Luis de Bethencourt
Cc: linux-kernel, Oleg Drokin, Andreas Dilger, John L. Hammond,
Ryan Haasken, Heena Sirwani, Hatice ERTÜRK, Joe Perches,
Supriya Karanth, Julia Lawall, Bobi Jam, HPDD-discuss, devel
On Tue, Jun 23, 2015 at 04:26:11PM +0200, Luis de Bethencourt wrote:
> Inverting the value of eof is a more direct way of passing to the debugging
> function if eof is false or not.
Really? I like the explicit-ness of the code as it is today, it's more
obvious what is going on, which is the most important thing.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-14 2:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-23 14:26 [PATCH] staging: lustre: mgc: no need to compare bool value Luis de Bethencourt
2015-07-14 2:38 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.