From: Stephen Boyd <sboyd@codeaurora.org> To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Cc: linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Rob Herring <robh+dt@kernel.org>, Kumar Gala <galak@codeaurora.org>, Mark Brown <broonie@kernel.org>, s.hauer@pengutronix.de, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, arnd@arndb.de, pantelis.antoniou@konsulko.com, mporter@konsulko.com, stefan.wahren@i2se.com, wxt@rock-chips.com Subject: Re: [PATCH v7 3/9] nvmem: Add nvmem_device based consumer apis. Date: Tue, 14 Jul 2015 15:06:07 -0700 [thread overview] Message-ID: <20150714220607.GP30412@codeaurora.org> (raw) In-Reply-To: <1436521505-10779-1-git-send-email-srinivas.kandagatla@linaro.org> On 07/10, Srinivas Kandagatla wrote: > +static int devm_nvmem_device_match(struct device *dev, void *res, void *data) > +{ > + struct nvmem_device **nvmem = res; > + > + if (!nvmem || !*nvmem) { > + WARN_ON(!nvmem || !*nvmem); This could be if (WARN_ON(!nvmem || !*nvmem)) > + return 0; > + } > + return *nvmem == data; > +} > + > [..] > + > +/** > + * nvmem_device_write() - Write cell to a given nvmem device > + * > + * @nvmem: nvmem device to be written to. > + * @offset: offset in nvmem device. > + * @bytes: number of bytes to write. > + * @buf: buffer to be written. > + * > + * The return value will be an length of bytes written or non zero on failure. Should say negative value instead of non-zero? Length is non-zero already. General nitpick comment: Kernel-doc allows for a standard return syntax. Return: length of bytes written or negative value on failure. > diff --git a/include/linux/nvmem-provider.h b/include/linux/nvmem-provider.h > index f589d3b..74eed42 100644 > --- a/include/linux/nvmem-provider.h > +++ b/include/linux/nvmem-provider.h > @@ -12,15 +12,9 @@ > #ifndef _LINUX_NVMEM_PROVIDER_H > #define _LINUX_NVMEM_PROVIDER_H > > -struct nvmem_device; > +#include <linux/nvmem-consumer.h> > > -struct nvmem_cell_info { > - const char *name; > - int offset; > - int bytes; > - int bit_offset; > - int nbits; > -}; Why does this move from provider to consumer? Can't we do put this struct in the right place from the beginning? > +struct nvmem_device; -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v7 3/9] nvmem: Add nvmem_device based consumer apis. Date: Tue, 14 Jul 2015 15:06:07 -0700 [thread overview] Message-ID: <20150714220607.GP30412@codeaurora.org> (raw) In-Reply-To: <1436521505-10779-1-git-send-email-srinivas.kandagatla@linaro.org> On 07/10, Srinivas Kandagatla wrote: > +static int devm_nvmem_device_match(struct device *dev, void *res, void *data) > +{ > + struct nvmem_device **nvmem = res; > + > + if (!nvmem || !*nvmem) { > + WARN_ON(!nvmem || !*nvmem); This could be if (WARN_ON(!nvmem || !*nvmem)) > + return 0; > + } > + return *nvmem == data; > +} > + > [..] > + > +/** > + * nvmem_device_write() - Write cell to a given nvmem device > + * > + * @nvmem: nvmem device to be written to. > + * @offset: offset in nvmem device. > + * @bytes: number of bytes to write. > + * @buf: buffer to be written. > + * > + * The return value will be an length of bytes written or non zero on failure. Should say negative value instead of non-zero? Length is non-zero already. General nitpick comment: Kernel-doc allows for a standard return syntax. Return: length of bytes written or negative value on failure. > diff --git a/include/linux/nvmem-provider.h b/include/linux/nvmem-provider.h > index f589d3b..74eed42 100644 > --- a/include/linux/nvmem-provider.h > +++ b/include/linux/nvmem-provider.h > @@ -12,15 +12,9 @@ > #ifndef _LINUX_NVMEM_PROVIDER_H > #define _LINUX_NVMEM_PROVIDER_H > > -struct nvmem_device; > +#include <linux/nvmem-consumer.h> > > -struct nvmem_cell_info { > - const char *name; > - int offset; > - int bytes; > - int bit_offset; > - int nbits; > -}; Why does this move from provider to consumer? Can't we do put this struct in the right place from the beginning? > +struct nvmem_device; -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-07-14 22:06 UTC|newest] Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-07-10 9:43 [PATCH v7 0/9] Add simple NVMEM Framework via regmap Srinivas Kandagatla 2015-07-10 9:43 ` Srinivas Kandagatla 2015-07-10 9:44 ` [PATCH v7 2/9] nvmem: Add a simple NVMEM framework for consumers Srinivas Kandagatla 2015-07-10 9:44 ` Srinivas Kandagatla [not found] ` <1436521495-10728-1-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2015-07-10 10:42 ` Joe Perches 2015-07-10 10:42 ` Joe Perches 2015-07-10 10:42 ` Joe Perches 2015-07-13 19:06 ` Stefan Wahren 2015-07-13 19:06 ` Stefan Wahren 2015-07-13 19:06 ` Stefan Wahren 2015-07-13 19:24 ` Srinivas Kandagatla 2015-07-13 19:24 ` Srinivas Kandagatla 2015-07-10 9:45 ` [PATCH v7 3/9] nvmem: Add nvmem_device based consumer apis Srinivas Kandagatla 2015-07-10 9:45 ` Srinivas Kandagatla 2015-07-10 9:45 ` Srinivas Kandagatla [not found] ` <1436521505-10779-1-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2015-07-10 10:49 ` Joe Perches 2015-07-10 10:49 ` Joe Perches 2015-07-10 10:49 ` Joe Perches 2015-07-14 22:06 ` Stephen Boyd [this message] 2015-07-14 22:06 ` Stephen Boyd [not found] ` <20150714220607.GP30412-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> 2015-07-15 8:21 ` Srinivas Kandagatla 2015-07-15 8:21 ` Srinivas Kandagatla 2015-07-15 8:21 ` Srinivas Kandagatla 2015-07-10 9:45 ` [PATCH v7 4/9] nvmem: Add bindings for simple nvmem framework Srinivas Kandagatla 2015-07-10 9:45 ` Srinivas Kandagatla [not found] ` <1436521513-10838-1-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2015-07-10 19:04 ` Rob Herring 2015-07-10 19:04 ` Rob Herring 2015-07-10 19:04 ` Rob Herring [not found] ` <CAL_JsqKYT-+T=D=TKCb1TcydOvBTE8_yc-EEe1cwdmhr1B0dHQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-07-13 10:21 ` Srinivas Kandagatla 2015-07-13 10:21 ` Srinivas Kandagatla 2015-07-13 10:21 ` Srinivas Kandagatla 2015-07-10 9:45 ` [PATCH v7 5/9] Documentation: nvmem: add nvmem api level and how-to doc Srinivas Kandagatla 2015-07-10 9:45 ` Srinivas Kandagatla [not found] ` <1436521521-10889-1-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2015-07-14 21:32 ` Stephen Boyd 2015-07-14 21:32 ` Stephen Boyd 2015-07-14 21:32 ` Stephen Boyd 2015-07-14 22:00 ` Srinivas Kandagatla 2015-07-14 22:00 ` Srinivas Kandagatla 2015-07-10 9:45 ` [PATCH v7 6/9] nvmem: qfprom: Add Qualcomm QFPROM support Srinivas Kandagatla 2015-07-10 9:45 ` Srinivas Kandagatla [not found] ` <1436521529-10931-1-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2015-07-14 21:18 ` Stephen Boyd 2015-07-14 21:18 ` Stephen Boyd 2015-07-14 21:18 ` Stephen Boyd [not found] ` <20150714211831.GN30412-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> 2015-07-14 22:02 ` Srinivas Kandagatla 2015-07-14 22:02 ` Srinivas Kandagatla 2015-07-14 22:02 ` Srinivas Kandagatla [not found] ` <1436521427-10568-1-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2015-07-10 9:44 ` [PATCH v7 1/9] nvmem: Add a simple NVMEM framework for nvmem providers Srinivas Kandagatla 2015-07-10 9:44 ` Srinivas Kandagatla 2015-07-10 9:44 ` Srinivas Kandagatla [not found] ` <1436521486-10682-1-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2015-07-10 10:29 ` Joe Perches 2015-07-10 10:29 ` Joe Perches 2015-07-10 10:29 ` Joe Perches 2015-07-10 10:39 ` Srinivas Kandagatla 2015-07-10 10:39 ` Srinivas Kandagatla 2015-07-13 16:50 ` Philipp Zabel 2015-07-13 16:50 ` Philipp Zabel 2015-07-13 16:50 ` Philipp Zabel 2015-07-10 9:45 ` [PATCH v7 7/9] nvmem: qfprom: Add bindings for qfprom Srinivas Kandagatla 2015-07-10 9:45 ` Srinivas Kandagatla 2015-07-10 9:45 ` Srinivas Kandagatla 2015-07-13 18:54 ` [PATCH v7 0/9] Add simple NVMEM Framework via regmap Stefan Wahren 2015-07-13 18:54 ` Stefan Wahren 2015-07-13 18:54 ` Stefan Wahren 2015-07-13 19:35 ` Srinivas Kandagatla 2015-07-13 19:35 ` Srinivas Kandagatla 2015-07-13 19:35 ` Srinivas Kandagatla 2015-07-13 20:11 ` Stefan Wahren 2015-07-13 20:11 ` Stefan Wahren [not found] ` <139301016.164015.1436818270753.JavaMail.open-xchange-0SF9iQWekqKZU4JK52HgGMgmgJlYmuWJ@public.gmane.org> 2015-07-13 21:39 ` Srinivas Kandagatla 2015-07-13 21:39 ` Srinivas Kandagatla 2015-07-13 21:39 ` Srinivas Kandagatla 2015-07-10 9:45 ` [PATCH v7 8/9] nvmem: sunxi: Move the SID driver to the nvmem framework Srinivas Kandagatla 2015-07-10 9:45 ` Srinivas Kandagatla 2015-07-10 9:46 ` [PATCH v7 9/9] nvmem: Add to MAINTAINERS for " Srinivas Kandagatla 2015-07-10 9:46 ` Srinivas Kandagatla
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20150714220607.GP30412@codeaurora.org \ --to=sboyd@codeaurora.org \ --cc=arnd@arndb.de \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=galak@codeaurora.org \ --cc=gregkh@linuxfoundation.org \ --cc=linux-api@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mporter@konsulko.com \ --cc=pantelis.antoniou@konsulko.com \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=srinivas.kandagatla@linaro.org \ --cc=stefan.wahren@i2se.com \ --cc=wxt@rock-chips.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.