From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> To: Joe Perches <joe@perches.com> Cc: linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Rob Herring <robh+dt@kernel.org>, Kumar Gala <galak@codeaurora.org>, Mark Brown <broonie@kernel.org>, s.hauer@pengutronix.de, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, arnd@arndb.de, sboyd@codeaurora.org, pantelis.antoniou@konsulko.com, mporter@konsulko.com, stefan.wahren@i2se.com, wxt@rock-chips.com, Maxime Ripard <maxime.ripard@free-electrons.com> Subject: Re: [PATCH v7 1/9] nvmem: Add a simple NVMEM framework for nvmem providers Date: Fri, 10 Jul 2015 11:39:07 +0100 [thread overview] Message-ID: <559FA0CB.50405@linaro.org> (raw) In-Reply-To: <1436524145.24866.21.camel@perches.com> Thanks for quick review, On 10/07/15 11:29, Joe Perches wrote: > On Fri, 2015-07-10 at 10:44 +0100, Srinivas Kandagatla wrote: >> This patch adds just providers part of the framework just to enable easy >> review. > > Trivial notes: Will fix all them. --srini > >> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c > >> +struct nvmem_device { >> + const char *name; >> + struct regmap *regmap; > [] >> +struct nvmem_cell { >> + const char *name; >> + int offset; >> + int bytes; > > It'd be nicer to use consistent indentation for *name > in nvmem_cell > >> +static ssize_t bin_attr_nvmem_read(struct file *filp, struct kobject *kobj, >> + struct bin_attribute *attr, >> + char *buf, loff_t pos, size_t count) >> +{ > [] >> + count = count/nvmem->word_size * nvmem->word_size; > > maybe rounddown() ? > >> +static ssize_t bin_attr_nvmem_write(struct file *filp, struct kobject *kobj, >> + struct bin_attribute *attr, >> + char *buf, loff_t pos, size_t count) >> +{ > >> + count = count/nvmem->word_size * nvmem->word_size; > > and rounddown() here too ? > >> +static struct nvmem_device *of_nvmem_find(struct device_node *nvmem_np) >> +{ >> + struct device *d; >> + >> + if (!nvmem_np) >> + return NULL; >> + >> + d = bus_find_device(&nvmem_bus_type, NULL, nvmem_np, of_nvmem_match); >> + >> + return d ? to_nvmem_device(d) : NULL; >> +} > > Perhaps more common as > > d = bus_find_device(&nvmem_bus_type, NULL, nvmem_np, of_nvmem_match); > if (!d) > return NULL; > > return to_nvmem_device(d); > } > >> +struct nvmem_device *nvmem_register(struct nvmem_config *config) >> +{ > [] >> + nvmem->read_only = nvmem->dev.of_node ? >> + of_property_read_bool(nvmem->dev.of_node, >> + "read-only") : >> + config->read_only; > > odd indentation. > Normally, "read-only" would be aligned with nvmem->dev.of_node, > >> + dev_dbg(&nvmem->dev, "Registering nvmem device %s\n", >> + dev_name(&nvmem->dev)); > > Isn't this going to have duplicated dev_name prefix and postfix? > >> + if (device_create_bin_file(&nvmem->dev, >> + nvmem->read_only ? &bin_attr_ro_nvmem : >> + &bin_attr_rw_nvmem)) >> + dev_info(&nvmem->dev, "Failed to create sysfs binary file\n"); > > Is the KERN_LEVEL correct? > Maybe dev_err/notice/warn/dbg? > >
WARNING: multiple messages have this Message-ID (diff)
From: srinivas.kandagatla@linaro.org (Srinivas Kandagatla) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v7 1/9] nvmem: Add a simple NVMEM framework for nvmem providers Date: Fri, 10 Jul 2015 11:39:07 +0100 [thread overview] Message-ID: <559FA0CB.50405@linaro.org> (raw) In-Reply-To: <1436524145.24866.21.camel@perches.com> Thanks for quick review, On 10/07/15 11:29, Joe Perches wrote: > On Fri, 2015-07-10 at 10:44 +0100, Srinivas Kandagatla wrote: >> This patch adds just providers part of the framework just to enable easy >> review. > > Trivial notes: Will fix all them. --srini > >> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c > >> +struct nvmem_device { >> + const char *name; >> + struct regmap *regmap; > [] >> +struct nvmem_cell { >> + const char *name; >> + int offset; >> + int bytes; > > It'd be nicer to use consistent indentation for *name > in nvmem_cell > >> +static ssize_t bin_attr_nvmem_read(struct file *filp, struct kobject *kobj, >> + struct bin_attribute *attr, >> + char *buf, loff_t pos, size_t count) >> +{ > [] >> + count = count/nvmem->word_size * nvmem->word_size; > > maybe rounddown() ? > >> +static ssize_t bin_attr_nvmem_write(struct file *filp, struct kobject *kobj, >> + struct bin_attribute *attr, >> + char *buf, loff_t pos, size_t count) >> +{ > >> + count = count/nvmem->word_size * nvmem->word_size; > > and rounddown() here too ? > >> +static struct nvmem_device *of_nvmem_find(struct device_node *nvmem_np) >> +{ >> + struct device *d; >> + >> + if (!nvmem_np) >> + return NULL; >> + >> + d = bus_find_device(&nvmem_bus_type, NULL, nvmem_np, of_nvmem_match); >> + >> + return d ? to_nvmem_device(d) : NULL; >> +} > > Perhaps more common as > > d = bus_find_device(&nvmem_bus_type, NULL, nvmem_np, of_nvmem_match); > if (!d) > return NULL; > > return to_nvmem_device(d); > } > >> +struct nvmem_device *nvmem_register(struct nvmem_config *config) >> +{ > [] >> + nvmem->read_only = nvmem->dev.of_node ? >> + of_property_read_bool(nvmem->dev.of_node, >> + "read-only") : >> + config->read_only; > > odd indentation. > Normally, "read-only" would be aligned with nvmem->dev.of_node, > >> + dev_dbg(&nvmem->dev, "Registering nvmem device %s\n", >> + dev_name(&nvmem->dev)); > > Isn't this going to have duplicated dev_name prefix and postfix? > >> + if (device_create_bin_file(&nvmem->dev, >> + nvmem->read_only ? &bin_attr_ro_nvmem : >> + &bin_attr_rw_nvmem)) >> + dev_info(&nvmem->dev, "Failed to create sysfs binary file\n"); > > Is the KERN_LEVEL correct? > Maybe dev_err/notice/warn/dbg? > >
next prev parent reply other threads:[~2015-07-10 10:39 UTC|newest] Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-07-10 9:43 [PATCH v7 0/9] Add simple NVMEM Framework via regmap Srinivas Kandagatla 2015-07-10 9:43 ` Srinivas Kandagatla 2015-07-10 9:44 ` [PATCH v7 2/9] nvmem: Add a simple NVMEM framework for consumers Srinivas Kandagatla 2015-07-10 9:44 ` Srinivas Kandagatla [not found] ` <1436521495-10728-1-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2015-07-10 10:42 ` Joe Perches 2015-07-10 10:42 ` Joe Perches 2015-07-10 10:42 ` Joe Perches 2015-07-13 19:06 ` Stefan Wahren 2015-07-13 19:06 ` Stefan Wahren 2015-07-13 19:06 ` Stefan Wahren 2015-07-13 19:24 ` Srinivas Kandagatla 2015-07-13 19:24 ` Srinivas Kandagatla 2015-07-10 9:45 ` [PATCH v7 3/9] nvmem: Add nvmem_device based consumer apis Srinivas Kandagatla 2015-07-10 9:45 ` Srinivas Kandagatla 2015-07-10 9:45 ` Srinivas Kandagatla [not found] ` <1436521505-10779-1-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2015-07-10 10:49 ` Joe Perches 2015-07-10 10:49 ` Joe Perches 2015-07-10 10:49 ` Joe Perches 2015-07-14 22:06 ` Stephen Boyd 2015-07-14 22:06 ` Stephen Boyd [not found] ` <20150714220607.GP30412-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> 2015-07-15 8:21 ` Srinivas Kandagatla 2015-07-15 8:21 ` Srinivas Kandagatla 2015-07-15 8:21 ` Srinivas Kandagatla 2015-07-10 9:45 ` [PATCH v7 4/9] nvmem: Add bindings for simple nvmem framework Srinivas Kandagatla 2015-07-10 9:45 ` Srinivas Kandagatla [not found] ` <1436521513-10838-1-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2015-07-10 19:04 ` Rob Herring 2015-07-10 19:04 ` Rob Herring 2015-07-10 19:04 ` Rob Herring [not found] ` <CAL_JsqKYT-+T=D=TKCb1TcydOvBTE8_yc-EEe1cwdmhr1B0dHQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-07-13 10:21 ` Srinivas Kandagatla 2015-07-13 10:21 ` Srinivas Kandagatla 2015-07-13 10:21 ` Srinivas Kandagatla 2015-07-10 9:45 ` [PATCH v7 5/9] Documentation: nvmem: add nvmem api level and how-to doc Srinivas Kandagatla 2015-07-10 9:45 ` Srinivas Kandagatla [not found] ` <1436521521-10889-1-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2015-07-14 21:32 ` Stephen Boyd 2015-07-14 21:32 ` Stephen Boyd 2015-07-14 21:32 ` Stephen Boyd 2015-07-14 22:00 ` Srinivas Kandagatla 2015-07-14 22:00 ` Srinivas Kandagatla 2015-07-10 9:45 ` [PATCH v7 6/9] nvmem: qfprom: Add Qualcomm QFPROM support Srinivas Kandagatla 2015-07-10 9:45 ` Srinivas Kandagatla [not found] ` <1436521529-10931-1-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2015-07-14 21:18 ` Stephen Boyd 2015-07-14 21:18 ` Stephen Boyd 2015-07-14 21:18 ` Stephen Boyd [not found] ` <20150714211831.GN30412-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> 2015-07-14 22:02 ` Srinivas Kandagatla 2015-07-14 22:02 ` Srinivas Kandagatla 2015-07-14 22:02 ` Srinivas Kandagatla [not found] ` <1436521427-10568-1-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2015-07-10 9:44 ` [PATCH v7 1/9] nvmem: Add a simple NVMEM framework for nvmem providers Srinivas Kandagatla 2015-07-10 9:44 ` Srinivas Kandagatla 2015-07-10 9:44 ` Srinivas Kandagatla [not found] ` <1436521486-10682-1-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2015-07-10 10:29 ` Joe Perches 2015-07-10 10:29 ` Joe Perches 2015-07-10 10:29 ` Joe Perches 2015-07-10 10:39 ` Srinivas Kandagatla [this message] 2015-07-10 10:39 ` Srinivas Kandagatla 2015-07-13 16:50 ` Philipp Zabel 2015-07-13 16:50 ` Philipp Zabel 2015-07-13 16:50 ` Philipp Zabel 2015-07-10 9:45 ` [PATCH v7 7/9] nvmem: qfprom: Add bindings for qfprom Srinivas Kandagatla 2015-07-10 9:45 ` Srinivas Kandagatla 2015-07-10 9:45 ` Srinivas Kandagatla 2015-07-13 18:54 ` [PATCH v7 0/9] Add simple NVMEM Framework via regmap Stefan Wahren 2015-07-13 18:54 ` Stefan Wahren 2015-07-13 18:54 ` Stefan Wahren 2015-07-13 19:35 ` Srinivas Kandagatla 2015-07-13 19:35 ` Srinivas Kandagatla 2015-07-13 19:35 ` Srinivas Kandagatla 2015-07-13 20:11 ` Stefan Wahren 2015-07-13 20:11 ` Stefan Wahren [not found] ` <139301016.164015.1436818270753.JavaMail.open-xchange-0SF9iQWekqKZU4JK52HgGMgmgJlYmuWJ@public.gmane.org> 2015-07-13 21:39 ` Srinivas Kandagatla 2015-07-13 21:39 ` Srinivas Kandagatla 2015-07-13 21:39 ` Srinivas Kandagatla 2015-07-10 9:45 ` [PATCH v7 8/9] nvmem: sunxi: Move the SID driver to the nvmem framework Srinivas Kandagatla 2015-07-10 9:45 ` Srinivas Kandagatla 2015-07-10 9:46 ` [PATCH v7 9/9] nvmem: Add to MAINTAINERS for " Srinivas Kandagatla 2015-07-10 9:46 ` Srinivas Kandagatla
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=559FA0CB.50405@linaro.org \ --to=srinivas.kandagatla@linaro.org \ --cc=arnd@arndb.de \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=galak@codeaurora.org \ --cc=gregkh@linuxfoundation.org \ --cc=joe@perches.com \ --cc=linux-api@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=maxime.ripard@free-electrons.com \ --cc=mporter@konsulko.com \ --cc=pantelis.antoniou@konsulko.com \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=sboyd@codeaurora.org \ --cc=stefan.wahren@i2se.com \ --cc=wxt@rock-chips.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.