[PATCH] perf: fix makefile generation under dash

[PATCH] perf: fix makefile generation under dash

[Sergei Trofimovich]

Under dash 'echo -n' yields '-n' to stdout.
Use printf "" instead.

CC: Peter Zijlstra <a.p.zijlstra@chello.nl>
CC: Ingo Molnar <mingo@redhat.com>
CC: Arnaldo Carvalho de Melo <acme@kernel.org>
CC: Jiri Olsa <jolsa@redhat.com>
CC: Namhyung Kim <namhyung@kernel.org>
CC: Adrian Hunter <adrian.hunter@intel.com>
CC: linux-kernel@vger.kernel.org
Signed-off-by: Sergei Trofimovich <siarheit@google.com>
---
 tools/perf/config/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
index 094ddae..bc0b59e 100644
--- a/tools/perf/config/Makefile
+++ b/tools/perf/config/Makefile
@@ -11,7 +11,7 @@ ifneq ($(obj-perf),)
 obj-perf := $(abspath $(obj-perf))/
 endif
 
-$(shell echo -n > $(OUTPUT).config-detected)
+$(shell printf "" > $(OUTPUT).config-detected)
 detected     = $(shell echo "$(1)=y"       >> $(OUTPUT).config-detected)
 detected_var = $(shell echo "$(1)=$($(1))" >> $(OUTPUT).config-detected)
 
-- 
2.4.6

Re: [PATCH] perf: fix makefile generation under dash

[Jiri Olsa]

On Sun, Jul 19, 2015 at 10:30:05AM +0100, Sergei Trofimovich wrote:
> Under dash 'echo -n' yields '-n' to stdout.
> Use printf "" instead.

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka

> 
> CC: Peter Zijlstra <a.p.zijlstra@chello.nl>
> CC: Ingo Molnar <mingo@redhat.com>
> CC: Arnaldo Carvalho de Melo <acme@kernel.org>
> CC: Jiri Olsa <jolsa@redhat.com>
> CC: Namhyung Kim <namhyung@kernel.org>
> CC: Adrian Hunter <adrian.hunter@intel.com>
> CC: linux-kernel@vger.kernel.org
> Signed-off-by: Sergei Trofimovich <siarheit@google.com>
> ---
>  tools/perf/config/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
> index 094ddae..bc0b59e 100644
> --- a/tools/perf/config/Makefile
> +++ b/tools/perf/config/Makefile
> @@ -11,7 +11,7 @@ ifneq ($(obj-perf),)
>  obj-perf := $(abspath $(obj-perf))/
>  endif
>  
> -$(shell echo -n > $(OUTPUT).config-detected)
> +$(shell printf "" > $(OUTPUT).config-detected)
>  detected     = $(shell echo "$(1)=y"       >> $(OUTPUT).config-detected)
>  detected_var = $(shell echo "$(1)=$($(1))" >> $(OUTPUT).config-detected)
>  
> -- 
> 2.4.6
> 

Re: [PATCH] perf: fix makefile generation under dash

[Ingo Molnar]

* Sergei Trofimovich <siarheit@google.com> wrote:

> Under dash 'echo -n' yields '-n' to stdout.

Acked-by: Ingo Molnar <mingo@kernel.org>

Btw, 'echo -n' is a pretty common construct in shell scripts - Dash would really 
do people a big favor by implementing it, and it's a very simple feature.

Thanks,

	Ingo

Re: [PATCH] perf: fix makefile generation under dash

[Arnaldo Carvalho de Melo]

Em Mon, Jul 20, 2015 at 09:44:55AM +0200, Ingo Molnar escreveu:
> 
> * Sergei Trofimovich <siarheit@google.com> wrote:
> 
> > Under dash 'echo -n' yields '-n' to stdout.
> 
> Acked-by: Ingo Molnar <mingo@kernel.org>
> 
> Btw, 'echo -n' is a pretty common construct in shell scripts - Dash would really 
> do people a big favor by implementing it, and it's a very simple feature.

Thanks, applied.

- Arnaldo

[tip:perf/core] perf tools: Fix makefile generation under dash

[tip-bot for Sergei Trofimovich]

Commit-ID:  52c0a18b9010fb19d10889e8a00aa784197d357c
Gitweb:     http://git.kernel.org/tip/52c0a18b9010fb19d10889e8a00aa784197d357c
Author:     Sergei Trofimovich <siarheit@google.com>
AuthorDate: Sun, 19 Jul 2015 10:30:05 +0100
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 20 Jul 2015 17:49:50 -0300

perf tools: Fix makefile generation under dash

Under dash 'echo -n' yields '-n' to stdout.  Use printf "" instead.

Signed-off-by: Sergei Trofimovich <siarheit@google.com>
Acked-by: Ingo Molnar <mingo@kernel.org>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1437298205-29305-1-git-send-email-siarheit@google.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/config/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
index a9b93d1..8768f84 100644
--- a/tools/perf/config/Makefile
+++ b/tools/perf/config/Makefile
@@ -11,7 +11,7 @@ ifneq ($(obj-perf),)
 obj-perf := $(abspath $(obj-perf))/
 endif
 
-$(shell echo -n > $(OUTPUT).config-detected)
+$(shell printf "" > $(OUTPUT).config-detected)
 detected     = $(shell echo "$(1)=y"       >> $(OUTPUT).config-detected)
 detected_var = $(shell echo "$(1)=$($(1))" >> $(OUTPUT).config-detected)