[patch] ASoC: max98925: reading beyond the end of the array

[patch] ASoC: max98925: reading beyond the end of the array

[Dan Carpenter]

Debug prints are seldom useful and this one has an annoying thing where
it reads one space beyond the end of the array on error.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/sound/soc/codecs/max98925.c b/sound/soc/codecs/max98925.c
index e1753c8..ebb648a 100644
--- a/sound/soc/codecs/max98925.c
+++ b/sound/soc/codecs/max98925.c
@@ -271,8 +271,6 @@ static inline int max98925_rate_value(struct snd_soc_codec *codec,
 			break;
 		}
 	}
-	dev_dbg(codec->dev, "%s: sample rate is %d, returning %d\n",
-				__func__, rate_table[i].rate, *value);
 	return ret;
 }
 

[patch] ASoC: max98925: reading beyond the end of the array

[Dan Carpenter]

Debug prints are seldom useful and this one has an annoying thing where
it reads one space beyond the end of the array on error.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/sound/soc/codecs/max98925.c b/sound/soc/codecs/max98925.c
index e1753c8..ebb648a 100644
--- a/sound/soc/codecs/max98925.c
+++ b/sound/soc/codecs/max98925.c
@@ -271,8 +271,6 @@ static inline int max98925_rate_value(struct snd_soc_codec *codec,
 			break;
 		}
 	}
-	dev_dbg(codec->dev, "%s: sample rate is %d, returning %d\n",
-				__func__, rate_table[i].rate, *value);
 	return ret;
 }
 

Re: [patch] ASoC: max98925: reading beyond the end of the array

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 269 bytes --]

On Tue, Jul 21, 2015 at 11:55:27AM +0300, Dan Carpenter wrote:
> Debug prints are seldom useful and this one has an annoying thing where
> it reads one space beyond the end of the array on error.

It's a pretty big stretch to say that debug prints are rarely useful...

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: [patch] ASoC: max98925: reading beyond the end of the array

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 269 bytes --]

On Tue, Jul 21, 2015 at 11:55:27AM +0300, Dan Carpenter wrote:
> Debug prints are seldom useful and this one has an annoying thing where
> it reads one space beyond the end of the array on error.

It's a pretty big stretch to say that debug prints are rarely useful...

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: [patch] ASoC: max98925: reading beyond the end of the array

[Dan Carpenter]

On Tue, Jul 21, 2015 at 11:43:50AM +0100, Mark Brown wrote:
> On Tue, Jul 21, 2015 at 11:55:27AM +0300, Dan Carpenter wrote:
> > Debug prints are seldom useful and this one has an annoying thing where
> > it reads one space beyond the end of the array on error.
> 
> It's a pretty big stretch to say that debug prints are rarely useful...

I asked Anish if it was worth fixing and he said to delete it.

regards,
dan carpenter

Re: [patch] ASoC: max98925: reading beyond the end of the array

[Dan Carpenter]

On Tue, Jul 21, 2015 at 11:43:50AM +0100, Mark Brown wrote:
> On Tue, Jul 21, 2015 at 11:55:27AM +0300, Dan Carpenter wrote:
> > Debug prints are seldom useful and this one has an annoying thing where
> > it reads one space beyond the end of the array on error.
> 
> It's a pretty big stretch to say that debug prints are rarely useful...

I asked Anish if it was worth fixing and he said to delete it.

regards,
dan carpenter

Re: [patch] ASoC: max98925: reading beyond the end of the array

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 599 bytes --]

On Tue, Jul 21, 2015 at 01:57:43PM +0300, Dan Carpenter wrote:
> On Tue, Jul 21, 2015 at 11:43:50AM +0100, Mark Brown wrote:
> > On Tue, Jul 21, 2015 at 11:55:27AM +0300, Dan Carpenter wrote:
> > > Debug prints are seldom useful and this one has an annoying thing where
> > > it reads one space beyond the end of the array on error.

> > It's a pretty big stretch to say that debug prints are rarely useful...

> I asked Anish if it was worth fixing and he said to delete it.

Sure, but you're making a general comment about debug prints being
seldom useful rather than just talking about this one.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: [patch] ASoC: max98925: reading beyond the end of the array

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 599 bytes --]

On Tue, Jul 21, 2015 at 01:57:43PM +0300, Dan Carpenter wrote:
> On Tue, Jul 21, 2015 at 11:43:50AM +0100, Mark Brown wrote:
> > On Tue, Jul 21, 2015 at 11:55:27AM +0300, Dan Carpenter wrote:
> > > Debug prints are seldom useful and this one has an annoying thing where
> > > it reads one space beyond the end of the array on error.

> > It's a pretty big stretch to say that debug prints are rarely useful...

> I asked Anish if it was worth fixing and he said to delete it.

Sure, but you're making a general comment about debug prints being
seldom useful rather than just talking about this one.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Applied "ASoC: max98925: reading beyond the end of the array" to the asoc tree

[Mark Brown]

The patch

   ASoC: max98925: reading beyond the end of the array

has been applied to the asoc tree at

   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 6eb1c2a63d0415bd66c9c866b7d405662f50d5e4 Mon Sep 17 00:00:00 2001
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 21 Jul 2015 11:55:27 +0300
Subject: [PATCH] ASoC: max98925: reading beyond the end of the array

Debug prints are seldom useful and this one has an annoying thing where
it reads one space beyond the end of the array on error.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/codecs/max98925.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/sound/soc/codecs/max98925.c b/sound/soc/codecs/max98925.c
index eddf8bc07314..0883d87776b1 100644
--- a/sound/soc/codecs/max98925.c
+++ b/sound/soc/codecs/max98925.c
@@ -271,8 +271,6 @@ static inline int max98925_rate_value(struct snd_soc_codec *codec,
 			break;
 		}
 	}
-	dev_dbg(codec->dev, "%s: sample rate is %d, returning %d\n",
-				__func__, rate_table[i].rate, *value);
 	return ret;
 }
 
-- 
2.1.4