* [PATCH for-4.6] tools: Don't try to update the firmware directory on ARM
@ 2015-08-07 17:27 Julien Grall
2015-08-08 15:16 ` Wei Liu
2015-08-13 9:44 ` Wei Liu
0 siblings, 2 replies; 7+ messages in thread
From: Julien Grall @ 2015-08-07 17:27 UTC (permalink / raw)
To: xen-devel
Cc: Wei Liu, ian.campbell, Stefano Stabellini, Ian Jackson,
Julien Grall, stefano.stabellini
The firmware directory is not built at all on ARM. Attempting to update
it using the target subtree-force-update will fail when try to update
seabios.
Signed-off-by: Julien Grall <julien.grall@citrix.com>
---
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Ian Campbell <ian.campbell@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>
I've noticed it while trying to update the QEMU tree used by Xen on
a platform where iasl is not present (required by seabios in order
to update it).
I think this should go in Xen 4.6 and possibly backport to Xen 4.5
---
tools/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/Makefile b/tools/Makefile
index 45cb4b2..2618559 100644
--- a/tools/Makefile
+++ b/tools/Makefile
@@ -305,7 +305,9 @@ endif
ifeq ($(CONFIG_QEMU_TRAD),y)
$(MAKE) qemu-xen-traditional-dir-force-update
endif
+ifeq ($(CONFIG_X86),y)
$(MAKE) -C firmware subtree-force-update
+endif
subtree-force-update-all:
$(MAKE) qemu-xen-dir-force-update
--
2.1.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH for-4.6] tools: Don't try to update the firmware directory on ARM
2015-08-07 17:27 [PATCH for-4.6] tools: Don't try to update the firmware directory on ARM Julien Grall
@ 2015-08-08 15:16 ` Wei Liu
2015-08-09 13:49 ` Julien Grall
2015-08-13 9:44 ` Wei Liu
1 sibling, 1 reply; 7+ messages in thread
From: Wei Liu @ 2015-08-08 15:16 UTC (permalink / raw)
To: Julien Grall
Cc: Wei.Liu2, ian.campbell, Stefano Stabellini, Ian Jackson,
stefano.stabellini, xen-devel
On Fri, Aug 07, 2015 at 06:27:18PM +0100, Julien Grall wrote:
> The firmware directory is not built at all on ARM. Attempting to update
> it using the target subtree-force-update will fail when try to update
> seabios.
>
> Signed-off-by: Julien Grall <julien.grall@citrix.com>
>
> ---
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
>
> I've noticed it while trying to update the QEMU tree used by Xen on
> a platform where iasl is not present (required by seabios in order
> to update it).
>
> I think this should go in Xen 4.6 and possibly backport to Xen 4.5
> ---
> tools/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/Makefile b/tools/Makefile
> index 45cb4b2..2618559 100644
> --- a/tools/Makefile
> +++ b/tools/Makefile
> @@ -305,7 +305,9 @@ endif
> ifeq ($(CONFIG_QEMU_TRAD),y)
> $(MAKE) qemu-xen-traditional-dir-force-update
> endif
> +ifeq ($(CONFIG_X86),y)
> $(MAKE) -C firmware subtree-force-update
> +endif
>
This is not optimal. What if you want to build OVMF on arm in the
future? You also can't preclude you don't have any other firmwares that
need to be built on ARM in the future.
I think a proper way of doing this is to make CONFIG_SEABIOS=n when
you're building on ARM. See tools/configure.ac.
Wei.
> subtree-force-update-all:
> $(MAKE) qemu-xen-dir-force-update
> --
> 2.1.4
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH for-4.6] tools: Don't try to update the firmware directory on ARM
2015-08-08 15:16 ` Wei Liu
@ 2015-08-09 13:49 ` Julien Grall
2015-08-11 12:22 ` Ian Campbell
0 siblings, 1 reply; 7+ messages in thread
From: Julien Grall @ 2015-08-09 13:49 UTC (permalink / raw)
To: Wei Liu
Cc: Ian Jackson, xen-devel, stefano.stabellini, ian.campbell,
Stefano Stabellini
Hi Wei,
On 08/08/2015 16:16, Wei Liu wrote:
> On Fri, Aug 07, 2015 at 06:27:18PM +0100, Julien Grall wrote:
>> The firmware directory is not built at all on ARM. Attempting to update
>> it using the target subtree-force-update will fail when try to update
>> seabios.
>>
>> Signed-off-by: Julien Grall <julien.grall@citrix.com>
>>
>> ---
>> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
>> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>> Cc: Ian Campbell <ian.campbell@citrix.com>
>> Cc: Wei Liu <wei.liu2@citrix.com>
>>
>> I've noticed it while trying to update the QEMU tree used by Xen on
>> a platform where iasl is not present (required by seabios in order
>> to update it).
>>
>> I think this should go in Xen 4.6 and possibly backport to Xen 4.5
>> ---
>> tools/Makefile | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/tools/Makefile b/tools/Makefile
>> index 45cb4b2..2618559 100644
>> --- a/tools/Makefile
>> +++ b/tools/Makefile
>> @@ -305,7 +305,9 @@ endif
>> ifeq ($(CONFIG_QEMU_TRAD),y)
>> $(MAKE) qemu-xen-traditional-dir-force-update
>> endif
>> +ifeq ($(CONFIG_X86),y)
>> $(MAKE) -C firmware subtree-force-update
>> +endif
>>
>
> This is not optimal. What if you want to build OVMF on arm in the
> future? You also can't preclude you don't have any other firmwares that
> need to be built on ARM in the future.
> I think a proper way of doing this is to make CONFIG_SEABIOS=n when
> you're building on ARM. See tools/configure.ac.
tools/Makefile only build the firmware directory for x86 see:
SUBDIRS-$(CONFIG_X86) += firmware
Hence why I wrote the patch in the current way.
Building the firmware directory for would require more work than replace
SUBDIRS-$(CONFIG_X86) to SUBDIRS-y.
In general, I do agree that we enable this with configure.ac but, IHMO
this is not Xen 4.6 material...
Although I would be happy to fix it for Xen 4.7.
Regards,
--
Julien Grall
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH for-4.6] tools: Don't try to update the firmware directory on ARM
2015-08-09 13:49 ` Julien Grall
@ 2015-08-11 12:22 ` Ian Campbell
2015-08-11 12:28 ` Wei Liu
0 siblings, 1 reply; 7+ messages in thread
From: Ian Campbell @ 2015-08-11 12:22 UTC (permalink / raw)
To: Julien Grall, Wei Liu
Cc: xen-devel, stefano.stabellini, Ian Jackson, Stefano Stabellini
On Sun, 2015-08-09 at 14:49 +0100, Julien Grall wrote:
> Hi Wei,
>
> On 08/08/2015 16:16, Wei Liu wrote:
> > On Fri, Aug 07, 2015 at 06:27:18PM +0100, Julien Grall wrote:
> > > The firmware directory is not built at all on ARM. Attempting to
> > > update
> > > it using the target subtree-force-update will fail when try to update
> > > seabios.
> > >
> > > Signed-off-by: Julien Grall <julien.grall@citrix.com>
> > >
> > > ---
> > > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > > Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> > > Cc: Ian Campbell <ian.campbell@citrix.com>
> > > Cc: Wei Liu <wei.liu2@citrix.com>
> > >
> > > I've noticed it while trying to update the QEMU tree used by Xen
> > > on
> > > a platform where iasl is not present (required by seabios in
> > > order
> > > to update it).
> > >
> > > I think this should go in Xen 4.6 and possibly backport to Xen
> > > 4.5
> > > ---
> > > tools/Makefile | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/tools/Makefile b/tools/Makefile
> > > index 45cb4b2..2618559 100644
> > > --- a/tools/Makefile
> > > +++ b/tools/Makefile
> > > @@ -305,7 +305,9 @@ endif
> > > ifeq ($(CONFIG_QEMU_TRAD),y)
> > > $(MAKE) qemu-xen-traditional-dir-force-update
> > > endif
> > > +ifeq ($(CONFIG_X86),y)
> > > $(MAKE) -C firmware subtree-force-update
> > > +endif
> > >
> >
> > This is not optimal. What if you want to build OVMF on arm in the
> > future?
Slight aside, but I already looked at doing this but concluded that the
right answer was to add this to raisin not xen.git. As it happens on ARM we
would boot the UEFI binary directly, so we don't need to compile it into
hvmloader or just through other hoops, so it is a bit easier than on x86.
> > You also can't preclude you don't have any other firmwares that
> > need to be built on ARM in the future.
> > I think a proper way of doing this is to make CONFIG_SEABIOS=n when
> > you're building on ARM. See tools/configure.ac.
>
> tools/Makefile only build the firmware directory for x86 see:
>
> SUBDIRS-$(CONFIG_X86) += firmware
>
> Hence why I wrote the patch in the current way.
I think having the update rule match (in spirit at least) the SUBDIRS rules
make sense as a patch for now, so I'm in favour of taking this patch as it
is.
> Building the firmware directory for would require more work than replace
> SUBDIRS-$(CONFIG_X86) to SUBDIRS-y.
> In general, I do agree that we enable this with configure.ac but, IHMO
> this is not Xen 4.6 material...
>
> Although I would be happy to fix it for Xen 4.7.
>
> Regards,
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH for-4.6] tools: Don't try to update the firmware directory on ARM
2015-08-11 12:22 ` Ian Campbell
@ 2015-08-11 12:28 ` Wei Liu
0 siblings, 0 replies; 7+ messages in thread
From: Wei Liu @ 2015-08-11 12:28 UTC (permalink / raw)
To: Ian Campbell
Cc: Wei Liu, Stefano Stabellini, Ian Jackson, Julien Grall,
stefano.stabellini, xen-devel
On Tue, Aug 11, 2015 at 01:22:24PM +0100, Ian Campbell wrote:
> On Sun, 2015-08-09 at 14:49 +0100, Julien Grall wrote:
> > Hi Wei,
> >
> > On 08/08/2015 16:16, Wei Liu wrote:
> > > On Fri, Aug 07, 2015 at 06:27:18PM +0100, Julien Grall wrote:
> > > > The firmware directory is not built at all on ARM. Attempting to
> > > > update
> > > > it using the target subtree-force-update will fail when try to update
> > > > seabios.
> > > >
> > > > Signed-off-by: Julien Grall <julien.grall@citrix.com>
> > > >
> > > > ---
> > > > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > > > Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> > > > Cc: Ian Campbell <ian.campbell@citrix.com>
> > > > Cc: Wei Liu <wei.liu2@citrix.com>
> > > >
> > > > I've noticed it while trying to update the QEMU tree used by Xen
> > > > on
> > > > a platform where iasl is not present (required by seabios in
> > > > order
> > > > to update it).
> > > >
> > > > I think this should go in Xen 4.6 and possibly backport to Xen
> > > > 4.5
> > > > ---
> > > > tools/Makefile | 2 ++
> > > > 1 file changed, 2 insertions(+)
> > > >
> > > > diff --git a/tools/Makefile b/tools/Makefile
> > > > index 45cb4b2..2618559 100644
> > > > --- a/tools/Makefile
> > > > +++ b/tools/Makefile
> > > > @@ -305,7 +305,9 @@ endif
> > > > ifeq ($(CONFIG_QEMU_TRAD),y)
> > > > $(MAKE) qemu-xen-traditional-dir-force-update
> > > > endif
> > > > +ifeq ($(CONFIG_X86),y)
> > > > $(MAKE) -C firmware subtree-force-update
> > > > +endif
> > > >
> > >
> > > This is not optimal. What if you want to build OVMF on arm in the
> > > future?
>
> Slight aside, but I already looked at doing this but concluded that the
> right answer was to add this to raisin not xen.git. As it happens on ARM we
> would boot the UEFI binary directly, so we don't need to compile it into
> hvmloader or just through other hoops, so it is a bit easier than on x86.
>
Right. Makes sense.
> > > You also can't preclude you don't have any other firmwares that
> > > need to be built on ARM in the future.
> > > I think a proper way of doing this is to make CONFIG_SEABIOS=n when
> > > you're building on ARM. See tools/configure.ac.
> >
> > tools/Makefile only build the firmware directory for x86 see:
> >
> > SUBDIRS-$(CONFIG_X86) += firmware
> >
> > Hence why I wrote the patch in the current way.
>
> I think having the update rule match (in spirit at least) the SUBDIRS rules
> make sense as a patch for now, so I'm in favour of taking this patch as it
> is.
>
Fine by me then.
Acked-by: Wei Liu <wei.liu2@citrix.com>
> > Building the firmware directory for would require more work than replace
> > SUBDIRS-$(CONFIG_X86) to SUBDIRS-y.
> > In general, I do agree that we enable this with configure.ac but, IHMO
> > this is not Xen 4.6 material...
> >
> > Although I would be happy to fix it for Xen 4.7.
> >
> > Regards,
> >
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH for-4.6] tools: Don't try to update the firmware directory on ARM
2015-08-07 17:27 [PATCH for-4.6] tools: Don't try to update the firmware directory on ARM Julien Grall
2015-08-08 15:16 ` Wei Liu
@ 2015-08-13 9:44 ` Wei Liu
2015-08-13 10:31 ` Ian Campbell
1 sibling, 1 reply; 7+ messages in thread
From: Wei Liu @ 2015-08-13 9:44 UTC (permalink / raw)
To: Julien Grall
Cc: Wei.Liu2, ian.campbell, Stefano Stabellini, Ian Jackson,
stefano.stabellini, xen-devel
On Fri, Aug 07, 2015 at 06:27:18PM +0100, Julien Grall wrote:
> The firmware directory is not built at all on ARM. Attempting to update
> it using the target subtree-force-update will fail when try to update
> seabios.
>
> Signed-off-by: Julien Grall <julien.grall@citrix.com>
Release-acked-by: Wei Liu <wei.liu2@citrix.com>
>
> ---
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
>
> I've noticed it while trying to update the QEMU tree used by Xen on
> a platform where iasl is not present (required by seabios in order
> to update it).
>
> I think this should go in Xen 4.6 and possibly backport to Xen 4.5
> ---
> tools/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/Makefile b/tools/Makefile
> index 45cb4b2..2618559 100644
> --- a/tools/Makefile
> +++ b/tools/Makefile
> @@ -305,7 +305,9 @@ endif
> ifeq ($(CONFIG_QEMU_TRAD),y)
> $(MAKE) qemu-xen-traditional-dir-force-update
> endif
> +ifeq ($(CONFIG_X86),y)
> $(MAKE) -C firmware subtree-force-update
> +endif
>
> subtree-force-update-all:
> $(MAKE) qemu-xen-dir-force-update
> --
> 2.1.4
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH for-4.6] tools: Don't try to update the firmware directory on ARM
2015-08-13 9:44 ` Wei Liu
@ 2015-08-13 10:31 ` Ian Campbell
0 siblings, 0 replies; 7+ messages in thread
From: Ian Campbell @ 2015-08-13 10:31 UTC (permalink / raw)
To: Wei Liu, Julien Grall
Cc: xen-devel, stefano.stabellini, Ian Jackson, Stefano Stabellini
On Thu, 2015-08-13 at 10:44 +0100, Wei Liu wrote:
> On Fri, Aug 07, 2015 at 06:27:18PM +0100, Julien Grall wrote:
> > The firmware directory is not built at all on ARM. Attempting to update
> > it using the target subtree-force-update will fail when try to update
> > seabios.
> >
> > Signed-off-by: Julien Grall <julien.grall@citrix.com>
>
> Release-acked-by: Wei Liu <wei.liu2@citrix.com>
Acked + applied, thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-08-13 10:32 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-07 17:27 [PATCH for-4.6] tools: Don't try to update the firmware directory on ARM Julien Grall
2015-08-08 15:16 ` Wei Liu
2015-08-09 13:49 ` Julien Grall
2015-08-11 12:22 ` Ian Campbell
2015-08-11 12:28 ` Wei Liu
2015-08-13 9:44 ` Wei Liu
2015-08-13 10:31 ` Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.