All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: santosh shilimkar <santosh.shilimkar@oracle.com>
Cc: "Kwok, WingMan" <w-kwok2@ti.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"pawel.moll@arm.com" <pawel.moll@arm.com>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
	"galak@codeaurora.org" <galak@codeaurora.org>,
	"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"ssantosh@kernel.org" <ssantosh@kernel.org>,
	"Karicheri, Muralidharan" <m-karicheri2@ti.com>
Subject: Re: [PATCH] ARM: dts: keystone: use one to one address translations under netcp
Date: Thu, 3 Sep 2015 07:26:46 -0700	[thread overview]
Message-ID: <20150903142645.GS4215@atomide.com> (raw)
In-Reply-To: <55E71AB3.7070406@oracle.com>

* santosh shilimkar <santosh.shilimkar@oracle.com> [150902 08:55]:
>
> I suspected the same. I know back then we started with SERDES code
> with NETCP but as you already know, its a separate block which
> is needed for NIC card to work. Its more of phy and hence its
> having different address space is not surprising.

The point Santosh is making here though is that any drivers
tinkering with registers belonging to a separate hardware block
is a recipe for a long term maintenance nightmare with mysterious
bugs popping up as things are not clocked or powered properly
or become racy with other drivers.

Each hardware block needs to have it's own driver and then the
drivers can communicate using some Linux generic APIs like clock,
regulator, phy, or mailbox frameworks.

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
To: santosh shilimkar
	<santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: "Kwok, WingMan" <w-kwok2-l0cyMroinI0@public.gmane.org>,
	"robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
	<robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"pawel.moll-5wv7dgnIgG8@public.gmane.org"
	<pawel.moll-5wv7dgnIgG8@public.gmane.org>,
	"mark.rutland-5wv7dgnIgG8@public.gmane.org"
	<mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	"ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org"
	<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
	"galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org"
	<galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	"linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org"
	<linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"ssantosh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
	<ssantosh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"Karicheri,
	Muralidharan" <m-karicheri2-l0cyMroinI0@public.gmane.org>
Subject: Re: [PATCH] ARM: dts: keystone: use one to one address translations under netcp
Date: Thu, 3 Sep 2015 07:26:46 -0700	[thread overview]
Message-ID: <20150903142645.GS4215@atomide.com> (raw)
In-Reply-To: <55E71AB3.7070406-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>

* santosh shilimkar <santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> [150902 08:55]:
>
> I suspected the same. I know back then we started with SERDES code
> with NETCP but as you already know, its a separate block which
> is needed for NIC card to work. Its more of phy and hence its
> having different address space is not surprising.

The point Santosh is making here though is that any drivers
tinkering with registers belonging to a separate hardware block
is a recipe for a long term maintenance nightmare with mysterious
bugs popping up as things are not clocked or powered properly
or become racy with other drivers.

Each hardware block needs to have it's own driver and then the
drivers can communicate using some Linux generic APIs like clock,
regulator, phy, or mailbox frameworks.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: keystone: use one to one address translations under netcp
Date: Thu, 3 Sep 2015 07:26:46 -0700	[thread overview]
Message-ID: <20150903142645.GS4215@atomide.com> (raw)
In-Reply-To: <55E71AB3.7070406@oracle.com>

* santosh shilimkar <santosh.shilimkar@oracle.com> [150902 08:55]:
>
> I suspected the same. I know back then we started with SERDES code
> with NETCP but as you already know, its a separate block which
> is needed for NIC card to work. Its more of phy and hence its
> having different address space is not surprising.

The point Santosh is making here though is that any drivers
tinkering with registers belonging to a separate hardware block
is a recipe for a long term maintenance nightmare with mysterious
bugs popping up as things are not clocked or powered properly
or become racy with other drivers.

Each hardware block needs to have it's own driver and then the
drivers can communicate using some Linux generic APIs like clock,
regulator, phy, or mailbox frameworks.

Regards,

Tony

  parent reply	other threads:[~2015-09-03 14:26 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-01 20:28 [PATCH] ARM: dts: keystone: use one to one address translations under netcp WingMan Kwok
2015-09-01 20:28 ` WingMan Kwok
2015-09-01 20:28 ` WingMan Kwok
2015-09-01 21:19 ` santosh.shilimkar
2015-09-01 21:19   ` santosh.shilimkar at oracle.com
2015-09-01 21:19   ` santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA
2015-09-02 15:31   ` Kwok, WingMan
2015-09-02 15:31     ` Kwok, WingMan
2015-09-02 15:31     ` Kwok, WingMan
2015-09-02 15:50     ` santosh shilimkar
2015-09-02 15:50       ` santosh shilimkar
2015-09-02 15:50       ` santosh shilimkar
2015-09-02 16:35       ` Murali Karicheri
2015-09-02 16:35         ` Murali Karicheri
2015-09-02 16:35         ` Murali Karicheri
2015-09-02 17:24         ` santosh shilimkar
2015-09-02 17:24           ` santosh shilimkar
2015-09-02 17:24           ` santosh shilimkar
2015-09-02 17:58           ` Murali Karicheri
2015-09-02 17:58             ` Murali Karicheri
2015-09-02 17:58             ` Murali Karicheri
2015-09-02 18:25             ` santosh shilimkar
2015-09-02 18:25               ` santosh shilimkar
2015-09-02 18:25               ` santosh shilimkar
2015-09-02 18:42               ` Murali Karicheri
2015-09-02 18:42                 ` Murali Karicheri
2015-09-02 18:42                 ` Murali Karicheri
2015-09-03 14:26       ` Tony Lindgren [this message]
2015-09-03 14:26         ` Tony Lindgren
2015-09-03 14:26         ` Tony Lindgren
2015-09-03 14:48         ` santosh.shilimkar
2015-09-03 14:48           ` santosh.shilimkar at oracle.com
2015-09-03 14:48           ` santosh.shilimkar
2015-09-03 19:18         ` Murali Karicheri
2015-09-03 19:18           ` Murali Karicheri
2015-09-03 19:18           ` Murali Karicheri
2015-09-08 15:13           ` Tony Lindgren
2015-09-08 15:13             ` Tony Lindgren
2015-09-08 15:13             ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150903142645.GS4215@atomide.com \
    --to=tony@atomide.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=m-karicheri2@ti.com \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=santosh.shilimkar@oracle.com \
    --cc=ssantosh@kernel.org \
    --cc=w-kwok2@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.