From: Brian Norris <computersforpeace@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Gregory Fong <gregory.0xf0@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH 6/7] ARM: brcmstb: mask GIC IRQs on suspend
Date: Mon, 14 Sep 2015 10:42:09 -0700 [thread overview]
Message-ID: <20150914174209.GQ11487@google.com> (raw)
In-Reply-To: <55F482BC.4050202@gmail.com>
One more thing:
On Sat, Sep 12, 2015 at 12:53:32PM -0700, Florian Fainelli wrote:
> Le 06/18/15 17:11, Brian Norris a écrit :
> > Lazily-masked IRQs can cause system suspend problems (e.g., spurious
> > wakeups from WFI), so we need to be sure non-wakeup GIC interrupts get
> > masked, not just disabled, during system suspend.
> >
> > Signed-off-by: Brian Norris <computersforpeace@gmail.com>
>
> Dropped this patch, no longer needed as of 4.3-rc0 with
> aec89ef72ba6c94420f599dcb684ed66937cdacf ("irqchip/gic: Enable
> SKIP_SET_WAKE and MASK_ON_SUSPEND")
With this patch dropped, then we really don't need
arch/arm/mach-bcm/brcmstb.c any more, AFAICT. Unless you have more plans
for this file, I can send a patch...
Brian
WARNING: multiple messages have this Message-ID (diff)
From: Brian Norris <computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Florian Fainelli <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Gregory Fong
<gregory.0xf0-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH 6/7] ARM: brcmstb: mask GIC IRQs on suspend
Date: Mon, 14 Sep 2015 10:42:09 -0700 [thread overview]
Message-ID: <20150914174209.GQ11487@google.com> (raw)
In-Reply-To: <55F482BC.4050202-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
One more thing:
On Sat, Sep 12, 2015 at 12:53:32PM -0700, Florian Fainelli wrote:
> Le 06/18/15 17:11, Brian Norris a écrit :
> > Lazily-masked IRQs can cause system suspend problems (e.g., spurious
> > wakeups from WFI), so we need to be sure non-wakeup GIC interrupts get
> > masked, not just disabled, during system suspend.
> >
> > Signed-off-by: Brian Norris <computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> Dropped this patch, no longer needed as of 4.3-rc0 with
> aec89ef72ba6c94420f599dcb684ed66937cdacf ("irqchip/gic: Enable
> SKIP_SET_WAKE and MASK_ON_SUSPEND")
With this patch dropped, then we really don't need
arch/arm/mach-bcm/brcmstb.c any more, AFAICT. Unless you have more plans
for this file, I can send a patch...
Brian
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: computersforpeace@gmail.com (Brian Norris)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/7] ARM: brcmstb: mask GIC IRQs on suspend
Date: Mon, 14 Sep 2015 10:42:09 -0700 [thread overview]
Message-ID: <20150914174209.GQ11487@google.com> (raw)
In-Reply-To: <55F482BC.4050202@gmail.com>
One more thing:
On Sat, Sep 12, 2015 at 12:53:32PM -0700, Florian Fainelli wrote:
> Le 06/18/15 17:11, Brian Norris a ?crit :
> > Lazily-masked IRQs can cause system suspend problems (e.g., spurious
> > wakeups from WFI), so we need to be sure non-wakeup GIC interrupts get
> > masked, not just disabled, during system suspend.
> >
> > Signed-off-by: Brian Norris <computersforpeace@gmail.com>
>
> Dropped this patch, no longer needed as of 4.3-rc0 with
> aec89ef72ba6c94420f599dcb684ed66937cdacf ("irqchip/gic: Enable
> SKIP_SET_WAKE and MASK_ON_SUSPEND")
With this patch dropped, then we really don't need
arch/arm/mach-bcm/brcmstb.c any more, AFAICT. Unless you have more plans
for this file, I can send a patch...
Brian
next prev parent reply other threads:[~2015-09-14 17:42 UTC|newest]
Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-19 0:11 [PATCH 0/7] soc: brcmstb: add system suspend support for STB SoCs Brian Norris
2015-06-19 0:11 ` Brian Norris
2015-06-19 0:11 ` Brian Norris
2015-06-19 0:11 ` [PATCH 1/7] Documentation: dt: brcmstb: add system PM bindings Brian Norris
2015-06-19 0:11 ` Brian Norris
2015-09-12 19:58 ` Florian Fainelli
2015-09-12 19:58 ` Florian Fainelli
2015-09-12 19:58 ` Florian Fainelli
2015-06-19 0:11 ` [PATCH 2/7] Documentation: dt: brcmstb: add waketimer documentation Brian Norris
2015-06-19 0:11 ` Brian Norris
2015-06-19 2:09 ` Gregory Fong
2015-06-19 2:09 ` Gregory Fong
2015-06-19 2:09 ` Gregory Fong
2015-09-12 19:58 ` Florian Fainelli
2015-09-12 19:58 ` Florian Fainelli
2015-06-19 0:11 ` [PATCH 3/7] soc: add stubs for brcmstb SoC's Brian Norris
2015-06-19 0:11 ` Brian Norris
2015-09-12 20:16 ` Florian Fainelli
2015-09-12 20:16 ` Florian Fainelli
2015-09-12 20:16 ` Florian Fainelli
2015-06-19 0:11 ` [PATCH 4/7] soc: brcmstb: add PM suspend/resume support (S2/S3/S5) Brian Norris
2015-06-19 0:11 ` Brian Norris
2015-09-12 20:23 ` Florian Fainelli
2015-09-12 20:23 ` Florian Fainelli
2015-09-12 20:23 ` Florian Fainelli
2015-06-19 0:11 ` [PATCH 5/7] soc: brcmstb: add wake-timer driver Brian Norris
2015-06-19 0:11 ` Brian Norris
2015-06-19 2:20 ` Gregory Fong
2015-06-19 2:20 ` Gregory Fong
2015-06-19 2:20 ` Gregory Fong
2015-06-19 17:36 ` Brian Norris
2015-06-19 17:36 ` Brian Norris
2015-06-19 17:36 ` Brian Norris
2015-09-12 20:00 ` Florian Fainelli
2015-09-12 20:00 ` Florian Fainelli
2015-09-12 20:00 ` Florian Fainelli
2015-06-19 0:11 ` [PATCH 6/7] ARM: brcmstb: mask GIC IRQs on suspend Brian Norris
2015-06-19 0:11 ` Brian Norris
2015-06-19 1:48 ` Gregory Fong
2015-06-19 1:48 ` Gregory Fong
2015-06-19 1:48 ` Gregory Fong
2015-09-12 19:53 ` Florian Fainelli
2015-09-12 19:53 ` Florian Fainelli
2015-09-12 19:53 ` Florian Fainelli
2015-09-14 17:29 ` Brian Norris
2015-09-14 17:29 ` Brian Norris
2015-09-14 17:29 ` Brian Norris
2015-09-14 17:42 ` Brian Norris [this message]
2015-09-14 17:42 ` Brian Norris
2015-09-14 17:42 ` Brian Norris
2015-09-14 17:43 ` Florian Fainelli
2015-09-14 17:43 ` Florian Fainelli
2015-09-14 17:43 ` Florian Fainelli
2015-06-19 0:11 ` [PATCH 7/7] ARM: dts: brcmstb: add BCM7445 system PM DT nodes Brian Norris
2015-06-19 0:11 ` Brian Norris
2015-09-12 19:58 ` Florian Fainelli
2015-09-12 19:58 ` Florian Fainelli
2015-09-12 19:58 ` Florian Fainelli
2015-06-19 3:20 ` [PATCH 0/7] soc: brcmstb: add system suspend support for STB SoCs Gregory Fong
2015-06-19 3:20 ` Gregory Fong
2015-06-19 3:20 ` Gregory Fong
2015-06-19 22:41 ` Brian Norris
2015-06-19 22:41 ` Brian Norris
2015-06-19 22:41 ` Brian Norris
2015-06-19 22:55 ` Brian Norris
2015-06-19 22:55 ` Brian Norris
2015-06-19 22:55 ` Brian Norris
2015-06-19 23:26 ` [PATCH 1/2] genirq: add chip_{suspend,resume} PM support to irq_chip Brian Norris
2015-06-19 23:26 ` Brian Norris
2015-06-19 23:26 ` Brian Norris
2015-06-19 23:26 ` [PATCH 2/2] IRQCHIP: bcm7120-l2: perform suspend/resume even without installed child IRQs Brian Norris
2015-06-19 23:26 ` Brian Norris
2015-06-19 23:26 ` Brian Norris
2015-06-19 23:39 ` Florian Fainelli
2015-06-19 23:39 ` Florian Fainelli
2015-06-19 23:38 ` [PATCH 1/2] genirq: add chip_{suspend,resume} PM support to irq_chip Florian Fainelli
2015-06-19 23:38 ` Florian Fainelli
2015-06-20 14:11 ` Thomas Gleixner
2015-06-20 14:11 ` Thomas Gleixner
2015-07-21 18:24 ` Florian Fainelli
2015-07-21 21:23 ` Thomas Gleixner
2015-07-21 21:26 ` Florian Fainelli
2015-07-21 21:26 ` Florian Fainelli
2015-07-21 21:58 ` Thomas Gleixner
2015-07-22 23:28 ` Brian Norris
2015-07-21 21:36 ` Brian Norris
2015-07-22 23:21 ` [PATCH v2 " Brian Norris
2015-07-22 23:21 ` [PATCH v2 2/2] IRQCHIP: bcm7120-l2: perform suspend/resume even without installed child IRQs Brian Norris
2015-07-27 6:15 ` [tip:irq/core] irqchip/bcm7120-l2: Perform suspend/ resume " tip-bot for Brian Norris
2015-07-27 6:14 ` [tip:irq/core] genirq: Add chip_[suspend|resume] PM support to irq_chip tip-bot for Brian Norris
2015-06-22 19:47 ` [PATCH 0/7] soc: brcmstb: add system suspend support for STB SoCs Brian Norris
2015-06-22 19:47 ` Brian Norris
2015-06-22 19:47 ` Brian Norris
2015-06-24 4:47 ` Florian Fainelli
2015-06-24 4:47 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150914174209.GQ11487@google.com \
--to=computersforpeace@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=galak@codeaurora.org \
--cc=gregory.0xf0@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.