All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
To: oleg@redhat.com, mhocko@kernel.org
Cc: torvalds@linux-foundation.org, kwalker@redhat.com, cl@linux.com,
	akpm@linux-foundation.org, rientjes@google.com,
	hannes@cmpxchg.org, vdavydov@parallels.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, skozina@redhat.com
Subject: Re: can't oom-kill zap the victim's memory?
Date: Tue, 22 Sep 2015 01:51:39 +0900	[thread overview]
Message-ID: <201509220151.CHF17629.LFFJSHQVOMtOFO@I-love.SAKURA.ne.jp> (raw)
In-Reply-To: <20150921153252.GA21988@redhat.com>

Oleg Nesterov wrote:
> Yes, yes, and I already tried to comment this part. We probably need a
> dedicated kernel thread, but I still think (although I am not sure) that
> initial change can use workueue. In the likely case system_unbound_wq pool
> should have an idle thread, if not - OK, this change won't help in this
> case. This is minor.
> 
I imagined a dedicated kernel thread doing something like shown below.
(I don't know about mm->mmap management.)
mm->mmap_zapped corresponds to MMF_MEMDIE.
I think this kernel thread can be used for normal kill(pid, SIGKILL) cases.

----------
bool has_sigkill_task;
wait_queue_head_t kick_mm_zapper;

static void mm_zapper(void *unused)
{
	struct task_struct *g, *p;
	struct mm_struct *mm;

sleep:
	wait_event(kick_remover, has_sigkill_task);
	has_sigkill_task = false;
restart:
	rcu_read_lock();
	for_each_process_thread(g, p) {
		if (likely(!fatal_signal_pending(p)))
			continue;
		task_lock(p);
		mm = p->mm;
		if (mm && mm->mmap && !mm->mmap_zapped && down_read_trylock(&mm->mmap_sem)) {
			atomic_inc(&mm->mm_users);
			task_unlock(p);
			rcu_read_unlock();
			if (mm->mmap && !mm->mmap_zapped)
				zap_page_range(mm->mmap, 0, TASK_SIZE, NULL);
			mm->mmap_zapped = 1;
			up_read(&mm->mmap_sem);
			mmput(mm);
			cond_resched();
			goto restart;
		}
		task_unlock(p);
	}
	rcu_read_unlock();
	goto sleep;
}

kthread_run(mm_zapper, NULL, "mm_zapper");
----------

WARNING: multiple messages have this Message-ID (diff)
From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
To: oleg@redhat.com, mhocko@kernel.org
Cc: torvalds@linux-foundation.org, kwalker@redhat.com, cl@linux.com,
	akpm@linux-foundation.org, rientjes@google.com,
	hannes@cmpxchg.org, vdavydov@parallels.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, skozina@redhat.com
Subject: Re: can't oom-kill zap the victim's memory?
Date: Tue, 22 Sep 2015 01:51:39 +0900	[thread overview]
Message-ID: <201509220151.CHF17629.LFFJSHQVOMtOFO@I-love.SAKURA.ne.jp> (raw)
In-Reply-To: <20150921153252.GA21988@redhat.com>

Oleg Nesterov wrote:
> Yes, yes, and I already tried to comment this part. We probably need a
> dedicated kernel thread, but I still think (although I am not sure) that
> initial change can use workueue. In the likely case system_unbound_wq pool
> should have an idle thread, if not - OK, this change won't help in this
> case. This is minor.
> 
I imagined a dedicated kernel thread doing something like shown below.
(I don't know about mm->mmap management.)
mm->mmap_zapped corresponds to MMF_MEMDIE.
I think this kernel thread can be used for normal kill(pid, SIGKILL) cases.

----------
bool has_sigkill_task;
wait_queue_head_t kick_mm_zapper;

static void mm_zapper(void *unused)
{
	struct task_struct *g, *p;
	struct mm_struct *mm;

sleep:
	wait_event(kick_remover, has_sigkill_task);
	has_sigkill_task = false;
restart:
	rcu_read_lock();
	for_each_process_thread(g, p) {
		if (likely(!fatal_signal_pending(p)))
			continue;
		task_lock(p);
		mm = p->mm;
		if (mm && mm->mmap && !mm->mmap_zapped && down_read_trylock(&mm->mmap_sem)) {
			atomic_inc(&mm->mm_users);
			task_unlock(p);
			rcu_read_unlock();
			if (mm->mmap && !mm->mmap_zapped)
				zap_page_range(mm->mmap, 0, TASK_SIZE, NULL);
			mm->mmap_zapped = 1;
			up_read(&mm->mmap_sem);
			mmput(mm);
			cond_resched();
			goto restart;
		}
		task_unlock(p);
	}
	rcu_read_unlock();
	goto sleep;
}

kthread_run(mm_zapper, NULL, "mm_zapper");
----------

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2015-09-21 16:51 UTC|newest]

Thread overview: 213+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-17 17:59 [PATCH] mm/oom_kill.c: don't kill TASK_UNINTERRUPTIBLE tasks Kyle Walker
2015-09-17 17:59 ` Kyle Walker
2015-09-17 19:22 ` Oleg Nesterov
2015-09-17 19:22   ` Oleg Nesterov
2015-09-18 15:41   ` Christoph Lameter
2015-09-18 15:41     ` Christoph Lameter
2015-09-18 16:24     ` Oleg Nesterov
2015-09-18 16:24       ` Oleg Nesterov
2015-09-18 16:39       ` Tetsuo Handa
2015-09-18 16:39         ` Tetsuo Handa
2015-09-18 16:54         ` Oleg Nesterov
2015-09-18 16:54           ` Oleg Nesterov
2015-09-18 17:00       ` Christoph Lameter
2015-09-18 17:00         ` Christoph Lameter
2015-09-18 19:07         ` Oleg Nesterov
2015-09-18 19:07           ` Oleg Nesterov
2015-09-18 19:19           ` Christoph Lameter
2015-09-18 19:19             ` Christoph Lameter
2015-09-18 21:28             ` Kyle Walker
2015-09-18 22:07               ` Christoph Lameter
2015-09-18 22:07                 ` Christoph Lameter
2015-09-19  8:32         ` Michal Hocko
2015-09-19  8:32           ` Michal Hocko
2015-09-19 14:33           ` Tetsuo Handa
2015-09-19 14:33             ` Tetsuo Handa
2015-09-19 15:51             ` Michal Hocko
2015-09-19 15:51               ` Michal Hocko
2015-09-21 23:33             ` David Rientjes
2015-09-21 23:33               ` David Rientjes
2015-09-22  5:33               ` Tetsuo Handa
2015-09-22  5:33                 ` Tetsuo Handa
2015-09-22 23:32                 ` David Rientjes
2015-09-22 23:32                   ` David Rientjes
2015-09-23 12:03                   ` Kyle Walker
2015-09-23 12:03                     ` Kyle Walker
2015-09-24 11:50                     ` Tetsuo Handa
2015-09-24 11:50                       ` Tetsuo Handa
2015-09-19 14:44           ` Oleg Nesterov
2015-09-19 14:44             ` Oleg Nesterov
2015-09-21 23:27         ` David Rientjes
2015-09-21 23:27           ` David Rientjes
2015-09-19  8:25     ` Michal Hocko
2015-09-19  8:25       ` Michal Hocko
2015-09-19  8:22 ` Michal Hocko
2015-09-19  8:22   ` Michal Hocko
2015-09-21 23:08   ` David Rientjes
2015-09-21 23:08     ` David Rientjes
2015-09-19 15:03 ` can't oom-kill zap the victim's memory? Oleg Nesterov
2015-09-19 15:03   ` Oleg Nesterov
2015-09-19 15:10   ` Oleg Nesterov
2015-09-19 15:10     ` Oleg Nesterov
2015-09-19 15:58   ` Michal Hocko
2015-09-19 15:58     ` Michal Hocko
2015-09-20 13:16     ` Oleg Nesterov
2015-09-20 13:16       ` Oleg Nesterov
2015-09-19 22:24   ` Linus Torvalds
2015-09-19 22:24     ` Linus Torvalds
2015-09-19 22:54     ` Raymond Jennings
2015-09-19 23:00     ` Raymond Jennings
2015-09-19 23:00       ` Raymond Jennings
2015-09-19 23:13       ` Linus Torvalds
2015-09-19 23:13         ` Linus Torvalds
2015-09-20  9:33     ` Michal Hocko
2015-09-20  9:33       ` Michal Hocko
2015-09-20 13:06       ` Oleg Nesterov
2015-09-20 13:06         ` Oleg Nesterov
2015-09-20 12:56     ` Oleg Nesterov
2015-09-20 12:56       ` Oleg Nesterov
2015-09-20 18:05       ` Linus Torvalds
2015-09-20 18:05         ` Linus Torvalds
2015-09-20 18:21         ` Raymond Jennings
2015-09-20 18:23         ` Raymond Jennings
2015-09-20 19:07         ` Raymond Jennings
2015-09-20 19:07           ` Raymond Jennings
2015-09-21 13:57           ` Oleg Nesterov
2015-09-21 13:57             ` Oleg Nesterov
2015-09-21 13:44         ` Oleg Nesterov
2015-09-21 13:44           ` Oleg Nesterov
2015-09-21 14:24           ` Michal Hocko
2015-09-21 14:24             ` Michal Hocko
2015-09-21 15:32             ` Oleg Nesterov
2015-09-21 15:32               ` Oleg Nesterov
2015-09-21 16:12               ` Michal Hocko
2015-09-21 16:12                 ` Michal Hocko
2015-09-22 16:06                 ` Oleg Nesterov
2015-09-22 16:06                   ` Oleg Nesterov
2015-09-22 23:04                   ` David Rientjes
2015-09-22 23:04                     ` David Rientjes
2015-09-23 20:59                   ` Michal Hocko
2015-09-23 20:59                     ` Michal Hocko
2015-09-24 21:15                     ` David Rientjes
2015-09-24 21:15                       ` David Rientjes
2015-09-25  9:35                       ` Michal Hocko
2015-09-25  9:35                         ` Michal Hocko
2015-09-25 16:14                         ` Tetsuo Handa
2015-09-25 16:14                           ` Tetsuo Handa
2015-09-28 16:18                           ` Tetsuo Handa
2015-09-28 16:18                             ` Tetsuo Handa
2015-09-28 22:28                             ` David Rientjes
2015-09-28 22:28                               ` David Rientjes
2015-10-02 12:36                             ` Michal Hocko
2015-10-02 12:36                               ` Michal Hocko
2015-10-02 19:01                               ` Linus Torvalds
2015-10-02 19:01                                 ` Linus Torvalds
2015-10-05 14:44                                 ` Michal Hocko
2015-10-05 14:44                                   ` Michal Hocko
2015-10-07  5:16                                   ` Vlastimil Babka
2015-10-07  5:16                                     ` Vlastimil Babka
2015-10-07 10:43                                     ` Tetsuo Handa
2015-10-07 10:43                                       ` Tetsuo Handa
2015-10-08  9:40                                       ` Vlastimil Babka
2015-10-08  9:40                                         ` Vlastimil Babka
2015-10-06  7:55                                 ` Eric W. Biederman
2015-10-06  7:55                                   ` Eric W. Biederman
2015-10-06  8:49                                   ` Linus Torvalds
2015-10-06  8:49                                     ` Linus Torvalds
2015-10-06  8:55                                     ` Linus Torvalds
2015-10-06  8:55                                       ` Linus Torvalds
2015-10-06 14:52                                       ` Eric W. Biederman
2015-10-06 14:52                                         ` Eric W. Biederman
2015-10-03  6:02                               ` Can't we use timeout based OOM warning/killing? Tetsuo Handa
2015-10-03  6:02                                 ` Tetsuo Handa
2015-10-06 14:51                                 ` Tetsuo Handa
2015-10-06 14:51                                   ` Tetsuo Handa
2015-10-12  6:43                                   ` Tetsuo Handa
2015-10-12  6:43                                     ` Tetsuo Handa
2015-10-12 15:25                                     ` Silent hang up caused by pages being not scanned? Tetsuo Handa
2015-10-12 15:25                                       ` Tetsuo Handa
2015-10-12 21:23                                       ` Linus Torvalds
2015-10-12 21:23                                         ` Linus Torvalds
2015-10-13 12:21                                         ` Tetsuo Handa
2015-10-13 12:21                                           ` Tetsuo Handa
2015-10-13 16:37                                           ` Linus Torvalds
2015-10-13 16:37                                             ` Linus Torvalds
2015-10-14 12:21                                             ` Tetsuo Handa
2015-10-14 12:21                                               ` Tetsuo Handa
2015-10-15 13:14                                             ` Michal Hocko
2015-10-15 13:14                                               ` Michal Hocko
2015-10-16 15:57                                               ` Michal Hocko
2015-10-16 15:57                                                 ` Michal Hocko
2015-10-16 18:34                                                 ` Linus Torvalds
2015-10-16 18:34                                                   ` Linus Torvalds
2015-10-16 18:49                                                   ` Tetsuo Handa
2015-10-16 18:49                                                     ` Tetsuo Handa
2015-10-19 12:57                                                     ` Michal Hocko
2015-10-19 12:57                                                       ` Michal Hocko
2015-10-19 12:53                                                   ` Michal Hocko
2015-10-19 12:53                                                     ` Michal Hocko
2015-10-13 13:32                                       ` Michal Hocko
2015-10-13 13:32                                         ` Michal Hocko
2015-10-13 16:19                                         ` Tetsuo Handa
2015-10-13 16:19                                           ` Tetsuo Handa
2015-10-14 13:22                                           ` Michal Hocko
2015-10-14 13:22                                             ` Michal Hocko
2015-10-14 14:38                                             ` Tetsuo Handa
2015-10-14 14:38                                               ` Tetsuo Handa
2015-10-14 14:59                                               ` Michal Hocko
2015-10-14 14:59                                                 ` Michal Hocko
2015-10-14 15:06                                                 ` Tetsuo Handa
2015-10-14 15:06                                                   ` Tetsuo Handa
2015-10-26 11:44                                     ` Newbie's question: memory allocation when reclaiming memory Tetsuo Handa
2015-10-26 11:44                                       ` Tetsuo Handa
2015-11-05  8:46                                       ` Vlastimil Babka
2015-11-05  8:46                                         ` Vlastimil Babka
2015-10-06 15:25                                 ` Can't we use timeout based OOM warning/killing? Linus Torvalds
2015-10-08 15:33                                   ` Tetsuo Handa
2015-10-08 15:33                                     ` Tetsuo Handa
2015-10-10 12:50                                 ` Tetsuo Handa
2015-10-10 12:50                                   ` Tetsuo Handa
2015-09-28 22:24                         ` can't oom-kill zap the victim's memory? David Rientjes
2015-09-28 22:24                           ` David Rientjes
2015-09-29  7:57                           ` Tetsuo Handa
2015-09-29  7:57                             ` Tetsuo Handa
2015-09-29 22:56                             ` David Rientjes
2015-09-29 22:56                               ` David Rientjes
2015-09-30  4:25                               ` Tetsuo Handa
2015-09-30  4:25                                 ` Tetsuo Handa
2015-09-30 10:21                                 ` Tetsuo Handa
2015-09-30 10:21                                   ` Tetsuo Handa
2015-09-30 21:11                                 ` David Rientjes
2015-09-30 21:11                                   ` David Rientjes
2015-10-01 12:13                                   ` Tetsuo Handa
2015-10-01 12:13                                     ` Tetsuo Handa
2015-10-01 14:48                           ` Michal Hocko
2015-10-01 14:48                             ` Michal Hocko
2015-10-02 13:06                             ` Tetsuo Handa
2015-10-02 13:06                               ` Tetsuo Handa
2015-10-06 18:45                     ` Oleg Nesterov
2015-10-06 18:45                       ` Oleg Nesterov
2015-10-07 11:03                       ` Tetsuo Handa
2015-10-07 11:03                         ` Tetsuo Handa
2015-10-07 12:00                         ` Oleg Nesterov
2015-10-07 12:00                           ` Oleg Nesterov
2015-10-08 14:04                           ` Michal Hocko
2015-10-08 14:04                             ` Michal Hocko
2015-10-08 14:01                       ` Michal Hocko
2015-10-08 14:01                         ` Michal Hocko
2015-09-21 16:51               ` Tetsuo Handa [this message]
2015-09-21 16:51                 ` Tetsuo Handa
2015-09-22 12:43                 ` Oleg Nesterov
2015-09-22 12:43                   ` Oleg Nesterov
2015-09-22 14:30                   ` Tetsuo Handa
2015-09-22 14:30                     ` Tetsuo Handa
2015-09-22 14:45                     ` Oleg Nesterov
2015-09-22 14:45                       ` Oleg Nesterov
2015-09-21 23:42               ` David Rientjes
2015-09-21 23:42                 ` David Rientjes
2015-09-21 16:55           ` Linus Torvalds
2015-09-21 16:55             ` Linus Torvalds
2015-09-20 14:50   ` Tetsuo Handa
2015-09-20 14:50     ` Tetsuo Handa
2015-09-20 14:55     ` Oleg Nesterov
2015-09-20 14:55       ` Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201509220151.CHF17629.LFFJSHQVOMtOFO@I-love.SAKURA.ne.jp \
    --to=penguin-kernel@i-love.sakura.ne.jp \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=hannes@cmpxchg.org \
    --cc=kwalker@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=oleg@redhat.com \
    --cc=rientjes@google.com \
    --cc=skozina@redhat.com \
    --cc=torvalds@linux-foundation.org \
    --cc=vdavydov@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.