* [patch] drm/layerscape: fix a signedness bug
@ 2015-09-22 12:31 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2015-09-22 12:31 UTC (permalink / raw)
To: Jianwei Wang; +Cc: kernel-janitors, dri-devel, Alison Wang
"index" needs to be signed for the error handling to work. Really "ret"
should be an int as well.
Fixes: 109eee2f2a18 ('drm/layerscape: Add Freescale DCU DRM driver')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c
index 82be6b8..d1e300d 100644
--- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c
+++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c
@@ -58,7 +58,8 @@ static void fsl_dcu_drm_plane_atomic_disable(struct drm_plane *plane,
struct drm_plane_state *old_state)
{
struct fsl_dcu_drm_device *fsl_dev = plane->dev->dev_private;
- unsigned int index, value, ret;
+ unsigned int value;
+ int index, ret;
index = fsl_dcu_drm_plane_index(plane);
if (index < 0)
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [patch] drm/layerscape: fix a signedness bug
@ 2015-09-22 12:31 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2015-09-22 12:31 UTC (permalink / raw)
To: Jianwei Wang; +Cc: kernel-janitors, dri-devel, Alison Wang
"index" needs to be signed for the error handling to work. Really "ret"
should be an int as well.
Fixes: 109eee2f2a18 ('drm/layerscape: Add Freescale DCU DRM driver')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c
index 82be6b8..d1e300d 100644
--- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c
+++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c
@@ -58,7 +58,8 @@ static void fsl_dcu_drm_plane_atomic_disable(struct drm_plane *plane,
struct drm_plane_state *old_state)
{
struct fsl_dcu_drm_device *fsl_dev = plane->dev->dev_private;
- unsigned int index, value, ret;
+ unsigned int value;
+ int index, ret;
index = fsl_dcu_drm_plane_index(plane);
if (index < 0)
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [patch] drm/layerscape: fix a signedness bug
2015-09-22 12:31 ` Dan Carpenter
@ 2015-09-22 12:55 ` Andrzej Hajda
-1 siblings, 0 replies; 6+ messages in thread
From: Andrzej Hajda @ 2015-09-22 12:55 UTC (permalink / raw)
To: Dan Carpenter, Jianwei Wang; +Cc: kernel-janitors, dri-devel, Alison Wang
Hi,
I have posted the same patch yesterday [1].
http://permalink.gmane.org/gmane.comp.video.dri.devel/136945
Regards
Andrzej
On 09/22/2015 02:31 PM, Dan Carpenter wrote:
> "index" needs to be signed for the error handling to work. Really "ret"
> should be an int as well.
>
> Fixes: 109eee2f2a18 ('drm/layerscape: Add Freescale DCU DRM driver')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c
> index 82be6b8..d1e300d 100644
> --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c
> +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c
> @@ -58,7 +58,8 @@ static void fsl_dcu_drm_plane_atomic_disable(struct drm_plane *plane,
> struct drm_plane_state *old_state)
> {
> struct fsl_dcu_drm_device *fsl_dev = plane->dev->dev_private;
> - unsigned int index, value, ret;
> + unsigned int value;
> + int index, ret;
>
> index = fsl_dcu_drm_plane_index(plane);
> if (index < 0)
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] drm/layerscape: fix a signedness bug
@ 2015-09-22 12:55 ` Andrzej Hajda
0 siblings, 0 replies; 6+ messages in thread
From: Andrzej Hajda @ 2015-09-22 12:55 UTC (permalink / raw)
To: Dan Carpenter, Jianwei Wang; +Cc: kernel-janitors, dri-devel, Alison Wang
Hi,
I have posted the same patch yesterday [1].
http://permalink.gmane.org/gmane.comp.video.dri.devel/136945
Regards
Andrzej
On 09/22/2015 02:31 PM, Dan Carpenter wrote:
> "index" needs to be signed for the error handling to work. Really "ret"
> should be an int as well.
>
> Fixes: 109eee2f2a18 ('drm/layerscape: Add Freescale DCU DRM driver')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c
> index 82be6b8..d1e300d 100644
> --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c
> +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c
> @@ -58,7 +58,8 @@ static void fsl_dcu_drm_plane_atomic_disable(struct drm_plane *plane,
> struct drm_plane_state *old_state)
> {
> struct fsl_dcu_drm_device *fsl_dev = plane->dev->dev_private;
> - unsigned int index, value, ret;
> + unsigned int value;
> + int index, ret;
>
> index = fsl_dcu_drm_plane_index(plane);
> if (index < 0)
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] drm/layerscape: fix a signedness bug
2015-09-22 12:55 ` Andrzej Hajda
@ 2015-09-28 21:38 ` Dan Carpenter
-1 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2015-09-28 21:38 UTC (permalink / raw)
To: Andrzej Hajda; +Cc: kernel-janitors, dri-devel, Alison Wang
On Tue, Sep 22, 2015 at 02:55:09PM +0200, Andrzej Hajda wrote:
> Hi,
>
> I have posted the same patch yesterday [1].
>
> http://permalink.gmane.org/gmane.comp.video.dri.devel/136945
>
We seem to be sending duplicates. I sent another duplicate today.
Could you CC kernel-janitors on static checker fixes so I can monitor
what fixes you send?
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] drm/layerscape: fix a signedness bug
@ 2015-09-28 21:38 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2015-09-28 21:38 UTC (permalink / raw)
To: Andrzej Hajda; +Cc: kernel-janitors, dri-devel, Alison Wang
On Tue, Sep 22, 2015 at 02:55:09PM +0200, Andrzej Hajda wrote:
> Hi,
>
> I have posted the same patch yesterday [1].
>
> http://permalink.gmane.org/gmane.comp.video.dri.devel/136945
>
We seem to be sending duplicates. I sent another duplicate today.
Could you CC kernel-janitors on static checker fixes so I can monitor
what fixes you send?
regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-09-28 21:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-22 12:31 [patch] drm/layerscape: fix a signedness bug Dan Carpenter
2015-09-22 12:31 ` Dan Carpenter
2015-09-22 12:55 ` Andrzej Hajda
2015-09-22 12:55 ` Andrzej Hajda
2015-09-28 21:38 ` Dan Carpenter
2015-09-28 21:38 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.