From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
Thierry Reding <thierry.reding@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Jingoo Han <jg1.han@samsung.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
linux-pwm@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH v2] backlight: pwm: reject legacy pwm request for device defined in dt
Date: Mon, 12 Oct 2015 17:19:31 +0200 [thread overview]
Message-ID: <20151012171931.3fb922d2@bbrezillon> (raw)
In-Reply-To: <561BC177.2050000@mentor.com>
On Mon, 12 Oct 2015 17:19:35 +0300
Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> wrote:
>
> > Thierry's patch makes sure that EPROBE_DEFER is not returned when the
> > PWM device definition is not found using in the PWM lookup tables or
> > the DT definition,
>
> This is okay, but I'm interested in proper handling of cases other than
> EPROBE_DEFER. EPROBE_DEFER and the related issues are on your balance
> and I'm attempting to avoid interfering with it here :)
I keep thinking we should fix all platforms using the ->pwm_id pdata
field to attach a PWM device to a PWM backlight instead of trying to
guess when falling back to the legacy API is acceptable...
>
> > and in this case the pwm_bl code will fallback to
> > the legacy PWM API, which AFAICT is what you're trying to solve.
>
> Fallback must happen exclusively under (IS_ERR(pb->pwm) &&
> PTR_ERR(pb->pwm) != -EPROBE_DEFER && !pdev->dev.of_node) condition IMHO.
>
> Before EPROBE_DEFER appeared on the scene the condition was
> (IS_ERR(pb->pwm) && !pdev->dev.of_node).
>
> So, the question is if my change requires any updates or not from your
> point of view.
... but from a functional point of view your patch seems correct.
Best Regards,
Boris
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
Thierry Reding <thierry.reding@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Jingoo Han <jg1.han@samsung.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
linux-pwm@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH v2] backlight: pwm: reject legacy pwm request for device defined in dt
Date: Mon, 12 Oct 2015 15:19:31 +0000 [thread overview]
Message-ID: <20151012171931.3fb922d2@bbrezillon> (raw)
In-Reply-To: <561BC177.2050000@mentor.com>
On Mon, 12 Oct 2015 17:19:35 +0300
Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> wrote:
>
> > Thierry's patch makes sure that EPROBE_DEFER is not returned when the
> > PWM device definition is not found using in the PWM lookup tables or
> > the DT definition,
>
> This is okay, but I'm interested in proper handling of cases other than
> EPROBE_DEFER. EPROBE_DEFER and the related issues are on your balance
> and I'm attempting to avoid interfering with it here :)
I keep thinking we should fix all platforms using the ->pwm_id pdata
field to attach a PWM device to a PWM backlight instead of trying to
guess when falling back to the legacy API is acceptable...
>
> > and in this case the pwm_bl code will fallback to
> > the legacy PWM API, which AFAICT is what you're trying to solve.
>
> Fallback must happen exclusively under (IS_ERR(pb->pwm) &&
> PTR_ERR(pb->pwm) != -EPROBE_DEFER && !pdev->dev.of_node) condition IMHO.
>
> Before EPROBE_DEFER appeared on the scene the condition was
> (IS_ERR(pb->pwm) && !pdev->dev.of_node).
>
> So, the question is if my change requires any updates or not from your
> point of view.
... but from a functional point of view your patch seems correct.
Best Regards,
Boris
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-10-12 15:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 12:29 [PATCH v2] backlight: pwm: reject legacy pwm request for device defined in dt Vladimir Zapolskiy
2015-10-12 12:29 ` Vladimir Zapolskiy
2015-10-12 13:16 ` Nicolas Ferre
2015-10-12 13:16 ` Nicolas Ferre
2015-10-12 13:30 ` Boris Brezillon
2015-10-12 13:30 ` Boris Brezillon
2015-10-12 13:54 ` Vladimir Zapolskiy
2015-10-12 13:54 ` Vladimir Zapolskiy
2015-10-12 14:06 ` Boris Brezillon
2015-10-12 14:06 ` Boris Brezillon
2015-10-12 14:19 ` Vladimir Zapolskiy
2015-10-12 14:19 ` Vladimir Zapolskiy
2015-10-12 15:19 ` Boris Brezillon [this message]
2015-10-12 15:19 ` Boris Brezillon
2015-10-12 15:32 ` Vladimir Zapolskiy
2015-10-12 15:32 ` Vladimir Zapolskiy
2015-10-12 17:11 ` Robert Jarzmik
2015-10-12 17:11 ` Robert Jarzmik
2015-10-13 7:29 ` Lee Jones
2015-10-13 7:29 ` Lee Jones
2015-10-15 10:45 ` Vladimir Zapolskiy
2015-10-15 10:45 ` Vladimir Zapolskiy
2015-10-13 9:21 ` Robert Jarzmik
2015-10-13 9:21 ` Robert Jarzmik
2015-10-15 11:03 ` Lee Jones
2015-10-15 11:03 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151012171931.3fb922d2@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=jg1.han@samsung.com \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=robert.jarzmik@free.fr \
--cc=thierry.reding@gmail.com \
--cc=vladimir_zapolskiy@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.