From: Guenter Roeck <linux@roeck-us.net>
To: Marc Titinger <mtitinger@baylibre.com>
Cc: jdelvare@suse.com, lm-sensors@lm-sensors.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] hwmon: ina2xx: convert driver to using regmap
Date: Mon, 26 Oct 2015 18:12:29 -0700 [thread overview]
Message-ID: <20151027011229.GC31838@roeck-us.net> (raw)
In-Reply-To: <1445876673-32180-2-git-send-email-mtitinger@baylibre.com>
On Mon, Oct 26, 2015 at 05:24:32PM +0100, Marc Titinger wrote:
> Any sysfs "show" read access from the client app will result in reading
> all registers (8 with ina226). Depending on the host this can limit the
> best achievable read rate.
>
> This changeset allows for individual register accesses through regmap.
>
> Tested with BeagleBone Black (Baylibre-ACME) and ina226.
>
> Signed-off-by: Marc Titinger <mtitinger@baylibre.com>
Another comment: In ina2xx_calibrate, also use regmap_write().
Then you can drop the client variable in ina2xx_data.
Thanks,
Guenter
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Marc Titinger <mtitinger@baylibre.com>
Cc: jdelvare@suse.com, lm-sensors@lm-sensors.org,
linux-kernel@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 1/2] hwmon: ina2xx: convert driver to using regmap
Date: Tue, 27 Oct 2015 01:12:29 +0000 [thread overview]
Message-ID: <20151027011229.GC31838@roeck-us.net> (raw)
In-Reply-To: <1445876673-32180-2-git-send-email-mtitinger@baylibre.com>
On Mon, Oct 26, 2015 at 05:24:32PM +0100, Marc Titinger wrote:
> Any sysfs "show" read access from the client app will result in reading
> all registers (8 with ina226). Depending on the host this can limit the
> best achievable read rate.
>
> This changeset allows for individual register accesses through regmap.
>
> Tested with BeagleBone Black (Baylibre-ACME) and ina226.
>
> Signed-off-by: Marc Titinger <mtitinger@baylibre.com>
Another comment: In ina2xx_calibrate, also use regmap_write().
Then you can drop the client variable in ina2xx_data.
Thanks,
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2015-10-27 1:12 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 16:21 [RFC] hwmon: ina2xx: allow for actual measurement bandwidth above 160 Hz Marc Titinger
2015-10-19 16:21 ` [lm-sensors] " Marc Titinger
2015-10-20 1:32 ` Guenter Roeck
2015-10-20 1:32 ` [lm-sensors] " Guenter Roeck
2015-10-20 7:58 ` Marc Titinger
2015-10-20 7:58 ` [lm-sensors] " Marc Titinger
2015-10-20 8:20 ` [PATCH v2] " Marc Titinger
2015-10-20 8:20 ` [lm-sensors] " Marc Titinger
2015-10-20 12:54 ` Guenter Roeck
2015-10-20 12:54 ` [lm-sensors] " Guenter Roeck
2015-10-20 13:17 ` Marc Titinger
2015-10-20 13:17 ` [lm-sensors] " Marc Titinger
2015-10-20 13:30 ` Guenter Roeck
2015-10-20 13:30 ` [lm-sensors] " Guenter Roeck
2015-10-20 13:46 ` Marc Titinger
2015-10-20 13:46 ` [lm-sensors] " Marc Titinger
2015-10-20 17:00 ` Guenter Roeck
2015-10-20 17:00 ` [lm-sensors] " Guenter Roeck
2015-10-21 7:46 ` Marc Titinger
2015-10-21 7:46 ` [lm-sensors] " Marc Titinger
2015-10-20 13:52 ` Michael Turquette
2015-10-20 13:52 ` [lm-sensors] " Michael Turquette
2015-10-23 16:13 ` [RFC] hwmon: ina2xx: port to using remap, improve bandwidth Marc Titinger
2015-10-23 16:13 ` [lm-sensors] " Marc Titinger
2015-10-23 16:49 ` kbuild test robot
2015-10-23 16:49 ` [lm-sensors] " kbuild test robot
2015-10-23 16:52 ` Guenter Roeck
2015-10-23 16:52 ` [lm-sensors] " Guenter Roeck
2015-10-23 20:35 ` Marc Titinger
2015-10-23 20:35 ` [lm-sensors] " Marc Titinger
2015-10-24 2:21 ` Guenter Roeck
2015-10-24 2:21 ` [lm-sensors] " Guenter Roeck
2015-10-24 12:45 ` Guenter Roeck
2015-10-24 12:45 ` [lm-sensors] " Guenter Roeck
2015-10-26 16:24 ` [PATCH 0/2] hwmon: ina2xx: convert driver to using regmap Marc Titinger
2015-10-26 16:24 ` [lm-sensors] " Marc Titinger
2015-10-26 16:24 ` [PATCH 1/2] " Marc Titinger
2015-10-26 16:24 ` [lm-sensors] " Marc Titinger
2015-10-27 1:02 ` Guenter Roeck
2015-10-27 1:02 ` [lm-sensors] " Guenter Roeck
2015-10-27 1:12 ` Guenter Roeck [this message]
2015-10-27 1:12 ` Guenter Roeck
2015-10-27 9:51 ` [PATCH v2 " Marc Titinger
2015-10-27 9:51 ` [lm-sensors] " Marc Titinger
2015-10-28 2:47 ` Guenter Roeck
2015-10-28 2:47 ` [lm-sensors] " Guenter Roeck
2015-10-28 9:23 ` Marc Titinger
2015-10-28 9:23 ` [lm-sensors] " Marc Titinger
2015-10-26 16:24 ` [PATCH 2/2] hwmon: ina2xx: give precedence to DT over checking for platform data Marc Titinger
2015-10-26 16:24 ` [lm-sensors] " Marc Titinger
2015-10-27 1:10 ` Guenter Roeck
2015-10-27 1:10 ` [lm-sensors] " Guenter Roeck
2015-10-27 9:51 ` [PATCH v2 " Marc Titinger
2015-10-27 9:51 ` [lm-sensors] " Marc Titinger
2015-10-23 16:55 ` [RFC] hwmon: ina2xx: port to using remap, improve bandwidth kbuild test robot
2015-10-23 16:55 ` [lm-sensors] " kbuild test robot
2015-10-23 20:10 ` kbuild test robot
2015-10-23 20:10 ` [lm-sensors] " kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151027011229.GC31838@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jdelvare@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=mtitinger@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.