All of lore.kernel.org
 help / color / mirror / Atom feed
From: Will Deacon <will.deacon@arm.com>
To: AKASHI Takahiro <takahiro.akashi@linaro.org>
Cc: catalin.marinas@arm.com, rostedt@goodmis.org,
	jungseoklee85@gmail.com, olof@lixom.net, broonie@kernel.org,
	david.griego@linaro.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/7] arm64: ftrace: fix incorrect output from stack tracer
Date: Wed, 28 Oct 2015 15:23:45 +0000	[thread overview]
Message-ID: <20151028152344.GG18966@arm.com> (raw)
In-Reply-To: <1444298504-10392-1-git-send-email-takahiro.akashi@linaro.org>

On Thu, Oct 08, 2015 at 07:01:37PM +0900, AKASHI Takahiro wrote:
> This is the third patch series for fixing stack tracer on arm64.
> The original issue was reported by Jungseok[1], and then I found more
> issues[2].
> (Steven, Jungseok, sorry for not replying to your comments directly.)
> 
> I address here all the issues and implement fixes described in [2] except
> for interrupt-triggered problems, ie. II-3). Recent discussions[3] about
> introducing a dedicated interrupt stack suggests that we may avoid walking
> through from an interrupt stack to a process stack.
> (So interrupt-stack patch is a prerequisite.)
> 
> Basically,
> patch1 corresponds to the original issue.
> patch2 is a proactive improvement of function_graph tracer. 
> patch3 corresponds to II-4(functions under function_graph tracer).
> patch4 corresponds to II-5(leaf function).
> patch5, 6 and 7 correspond to II-1(slurping stack) and II-2(differences
> between x86 and arm64).
> 
> Each fix can be applied independently, but if patch5, 6 and 7 are
> acceptable, patch1 is not necessary because patch7 replaces a default
> stack tracer.

Given the comments and kbuild robot build errors, do you plan to post a
new version of this series?

Will

WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 0/7] arm64: ftrace: fix incorrect output from stack tracer
Date: Wed, 28 Oct 2015 15:23:45 +0000	[thread overview]
Message-ID: <20151028152344.GG18966@arm.com> (raw)
In-Reply-To: <1444298504-10392-1-git-send-email-takahiro.akashi@linaro.org>

On Thu, Oct 08, 2015 at 07:01:37PM +0900, AKASHI Takahiro wrote:
> This is the third patch series for fixing stack tracer on arm64.
> The original issue was reported by Jungseok[1], and then I found more
> issues[2].
> (Steven, Jungseok, sorry for not replying to your comments directly.)
> 
> I address here all the issues and implement fixes described in [2] except
> for interrupt-triggered problems, ie. II-3). Recent discussions[3] about
> introducing a dedicated interrupt stack suggests that we may avoid walking
> through from an interrupt stack to a process stack.
> (So interrupt-stack patch is a prerequisite.)
> 
> Basically,
> patch1 corresponds to the original issue.
> patch2 is a proactive improvement of function_graph tracer. 
> patch3 corresponds to II-4(functions under function_graph tracer).
> patch4 corresponds to II-5(leaf function).
> patch5, 6 and 7 correspond to II-1(slurping stack) and II-2(differences
> between x86 and arm64).
> 
> Each fix can be applied independently, but if patch5, 6 and 7 are
> acceptable, patch1 is not necessary because patch7 replaces a default
> stack tracer.

Given the comments and kbuild robot build errors, do you plan to post a
new version of this series?

Will

  parent reply	other threads:[~2015-10-28 15:23 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-08 10:01 [PATCH v3 0/7] arm64: ftrace: fix incorrect output from stack tracer AKASHI Takahiro
2015-10-08 10:01 ` AKASHI Takahiro
2015-10-08 10:01 ` [PATCH v3 1/7] arm64: ftrace: adjust callsite addresses examined by " AKASHI Takahiro
2015-10-08 10:01   ` AKASHI Takahiro
2015-10-13 15:15   ` Jungseok Lee
2015-10-13 15:15     ` Jungseok Lee
2015-10-13 15:37   ` Steven Rostedt
2015-10-13 15:37     ` Steven Rostedt
2015-10-14  5:09     ` AKASHI Takahiro
2015-10-14  5:09       ` AKASHI Takahiro
2015-10-08 10:01 ` [PATCH v3 2/7] arm64: ftrace: modify a stack frame in a safe way AKASHI Takahiro
2015-10-08 10:01   ` AKASHI Takahiro
2015-10-08 10:01 ` [PATCH v3 3/7] arm64: ftrace: fix a stack tracer's output under function graph tracer AKASHI Takahiro
2015-10-08 10:01   ` AKASHI Takahiro
2015-10-09  6:46   ` kbuild test robot
2015-10-09  6:46     ` kbuild test robot
2015-10-13 15:24   ` Jungseok Lee
2015-10-13 15:24     ` Jungseok Lee
2015-10-14  5:03     ` AKASHI Takahiro
2015-10-14  5:03       ` AKASHI Takahiro
2015-10-08 10:01 ` [PATCH v3 4/7] arm64: ftrace: allow for tracing leaf functions AKASHI Takahiro
2015-10-08 10:01   ` AKASHI Takahiro
2015-10-08 10:01 ` [PATCH v3 5/7] ftrace: allow arch-specific stack tracer AKASHI Takahiro
2015-10-08 10:01   ` AKASHI Takahiro
2015-10-13 15:45   ` Steven Rostedt
2015-10-13 15:45     ` Steven Rostedt
2015-10-08 10:01 ` [PATCH v3 6/7] arm64: insn: add instruction decoders for ldp/stp and add/sub AKASHI Takahiro
2015-10-08 10:01   ` AKASHI Takahiro
2015-10-08 10:01 ` [PATCH v3 7/7] arm64: ftrace: add arch-specific stack tracer AKASHI Takahiro
2015-10-08 10:01   ` AKASHI Takahiro
2015-10-09  6:41   ` kbuild test robot
2015-10-09  6:41     ` kbuild test robot
2015-10-08 14:45 ` [PATCH v3 0/7] arm64: ftrace: fix incorrect output from " Jungseok Lee
2015-10-08 14:45   ` Jungseok Lee
2015-10-22 14:05   ` Jungseok Lee
2015-10-22 14:05     ` Jungseok Lee
2015-10-28 15:23 ` Will Deacon [this message]
2015-10-28 15:23   ` Will Deacon
2015-10-29  5:24   ` AKASHI Takahiro
2015-10-29  5:24     ` AKASHI Takahiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151028152344.GG18966@arm.com \
    --to=will.deacon@arm.com \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=david.griego@linaro.org \
    --cc=jungseoklee85@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=rostedt@goodmis.org \
    --cc=takahiro.akashi@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.