All of lore.kernel.org
 help / color / mirror / Atom feed
From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: Jungseok Lee <jungseoklee85@gmail.com>
Cc: catalin.marinas@arm.com, will.deacon@arm.com,
	rostedt@goodmis.org, olof@lixom.net, broonie@kernel.org,
	david.griego@linaro.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/7] arm64: ftrace: fix a stack tracer's output under function graph tracer
Date: Wed, 14 Oct 2015 14:03:50 +0900	[thread overview]
Message-ID: <561DE236.7010703@linaro.org> (raw)
In-Reply-To: <DBC9AC69-1187-4BF5-887D-23ACA29C2865@gmail.com>

On 10/14/2015 12:24 AM, Jungseok Lee wrote:
> On Oct 8, 2015, at 7:01 PM, AKASHI Takahiro wrote:
>
> Hi Akashi,
>
>> Function graph tracer modifies a return address (LR) in a stack frame
>> to hook a function return. This will result in many useless entries
>> (return_to_handler) showing up in a stack tracer's output.
>>
>> This patch replaces such entries with originals values preserved in
>> current->ret_stack[].
>>
>> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
>
> The following diff should be folded into this patch, not [7/7] one, to
> address build breakage.

Thanks.
I fixed all the build errors reported by kbuild test robot.

-Takahiro AKASHI

> ----8<----
> diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c
> index 407991b..7126d4d 100644
> --- a/arch/arm64/kernel/stacktrace.c
> +++ b/arch/arm64/kernel/stacktrace.c
> @@ -17,6 +17,7 @@
>    */
>   #include <linux/kernel.h>
>   #include <linux/export.h>
> +#include <linux/ftrace.h>
>   #include <linux/sched.h>
>   #include <linux/stacktrace.h>
> ----8<----
>
> Best Regards
> Jungseok Lee
>

WARNING: multiple messages have this Message-ID (diff)
From: takahiro.akashi@linaro.org (AKASHI Takahiro)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 3/7] arm64: ftrace: fix a stack tracer's output under function graph tracer
Date: Wed, 14 Oct 2015 14:03:50 +0900	[thread overview]
Message-ID: <561DE236.7010703@linaro.org> (raw)
In-Reply-To: <DBC9AC69-1187-4BF5-887D-23ACA29C2865@gmail.com>

On 10/14/2015 12:24 AM, Jungseok Lee wrote:
> On Oct 8, 2015, at 7:01 PM, AKASHI Takahiro wrote:
>
> Hi Akashi,
>
>> Function graph tracer modifies a return address (LR) in a stack frame
>> to hook a function return. This will result in many useless entries
>> (return_to_handler) showing up in a stack tracer's output.
>>
>> This patch replaces such entries with originals values preserved in
>> current->ret_stack[].
>>
>> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
>
> The following diff should be folded into this patch, not [7/7] one, to
> address build breakage.

Thanks.
I fixed all the build errors reported by kbuild test robot.

-Takahiro AKASHI

> ----8<----
> diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c
> index 407991b..7126d4d 100644
> --- a/arch/arm64/kernel/stacktrace.c
> +++ b/arch/arm64/kernel/stacktrace.c
> @@ -17,6 +17,7 @@
>    */
>   #include <linux/kernel.h>
>   #include <linux/export.h>
> +#include <linux/ftrace.h>
>   #include <linux/sched.h>
>   #include <linux/stacktrace.h>
> ----8<----
>
> Best Regards
> Jungseok Lee
>

  reply	other threads:[~2015-10-14  5:03 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-08 10:01 [PATCH v3 0/7] arm64: ftrace: fix incorrect output from stack tracer AKASHI Takahiro
2015-10-08 10:01 ` AKASHI Takahiro
2015-10-08 10:01 ` [PATCH v3 1/7] arm64: ftrace: adjust callsite addresses examined by " AKASHI Takahiro
2015-10-08 10:01   ` AKASHI Takahiro
2015-10-13 15:15   ` Jungseok Lee
2015-10-13 15:15     ` Jungseok Lee
2015-10-13 15:37   ` Steven Rostedt
2015-10-13 15:37     ` Steven Rostedt
2015-10-14  5:09     ` AKASHI Takahiro
2015-10-14  5:09       ` AKASHI Takahiro
2015-10-08 10:01 ` [PATCH v3 2/7] arm64: ftrace: modify a stack frame in a safe way AKASHI Takahiro
2015-10-08 10:01   ` AKASHI Takahiro
2015-10-08 10:01 ` [PATCH v3 3/7] arm64: ftrace: fix a stack tracer's output under function graph tracer AKASHI Takahiro
2015-10-08 10:01   ` AKASHI Takahiro
2015-10-09  6:46   ` kbuild test robot
2015-10-09  6:46     ` kbuild test robot
2015-10-13 15:24   ` Jungseok Lee
2015-10-13 15:24     ` Jungseok Lee
2015-10-14  5:03     ` AKASHI Takahiro [this message]
2015-10-14  5:03       ` AKASHI Takahiro
2015-10-08 10:01 ` [PATCH v3 4/7] arm64: ftrace: allow for tracing leaf functions AKASHI Takahiro
2015-10-08 10:01   ` AKASHI Takahiro
2015-10-08 10:01 ` [PATCH v3 5/7] ftrace: allow arch-specific stack tracer AKASHI Takahiro
2015-10-08 10:01   ` AKASHI Takahiro
2015-10-13 15:45   ` Steven Rostedt
2015-10-13 15:45     ` Steven Rostedt
2015-10-08 10:01 ` [PATCH v3 6/7] arm64: insn: add instruction decoders for ldp/stp and add/sub AKASHI Takahiro
2015-10-08 10:01   ` AKASHI Takahiro
2015-10-08 10:01 ` [PATCH v3 7/7] arm64: ftrace: add arch-specific stack tracer AKASHI Takahiro
2015-10-08 10:01   ` AKASHI Takahiro
2015-10-09  6:41   ` kbuild test robot
2015-10-09  6:41     ` kbuild test robot
2015-10-08 14:45 ` [PATCH v3 0/7] arm64: ftrace: fix incorrect output from " Jungseok Lee
2015-10-08 14:45   ` Jungseok Lee
2015-10-22 14:05   ` Jungseok Lee
2015-10-22 14:05     ` Jungseok Lee
2015-10-28 15:23 ` Will Deacon
2015-10-28 15:23   ` Will Deacon
2015-10-29  5:24   ` AKASHI Takahiro
2015-10-29  5:24     ` AKASHI Takahiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=561DE236.7010703@linaro.org \
    --to=takahiro.akashi@linaro.org \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=david.griego@linaro.org \
    --cc=jungseoklee85@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=rostedt@goodmis.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.