All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: Phil Edworthy <phil.edworthy@renesas.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Simon Horman <horms@verge.net.au>,
	linux-pci@vger.kernel.org, linux-sh@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: pcie-rcar: Fix OF node passed to MSI irq domain
Date: Sat, 07 Nov 2015 13:59:51 +0000	[thread overview]
Message-ID: <20151107135951.GD21726@katana> (raw)
In-Reply-To: <1446542899-25137-1-git-send-email-phil.edworthy@renesas.com>

[-- Attachment #1: Type: text/plain, Size: 560 bytes --]

On Tue, Nov 03, 2015 at 09:28:19AM +0000, Phil Edworthy wrote:
> The OF node passed to irq_domain_add_linear() should be a
> pointer to interrupt controller's device tree node, or NULL,
> but not the PCI controller's node.
> 
> This fixes an oops in msi_domain_alloc_irqs() when it tries
> to call msi_check().
> 
> Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Was this the MSI problem you were talking about?


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Phil Edworthy <phil.edworthy@renesas.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Simon Horman <horms@verge.net.au>,
	linux-pci@vger.kernel.org, linux-sh@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: pcie-rcar: Fix OF node passed to MSI irq domain
Date: Sat, 7 Nov 2015 14:59:51 +0100	[thread overview]
Message-ID: <20151107135951.GD21726@katana> (raw)
In-Reply-To: <1446542899-25137-1-git-send-email-phil.edworthy@renesas.com>

[-- Attachment #1: Type: text/plain, Size: 560 bytes --]

On Tue, Nov 03, 2015 at 09:28:19AM +0000, Phil Edworthy wrote:
> The OF node passed to irq_domain_add_linear() should be a
> pointer to interrupt controller's device tree node, or NULL,
> but not the PCI controller's node.
> 
> This fixes an oops in msi_domain_alloc_irqs() when it tries
> to call msi_check().
> 
> Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Was this the MSI problem you were talking about?


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2015-11-07 13:59 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-03  9:28 [PATCH] PCI: pcie-rcar: Fix OF node passed to MSI irq domain Phil Edworthy
2015-11-03  9:28 ` Phil Edworthy
2015-11-07 13:59 ` Wolfram Sang [this message]
2015-11-07 13:59   ` Wolfram Sang
2015-11-09  9:00   ` Phil Edworthy
2015-11-09  9:00     ` Phil Edworthy
2015-11-10  1:21   ` Simon Horman
2015-11-10  1:21     ` Simon Horman
2015-11-09 15:20 ` Phil Edworthy
2015-11-09 15:20   ` Phil Edworthy
2015-11-09 16:11   ` Thierry Reding
2015-11-09 16:11     ` Thierry Reding
2015-11-09 17:24     ` Phil Edworthy
2015-11-09 17:24       ` Phil Edworthy
2015-11-09 18:01     ` Phil Edworthy
2015-11-09 18:01       ` Phil Edworthy
2015-11-10 15:52       ` Thierry Reding
2015-11-10 15:52         ` Thierry Reding
2015-11-11 16:38         ` Marc Zyngier
2015-11-12  8:57           ` Phil Edworthy
2015-11-12  8:57             ` Phil Edworthy
2015-11-12 20:31             ` Marc Zyngier
2015-11-12 20:31               ` Marc Zyngier
2015-11-13  9:36               ` Phil Edworthy
2015-11-13  9:36                 ` Phil Edworthy
2015-11-16 18:31                 ` Marc Zyngier
2015-11-16 18:31                   ` Marc Zyngier
2015-11-18 18:01                   ` Phil Edworthy
2015-11-18 18:01                     ` Phil Edworthy
2015-11-20  9:38                     ` Marc Zyngier
2015-11-20  9:38                       ` Marc Zyngier
2015-11-20  9:49                     ` Marc Zyngier
2015-11-20  9:49                       ` Marc Zyngier
2015-11-23  9:44                       ` Phil Edworthy
2015-11-23  9:44                         ` Phil Edworthy
2015-11-23 10:15                         ` Marc Zyngier
2015-11-23 10:15                           ` Marc Zyngier
2015-11-23 10:29                           ` Wolfram Sang
2015-11-23 10:29                             ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151107135951.GD21726@katana \
    --to=wsa@the-dreams.de \
    --cc=bhelgaas@google.com \
    --cc=geert@linux-m68k.org \
    --cc=horms@verge.net.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=phil.edworthy@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.