* MPT2SAS boot fail... due to silently loosing the driver @ 2015-11-23 12:46 Peter Zijlstra 2015-11-24 7:51 ` Christoph Hellwig 2015-11-24 12:02 ` Martin K. Petersen 0 siblings, 2 replies; 13+ messages in thread From: Peter Zijlstra @ 2015-11-23 12:46 UTC (permalink / raw) To: Sreekanth.Reddy; +Cc: mingo, hch, hare, martin.petersen, linux-kernel Hi all, Due to merging the MPT[23]SAS drivers (which undoubtedly is a good thing) my .config automagically lost its MPT2SAS entries and didn't ask for MPT3SAS because that was a pre-existing config which I didn't have selected. c84b06a48c4d ("mpt3sas: Single driver module which supports both SAS 2.0 & SAS 3.0 HBAs") Please either create a fake MPT2SAS config that selects the MPT3SAS driver, or rename the whole thing to MPT23SAS such that we at least get a relevant question on oldconfig. Thanks for wasting my morning playing with horribly slow booting machines trying to figure out WTF it wouldn't go. ~ Peter ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: MPT2SAS boot fail... due to silently loosing the driver 2015-11-23 12:46 MPT2SAS boot fail... due to silently loosing the driver Peter Zijlstra @ 2015-11-24 7:51 ` Christoph Hellwig 2015-11-24 7:54 ` Hannes Reinecke 2015-11-24 8:04 ` Ingo Molnar 2015-11-24 12:02 ` Martin K. Petersen 1 sibling, 2 replies; 13+ messages in thread From: Christoph Hellwig @ 2015-11-24 7:51 UTC (permalink / raw) To: Peter Zijlstra Cc: Sreekanth.Reddy, mingo, hch, hare, martin.petersen, linux-kernel I wonder what the "classic" way to such transitions is. Adding a mpt2 option that just selects mpt3 sound easy, but might be very confusing. ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: MPT2SAS boot fail... due to silently loosing the driver 2015-11-24 7:51 ` Christoph Hellwig @ 2015-11-24 7:54 ` Hannes Reinecke 2015-11-24 7:56 ` Christoph Hellwig 2015-11-24 8:04 ` Ingo Molnar 1 sibling, 1 reply; 13+ messages in thread From: Hannes Reinecke @ 2015-11-24 7:54 UTC (permalink / raw) To: Christoph Hellwig, Peter Zijlstra Cc: Sreekanth.Reddy, mingo, martin.petersen, linux-kernel On 11/24/2015 08:51 AM, Christoph Hellwig wrote: > I wonder what the "classic" way to such transitions is. Adding a mpt2 > option that just selects mpt3 sound easy, but might be very confusing. > Personally, I would rename everything to 'mptXsas', and have the original options map onto that. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: MPT2SAS boot fail... due to silently loosing the driver 2015-11-24 7:54 ` Hannes Reinecke @ 2015-11-24 7:56 ` Christoph Hellwig 0 siblings, 0 replies; 13+ messages in thread From: Christoph Hellwig @ 2015-11-24 7:56 UTC (permalink / raw) To: Hannes Reinecke Cc: Christoph Hellwig, Peter Zijlstra, Sreekanth.Reddy, mingo, martin.petersen, linux-kernel Send a patch so we can understand what you mean :) ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: MPT2SAS boot fail... due to silently loosing the driver 2015-11-24 7:51 ` Christoph Hellwig 2015-11-24 7:54 ` Hannes Reinecke @ 2015-11-24 8:04 ` Ingo Molnar 1 sibling, 0 replies; 13+ messages in thread From: Ingo Molnar @ 2015-11-24 8:04 UTC (permalink / raw) To: Christoph Hellwig Cc: Peter Zijlstra, Sreekanth.Reddy, hare, martin.petersen, linux-kernel * Christoph Hellwig <hch@lst.de> wrote: > I wonder what the "classic" way to such transitions is. Adding a mpt2 option > that just selects mpt3 sound easy, but might be very confusing. I was hit by the same problem, and wasted some time on it before Peter did his time wasting, so a solution would be nice. An interactive SCSI_MPT2SAS option has to exist in any case, so that we can migrate those people who have it configured - and its help text should explain that it's a legacy setting that should not be used anymore. That won't be confusing. Then the MPT3 section can do something like: # Default to enabled if the config has the old driver enabled: default y if SCSI_MPT2SAS Doing this will also help bisectability: right now we cannot bisect on that system without figuring out whether to enable MPT2 or MPT3 at every single bisection step. Don't ever break configs this way. Please! Also, please pick hardware version invariant names - do we want to go through this again when MPT4 is introduced? Thanks, Ingo ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: MPT2SAS boot fail... due to silently loosing the driver 2015-11-23 12:46 MPT2SAS boot fail... due to silently loosing the driver Peter Zijlstra 2015-11-24 7:51 ` Christoph Hellwig @ 2015-11-24 12:02 ` Martin K. Petersen 2015-11-26 10:48 ` Ingo Molnar 2015-11-26 10:51 ` Ingo Molnar 1 sibling, 2 replies; 13+ messages in thread From: Martin K. Petersen @ 2015-11-24 12:02 UTC (permalink / raw) To: Peter Zijlstra Cc: Sreekanth.Reddy, mingo, hch, hare, martin.petersen, linux-kernel >>>>> "Peter" == Peter Zijlstra <peterz@infradead.org> writes: Peter> Please either create a fake MPT2SAS config that selects the Peter> MPT3SAS driver, or rename the whole thing to MPT23SAS such that Peter> we at least get a relevant question on oldconfig. Sorry about that, Peter. I get bitten by oldconfig all the time so I have a script to manage all my configs. But it it would be nice if we had a way to express config options transitions in kbuild. I guess we could do something like the following and let it sit for a release cycle to help people transition. Bit of a hack, but it worked for me in my quick testing... -- Martin K. Petersen Oracle Linux Engineering diff --git a/drivers/scsi/mpt3sas/Kconfig b/drivers/scsi/mpt3sas/Kconfig index 29061467cc17..901c97f1e368 100644 --- a/drivers/scsi/mpt3sas/Kconfig +++ b/drivers/scsi/mpt3sas/Kconfig @@ -48,6 +48,13 @@ config SCSI_MPT3SAS ---help--- This driver supports PCI-Express SAS 12Gb/s Host Adapters. +config SCSI_MPT2SAS + tristate + default n + select SCSI_MPT3SAS + ---help--- + Dummy config option for backwards compatiblity. + config SCSI_MPT2SAS_MAX_SGE int "LSI MPT Fusion SAS 2.0 Max number of SG Entries (16 - 256)" depends on PCI && SCSI && SCSI_MPT3SAS ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: MPT2SAS boot fail... due to silently loosing the driver 2015-11-24 12:02 ` Martin K. Petersen @ 2015-11-26 10:48 ` Ingo Molnar 2015-11-30 17:21 ` Martin K. Petersen 2015-11-26 10:51 ` Ingo Molnar 1 sibling, 1 reply; 13+ messages in thread From: Ingo Molnar @ 2015-11-26 10:48 UTC (permalink / raw) To: Martin K. Petersen Cc: Peter Zijlstra, Sreekanth.Reddy, hch, hare, linux-kernel * Martin K. Petersen <martin.petersen@oracle.com> wrote: > >>>>> "Peter" == Peter Zijlstra <peterz@infradead.org> writes: > > Peter> Please either create a fake MPT2SAS config that selects the > Peter> MPT3SAS driver, or rename the whole thing to MPT23SAS such that > Peter> we at least get a relevant question on oldconfig. > > Sorry about that, Peter. > > I get bitten by oldconfig all the time so I have a script to manage all > my configs. But it it would be nice if we had a way to express config > options transitions in kbuild. > > I guess we could do something like the following and let it sit for a > release cycle to help people transition. Bit of a hack, but it worked > for me in my quick testing... > > -- > Martin K. Petersen Oracle Linux Engineering > > diff --git a/drivers/scsi/mpt3sas/Kconfig b/drivers/scsi/mpt3sas/Kconfig > index 29061467cc17..901c97f1e368 100644 > --- a/drivers/scsi/mpt3sas/Kconfig > +++ b/drivers/scsi/mpt3sas/Kconfig > @@ -48,6 +48,13 @@ config SCSI_MPT3SAS > ---help--- > This driver supports PCI-Express SAS 12Gb/s Host Adapters. > > +config SCSI_MPT2SAS > + tristate > + default n > + select SCSI_MPT3SAS > + ---help--- > + Dummy config option for backwards compatiblity. So I don't think this does what you expect it to do: non-interactive options will be set to their defaults, regardless of what's in the oldconfig. So you need to make it interactive, with a short help text that explains to users that this is legacy option only, and that they should enable the MPT3SAS option if they want to configure things manually. i.e. something like: +config SCSI_MPT2SAS + tristate "Legacy MPT2SAS config option" + default n + select SCSI_MPT3SAS + ---help--- + Dummy config option for backwards compatiblity: configure the MPT3SAS + driver instead. Thanks, Ingo ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: MPT2SAS boot fail... due to silently loosing the driver 2015-11-26 10:48 ` Ingo Molnar @ 2015-11-30 17:21 ` Martin K. Petersen 2015-11-30 17:24 ` Christoph Hellwig ` (3 more replies) 0 siblings, 4 replies; 13+ messages in thread From: Martin K. Petersen @ 2015-11-30 17:21 UTC (permalink / raw) To: Ingo Molnar Cc: Martin K. Petersen, Peter Zijlstra, Sreekanth.Reddy, hch, hare, linux-kernel, James Bottomley >>>>> "Ingo" == Ingo Molnar <mingo@kernel.org> writes: Ingo> So you need to make it interactive, with a short help text that Ingo> explains to users that this is legacy option only, and that they Ingo> should enable the MPT3SAS option if they want to configure things Ingo> manually. +config SCSI_MPT2SAS + tristate "Legacy MPT2SAS config option" + default n + select SCSI_MPT3SAS + ---help--- + Dummy config option for backwards compatiblity: configure the MPT3SAS + driver instead. That's fine with me. Sreekanth/Christoph/James: Any objections? -- Martin K. Petersen Oracle Linux Engineering ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: MPT2SAS boot fail... due to silently loosing the driver 2015-11-30 17:21 ` Martin K. Petersen @ 2015-11-30 17:24 ` Christoph Hellwig 2015-11-30 17:27 ` James Bottomley ` (2 subsequent siblings) 3 siblings, 0 replies; 13+ messages in thread From: Christoph Hellwig @ 2015-11-30 17:24 UTC (permalink / raw) To: Martin K. Petersen Cc: Ingo Molnar, Peter Zijlstra, Sreekanth.Reddy, hch, hare, linux-kernel, James Bottomley If that's been tested to work I'm fine with it. ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: MPT2SAS boot fail... due to silently loosing the driver 2015-11-30 17:21 ` Martin K. Petersen 2015-11-30 17:24 ` Christoph Hellwig @ 2015-11-30 17:27 ` James Bottomley 2015-12-01 9:49 ` Sreekanth Reddy 2015-12-02 9:57 ` Ingo Molnar 3 siblings, 0 replies; 13+ messages in thread From: James Bottomley @ 2015-11-30 17:27 UTC (permalink / raw) To: Martin K. Petersen Cc: Ingo Molnar, Peter Zijlstra, Sreekanth.Reddy, hch, hare, linux-kernel, linux-scsi [cc to linux-scsi added] On Mon, 2015-11-30 at 12:21 -0500, Martin K. Petersen wrote: > >>>>> "Ingo" == Ingo Molnar <mingo@kernel.org> writes: > > Ingo> So you need to make it interactive, with a short help text that > Ingo> explains to users that this is legacy option only, and that they > Ingo> should enable the MPT3SAS option if they want to configure things > Ingo> manually. > > +config SCSI_MPT2SAS > + tristate "Legacy MPT2SAS config option" > + default n > + select SCSI_MPT3SAS > + ---help--- > + Dummy config option for backwards compatiblity: configure the MPT3SAS > + driver instead. > > That's fine with me. > > Sreekanth/Christoph/James: Any objections? Looks OK, we probably need a removal timeframe for it as well. What about removal in 4.6? James ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: MPT2SAS boot fail... due to silently loosing the driver 2015-11-30 17:21 ` Martin K. Petersen 2015-11-30 17:24 ` Christoph Hellwig 2015-11-30 17:27 ` James Bottomley @ 2015-12-01 9:49 ` Sreekanth Reddy 2015-12-02 9:57 ` Ingo Molnar 3 siblings, 0 replies; 13+ messages in thread From: Sreekanth Reddy @ 2015-12-01 9:49 UTC (permalink / raw) To: Martin K. Petersen Cc: Ingo Molnar, Peter Zijlstra, Christoph Hellwig, Hannes Reinecke, linux-kernel, James Bottomley On Mon, Nov 30, 2015 at 10:51 PM, Martin K. Petersen <martin.petersen@oracle.com> wrote: > > >>>>> "Ingo" == Ingo Molnar <mingo@kernel.org> writes: > > Ingo> So you need to make it interactive, with a short help text that > Ingo> explains to users that this is legacy option only, and that they > Ingo> should enable the MPT3SAS option if they want to configure things > Ingo> manually. > > +config SCSI_MPT2SAS > + tristate "Legacy MPT2SAS config option" > + default n > + select SCSI_MPT3SAS > + ---help--- > + Dummy config option for backwards compatiblity: configure the MPT3SAS > + driver instead. > > That's fine with me. > > Sreekanth/Christoph/James: Any objections? [Sreekanth] Martin, I am fine with this change. > > -- > Martin K. Petersen Oracle Linux Engineering ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: MPT2SAS boot fail... due to silently loosing the driver 2015-11-30 17:21 ` Martin K. Petersen ` (2 preceding siblings ...) 2015-12-01 9:49 ` Sreekanth Reddy @ 2015-12-02 9:57 ` Ingo Molnar 3 siblings, 0 replies; 13+ messages in thread From: Ingo Molnar @ 2015-12-02 9:57 UTC (permalink / raw) To: Martin K. Petersen Cc: Peter Zijlstra, Sreekanth.Reddy, hch, hare, linux-kernel, James Bottomley * Martin K. Petersen <martin.petersen@oracle.com> wrote: > >>>>> "Ingo" == Ingo Molnar <mingo@kernel.org> writes: > > Ingo> So you need to make it interactive, with a short help text that > Ingo> explains to users that this is legacy option only, and that they > Ingo> should enable the MPT3SAS option if they want to configure things > Ingo> manually. > > +config SCSI_MPT2SAS > + tristate "Legacy MPT2SAS config option" > + default n > + select SCSI_MPT3SAS > + ---help--- > + Dummy config option for backwards compatiblity: configure the MPT3SAS > + driver instead. > > That's fine with me. > > Sreekanth/Christoph/James: Any objections? Acked-by: Ingo Molnar <mingo@kernel.org> Could we get this upstream ASAP so that people testing later rc's don't lose their settings? Thanks! Ingo ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: MPT2SAS boot fail... due to silently loosing the driver 2015-11-24 12:02 ` Martin K. Petersen 2015-11-26 10:48 ` Ingo Molnar @ 2015-11-26 10:51 ` Ingo Molnar 1 sibling, 0 replies; 13+ messages in thread From: Ingo Molnar @ 2015-11-26 10:51 UTC (permalink / raw) To: Martin K. Petersen Cc: Peter Zijlstra, Sreekanth.Reddy, hch, hare, linux-kernel * Martin K. Petersen <martin.petersen@oracle.com> wrote: > I guess we could do something like the following and let it sit for a > release cycle to help people transition. Bit of a hack, but it worked > for me in my quick testing... So I'm not sure how this could have worked for you in testing: try to set the MPT2SAS option to =y in your .config: CONFIG_SCSI_MPT2SAS=y then run 'make oldconfig', and the option is disabled: # CONFIG_SCSI_MPT2SAS is not set The way to solve this is to make it an interactive option, with text to make sure users don't mistake it for anything else than it is: a legacy/migration helper config. Thanks, Ingo ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2015-12-02 9:57 UTC | newest] Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2015-11-23 12:46 MPT2SAS boot fail... due to silently loosing the driver Peter Zijlstra 2015-11-24 7:51 ` Christoph Hellwig 2015-11-24 7:54 ` Hannes Reinecke 2015-11-24 7:56 ` Christoph Hellwig 2015-11-24 8:04 ` Ingo Molnar 2015-11-24 12:02 ` Martin K. Petersen 2015-11-26 10:48 ` Ingo Molnar 2015-11-30 17:21 ` Martin K. Petersen 2015-11-30 17:24 ` Christoph Hellwig 2015-11-30 17:27 ` James Bottomley 2015-12-01 9:49 ` Sreekanth Reddy 2015-12-02 9:57 ` Ingo Molnar 2015-11-26 10:51 ` Ingo Molnar
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.