Re: [PATCH v4 2/2] USB: quirks: Apply ALWAYS_POLL to all ELAN devices

From: kbuild test robot <lkp@intel.com>
To: "Adrien Vergé" <adrienverge@gmail.com>
Cc: kbuild-all@01.org,
	"Benjamin Tissoires" <benjamin.tissoires@gmail.com>,
	"Oliver Neukum" <oneukum@suse.com>,
	"Jiri Kosina" <jikos@kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Logan Gunthorpe" <logang@deltatee.com>,
	"Hans de Goede" <hdegoede@redhat.com>,
	"Vincent Palatin" <vpalatin@chromium.org>,
	"Adrien Vergé" <adrienverge@gmail.com>,
	"Macpaul Lin" <macpaul@gmail.com>,
	"Adel Gadllah" <adel.gadllah@gmail.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org
Subject: Re: [PATCH v4 2/2] USB: quirks: Apply ALWAYS_POLL to all ELAN devices
Date: Wed, 25 Nov 2015 00:41:35 +0800	[thread overview]
Message-ID: <201511250047.RxdAXBvy%fengguang.wu@intel.com> (raw)
In-Reply-To: <1448377325-4725-3-git-send-email-adrienverge@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2032 bytes --]

Hi Adrien,

[auto build test WARNING on hid/for-next]
[also build test WARNING on v4.4-rc2 next-20151124]

url:    https://github.com/0day-ci/linux/commits/Adrien-Verg/Fixes-for-ELAN-touchscreens/20151124-230537
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git for-next
config: avr32-hammerhead_defconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=avr32 

All warnings (new ones prefixed by >>):

   drivers/hid/usbhid/hid-quirks.c: In function 'usbhid_exists_squirk':
>> drivers/hid/usbhid/hid-quirks.c:339: warning: comparison is always false due to limited range of data type

vim +339 drivers/hid/usbhid/hid-quirks.c

   323	 * @idProduct: the 16-bit USB product ID, in native byteorder
   324	 *
   325	 * Description:
   326	 *     Given a USB vendor ID and product ID, return a pointer to
   327	 *     the hid_blacklist entry associated with that device.
   328	 *
   329	 * Returns: pointer if quirk found, or NULL if no quirks found.
   330	 */
   331	static const struct hid_blacklist *usbhid_exists_squirk(const u16 idVendor,
   332			const u16 idProduct)
   333	{
   334		const struct hid_blacklist *bl_entry = NULL;
   335		int n = 0;
   336	
   337		for (; hid_blacklist[n].idVendor; n++)
   338			if (hid_blacklist[n].idVendor == idVendor &&
 > 339				(hid_blacklist[n].idProduct == HID_ANY_ID ||
   340					hid_blacklist[n].idProduct == idProduct))
   341				bl_entry = &hid_blacklist[n];
   342	
   343		if (bl_entry != NULL)
   344			dbg_hid("Found squirk 0x%x for USB HID vendor 0x%hx prod 0x%hx\n",
   345					bl_entry->quirks, bl_entry->idVendor, 
   346					bl_entry->idProduct);
   347		return bl_entry;

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 14302 bytes --]