Re: [PATCH] USB: quirks: Fix another ELAN touchscreen

From: Jiri Kosina <jikos@kernel.org>
To: "Adrien Vergé" <adrienverge@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Macpaul Lin <macpaul@gmail.com>,
	Vincent Palatin <vpalatin@chromium.org>,
	Logan Gunthorpe <logang@deltatee.com>,
	Hans de Goede <hdegoede@redhat.com>,
	Yao-Wen Mao <yaowen@google.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org
Subject: Re: [PATCH] USB: quirks: Fix another ELAN touchscreen
Date: Mon, 23 Nov 2015 15:52:22 +0100 (CET)	[thread overview]
Message-ID: <alpine.LNX.2.00.1511231551330.20111@pobox.suse.cz> (raw)
In-Reply-To: <1448165164-11398-1-git-send-email-adrienverge@gmail.com>

On Sat, 21 Nov 2015, Adrien Vergé wrote:

> Like other buggy models that had their fixes [1], the touchscreen with
> id 04f3:21b8 from ELAN Microelectronics needs the device-qualifier
> quirk. Otherwise, it fails to respond, blocks the boot for a random
> amount of time and pollutes dmesg with:
> 
> [ 2887.373196] usb 1-5: new full-speed USB device number 41 using xhci_hcd
> [ 2889.502000] usb 1-5: unable to read config index 0 descriptor/start: -71
> [ 2889.502005] usb 1-5: can't read configurations, error -71
> [ 2889.654571] usb 1-5: new full-speed USB device number 42 using xhci_hcd
> [ 2891.783438] usb 1-5: unable to read config index 0 descriptor/start: -71
> [ 2891.783443] usb 1-5: can't read configurations, error -71

The drivers/hid part is

	Acked-by: Jiri Kosina <jkosina@suse.cz>

Makes one wonder however whether we shouldn't be applying ALWAYS_POLL to 
all ELAN devices by default anyway.

> [1]: See commits c68929f, 876af5d, d749947, a32c99e and dc703ec.
> 
> Tested-by: Adrien Vergé <adrienverge@gmail.com>

You need signoff here as well so that the patch can be applied.

Thanks,

-- 
Jiri Kosina
SUSE Labs