All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Matthijs van Duin <matthijsvanduin@gmail.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	Brian Hutchinson <b.hutchman@gmail.com>,
	Delio Brignoli <dbrignoli@audioscience.com>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Philipp Rosenberger <ilu@linutronix.de>
Subject: Re: [PATCH 10/10] ARM: dts: Fix dm814x pinctrl address and mask
Date: Tue, 1 Dec 2015 17:22:01 -0800	[thread overview]
Message-ID: <20151202012200.GZ23396@atomide.com> (raw)
In-Reply-To: <CAALWOA8J5xJaa2jSoY3RJ2iGNAcAypbWsC3+9YTNMFZPY2r5pA@mail.gmail.com>

* Matthijs van Duin <matthijsvanduin@gmail.com> [151201 17:15]:
> On 2 December 2015 at 01:46, Tony Lindgren <tony@atomide.com> wrote:
> > Ouch. We should probably have separate PIN_INPUT_3V3 and PIN_OUTPUT_3V3
> > dts macros that ensure that?
> 
> Can't we just keep bit 18 out of the function mask? The bootloader
> should already have made sure all pins have bit 18 set (and bit 19 set
> to correct values after ROM mucked them up, see advisory 2.1.88), so
> all that needs to be done is avoid touching them.

Sounds good to me. And people who really want to override the mask can
do it in the board specifc dts file.

> Are the power savings from disabling unnecessary inputs significant
> enough to spend any headache on it?

Only for some battery powered devices, not in this case for sure.

Regards,.

Tony

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 10/10] ARM: dts: Fix dm814x pinctrl address and mask
Date: Tue, 1 Dec 2015 17:22:01 -0800	[thread overview]
Message-ID: <20151202012200.GZ23396@atomide.com> (raw)
In-Reply-To: <CAALWOA8J5xJaa2jSoY3RJ2iGNAcAypbWsC3+9YTNMFZPY2r5pA@mail.gmail.com>

* Matthijs van Duin <matthijsvanduin@gmail.com> [151201 17:15]:
> On 2 December 2015 at 01:46, Tony Lindgren <tony@atomide.com> wrote:
> > Ouch. We should probably have separate PIN_INPUT_3V3 and PIN_OUTPUT_3V3
> > dts macros that ensure that?
> 
> Can't we just keep bit 18 out of the function mask? The bootloader
> should already have made sure all pins have bit 18 set (and bit 19 set
> to correct values after ROM mucked them up, see advisory 2.1.88), so
> all that needs to be done is avoid touching them.

Sounds good to me. And people who really want to override the mask can
do it in the board specifc dts file.

> Are the power savings from disabling unnecessary inputs significant
> enough to spend any headache on it?

Only for some battery powered devices, not in this case for sure.

Regards,.

Tony

  reply	other threads:[~2015-12-02  1:22 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-01 23:38 [PATCH 00/10] Patches to get dm814x-evm booting to NFSroot Tony Lindgren
2015-12-01 23:38 ` Tony Lindgren
2015-12-01 23:38 ` [PATCH 01/10] ARM: OMAP2+: Fix timer entries for dm814x Tony Lindgren
2015-12-01 23:38   ` Tony Lindgren
2015-12-01 23:38 ` [PATCH 02/10] clk: ti: Add few dm814x clock aliases Tony Lindgren
2015-12-01 23:38   ` Tony Lindgren
2015-12-08 16:57   ` Tony Lindgren
2015-12-08 16:57     ` Tony Lindgren
2015-12-08 19:26     ` Tero Kristo
2015-12-08 19:26       ` Tero Kristo
2015-12-08 19:26       ` Tero Kristo
2015-12-08 20:11       ` Tony Lindgren
2015-12-08 20:11         ` Tony Lindgren
2015-12-09  7:51         ` Tero Kristo
2015-12-09  7:51           ` Tero Kristo
2015-12-09  7:51           ` Tero Kristo
2015-12-10  0:56           ` Tony Lindgren
2015-12-10  0:56             ` Tony Lindgren
2015-12-01 23:38 ` [PATCH 03/10] ARM: OMAP2+: Add DPPLS clock manager for dm814x Tony Lindgren
2015-12-01 23:38   ` Tony Lindgren
2015-12-01 23:38 ` [PATCH 04/10] ARM: OMAP2+: Enable GPIO " Tony Lindgren
2015-12-01 23:38   ` Tony Lindgren
2015-12-01 23:38 ` [PATCH 05/10] ARM: OMAP2+: Disable GPIO softreset for dm81xx Tony Lindgren
2015-12-01 23:38   ` Tony Lindgren
2015-12-01 23:38   ` Tony Lindgren
2015-12-02  0:10   ` Matthijs van Duin
2015-12-02  0:10     ` Matthijs van Duin
2015-12-02  0:10     ` Matthijs van Duin
2015-12-02  0:41     ` Tony Lindgren
2015-12-02  0:41       ` Tony Lindgren
2015-12-02  0:41       ` Tony Lindgren
2015-12-02  0:54       ` Tony Lindgren
2015-12-02  0:54         ` Tony Lindgren
2015-12-02  0:54         ` Tony Lindgren
2015-12-02  1:38         ` Tony Lindgren
2015-12-02  1:38           ` Tony Lindgren
2015-12-02  1:38           ` Tony Lindgren
2015-12-01 23:38 ` [PATCH 06/10] ARM: OMAP2+: Remove useless check for legacy booting for dm814x Tony Lindgren
2015-12-01 23:38   ` Tony Lindgren
2015-12-01 23:38 ` [PATCH 07/10] ARM: dts: Fix dm814x entries for pllss and prcm Tony Lindgren
2015-12-01 23:38   ` Tony Lindgren
2015-12-01 23:38 ` [PATCH 08/10] ARM: dts: Fix some mux and divider clocks to get dm814x-evm booting Tony Lindgren
2015-12-01 23:38   ` Tony Lindgren
2015-12-01 23:38 ` [PATCH 09/10] ARM: dts: Fix dm8148 control modules ranges Tony Lindgren
2015-12-01 23:38   ` Tony Lindgren
2015-12-01 23:38 ` [PATCH 10/10] ARM: dts: Fix dm814x pinctrl address and mask Tony Lindgren
2015-12-01 23:38   ` Tony Lindgren
2015-12-02  0:25   ` Matthijs van Duin
2015-12-02  0:25     ` Matthijs van Duin
2015-12-02  0:25     ` Matthijs van Duin
2015-12-02  0:46     ` Tony Lindgren
2015-12-02  0:46       ` Tony Lindgren
2015-12-02  0:46       ` Tony Lindgren
2015-12-02  1:14       ` Matthijs van Duin
2015-12-02  1:14         ` Matthijs van Duin
2015-12-02  1:14         ` Matthijs van Duin
2015-12-02  1:22         ` Tony Lindgren [this message]
2015-12-02  1:22           ` Tony Lindgren
2015-12-02  1:22           ` Tony Lindgren
2015-12-02 16:09           ` Tony Lindgren
2015-12-02 16:09             ` Tony Lindgren
2015-12-02 16:09             ` Tony Lindgren
2015-12-02  1:21       ` Matthijs van Duin
2015-12-02  1:21         ` Matthijs van Duin
2015-12-02  1:21         ` Matthijs van Duin
2015-12-02 16:13         ` Tony Lindgren
2015-12-02 16:13           ` Tony Lindgren
2015-12-02 16:13           ` Tony Lindgren
2015-12-03 18:17 ` [PATCH 00/10] Patches to get dm814x-evm booting to NFSroot Grygorii Strashko
2015-12-03 18:17   ` Grygorii Strashko
2015-12-03 18:17   ` Grygorii Strashko
2015-12-03 19:21   ` Tony Lindgren
2015-12-03 19:21     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151202012200.GZ23396@atomide.com \
    --to=tony@atomide.com \
    --cc=b.hutchman@gmail.com \
    --cc=dbrignoli@audioscience.com \
    --cc=ilu@linutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=matthijsvanduin@gmail.com \
    --cc=narmstrong@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.