All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: tj@kernel.org
Cc: alaa@dev.mellanox.co.il, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] cgroup: fix sock_cgroup_data initialization on earlier compilers
Date: Wed, 09 Dec 2015 15:02:37 -0500 (EST)	[thread overview]
Message-ID: <20151209.150237.1395563395881100002.davem@davemloft.net> (raw)
In-Reply-To: <20151209173046.GO30240@mtj.duckdns.org>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: Text/Plain; charset=iso-8859-7, Size: 1254 bytes --]

From: Tejun Heo <tj@kernel.org>
Date: Wed, 9 Dec 2015 12:30:46 -0500

> sock_cgroup_data is a struct containing an anonymous union.
> sock_cgroup_set_prioidx() and sock_cgroup_set_classid() were
> initializing a field inside the anonymous union as follows.
> 
>  struct sock_ccgroup_data skcd_buf = { .val = VAL };
> 
> While this is fine on more recent compilers, gcc-4.4.7 triggers the
> following errors.
> 
>  include/linux/cgroup-defs.h: In function ¡sock_cgroup_set_prioidx¢:
>  include/linux/cgroup-defs.h:619: error: unknown field ¡val¢ specified in initializer
>  include/linux/cgroup-defs.h:619: warning: missing braces around initializer
>  include/linux/cgroup-defs.h:619: warning: (near initialization for ¡skcd_buf.<anonymous>¢)
> 
> This is because .val belongs to the anonymous union nested inside the
> struct but the initializer is missing the nesting.  Fix it by adding
> an extra pair of braces.
> 
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Reported-by: Alaa Hleihel <alaa@dev.mellanox.co.il>
> Fixes: bd1060a1d671 ("sock, cgroup: add sock->sk_cgroup")

Applied, thanks.
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: tj@kernel.org
Cc: alaa@dev.mellanox.co.il, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] cgroup: fix sock_cgroup_data initialization on earlier compilers
Date: Wed, 09 Dec 2015 15:02:37 -0500 (EST)	[thread overview]
Message-ID: <20151209.150237.1395563395881100002.davem@davemloft.net> (raw)
In-Reply-To: <20151209173046.GO30240@mtj.duckdns.org>

From: Tejun Heo <tj@kernel.org>
Date: Wed, 9 Dec 2015 12:30:46 -0500

> sock_cgroup_data is a struct containing an anonymous union.
> sock_cgroup_set_prioidx() and sock_cgroup_set_classid() were
> initializing a field inside the anonymous union as follows.
> 
>  struct sock_ccgroup_data skcd_buf = { .val = VAL };
> 
> While this is fine on more recent compilers, gcc-4.4.7 triggers the
> following errors.
> 
>  include/linux/cgroup-defs.h: In function ‘sock_cgroup_set_prioidx’:
>  include/linux/cgroup-defs.h:619: error: unknown field ‘val’ specified in initializer
>  include/linux/cgroup-defs.h:619: warning: missing braces around initializer
>  include/linux/cgroup-defs.h:619: warning: (near initialization for ‘skcd_buf.<anonymous>’)
> 
> This is because .val belongs to the anonymous union nested inside the
> struct but the initializer is missing the nesting.  Fix it by adding
> an extra pair of braces.
> 
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Reported-by: Alaa Hleihel <alaa@dev.mellanox.co.il>
> Fixes: bd1060a1d671 ("sock, cgroup: add sock->sk_cgroup")

Applied, thanks.

  reply	other threads:[~2015-12-09 20:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-09 17:30 [PATCH net-next] cgroup: fix sock_cgroup_data initialization on earlier compilers Tejun Heo
2015-12-09 20:02 ` David Miller [this message]
2015-12-09 20:02   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151209.150237.1395563395881100002.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=alaa@dev.mellanox.co.il \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.