* [PATCH 0/2] usb: renesas_usbhs: More compat strings @ 2015-12-08 5:51 ` Simon Horman 0 siblings, 0 replies; 28+ messages in thread From: Simon Horman @ 2015-12-08 5:51 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: Yoshihiro Shimoda, Magnus Damm, linux-usb, devicetree, linux-sh, Simon Horman Hi, this short series adds generic, and soc-specific r8a7792 and r8a7793 compat strings to the Renesas USBHS driver. The intention is to provide a complete set of compat strings for known R-Car SoCs. Simon Horman (2): usb: renesas_usbhs: add fallback compatibility string usb: renesas_usbhs: add device tree support for r8a779[23] Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 14 ++++++++------ drivers/usb/renesas_usbhs/common.c | 4 ++++ 2 files changed, 12 insertions(+), 6 deletions(-) -- 2.1.4 ^ permalink raw reply [flat|nested] 28+ messages in thread
* [PATCH 0/2] usb: renesas_usbhs: More compat strings @ 2015-12-08 5:51 ` Simon Horman 0 siblings, 0 replies; 28+ messages in thread From: Simon Horman @ 2015-12-08 5:51 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: Yoshihiro Shimoda, Magnus Damm, linux-usb, devicetree, linux-sh, Simon Horman Hi, this short series adds generic, and soc-specific r8a7792 and r8a7793 compat strings to the Renesas USBHS driver. The intention is to provide a complete set of compat strings for known R-Car SoCs. Simon Horman (2): usb: renesas_usbhs: add fallback compatibility string usb: renesas_usbhs: add device tree support for r8a779[23] Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 14 ++++++++------ drivers/usb/renesas_usbhs/common.c | 4 ++++ 2 files changed, 12 insertions(+), 6 deletions(-) -- 2.1.4 ^ permalink raw reply [flat|nested] 28+ messages in thread
[parent not found: <1449553911-21412-1-git-send-email-horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>]
* [PATCH 1/2] usb: renesas_usbhs: add fallback compatibility string [not found] ` <1449553911-21412-1-git-send-email-horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> @ 2015-12-08 5:51 ` Simon Horman 0 siblings, 0 replies; 28+ messages in thread From: Simon Horman @ 2015-12-08 5:51 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: Yoshihiro Shimoda, Magnus Damm, linux-usb-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-sh-u79uwXL29TY76Z2rM5mHXA, Simon Horman Add fallback compatibility string. This is in keeping with the fallback scheme being adopted wherever appropriate for drivers for Renesas SoCs. Signed-off-by: Simon Horman <horms+renesas@verge.net.au> --- Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 4 ++-- drivers/usb/renesas_usbhs/common.c | 4 ++++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt index 7d48f63db44e..8c50df8441c9 100644 --- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt +++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt @@ -1,7 +1,7 @@ Renesas Electronics USBHS driver Required properties: - - compatible: Must contain one of the following: + - compatible: "renesas,usbhs-<soctype>", "renesas,rcar-usbhs" as fallback. - "renesas,usbhs-r8a7790" - "renesas,usbhs-r8a7791" - "renesas,usbhs-r8a7794" @@ -22,7 +22,7 @@ Optional properties: Example: usbhs: usb@e6590000 { - compatible = "renesas,usbhs-r8a7790"; + compatible = "renesas,usbhs-r8a7790", "renesas,rcar-usbhs"; reg = <0 0xe6590000 0 0x100>; interrupts = <0 107 IRQ_TYPE_LEVEL_HIGH>; clocks = <&mstp7_clks R8A7790_CLK_HSUSB>; diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c index d82fa36c3465..2a9d4f405f30 100644 --- a/drivers/usb/renesas_usbhs/common.c +++ b/drivers/usb/renesas_usbhs/common.c @@ -481,6 +481,10 @@ static const struct of_device_id usbhs_of_match[] = { .compatible = "renesas,usbhs-r8a7795", .data = (void *)USBHS_TYPE_RCAR_GEN2, }, + { + .compatible = "renesas,usbhs", + .data = (void *)USBHS_TYPE_RCAR_GEN2, + }, { }, }; MODULE_DEVICE_TABLE(of, usbhs_of_match); -- 2.1.4 ^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH 1/2] usb: renesas_usbhs: add fallback compatibility string @ 2015-12-08 5:51 ` Simon Horman 0 siblings, 0 replies; 28+ messages in thread From: Simon Horman @ 2015-12-08 5:51 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: Yoshihiro Shimoda, Magnus Damm, linux-usb-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-sh-u79uwXL29TY76Z2rM5mHXA, Simon Horman Add fallback compatibility string. This is in keeping with the fallback scheme being adopted wherever appropriate for drivers for Renesas SoCs. Signed-off-by: Simon Horman <horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> --- Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 4 ++-- drivers/usb/renesas_usbhs/common.c | 4 ++++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt index 7d48f63db44e..8c50df8441c9 100644 --- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt +++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt @@ -1,7 +1,7 @@ Renesas Electronics USBHS driver Required properties: - - compatible: Must contain one of the following: + - compatible: "renesas,usbhs-<soctype>", "renesas,rcar-usbhs" as fallback. - "renesas,usbhs-r8a7790" - "renesas,usbhs-r8a7791" - "renesas,usbhs-r8a7794" @@ -22,7 +22,7 @@ Optional properties: Example: usbhs: usb@e6590000 { - compatible = "renesas,usbhs-r8a7790"; + compatible = "renesas,usbhs-r8a7790", "renesas,rcar-usbhs"; reg = <0 0xe6590000 0 0x100>; interrupts = <0 107 IRQ_TYPE_LEVEL_HIGH>; clocks = <&mstp7_clks R8A7790_CLK_HSUSB>; diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c index d82fa36c3465..2a9d4f405f30 100644 --- a/drivers/usb/renesas_usbhs/common.c +++ b/drivers/usb/renesas_usbhs/common.c @@ -481,6 +481,10 @@ static const struct of_device_id usbhs_of_match[] = { .compatible = "renesas,usbhs-r8a7795", .data = (void *)USBHS_TYPE_RCAR_GEN2, }, + { + .compatible = "renesas,usbhs", + .data = (void *)USBHS_TYPE_RCAR_GEN2, + }, { }, }; MODULE_DEVICE_TABLE(of, usbhs_of_match); -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 28+ messages in thread
[parent not found: <1449553911-21412-2-git-send-email-horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>]
* Re: [PATCH 1/2] usb: renesas_usbhs: add fallback compatibility string [not found] ` <1449553911-21412-2-git-send-email-horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> @ 2015-12-08 6:05 ` Kuninori Morimoto 2015-12-08 14:35 ` Sergei Shtylyov 1 sibling, 0 replies; 28+ messages in thread From: Kuninori Morimoto @ 2015-12-08 6:05 UTC (permalink / raw) To: Simon Horman Cc: Greg Kroah-Hartman, Yoshihiro Shimoda, Magnus Damm, linux-usb-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-sh-u79uwXL29TY76Z2rM5mHXA Hi Simon > Add fallback compatibility string. > This is in keeping with the fallback scheme being adopted wherever > appropriate for drivers for Renesas SoCs. > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > --- (snip) > + { > + .compatible = "renesas,usbhs", > + .data = (void *)USBHS_TYPE_RCAR_GEN2, > + }, > { }, > }; I think this is too much. This driver is used not only from R-Car Gen2. It will work as normal mode if .data was 0. see usbhs_parse_dt() ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 1/2] usb: renesas_usbhs: add fallback compatibility string @ 2015-12-08 6:05 ` Kuninori Morimoto 0 siblings, 0 replies; 28+ messages in thread From: Kuninori Morimoto @ 2015-12-08 6:05 UTC (permalink / raw) To: Simon Horman Cc: Greg Kroah-Hartman, Yoshihiro Shimoda, Magnus Damm, linux-usb-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-sh-u79uwXL29TY76Z2rM5mHXA Hi Simon > Add fallback compatibility string. > This is in keeping with the fallback scheme being adopted wherever > appropriate for drivers for Renesas SoCs. > > Signed-off-by: Simon Horman <horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> > --- (snip) > + { > + .compatible = "renesas,usbhs", > + .data = (void *)USBHS_TYPE_RCAR_GEN2, > + }, > { }, > }; I think this is too much. This driver is used not only from R-Car Gen2. It will work as normal mode if .data was 0. see usbhs_parse_dt() -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 28+ messages in thread
[parent not found: <87egex5vfl.wl%kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>]
* Re: [PATCH 1/2] usb: renesas_usbhs: add fallback compatibility string [not found] ` <87egex5vfl.wl%kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org> @ 2015-12-08 7:49 ` Simon Horman 0 siblings, 0 replies; 28+ messages in thread From: Simon Horman @ 2015-12-08 7:49 UTC (permalink / raw) To: Kuninori Morimoto Cc: Greg Kroah-Hartman, Yoshihiro Shimoda, Magnus Damm, linux-usb-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-sh-u79uwXL29TY76Z2rM5mHXA On Tue, Dec 08, 2015 at 06:05:51AM +0000, Kuninori Morimoto wrote: > > Hi Simon > > > Add fallback compatibility string. > > This is in keeping with the fallback scheme being adopted wherever > > appropriate for drivers for Renesas SoCs. > > > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > --- > (snip) > > + { > > + .compatible = "renesas,usbhs", > > + .data = (void *)USBHS_TYPE_RCAR_GEN2, > > + }, > > { }, > > }; > > I think this is too much. This driver is used not only from R-Car Gen2. > It will work as normal mode if .data was 0. > see usbhs_parse_dt() Are you suggesting that we remove USBHS_TYPE_RCAR_GEN2 from the driver? ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 1/2] usb: renesas_usbhs: add fallback compatibility string @ 2015-12-08 7:49 ` Simon Horman 0 siblings, 0 replies; 28+ messages in thread From: Simon Horman @ 2015-12-08 7:49 UTC (permalink / raw) To: Kuninori Morimoto Cc: Greg Kroah-Hartman, Yoshihiro Shimoda, Magnus Damm, linux-usb-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-sh-u79uwXL29TY76Z2rM5mHXA On Tue, Dec 08, 2015 at 06:05:51AM +0000, Kuninori Morimoto wrote: > > Hi Simon > > > Add fallback compatibility string. > > This is in keeping with the fallback scheme being adopted wherever > > appropriate for drivers for Renesas SoCs. > > > > Signed-off-by: Simon Horman <horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> > > --- > (snip) > > + { > > + .compatible = "renesas,usbhs", > > + .data = (void *)USBHS_TYPE_RCAR_GEN2, > > + }, > > { }, > > }; > > I think this is too much. This driver is used not only from R-Car Gen2. > It will work as normal mode if .data was 0. > see usbhs_parse_dt() Are you suggesting that we remove USBHS_TYPE_RCAR_GEN2 from the driver? -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 1/2] usb: renesas_usbhs: add fallback compatibility string 2015-12-08 7:49 ` Simon Horman @ 2015-12-08 8:32 ` Kuninori Morimoto -1 siblings, 0 replies; 28+ messages in thread From: Kuninori Morimoto @ 2015-12-08 8:32 UTC (permalink / raw) To: Simon Horman Cc: Greg Kroah-Hartman, Yoshihiro Shimoda, Magnus Damm, linux-usb, devicetree, linux-sh Hi Simon > > > Add fallback compatibility string. > > > This is in keeping with the fallback scheme being adopted wherever > > > appropriate for drivers for Renesas SoCs. > > > > > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > > --- > > (snip) > > > + { > > > + .compatible = "renesas,usbhs", > > > + .data = (void *)USBHS_TYPE_RCAR_GEN2, > > > + }, > > > { }, > > > }; > > > > I think this is too much. This driver is used not only from R-Car Gen2. > > It will work as normal mode if .data was 0. > > see usbhs_parse_dt() > > Are you suggesting that we remove USBHS_TYPE_RCAR_GEN2 from the driver? I mean this + { + .compatible = "renesas,usbhs", + }, ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 1/2] usb: renesas_usbhs: add fallback compatibility string @ 2015-12-08 8:32 ` Kuninori Morimoto 0 siblings, 0 replies; 28+ messages in thread From: Kuninori Morimoto @ 2015-12-08 8:32 UTC (permalink / raw) To: Simon Horman Cc: Greg Kroah-Hartman, Yoshihiro Shimoda, Magnus Damm, linux-usb, devicetree, linux-sh Hi Simon > > > Add fallback compatibility string. > > > This is in keeping with the fallback scheme being adopted wherever > > > appropriate for drivers for Renesas SoCs. > > > > > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > > --- > > (snip) > > > + { > > > + .compatible = "renesas,usbhs", > > > + .data = (void *)USBHS_TYPE_RCAR_GEN2, > > > + }, > > > { }, > > > }; > > > > I think this is too much. This driver is used not only from R-Car Gen2. > > It will work as normal mode if .data was 0. > > see usbhs_parse_dt() > > Are you suggesting that we remove USBHS_TYPE_RCAR_GEN2 from the driver? I mean this + { + .compatible = "renesas,usbhs", + }, ^ permalink raw reply [flat|nested] 28+ messages in thread
[parent not found: <87a8pl5oms.wl%kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>]
* Re: [PATCH 1/2] usb: renesas_usbhs: add fallback compatibility string [not found] ` <87a8pl5oms.wl%kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org> @ 2015-12-09 2:37 ` Simon Horman 0 siblings, 0 replies; 28+ messages in thread From: Simon Horman @ 2015-12-09 2:37 UTC (permalink / raw) To: Kuninori Morimoto Cc: Greg Kroah-Hartman, Yoshihiro Shimoda, Magnus Damm, linux-usb-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-sh-u79uwXL29TY76Z2rM5mHXA On Tue, Dec 08, 2015 at 08:32:49AM +0000, Kuninori Morimoto wrote: > > Hi Simon > > > > > Add fallback compatibility string. > > > > This is in keeping with the fallback scheme being adopted wherever > > > > appropriate for drivers for Renesas SoCs. > > > > > > > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > > > --- > > > (snip) > > > > + { > > > > + .compatible = "renesas,usbhs", > > > > + .data = (void *)USBHS_TYPE_RCAR_GEN2, > > > > + }, > > > > { }, > > > > }; > > > > > > I think this is too much. This driver is used not only from R-Car Gen2. > > > It will work as normal mode if .data was 0. > > > see usbhs_parse_dt() > > > > Are you suggesting that we remove USBHS_TYPE_RCAR_GEN2 from the driver? > > I mean this > > + { > + .compatible = "renesas,usbhs", > + }, (As Sergei noted elsewhere, "renesas,rcar-usbhs" is consistent with what I documented elsewhere in the patch) My understanding is that will cause the driver to operate in a different manner to if USBHS_TYPE_RCAR_GEN2 was set. And thus meaning of the generic and SoC-specifc compatibility strings will cause the driver to operate differently. Currently the only compat strings present are as follows: * renesas,usbhs-r8a7790 * renesas,usbhs-r8a7791 * renesas,usbhs-r8a7794 * renesas,usbhs-r8a7795 And they all set USBHS_TYPE_RCAR_GEN2 (even though r8a7795 is a Gen3 SoC). What I am aiming is either: * A compatibility string for R-Car or; * Two compatibility strings, one for R-Car Gen2 and one for R-Car Gen3 And for this new compatibility string or strings to operate the same way as the current compatibility strings. Looking over the driver its not clear to me why the non-USBHS_TYPE_RCAR_GEN2 case is handled by the code as there are no compatibility strings present that trigger that mode of operation. I feel that I must be missing something. ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 1/2] usb: renesas_usbhs: add fallback compatibility string @ 2015-12-09 2:37 ` Simon Horman 0 siblings, 0 replies; 28+ messages in thread From: Simon Horman @ 2015-12-09 2:37 UTC (permalink / raw) To: Kuninori Morimoto Cc: Greg Kroah-Hartman, Yoshihiro Shimoda, Magnus Damm, linux-usb-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-sh-u79uwXL29TY76Z2rM5mHXA On Tue, Dec 08, 2015 at 08:32:49AM +0000, Kuninori Morimoto wrote: > > Hi Simon > > > > > Add fallback compatibility string. > > > > This is in keeping with the fallback scheme being adopted wherever > > > > appropriate for drivers for Renesas SoCs. > > > > > > > > Signed-off-by: Simon Horman <horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> > > > > --- > > > (snip) > > > > + { > > > > + .compatible = "renesas,usbhs", > > > > + .data = (void *)USBHS_TYPE_RCAR_GEN2, > > > > + }, > > > > { }, > > > > }; > > > > > > I think this is too much. This driver is used not only from R-Car Gen2. > > > It will work as normal mode if .data was 0. > > > see usbhs_parse_dt() > > > > Are you suggesting that we remove USBHS_TYPE_RCAR_GEN2 from the driver? > > I mean this > > + { > + .compatible = "renesas,usbhs", > + }, (As Sergei noted elsewhere, "renesas,rcar-usbhs" is consistent with what I documented elsewhere in the patch) My understanding is that will cause the driver to operate in a different manner to if USBHS_TYPE_RCAR_GEN2 was set. And thus meaning of the generic and SoC-specifc compatibility strings will cause the driver to operate differently. Currently the only compat strings present are as follows: * renesas,usbhs-r8a7790 * renesas,usbhs-r8a7791 * renesas,usbhs-r8a7794 * renesas,usbhs-r8a7795 And they all set USBHS_TYPE_RCAR_GEN2 (even though r8a7795 is a Gen3 SoC). What I am aiming is either: * A compatibility string for R-Car or; * Two compatibility strings, one for R-Car Gen2 and one for R-Car Gen3 And for this new compatibility string or strings to operate the same way as the current compatibility strings. Looking over the driver its not clear to me why the non-USBHS_TYPE_RCAR_GEN2 case is handled by the code as there are no compatibility strings present that trigger that mode of operation. I feel that I must be missing something. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 1/2] usb: renesas_usbhs: add fallback compatibility string 2015-12-09 2:37 ` Simon Horman @ 2015-12-09 4:48 ` Kuninori Morimoto -1 siblings, 0 replies; 28+ messages in thread From: Kuninori Morimoto @ 2015-12-09 4:48 UTC (permalink / raw) To: Simon Horman Cc: Greg Kroah-Hartman, Yoshihiro Shimoda, Magnus Damm, linux-usb, devicetree, linux-sh Hi Simon > (As Sergei noted elsewhere, "renesas,rcar-usbhs" is consistent > with what I documented elsewhere in the patch) "renesas,rcar-usbhs" is better, but I guess you want to have "renesas,rcar-gen2-usbhs" ? My understanding is these * renesas,usbhs-r8a77xx # SoC specific * renesas,rcar-usbhs # R-Car common * renesas,rcar-gen2-usbhs # R-Car Gen2 common * renesas,rcar-gen3-usbhs # R-Car Gen3 common * renesas,usbhs # Renesas USBHS common ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 1/2] usb: renesas_usbhs: add fallback compatibility string @ 2015-12-09 4:48 ` Kuninori Morimoto 0 siblings, 0 replies; 28+ messages in thread From: Kuninori Morimoto @ 2015-12-09 4:48 UTC (permalink / raw) To: Simon Horman Cc: Greg Kroah-Hartman, Yoshihiro Shimoda, Magnus Damm, linux-usb, devicetree, linux-sh Hi Simon > (As Sergei noted elsewhere, "renesas,rcar-usbhs" is consistent > with what I documented elsewhere in the patch) "renesas,rcar-usbhs" is better, but I guess you want to have "renesas,rcar-gen2-usbhs" ? My understanding is these * renesas,usbhs-r8a77xx # SoC specific * renesas,rcar-usbhs # R-Car common * renesas,rcar-gen2-usbhs # R-Car Gen2 common * renesas,rcar-gen3-usbhs # R-Car Gen3 common * renesas,usbhs # Renesas USBHS common ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 1/2] usb: renesas_usbhs: add fallback compatibility string 2015-12-09 4:48 ` Kuninori Morimoto @ 2015-12-09 5:30 ` Simon Horman -1 siblings, 0 replies; 28+ messages in thread From: Simon Horman @ 2015-12-09 5:30 UTC (permalink / raw) To: Kuninori Morimoto Cc: Greg Kroah-Hartman, Yoshihiro Shimoda, Magnus Damm, linux-usb, devicetree, linux-sh On Wed, Dec 09, 2015 at 04:48:47AM +0000, Kuninori Morimoto wrote: > > Hi Simon > > > (As Sergei noted elsewhere, "renesas,rcar-usbhs" is consistent > > with what I documented elsewhere in the patch) > > "renesas,rcar-usbhs" is better, > but I guess you want to have "renesas,rcar-gen2-usbhs" ? > > My understanding is these > > * renesas,usbhs-r8a77xx # SoC specific > * renesas,rcar-usbhs # R-Car common > * renesas,rcar-gen2-usbhs # R-Car Gen2 common > * renesas,rcar-gen3-usbhs # R-Car Gen3 common > * renesas,usbhs # Renesas USBHS common > I was intentionally including gen3 as well. So I think we have two options: 1. renesas,rcar-usbhs 2. renesas,rcar-gen2-usbhs and renesas,rcar-gen3-usbhs Which do you prefer? ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 1/2] usb: renesas_usbhs: add fallback compatibility string @ 2015-12-09 5:30 ` Simon Horman 0 siblings, 0 replies; 28+ messages in thread From: Simon Horman @ 2015-12-09 5:30 UTC (permalink / raw) To: Kuninori Morimoto Cc: Greg Kroah-Hartman, Yoshihiro Shimoda, Magnus Damm, linux-usb, devicetree, linux-sh On Wed, Dec 09, 2015 at 04:48:47AM +0000, Kuninori Morimoto wrote: > > Hi Simon > > > (As Sergei noted elsewhere, "renesas,rcar-usbhs" is consistent > > with what I documented elsewhere in the patch) > > "renesas,rcar-usbhs" is better, > but I guess you want to have "renesas,rcar-gen2-usbhs" ? > > My understanding is these > > * renesas,usbhs-r8a77xx # SoC specific > * renesas,rcar-usbhs # R-Car common > * renesas,rcar-gen2-usbhs # R-Car Gen2 common > * renesas,rcar-gen3-usbhs # R-Car Gen3 common > * renesas,usbhs # Renesas USBHS common > I was intentionally including gen3 as well. So I think we have two options: 1. renesas,rcar-usbhs 2. renesas,rcar-gen2-usbhs and renesas,rcar-gen3-usbhs Which do you prefer? ^ permalink raw reply [flat|nested] 28+ messages in thread
[parent not found: <20151209052957.GA20831-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>]
* Re: [PATCH 1/2] usb: renesas_usbhs: add fallback compatibility string [not found] ` <20151209052957.GA20831-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> @ 2015-12-09 6:29 ` Kuninori Morimoto 0 siblings, 0 replies; 28+ messages in thread From: Kuninori Morimoto @ 2015-12-09 6:29 UTC (permalink / raw) To: Simon Horman Cc: Greg Kroah-Hartman, Yoshihiro Shimoda, Magnus Damm, linux-usb-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-sh-u79uwXL29TY76Z2rM5mHXA Hi Simon > > > (As Sergei noted elsewhere, "renesas,rcar-usbhs" is consistent > > > with what I documented elsewhere in the patch) > > > > "renesas,rcar-usbhs" is better, > > but I guess you want to have "renesas,rcar-gen2-usbhs" ? > > > > My understanding is these > > > > * renesas,usbhs-r8a77xx # SoC specific > > * renesas,rcar-usbhs # R-Car common > > * renesas,rcar-gen2-usbhs # R-Car Gen2 common > > * renesas,rcar-gen3-usbhs # R-Car Gen3 common > > * renesas,usbhs # Renesas USBHS common > > > > I was intentionally including gen3 as well. So I think we have two options: > > 1. renesas,rcar-usbhs > 2. renesas,rcar-gen2-usbhs and renesas,rcar-gen3-usbhs Renesas USB always have pick feature/settings. Thus, generic name (= "renesas,rcar-usbhs") is very risky IMO. I think 2 is more safety. ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 1/2] usb: renesas_usbhs: add fallback compatibility string @ 2015-12-09 6:29 ` Kuninori Morimoto 0 siblings, 0 replies; 28+ messages in thread From: Kuninori Morimoto @ 2015-12-09 6:29 UTC (permalink / raw) To: Simon Horman Cc: Greg Kroah-Hartman, Yoshihiro Shimoda, Magnus Damm, linux-usb-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-sh-u79uwXL29TY76Z2rM5mHXA Hi Simon > > > (As Sergei noted elsewhere, "renesas,rcar-usbhs" is consistent > > > with what I documented elsewhere in the patch) > > > > "renesas,rcar-usbhs" is better, > > but I guess you want to have "renesas,rcar-gen2-usbhs" ? > > > > My understanding is these > > > > * renesas,usbhs-r8a77xx # SoC specific > > * renesas,rcar-usbhs # R-Car common > > * renesas,rcar-gen2-usbhs # R-Car Gen2 common > > * renesas,rcar-gen3-usbhs # R-Car Gen3 common > > * renesas,usbhs # Renesas USBHS common > > > > I was intentionally including gen3 as well. So I think we have two options: > > 1. renesas,rcar-usbhs > 2. renesas,rcar-gen2-usbhs and renesas,rcar-gen3-usbhs Renesas USB always have pick feature/settings. Thus, generic name (= "renesas,rcar-usbhs") is very risky IMO. I think 2 is more safety. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 1/2] usb: renesas_usbhs: add fallback compatibility string 2015-12-09 6:29 ` Kuninori Morimoto @ 2015-12-09 6:42 ` Simon Horman -1 siblings, 0 replies; 28+ messages in thread From: Simon Horman @ 2015-12-09 6:42 UTC (permalink / raw) To: Kuninori Morimoto Cc: Greg Kroah-Hartman, Yoshihiro Shimoda, Magnus Damm, linux-usb, devicetree, linux-sh On Wed, Dec 09, 2015 at 06:29:07AM +0000, Kuninori Morimoto wrote: > > Hi Simon > > > > > (As Sergei noted elsewhere, "renesas,rcar-usbhs" is consistent > > > > with what I documented elsewhere in the patch) > > > > > > "renesas,rcar-usbhs" is better, > > > but I guess you want to have "renesas,rcar-gen2-usbhs" ? > > > > > > My understanding is these > > > > > > * renesas,usbhs-r8a77xx # SoC specific > > > * renesas,rcar-usbhs # R-Car common > > > * renesas,rcar-gen2-usbhs # R-Car Gen2 common > > > * renesas,rcar-gen3-usbhs # R-Car Gen3 common > > > * renesas,usbhs # Renesas USBHS common > > > > > > > I was intentionally including gen3 as well. So I think we have two options: > > > > 1. renesas,rcar-usbhs > > 2. renesas,rcar-gen2-usbhs and renesas,rcar-gen3-usbhs > > Renesas USB always have pick feature/settings. > Thus, generic name (= "renesas,rcar-usbhs") is very risky IMO. > I think 2 is more safety. Sure, better safe than sorry. ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 1/2] usb: renesas_usbhs: add fallback compatibility string @ 2015-12-09 6:42 ` Simon Horman 0 siblings, 0 replies; 28+ messages in thread From: Simon Horman @ 2015-12-09 6:42 UTC (permalink / raw) To: Kuninori Morimoto Cc: Greg Kroah-Hartman, Yoshihiro Shimoda, Magnus Damm, linux-usb, devicetree, linux-sh On Wed, Dec 09, 2015 at 06:29:07AM +0000, Kuninori Morimoto wrote: > > Hi Simon > > > > > (As Sergei noted elsewhere, "renesas,rcar-usbhs" is consistent > > > > with what I documented elsewhere in the patch) > > > > > > "renesas,rcar-usbhs" is better, > > > but I guess you want to have "renesas,rcar-gen2-usbhs" ? > > > > > > My understanding is these > > > > > > * renesas,usbhs-r8a77xx # SoC specific > > > * renesas,rcar-usbhs # R-Car common > > > * renesas,rcar-gen2-usbhs # R-Car Gen2 common > > > * renesas,rcar-gen3-usbhs # R-Car Gen3 common > > > * renesas,usbhs # Renesas USBHS common > > > > > > > I was intentionally including gen3 as well. So I think we have two options: > > > > 1. renesas,rcar-usbhs > > 2. renesas,rcar-gen2-usbhs and renesas,rcar-gen3-usbhs > > Renesas USB always have pick feature/settings. > Thus, generic name (= "renesas,rcar-usbhs") is very risky IMO. > I think 2 is more safety. Sure, better safe than sorry. ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 1/2] usb: renesas_usbhs: add fallback compatibility string [not found] ` <1449553911-21412-2-git-send-email-horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> @ 2015-12-08 14:35 ` Sergei Shtylyov 2015-12-08 14:35 ` Sergei Shtylyov 1 sibling, 0 replies; 28+ messages in thread From: Sergei Shtylyov @ 2015-12-08 14:35 UTC (permalink / raw) To: Simon Horman, Greg Kroah-Hartman Cc: Yoshihiro Shimoda, Magnus Damm, linux-usb-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-sh-u79uwXL29TY76Z2rM5mHXA On 12/08/2015 08:51 AM, Simon Horman wrote: > Add fallback compatibility string. > This is in keeping with the fallback scheme being adopted wherever > appropriate for drivers for Renesas SoCs. > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > --- > Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 4 ++-- > drivers/usb/renesas_usbhs/common.c | 4 ++++ > 2 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt > index 7d48f63db44e..8c50df8441c9 100644 > --- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt > +++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt > @@ -1,7 +1,7 @@ > Renesas Electronics USBHS driver > > Required properties: > - - compatible: Must contain one of the following: > + - compatible: "renesas,usbhs-<soctype>", "renesas,rcar-usbhs" as fallback. > - "renesas,usbhs-r8a7790" > - "renesas,usbhs-r8a7791" > - "renesas,usbhs-r8a7794" [...] > diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c > index d82fa36c3465..2a9d4f405f30 100644 > --- a/drivers/usb/renesas_usbhs/common.c > +++ b/drivers/usb/renesas_usbhs/common.c > @@ -481,6 +481,10 @@ static const struct of_device_id usbhs_of_match[] = { > .compatible = "renesas,usbhs-r8a7795", > .data = (void *)USBHS_TYPE_RCAR_GEN2, > }, > + { > + .compatible = "renesas,usbhs", You just documented "renesas,rcar-usbhs". MBR, Sergei ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 1/2] usb: renesas_usbhs: add fallback compatibility string @ 2015-12-08 14:35 ` Sergei Shtylyov 0 siblings, 0 replies; 28+ messages in thread From: Sergei Shtylyov @ 2015-12-08 14:35 UTC (permalink / raw) To: Simon Horman, Greg Kroah-Hartman Cc: Yoshihiro Shimoda, Magnus Damm, linux-usb-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-sh-u79uwXL29TY76Z2rM5mHXA On 12/08/2015 08:51 AM, Simon Horman wrote: > Add fallback compatibility string. > This is in keeping with the fallback scheme being adopted wherever > appropriate for drivers for Renesas SoCs. > > Signed-off-by: Simon Horman <horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> > --- > Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 4 ++-- > drivers/usb/renesas_usbhs/common.c | 4 ++++ > 2 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt > index 7d48f63db44e..8c50df8441c9 100644 > --- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt > +++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt > @@ -1,7 +1,7 @@ > Renesas Electronics USBHS driver > > Required properties: > - - compatible: Must contain one of the following: > + - compatible: "renesas,usbhs-<soctype>", "renesas,rcar-usbhs" as fallback. > - "renesas,usbhs-r8a7790" > - "renesas,usbhs-r8a7791" > - "renesas,usbhs-r8a7794" [...] > diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c > index d82fa36c3465..2a9d4f405f30 100644 > --- a/drivers/usb/renesas_usbhs/common.c > +++ b/drivers/usb/renesas_usbhs/common.c > @@ -481,6 +481,10 @@ static const struct of_device_id usbhs_of_match[] = { > .compatible = "renesas,usbhs-r8a7795", > .data = (void *)USBHS_TYPE_RCAR_GEN2, > }, > + { > + .compatible = "renesas,usbhs", You just documented "renesas,rcar-usbhs". MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 28+ messages in thread
[parent not found: <5666EAB0.6000109-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>]
* Re: [PATCH 1/2] usb: renesas_usbhs: add fallback compatibility string [not found] ` <5666EAB0.6000109-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> @ 2015-12-09 2:37 ` Simon Horman 0 siblings, 0 replies; 28+ messages in thread From: Simon Horman @ 2015-12-09 2:37 UTC (permalink / raw) To: Sergei Shtylyov Cc: Greg Kroah-Hartman, Yoshihiro Shimoda, Magnus Damm, linux-usb-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-sh-u79uwXL29TY76Z2rM5mHXA On Tue, Dec 08, 2015 at 05:35:28PM +0300, Sergei Shtylyov wrote: > On 12/08/2015 08:51 AM, Simon Horman wrote: > > >Add fallback compatibility string. > >This is in keeping with the fallback scheme being adopted wherever > >appropriate for drivers for Renesas SoCs. > > > >Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > >--- > > Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 4 ++-- > > drivers/usb/renesas_usbhs/common.c | 4 ++++ > > 2 files changed, 6 insertions(+), 2 deletions(-) > > > >diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt > >index 7d48f63db44e..8c50df8441c9 100644 > >--- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt > >+++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt > >@@ -1,7 +1,7 @@ > > Renesas Electronics USBHS driver > > > > Required properties: > >- - compatible: Must contain one of the following: > >+ - compatible: "renesas,usbhs-<soctype>", "renesas,rcar-usbhs" as fallback. > > - "renesas,usbhs-r8a7790" > > - "renesas,usbhs-r8a7791" > > - "renesas,usbhs-r8a7794" > [...] > >diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c > >index d82fa36c3465..2a9d4f405f30 100644 > >--- a/drivers/usb/renesas_usbhs/common.c > >+++ b/drivers/usb/renesas_usbhs/common.c > >@@ -481,6 +481,10 @@ static const struct of_device_id usbhs_of_match[] = { > > .compatible = "renesas,usbhs-r8a7795", > > .data = (void *)USBHS_TYPE_RCAR_GEN2, > > }, > >+ { > >+ .compatible = "renesas,usbhs", > > You just documented "renesas,rcar-usbhs". Thanks. I meant to use "renesas,rcar-usbhs" throughout the patch. ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 1/2] usb: renesas_usbhs: add fallback compatibility string @ 2015-12-09 2:37 ` Simon Horman 0 siblings, 0 replies; 28+ messages in thread From: Simon Horman @ 2015-12-09 2:37 UTC (permalink / raw) To: Sergei Shtylyov Cc: Greg Kroah-Hartman, Yoshihiro Shimoda, Magnus Damm, linux-usb-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-sh-u79uwXL29TY76Z2rM5mHXA On Tue, Dec 08, 2015 at 05:35:28PM +0300, Sergei Shtylyov wrote: > On 12/08/2015 08:51 AM, Simon Horman wrote: > > >Add fallback compatibility string. > >This is in keeping with the fallback scheme being adopted wherever > >appropriate for drivers for Renesas SoCs. > > > >Signed-off-by: Simon Horman <horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> > >--- > > Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 4 ++-- > > drivers/usb/renesas_usbhs/common.c | 4 ++++ > > 2 files changed, 6 insertions(+), 2 deletions(-) > > > >diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt > >index 7d48f63db44e..8c50df8441c9 100644 > >--- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt > >+++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt > >@@ -1,7 +1,7 @@ > > Renesas Electronics USBHS driver > > > > Required properties: > >- - compatible: Must contain one of the following: > >+ - compatible: "renesas,usbhs-<soctype>", "renesas,rcar-usbhs" as fallback. > > - "renesas,usbhs-r8a7790" > > - "renesas,usbhs-r8a7791" > > - "renesas,usbhs-r8a7794" > [...] > >diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c > >index d82fa36c3465..2a9d4f405f30 100644 > >--- a/drivers/usb/renesas_usbhs/common.c > >+++ b/drivers/usb/renesas_usbhs/common.c > >@@ -481,6 +481,10 @@ static const struct of_device_id usbhs_of_match[] = { > > .compatible = "renesas,usbhs-r8a7795", > > .data = (void *)USBHS_TYPE_RCAR_GEN2, > > }, > >+ { > >+ .compatible = "renesas,usbhs", > > You just documented "renesas,rcar-usbhs". Thanks. I meant to use "renesas,rcar-usbhs" throughout the patch. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 28+ messages in thread
* [PATCH 2/2] usb: renesas_usbhs: add device tree support for r8a779[23] 2015-12-08 5:51 ` Simon Horman @ 2015-12-08 5:51 ` Simon Horman -1 siblings, 0 replies; 28+ messages in thread From: Simon Horman @ 2015-12-08 5:51 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: Yoshihiro Shimoda, Magnus Damm, linux-usb, devicetree, linux-sh, Simon Horman Simply document new compatibility string. As a previous patch adds a generic R-Car Gen2 compatibility string there appears to be no need for a driver updates. Also add names for SoCs. Signed-off-by: Simon Horman <horms+renesas@verge.net.au> --- Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt index 8c50df8441c9..b31f036d2171 100644 --- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt +++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt @@ -2,10 +2,12 @@ Renesas Electronics USBHS driver Required properties: - compatible: "renesas,usbhs-<soctype>", "renesas,rcar-usbhs" as fallback. - - "renesas,usbhs-r8a7790" - - "renesas,usbhs-r8a7791" - - "renesas,usbhs-r8a7794" - - "renesas,usbhs-r8a7795" + - "renesas,usbhs-r8a7790" (R-Car H2) + - "renesas,usbhs-r8a7791" (R-Car M2-W) + - "renesas,usbhs-r8a7792" (R-Car V2H) + - "renesas,usbhs-r8a7793" (R-Car M2-N) + - "renesas,usbhs-r8a7794" (R-Car E2) + - "renesas,usbhs-r8a7795" (R-Car H3) - reg: Base address and length of the register for the USBHS - interrupts: Interrupt specifier for the USBHS - clocks: A list of phandle + clock specifier pairs -- 2.1.4 ^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH 2/2] usb: renesas_usbhs: add device tree support for r8a779[23] @ 2015-12-08 5:51 ` Simon Horman 0 siblings, 0 replies; 28+ messages in thread From: Simon Horman @ 2015-12-08 5:51 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: Yoshihiro Shimoda, Magnus Damm, linux-usb, devicetree, linux-sh, Simon Horman Simply document new compatibility string. As a previous patch adds a generic R-Car Gen2 compatibility string there appears to be no need for a driver updates. Also add names for SoCs. Signed-off-by: Simon Horman <horms+renesas@verge.net.au> --- Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt index 8c50df8441c9..b31f036d2171 100644 --- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt +++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt @@ -2,10 +2,12 @@ Renesas Electronics USBHS driver Required properties: - compatible: "renesas,usbhs-<soctype>", "renesas,rcar-usbhs" as fallback. - - "renesas,usbhs-r8a7790" - - "renesas,usbhs-r8a7791" - - "renesas,usbhs-r8a7794" - - "renesas,usbhs-r8a7795" + - "renesas,usbhs-r8a7790" (R-Car H2) + - "renesas,usbhs-r8a7791" (R-Car M2-W) + - "renesas,usbhs-r8a7792" (R-Car V2H) + - "renesas,usbhs-r8a7793" (R-Car M2-N) + - "renesas,usbhs-r8a7794" (R-Car E2) + - "renesas,usbhs-r8a7795" (R-Car H3) - reg: Base address and length of the register for the USBHS - interrupts: Interrupt specifier for the USBHS - clocks: A list of phandle + clock specifier pairs -- 2.1.4 ^ permalink raw reply related [flat|nested] 28+ messages in thread
[parent not found: <1449553911-21412-3-git-send-email-horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>]
* Re: [PATCH 2/2] usb: renesas_usbhs: add device tree support for r8a779[23] [not found] ` <1449553911-21412-3-git-send-email-horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> @ 2015-12-09 3:29 ` Rob Herring 0 siblings, 0 replies; 28+ messages in thread From: Rob Herring @ 2015-12-09 3:29 UTC (permalink / raw) To: Simon Horman Cc: Greg Kroah-Hartman, Yoshihiro Shimoda, Magnus Damm, linux-usb-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-sh-u79uwXL29TY76Z2rM5mHXA On Tue, Dec 08, 2015 at 02:51:51PM +0900, Simon Horman wrote: > Simply document new compatibility string. > As a previous patch adds a generic R-Car Gen2 compatibility string > there appears to be no need for a driver updates. > > Also add names for SoCs. > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> Acked-by: Rob Herring <robh@kernel.org> > --- > Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt > index 8c50df8441c9..b31f036d2171 100644 > --- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt > +++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt > @@ -2,10 +2,12 @@ Renesas Electronics USBHS driver > > Required properties: > - compatible: "renesas,usbhs-<soctype>", "renesas,rcar-usbhs" as fallback. > - - "renesas,usbhs-r8a7790" > - - "renesas,usbhs-r8a7791" > - - "renesas,usbhs-r8a7794" > - - "renesas,usbhs-r8a7795" > + - "renesas,usbhs-r8a7790" (R-Car H2) > + - "renesas,usbhs-r8a7791" (R-Car M2-W) > + - "renesas,usbhs-r8a7792" (R-Car V2H) > + - "renesas,usbhs-r8a7793" (R-Car M2-N) > + - "renesas,usbhs-r8a7794" (R-Car E2) > + - "renesas,usbhs-r8a7795" (R-Car H3) > - reg: Base address and length of the register for the USBHS > - interrupts: Interrupt specifier for the USBHS > - clocks: A list of phandle + clock specifier pairs > -- > 2.1.4 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/2] usb: renesas_usbhs: add device tree support for r8a779[23] @ 2015-12-09 3:29 ` Rob Herring 0 siblings, 0 replies; 28+ messages in thread From: Rob Herring @ 2015-12-09 3:29 UTC (permalink / raw) To: Simon Horman Cc: Greg Kroah-Hartman, Yoshihiro Shimoda, Magnus Damm, linux-usb-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-sh-u79uwXL29TY76Z2rM5mHXA On Tue, Dec 08, 2015 at 02:51:51PM +0900, Simon Horman wrote: > Simply document new compatibility string. > As a previous patch adds a generic R-Car Gen2 compatibility string > there appears to be no need for a driver updates. > > Also add names for SoCs. > > Signed-off-by: Simon Horman <horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> > --- > Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt > index 8c50df8441c9..b31f036d2171 100644 > --- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt > +++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt > @@ -2,10 +2,12 @@ Renesas Electronics USBHS driver > > Required properties: > - compatible: "renesas,usbhs-<soctype>", "renesas,rcar-usbhs" as fallback. > - - "renesas,usbhs-r8a7790" > - - "renesas,usbhs-r8a7791" > - - "renesas,usbhs-r8a7794" > - - "renesas,usbhs-r8a7795" > + - "renesas,usbhs-r8a7790" (R-Car H2) > + - "renesas,usbhs-r8a7791" (R-Car M2-W) > + - "renesas,usbhs-r8a7792" (R-Car V2H) > + - "renesas,usbhs-r8a7793" (R-Car M2-N) > + - "renesas,usbhs-r8a7794" (R-Car E2) > + - "renesas,usbhs-r8a7795" (R-Car H3) > - reg: Base address and length of the register for the USBHS > - interrupts: Interrupt specifier for the USBHS > - clocks: A list of phandle + clock specifier pairs > -- > 2.1.4 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 28+ messages in thread
end of thread, other threads:[~2015-12-09 6:42 UTC | newest] Thread overview: 28+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2015-12-08 5:51 [PATCH 0/2] usb: renesas_usbhs: More compat strings Simon Horman 2015-12-08 5:51 ` Simon Horman [not found] ` <1449553911-21412-1-git-send-email-horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> 2015-12-08 5:51 ` [PATCH 1/2] usb: renesas_usbhs: add fallback compatibility string Simon Horman 2015-12-08 5:51 ` Simon Horman [not found] ` <1449553911-21412-2-git-send-email-horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> 2015-12-08 6:05 ` Kuninori Morimoto 2015-12-08 6:05 ` Kuninori Morimoto [not found] ` <87egex5vfl.wl%kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org> 2015-12-08 7:49 ` Simon Horman 2015-12-08 7:49 ` Simon Horman 2015-12-08 8:32 ` Kuninori Morimoto 2015-12-08 8:32 ` Kuninori Morimoto [not found] ` <87a8pl5oms.wl%kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org> 2015-12-09 2:37 ` Simon Horman 2015-12-09 2:37 ` Simon Horman 2015-12-09 4:48 ` Kuninori Morimoto 2015-12-09 4:48 ` Kuninori Morimoto 2015-12-09 5:30 ` Simon Horman 2015-12-09 5:30 ` Simon Horman [not found] ` <20151209052957.GA20831-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> 2015-12-09 6:29 ` Kuninori Morimoto 2015-12-09 6:29 ` Kuninori Morimoto 2015-12-09 6:42 ` Simon Horman 2015-12-09 6:42 ` Simon Horman 2015-12-08 14:35 ` Sergei Shtylyov 2015-12-08 14:35 ` Sergei Shtylyov [not found] ` <5666EAB0.6000109-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> 2015-12-09 2:37 ` Simon Horman 2015-12-09 2:37 ` Simon Horman 2015-12-08 5:51 ` [PATCH 2/2] usb: renesas_usbhs: add device tree support for r8a779[23] Simon Horman 2015-12-08 5:51 ` Simon Horman [not found] ` <1449553911-21412-3-git-send-email-horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> 2015-12-09 3:29 ` Rob Herring 2015-12-09 3:29 ` Rob Herring
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.