* [Buildroot] [PATCH] libass: allow compilation without a system font provider
@ 2015-12-16 21:11 Yann E. MORIN
2015-12-16 22:38 ` Thomas Petazzoni
0 siblings, 1 reply; 8+ messages in thread
From: Yann E. MORIN @ 2015-12-16 21:11 UTC (permalink / raw)
To: buildroot
From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
If no system font provider is provided, then libass will fail to build
because it requires one by default. The error looks like this:
configure: error: Either DirectWrite (on Windows), CoreText (on OSX),
or Fontconfig(Linux, other) is required. If you really want to compile
withouta system font provider, add --disable-require-system-font-provider
(typo is from the actual message)
But, as the error messages says, we can allow the compilation without a
system font provider if we use the above configure option, so let's do
it.
Fixes:
http://autobuild.buildroot.net/results/3a4/3a4c07a0a54d5497fa8a4be2191856e286729637/
http://autobuild.buildroot.org/results/d5a/d5a93b5a870de748259b097ec0b98b207cfaa303/
and many others...
Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
[yann.morin.1998 at free.fr: move the --disable option in the !fontconfig
case]
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Bernd Kuhls <bernd.kuhls@t-online.de>
---
package/libass/libass.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/libass/libass.mk b/package/libass/libass.mk
index 83939e2..2f0ca08 100644
--- a/package/libass/libass.mk
+++ b/package/libass/libass.mk
@@ -28,7 +28,7 @@ ifeq ($(BR2_PACKAGE_FONTCONFIG),y)
LIBASS_DEPENDENCIES += fontconfig
LIBASS_CONF_OPTS += --enable-fontconfig
else
-LIBASS_CONF_OPTS += --disable-fontconfig
+LIBASS_CONF_OPTS += --disable-fontconfig --disable-require-system-font-provider
endif
ifeq ($(BR2_PACKAGE_HARFBUZZ),y)
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [Buildroot] [PATCH] libass: allow compilation without a system font provider
2015-12-16 21:11 [Buildroot] [PATCH] libass: allow compilation without a system font provider Yann E. MORIN
@ 2015-12-16 22:38 ` Thomas Petazzoni
0 siblings, 0 replies; 8+ messages in thread
From: Thomas Petazzoni @ 2015-12-16 22:38 UTC (permalink / raw)
To: buildroot
Dear Yann E. MORIN,
On Wed, 16 Dec 2015 22:11:48 +0100, Yann E. MORIN wrote:
> From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
>
> If no system font provider is provided, then libass will fail to build
> because it requires one by default. The error looks like this:
>
> configure: error: Either DirectWrite (on Windows), CoreText (on OSX),
> or Fontconfig(Linux, other) is required. If you really want to compile
> withouta system font provider, add --disable-require-system-font-provider
>
> (typo is from the actual message)
>
> But, as the error messages says, we can allow the compilation without a
> system font provider if we use the above configure option, so let's do
> it.
>
> Fixes:
> http://autobuild.buildroot.net/results/3a4/3a4c07a0a54d5497fa8a4be2191856e286729637/
> http://autobuild.buildroot.org/results/d5a/d5a93b5a870de748259b097ec0b98b207cfaa303/
> and many others...
>
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> [yann.morin.1998 at free.fr: move the --disable option in the !fontconfig
> case]
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> package/libass/libass.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH] libass: allow compilation without a system font provider
@ 2015-12-07 16:19 Vicente Olivert Riera
2015-12-08 17:16 ` Yann E. MORIN
0 siblings, 1 reply; 8+ messages in thread
From: Vicente Olivert Riera @ 2015-12-07 16:19 UTC (permalink / raw)
To: buildroot
If no system font provider is provided, then libass will fail to build
because it requires one by default. The error looks like this:
configure: error: Either DirectWrite (on Windows), CoreText (on OSX), or
Fontconfig(Linux, other) is required. If you really want to compile
withouta system font provider, add
--disable-require-system-font-provider
But, as the error messages says, we can allow the compilation without a
system font provider if we use the above configure option, so let's do
it.
Fixes:
http://autobuild.buildroot.net/results/3a4/3a4c07a0a54d5497fa8a4be2191856e286729637/
Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
package/libass/libass.mk | 3 +++
1 file changed, 3 insertions(+)
diff --git a/package/libass/libass.mk b/package/libass/libass.mk
index 83939e2..f1ec503 100644
--- a/package/libass/libass.mk
+++ b/package/libass/libass.mk
@@ -24,6 +24,9 @@ ifeq ($(BR2_i386)$(BR2_x86_64),y)
LIBASS_DEPENDENCIES += host-yasm
endif
+# Allow compilation without a system font provider
+LIBASS_CONF_OPTS = --disable-require-system-font-provider
+
ifeq ($(BR2_PACKAGE_FONTCONFIG),y)
LIBASS_DEPENDENCIES += fontconfig
LIBASS_CONF_OPTS += --enable-fontconfig
--
2.4.10
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH] libass: allow compilation without a system font provider
2015-12-07 16:19 Vicente Olivert Riera
@ 2015-12-08 17:16 ` Yann E. MORIN
2015-12-09 10:19 ` Vicente Olivert Riera
0 siblings, 1 reply; 8+ messages in thread
From: Yann E. MORIN @ 2015-12-08 17:16 UTC (permalink / raw)
To: buildroot
Vicente, All,
On 2015-12-07 16:19 +0000, Vicente Olivert Riera spake thusly:
> If no system font provider is provided, then libass will fail to build
> because it requires one by default. The error looks like this:
>
> configure: error: Either DirectWrite (on Windows), CoreText (on OSX), or
> Fontconfig(Linux, other) is required. If you really want to compile
> withouta system font provider, add
> --disable-require-system-font-provider
>
> But, as the error messages says, we can allow the compilation without a
> system font provider if we use the above configure option, so let's do
> it.
>
> Fixes:
>
> http://autobuild.buildroot.net/results/3a4/3a4c07a0a54d5497fa8a4be2191856e286729637/
>
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
> package/libass/libass.mk | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/package/libass/libass.mk b/package/libass/libass.mk
> index 83939e2..f1ec503 100644
> --- a/package/libass/libass.mk
> +++ b/package/libass/libass.mk
> @@ -24,6 +24,9 @@ ifeq ($(BR2_i386)$(BR2_x86_64),y)
> LIBASS_DEPENDENCIES += host-yasm
> endif
>
> +# Allow compilation without a system font provider
> +LIBASS_CONF_OPTS = --disable-require-system-font-provider
It is my understanding that fontconfig *is* a "system font provider", so
maybe that should go n the else-case for fontconfig, below?
> ifeq ($(BR2_PACKAGE_FONTCONFIG),y)
> LIBASS_DEPENDENCIES += fontconfig
> LIBASS_CONF_OPTS += --enable-fontconfig
Here:
else
LIBASS_CONF_OPTS += \
--disable-fontconfig \
--disable-require-system-font-provider
endif
Regards,
Yann E. MORIN.
> --
> 2.4.10
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 8+ messages in thread* [Buildroot] [PATCH] libass: allow compilation without a system font provider
2015-12-08 17:16 ` Yann E. MORIN
@ 2015-12-09 10:19 ` Vicente Olivert Riera
2015-12-09 17:28 ` Yann E. MORIN
0 siblings, 1 reply; 8+ messages in thread
From: Vicente Olivert Riera @ 2015-12-09 10:19 UTC (permalink / raw)
To: buildroot
Hello Yann,
On 08/12/15 17:16, Yann E. MORIN wrote:
> Vicente, All,
>
> On 2015-12-07 16:19 +0000, Vicente Olivert Riera spake thusly:
>> If no system font provider is provided, then libass will fail to build
>> because it requires one by default. The error looks like this:
>>
>> configure: error: Either DirectWrite (on Windows), CoreText (on OSX), or
>> Fontconfig(Linux, other) is required. If you really want to compile
>> withouta system font provider, add
>> --disable-require-system-font-provider
>>
>> But, as the error messages says, we can allow the compilation without a
>> system font provider if we use the above configure option, so let's do
>> it.
>>
>> Fixes:
>>
>> http://autobuild.buildroot.net/results/3a4/3a4c07a0a54d5497fa8a4be2191856e286729637/
>>
>> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
>> ---
>> package/libass/libass.mk | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/package/libass/libass.mk b/package/libass/libass.mk
>> index 83939e2..f1ec503 100644
>> --- a/package/libass/libass.mk
>> +++ b/package/libass/libass.mk
>> @@ -24,6 +24,9 @@ ifeq ($(BR2_i386)$(BR2_x86_64),y)
>> LIBASS_DEPENDENCIES += host-yasm
>> endif
>>
>> +# Allow compilation without a system font provider
>> +LIBASS_CONF_OPTS = --disable-require-system-font-provider
>
> It is my understanding that fontconfig *is* a "system font provider", so
> maybe that should go n the else-case for fontconfig, below?
>
>> ifeq ($(BR2_PACKAGE_FONTCONFIG),y)
>> LIBASS_DEPENDENCIES += fontconfig
>> LIBASS_CONF_OPTS += --enable-fontconfig
> Here:
>
> else
> LIBASS_CONF_OPTS += \
> --disable-fontconfig \
> --disable-require-system-font-provider
> endif
That was my first approach, but then I thought a bit more about it, and
I realized that there could be more system font providers in the future
(not only fontconfig). So, by using that option we enable the
possibility to build libass without a system font provider. That doesn't
mean necessarily that libass will be built without one. If the
fontconfig package is selected, it will be built with support for it.
Regards,
Vincent.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH] libass: allow compilation without a system font provider
2015-12-09 10:19 ` Vicente Olivert Riera
@ 2015-12-09 17:28 ` Yann E. MORIN
2015-12-09 17:30 ` Vicente Olivert Riera
0 siblings, 1 reply; 8+ messages in thread
From: Yann E. MORIN @ 2015-12-09 17:28 UTC (permalink / raw)
To: buildroot
Vicente, All,
On 2015-12-09 10:19 +0000, Vicente Olivert Riera spake thusly:
> On 08/12/15 17:16, Yann E. MORIN wrote:
> > On 2015-12-07 16:19 +0000, Vicente Olivert Riera spake thusly:
> >> If no system font provider is provided, then libass will fail to build
> >> because it requires one by default. The error looks like this:
> >>
> >> configure: error: Either DirectWrite (on Windows), CoreText (on OSX), or
> >> Fontconfig(Linux, other) is required. If you really want to compile
> >> withouta system font provider, add
> >> --disable-require-system-font-provider
> >>
> >> But, as the error messages says, we can allow the compilation without a
> >> system font provider if we use the above configure option, so let's do
> >> it.
> >>
> >> Fixes:
> >>
> >> http://autobuild.buildroot.net/results/3a4/3a4c07a0a54d5497fa8a4be2191856e286729637/
> >>
> >> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> >> ---
> >> package/libass/libass.mk | 3 +++
> >> 1 file changed, 3 insertions(+)
> >>
> >> diff --git a/package/libass/libass.mk b/package/libass/libass.mk
> >> index 83939e2..f1ec503 100644
> >> --- a/package/libass/libass.mk
> >> +++ b/package/libass/libass.mk
> >> @@ -24,6 +24,9 @@ ifeq ($(BR2_i386)$(BR2_x86_64),y)
> >> LIBASS_DEPENDENCIES += host-yasm
> >> endif
> >>
> >> +# Allow compilation without a system font provider
> >> +LIBASS_CONF_OPTS = --disable-require-system-font-provider
> >
> > It is my understanding that fontconfig *is* a "system font provider", so
> > maybe that should go n the else-case for fontconfig, below?
> >
> >> ifeq ($(BR2_PACKAGE_FONTCONFIG),y)
> >> LIBASS_DEPENDENCIES += fontconfig
> >> LIBASS_CONF_OPTS += --enable-fontconfig
> > Here:
> >
> > else
> > LIBASS_CONF_OPTS += \
> > --disable-fontconfig \
> > --disable-require-system-font-provider
> > endif
>
> That was my first approach, but then I thought a bit more about it, and
> I realized that there could be more system font providers in the future
> (not only fontconfig). So, by using that option we enable the
> possibility to build libass without a system font provider. That doesn't
> mean necessarily that libass will be built without one. If the
> fontconfig package is selected, it will be built with support for it.
But since that is currently not the case (i.e. we have a single font
provider), I think we should do as I suggest. When/if we have another
font provider, then we can revisit that at that time.
And I don't know what other font provider we'd have on Linux, beside
fontconfig. Arguably, I'm not a font expert either! ;-)
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH] libass: allow compilation without a system font provider
2015-12-09 17:28 ` Yann E. MORIN
@ 2015-12-09 17:30 ` Vicente Olivert Riera
2015-12-13 17:00 ` Bernd Kuhls
0 siblings, 1 reply; 8+ messages in thread
From: Vicente Olivert Riera @ 2015-12-09 17:30 UTC (permalink / raw)
To: buildroot
Hi Yann,
On 09/12/15 17:28, Yann E. MORIN wrote:
> Vicente, All,
>
> On 2015-12-09 10:19 +0000, Vicente Olivert Riera spake thusly:
>> On 08/12/15 17:16, Yann E. MORIN wrote:
>>> On 2015-12-07 16:19 +0000, Vicente Olivert Riera spake thusly:
>>>> If no system font provider is provided, then libass will fail to build
>>>> because it requires one by default. The error looks like this:
>>>>
>>>> configure: error: Either DirectWrite (on Windows), CoreText (on OSX), or
>>>> Fontconfig(Linux, other) is required. If you really want to compile
>>>> withouta system font provider, add
>>>> --disable-require-system-font-provider
>>>>
>>>> But, as the error messages says, we can allow the compilation without a
>>>> system font provider if we use the above configure option, so let's do
>>>> it.
>>>>
>>>> Fixes:
>>>>
>>>> http://autobuild.buildroot.net/results/3a4/3a4c07a0a54d5497fa8a4be2191856e286729637/
>>>>
>>>> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
>>>> ---
>>>> package/libass/libass.mk | 3 +++
>>>> 1 file changed, 3 insertions(+)
>>>>
>>>> diff --git a/package/libass/libass.mk b/package/libass/libass.mk
>>>> index 83939e2..f1ec503 100644
>>>> --- a/package/libass/libass.mk
>>>> +++ b/package/libass/libass.mk
>>>> @@ -24,6 +24,9 @@ ifeq ($(BR2_i386)$(BR2_x86_64),y)
>>>> LIBASS_DEPENDENCIES += host-yasm
>>>> endif
>>>>
>>>> +# Allow compilation without a system font provider
>>>> +LIBASS_CONF_OPTS = --disable-require-system-font-provider
>>>
>>> It is my understanding that fontconfig *is* a "system font provider", so
>>> maybe that should go n the else-case for fontconfig, below?
>>>
>>>> ifeq ($(BR2_PACKAGE_FONTCONFIG),y)
>>>> LIBASS_DEPENDENCIES += fontconfig
>>>> LIBASS_CONF_OPTS += --enable-fontconfig
>>> Here:
>>>
>>> else
>>> LIBASS_CONF_OPTS += \
>>> --disable-fontconfig \
>>> --disable-require-system-font-provider
>>> endif
>>
>> That was my first approach, but then I thought a bit more about it, and
>> I realized that there could be more system font providers in the future
>> (not only fontconfig). So, by using that option we enable the
>> possibility to build libass without a system font provider. That doesn't
>> mean necessarily that libass will be built without one. If the
>> fontconfig package is selected, it will be built with support for it.
>
> But since that is currently not the case (i.e. we have a single font
> provider), I think we should do as I suggest. When/if we have another
> font provider, then we can revisit that at that time.
With my approach we won't need to revisit it :P
> And I don't know what other font provider we'd have on Linux, beside
> fontconfig. Arguably, I'm not a font expert either! ;-)
Me neither.
Anyway, let's the maintainer decide.
Regards,
Vincent.
> Regards,
> Yann E. MORIN.
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH] libass: allow compilation without a system font provider
2015-12-09 17:30 ` Vicente Olivert Riera
@ 2015-12-13 17:00 ` Bernd Kuhls
0 siblings, 0 replies; 8+ messages in thread
From: Bernd Kuhls @ 2015-12-13 17:00 UTC (permalink / raw)
To: buildroot
Am Wed, 09 Dec 2015 17:30:24 +0000 schrieb Vicente Olivert Riera:
> Hi Yann,
>
> On 09/12/15 17:28, Yann E. MORIN wrote:
>> Vicente, All,
>>
>> On 2015-12-09 10:19 +0000, Vicente Olivert Riera spake thusly:
>>> On 08/12/15 17:16, Yann E. MORIN wrote:
>>>> On 2015-12-07 16:19 +0000, Vicente Olivert Riera spake thusly:
>>>>>
>>>>> +# Allow compilation without a system font provider
>>>>> +LIBASS_CONF_OPTS = --disable-require-system-font-provider
>>>>
>>>> It is my understanding that fontconfig *is* a "system font provider",
>>>> so maybe that should go n the else-case for fontconfig, below?
>>>>
>>>>> ifeq ($(BR2_PACKAGE_FONTCONFIG),y) LIBASS_DEPENDENCIES +=
>>>>> fontconfig LIBASS_CONF_OPTS += --enable-fontconfig
>>>> Here:
>>>>
>>>> else LIBASS_CONF_OPTS += \
>>>> --disable-fontconfig \ --disable-require-system-font-provider
>>>> endif
Hi Vicente, hi Yann,
reading your comments about this problem I created a patch
http://patchwork.ozlabs.org/patch/556201/
combining both of your approaches, what do you think?
Regards, Bernd
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-12-16 22:38 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-16 21:11 [Buildroot] [PATCH] libass: allow compilation without a system font provider Yann E. MORIN
2015-12-16 22:38 ` Thomas Petazzoni
-- strict thread matches above, loose matches on Subject: below --
2015-12-07 16:19 Vicente Olivert Riera
2015-12-08 17:16 ` Yann E. MORIN
2015-12-09 10:19 ` Vicente Olivert Riera
2015-12-09 17:28 ` Yann E. MORIN
2015-12-09 17:30 ` Vicente Olivert Riera
2015-12-13 17:00 ` Bernd Kuhls
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.