From: Michal Hocko <mhocko@kernel.org> To: Andrew Morton <akpm@linux-foundation.org> Cc: Linus Torvalds <torvalds@linux-foundation.org>, Mel Gorman <mgorman@suse.de>, Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>, David Rientjes <rientjes@google.com>, Oleg Nesterov <oleg@redhat.com>, Hugh Dickins <hughd@google.com>, Andrea Argangeli <andrea@kernel.org>, Rik van Riel <riel@redhat.com>, linux-mm <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 1/2] mm, oom: introduce oom reaper Date: Mon, 21 Dec 2015 09:38:14 +0100 [thread overview] Message-ID: <20151221083812.GB11089@dhcp22.suse.cz> (raw) In-Reply-To: <20151218131400.751bc4d582a947c9833c09eb@linux-foundation.org> On Fri 18-12-15 13:14:00, Andrew Morton wrote: > On Fri, 18 Dec 2015 12:54:55 +0100 Michal Hocko <mhocko@kernel.org> wrote: > > > /* Retry the down_read_trylock(mmap_sem) a few times */ > > - while (attempts++ < 10 && !__oom_reap_vmas(mm)) > > - msleep_interruptible(100); > > + while (attempts++ < 10 && !__oom_reap_vmas(mm)) { > > + __set_task_state(current, TASK_IDLE); > > + schedule_timeout(HZ/10); > > + } > > If you won't, I shall ;) > > > From: Andrew Morton <akpm@linux-foundation.org> > Subject: sched: add schedule_timeout_idle() > > This will be needed in the patch "mm, oom: introduce oom reaper". > > Cc: Michal Hocko <mhocko@kernel.org> > Cc: Ingo Molnar <mingo@elte.hu> > Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Thanks! This makes more sense. Acked-by: Michal Hocko <mhocko@suse.com> > --- > > include/linux/sched.h | 1 + > kernel/time/timer.c | 11 +++++++++++ > 2 files changed, 12 insertions(+) > > diff -puN kernel/time/timer.c~sched-add-schedule_timeout_idle kernel/time/timer.c > --- a/kernel/time/timer.c~sched-add-schedule_timeout_idle > +++ a/kernel/time/timer.c > @@ -1566,6 +1566,17 @@ signed long __sched schedule_timeout_uni > } > EXPORT_SYMBOL(schedule_timeout_uninterruptible); > > +/* > + * Like schedule_timeout_uninterruptible(), except this task will not contribute > + * to load average. > + */ > +signed long __sched schedule_timeout_idle(signed long timeout) > +{ > + __set_current_state(TASK_IDLE); > + return schedule_timeout(timeout); > +} > +EXPORT_SYMBOL(schedule_timeout_idle); > + > #ifdef CONFIG_HOTPLUG_CPU > static void migrate_timer_list(struct tvec_base *new_base, struct hlist_head *head) > { > diff -puN include/linux/sched.h~sched-add-schedule_timeout_idle include/linux/sched.h > --- a/include/linux/sched.h~sched-add-schedule_timeout_idle > +++ a/include/linux/sched.h > @@ -423,6 +423,7 @@ extern signed long schedule_timeout(sign > extern signed long schedule_timeout_interruptible(signed long timeout); > extern signed long schedule_timeout_killable(signed long timeout); > extern signed long schedule_timeout_uninterruptible(signed long timeout); > +extern signed long schedule_timeout_idle(signed long timeout); > asmlinkage void schedule(void); > extern void schedule_preempt_disabled(void); > > _ -- Michal Hocko SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org> To: Andrew Morton <akpm@linux-foundation.org> Cc: Linus Torvalds <torvalds@linux-foundation.org>, Mel Gorman <mgorman@suse.de>, Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>, David Rientjes <rientjes@google.com>, Oleg Nesterov <oleg@redhat.com>, Hugh Dickins <hughd@google.com>, Andrea Argangeli <andrea@kernel.org>, Rik van Riel <riel@redhat.com>, linux-mm <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 1/2] mm, oom: introduce oom reaper Date: Mon, 21 Dec 2015 09:38:14 +0100 [thread overview] Message-ID: <20151221083812.GB11089@dhcp22.suse.cz> (raw) In-Reply-To: <20151218131400.751bc4d582a947c9833c09eb@linux-foundation.org> On Fri 18-12-15 13:14:00, Andrew Morton wrote: > On Fri, 18 Dec 2015 12:54:55 +0100 Michal Hocko <mhocko@kernel.org> wrote: > > > /* Retry the down_read_trylock(mmap_sem) a few times */ > > - while (attempts++ < 10 && !__oom_reap_vmas(mm)) > > - msleep_interruptible(100); > > + while (attempts++ < 10 && !__oom_reap_vmas(mm)) { > > + __set_task_state(current, TASK_IDLE); > > + schedule_timeout(HZ/10); > > + } > > If you won't, I shall ;) > > > From: Andrew Morton <akpm@linux-foundation.org> > Subject: sched: add schedule_timeout_idle() > > This will be needed in the patch "mm, oom: introduce oom reaper". > > Cc: Michal Hocko <mhocko@kernel.org> > Cc: Ingo Molnar <mingo@elte.hu> > Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Thanks! This makes more sense. Acked-by: Michal Hocko <mhocko@suse.com> > --- > > include/linux/sched.h | 1 + > kernel/time/timer.c | 11 +++++++++++ > 2 files changed, 12 insertions(+) > > diff -puN kernel/time/timer.c~sched-add-schedule_timeout_idle kernel/time/timer.c > --- a/kernel/time/timer.c~sched-add-schedule_timeout_idle > +++ a/kernel/time/timer.c > @@ -1566,6 +1566,17 @@ signed long __sched schedule_timeout_uni > } > EXPORT_SYMBOL(schedule_timeout_uninterruptible); > > +/* > + * Like schedule_timeout_uninterruptible(), except this task will not contribute > + * to load average. > + */ > +signed long __sched schedule_timeout_idle(signed long timeout) > +{ > + __set_current_state(TASK_IDLE); > + return schedule_timeout(timeout); > +} > +EXPORT_SYMBOL(schedule_timeout_idle); > + > #ifdef CONFIG_HOTPLUG_CPU > static void migrate_timer_list(struct tvec_base *new_base, struct hlist_head *head) > { > diff -puN include/linux/sched.h~sched-add-schedule_timeout_idle include/linux/sched.h > --- a/include/linux/sched.h~sched-add-schedule_timeout_idle > +++ a/include/linux/sched.h > @@ -423,6 +423,7 @@ extern signed long schedule_timeout(sign > extern signed long schedule_timeout_interruptible(signed long timeout); > extern signed long schedule_timeout_killable(signed long timeout); > extern signed long schedule_timeout_uninterruptible(signed long timeout); > +extern signed long schedule_timeout_idle(signed long timeout); > asmlinkage void schedule(void); > extern void schedule_preempt_disabled(void); > > _ -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-12-21 8:38 UTC|newest] Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-12-15 18:36 [PATCH 1/2] mm, oom: introduce oom reaper Michal Hocko 2015-12-15 18:36 ` Michal Hocko 2015-12-17 0:50 ` Andrew Morton 2015-12-17 0:50 ` Andrew Morton 2015-12-17 13:02 ` Michal Hocko 2015-12-17 13:02 ` Michal Hocko 2015-12-17 19:55 ` Linus Torvalds 2015-12-17 19:55 ` Linus Torvalds 2015-12-17 20:00 ` Andrew Morton 2015-12-17 20:00 ` Andrew Morton 2015-12-18 11:54 ` Michal Hocko 2015-12-18 11:54 ` Michal Hocko 2015-12-18 21:14 ` Andrew Morton 2015-12-18 21:14 ` Andrew Morton 2015-12-21 8:38 ` Michal Hocko [this message] 2015-12-21 8:38 ` Michal Hocko 2015-12-17 21:13 ` Andrew Morton 2015-12-17 21:13 ` Andrew Morton 2015-12-18 12:11 ` Michal Hocko 2015-12-18 12:11 ` Michal Hocko 2015-12-18 12:10 ` Tetsuo Handa 2015-12-18 12:10 ` Tetsuo Handa 2015-12-20 7:14 ` Tetsuo Handa 2015-12-20 7:14 ` Tetsuo Handa 2015-12-18 0:15 ` Andrew Morton 2015-12-18 0:15 ` Andrew Morton 2015-12-18 11:48 ` Michal Hocko 2015-12-18 11:48 ` Michal Hocko 2015-12-21 20:38 ` Paul Gortmaker 2015-12-21 20:38 ` Paul Gortmaker 2016-01-06 9:10 ` Michal Hocko 2016-01-06 9:10 ` Michal Hocko 2016-01-06 14:26 ` Paul Gortmaker 2016-01-06 14:26 ` Paul Gortmaker 2016-01-06 15:00 ` Michal Hocko 2016-01-06 15:00 ` Michal Hocko 2015-12-23 23:00 ` Ross Zwisler 2015-12-23 23:00 ` Ross Zwisler 2015-12-24 9:47 ` Michal Hocko 2015-12-24 9:47 ` Michal Hocko 2015-12-24 11:06 ` Tetsuo Handa 2015-12-24 11:06 ` Tetsuo Handa 2015-12-24 20:39 ` Ross Zwisler 2015-12-24 20:39 ` Ross Zwisler 2015-12-25 11:41 ` Michal Hocko 2015-12-25 11:41 ` Michal Hocko 2015-12-24 20:44 ` Ross Zwisler 2015-12-24 20:44 ` Ross Zwisler 2015-12-25 11:35 ` Michal Hocko 2015-12-25 11:35 ` Michal Hocko 2015-12-25 11:44 ` Michal Hocko 2015-12-25 11:44 ` Michal Hocko 2016-01-06 15:42 [PATCH 0/2 -mm] oom reaper v4 Michal Hocko 2016-01-06 15:42 ` [PATCH 1/2] mm, oom: introduce oom reaper Michal Hocko 2016-01-06 15:42 ` Michal Hocko 2016-01-07 11:23 ` Tetsuo Handa 2016-01-07 11:23 ` Tetsuo Handa 2016-01-07 12:30 ` Michal Hocko 2016-01-07 12:30 ` Michal Hocko 2016-01-11 22:54 ` Andrew Morton 2016-01-11 22:54 ` Andrew Morton 2016-01-12 8:16 ` Michal Hocko 2016-01-12 8:16 ` Michal Hocko 2016-01-28 1:28 ` David Rientjes 2016-01-28 1:28 ` David Rientjes 2016-01-28 21:42 ` Michal Hocko 2016-01-28 21:42 ` Michal Hocko 2016-02-02 3:02 ` David Rientjes 2016-02-02 3:02 ` David Rientjes 2016-02-02 8:57 ` Michal Hocko 2016-02-02 8:57 ` Michal Hocko 2016-02-02 11:48 ` Tetsuo Handa 2016-02-02 11:48 ` Tetsuo Handa 2016-02-02 22:55 ` David Rientjes 2016-02-02 22:55 ` David Rientjes 2016-02-02 22:51 ` David Rientjes 2016-02-02 22:51 ` David Rientjes 2016-02-03 10:31 ` Tetsuo Handa 2016-02-03 10:31 ` Tetsuo Handa
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20151221083812.GB11089@dhcp22.suse.cz \ --to=mhocko@kernel.org \ --cc=akpm@linux-foundation.org \ --cc=andrea@kernel.org \ --cc=hughd@google.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mgorman@suse.de \ --cc=oleg@redhat.com \ --cc=penguin-kernel@i-love.sakura.ne.jp \ --cc=riel@redhat.com \ --cc=rientjes@google.com \ --cc=torvalds@linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.