From: Viresh Kumar <viresh.kumar@linaro.org> To: SF Markus Elfring <elfring@users.sourceforge.net> Cc: LKML <linux-kernel@vger.kernel.org>, linux-pm@vger.kernel.org, "Rafael J. Wysocki" <rjw@rjwysocki.net>, kernel-janitors@vger.kernel.org, Julia Lawall <julia.lawall@lip6.fr> Subject: Re: blackfin-cpufreq: How to mark cpu_set_cclk() as static? Date: Mon, 21 Dec 2015 15:23:08 +0530 [thread overview] Message-ID: <20151221095308.GE5532@ubuntu> (raw) In-Reply-To: <5677CB72.8090504@users.sourceforge.net> On 21-12-15, 10:50, SF Markus Elfring wrote: > In which order would you prefer that the properties of the > function "cpu_set_cclk" will be improved? > * Should the linkage specifier be added on a separate source code line? No, it can be there in the same line. > * Can this fix be combined with my previous update suggestion for > the return type? I think the first patch is already Acked now and can be applied as it is. Just send the next patch based on the previous one. -- viresh
WARNING: multiple messages have this Message-ID (diff)
From: Viresh Kumar <viresh.kumar@linaro.org> To: SF Markus Elfring <elfring@users.sourceforge.net> Cc: LKML <linux-kernel@vger.kernel.org>, linux-pm@vger.kernel.org, "Rafael J. Wysocki" <rjw@rjwysocki.net>, kernel-janitors@vger.kernel.org, Julia Lawall <julia.lawall@lip6.fr> Subject: Re: blackfin-cpufreq: How to mark cpu_set_cclk() as static? Date: Mon, 21 Dec 2015 09:53:29 +0000 [thread overview] Message-ID: <20151221095308.GE5532@ubuntu> (raw) In-Reply-To: <5677CB72.8090504@users.sourceforge.net> On 21-12-15, 10:50, SF Markus Elfring wrote: > In which order would you prefer that the properties of the > function "cpu_set_cclk" will be improved? > * Should the linkage specifier be added on a separate source code line? No, it can be there in the same line. > * Can this fix be combined with my previous update suggestion for > the return type? I think the first patch is already Acked now and can be applied as it is. Just send the next patch based on the previous one. -- viresh
next prev parent reply other threads:[~2015-12-21 9:53 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-12-18 19:07 [PATCH] blackfin-cpufreq: Change return type of cpu_set_cclk() to that of clk_set_rate() SF Markus Elfring 2015-12-18 19:07 ` SF Markus Elfring 2015-12-19 1:59 ` Viresh Kumar 2015-12-19 2:11 ` Viresh Kumar 2015-12-19 8:23 ` SF Markus Elfring 2015-12-19 8:23 ` SF Markus Elfring 2015-12-21 3:17 ` Viresh Kumar 2015-12-21 3:29 ` Viresh Kumar 2015-12-21 9:20 ` blackfin-cpufreq: How to mark cpu_set_cclk() as static? SF Markus Elfring 2015-12-21 9:20 ` SF Markus Elfring 2015-12-21 9:28 ` Viresh Kumar 2015-12-21 9:40 ` Viresh Kumar 2015-12-21 9:50 ` SF Markus Elfring 2015-12-21 9:50 ` SF Markus Elfring 2015-12-21 9:53 ` Viresh Kumar [this message] 2015-12-21 9:53 ` Viresh Kumar 2015-12-21 10:00 ` SF Markus Elfring 2015-12-21 10:00 ` SF Markus Elfring 2015-12-21 10:04 ` Viresh Kumar 2015-12-21 10:16 ` Viresh Kumar 2015-12-21 21:28 ` [PATCH 0/2] blackfin-cpufreq: Fine-tuning for properties of one function SF Markus Elfring 2015-12-21 21:28 ` SF Markus Elfring 2015-12-21 21:30 ` [PATCH 1/2] blackfin-cpufreq: Change return type of cpu_set_cclk() to that of clk_set_rate() SF Markus Elfring 2015-12-21 21:30 ` SF Markus Elfring 2015-12-21 21:32 ` [PATCH 2/2] blackfin-cpufreq: Mark cpu_set_cclk() as static SF Markus Elfring 2015-12-21 21:32 ` SF Markus Elfring 2015-12-22 5:35 ` Viresh Kumar 2015-12-22 5:47 ` Viresh Kumar 2015-12-22 8:29 ` SF Markus Elfring 2015-12-22 8:29 ` SF Markus Elfring 2015-12-22 8:31 ` Viresh Kumar 2015-12-22 8:43 ` Viresh Kumar 2016-01-03 0:31 ` [PATCH 2/2] " Rafael J. Wysocki 2016-01-03 1:02 ` Rafael J. Wysocki
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20151221095308.GE5532@ubuntu \ --to=viresh.kumar@linaro.org \ --cc=elfring@users.sourceforge.net \ --cc=julia.lawall@lip6.fr \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=rjw@rjwysocki.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.