* [Buildroot] [PATCH 1/1] emlog: new package
@ 2015-12-18 13:44 Joris Lijssens
2015-12-18 16:07 ` Thomas Petazzoni
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Joris Lijssens @ 2015-12-18 13:44 UTC (permalink / raw)
To: buildroot
Signed-off-by: Joris Lijssens <joris.lijssens@gmail.com>
---
package/Config.in | 1 +
package/emlog/Config.in | 12 ++++++++++++
package/emlog/emlog.hash | 2 ++
package/emlog/emlog.mk | 21 +++++++++++++++++++++
4 files changed, 36 insertions(+)
create mode 100644 package/emlog/Config.in
create mode 100644 package/emlog/emlog.hash
create mode 100644 package/emlog/emlog.mk
diff --git a/package/Config.in b/package/Config.in
index c78baac..dfa4d3b 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1515,6 +1515,7 @@ if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
source "package/debianutils/Config.in"
endif
source "package/dsp-tools/Config.in"
+ source "package/emlog/Config.in"
source "package/ftop/Config.in"
source "package/getent/Config.in"
source "package/htop/Config.in"
diff --git a/package/emlog/Config.in b/package/emlog/Config.in
new file mode 100644
index 0000000..85a9ed6
--- /dev/null
+++ b/package/emlog/Config.in
@@ -0,0 +1,12 @@
+config BR2_PACKAGE_EMLOG
+ bool "emlog"
+ help
+ emlog is a Linux kernel module that makes it easy to access the most
+ recent (and only the most recent) output from a process. It works
+ just like "tail -f" on a log file, except that the storage required
+ never grows. This can be useful in embedded systems where there isn't
+ enough memory or disk space for keeping complete log files, but the
+ most recent debugging messages are sometimes needed (e.g., after an
+ error is observed).
+
+ https://github.com/nicupavel/emlog
diff --git a/package/emlog/emlog.hash b/package/emlog/emlog.hash
new file mode 100644
index 0000000..ab729f8
--- /dev/null
+++ b/package/emlog/emlog.hash
@@ -0,0 +1,2 @@
+# Locally calculated
+sha256 37b03b79684245ddcb33cfff388a7f2d74f465f2e1fce4f661b81726f5ccd595 emlog-0.52.tar.gz
diff --git a/package/emlog/emlog.mk b/package/emlog/emlog.mk
new file mode 100644
index 0000000..d368652
--- /dev/null
+++ b/package/emlog/emlog.mk
@@ -0,0 +1,21 @@
+################################################################################
+#
+# emlog
+#
+################################################################################
+
+EMLOG_VERSION = 0.52
+EMLOG_SITE = $(call github,nicupavel,emlog,emlog-$(EMLOG_VERSION))
+EMLOG_LICENSE = GPLv2
+EMLOG_LICENSE_FILES = COPYING
+
+define EMLOG_BUILD_CMDS
+ $(MAKE) CC="$(TARGET_CC)" CFLAGS="$(TARGET_CFLAGS)" -C $(@D) nbcat
+endef
+
+define EMLOG_INSTALL_TARGET_CMDS
+ $(INSTALL) -m 0755 $(@D)/nbcat $(TARGET_DIR)/usr/bin
+endef
+
+$(eval $(kernel-module))
+$(eval $(generic-package))
--
1.8.3.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Buildroot] [PATCH 1/1] emlog: new package
2015-12-18 13:44 [Buildroot] [PATCH 1/1] emlog: new package Joris Lijssens
@ 2015-12-18 16:07 ` Thomas Petazzoni
2015-12-20 16:06 ` Arnout Vandecappelle
2015-12-21 22:52 ` Thomas Petazzoni
2 siblings, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2015-12-18 16:07 UTC (permalink / raw)
To: buildroot
Joris,
On Fri, 18 Dec 2015 14:44:58 +0100, Joris Lijssens wrote:
> Signed-off-by: Joris Lijssens <joris.lijssens@gmail.com>
> ---
> package/Config.in | 1 +
> package/emlog/Config.in | 12 ++++++++++++
> package/emlog/emlog.hash | 2 ++
> package/emlog/emlog.mk | 21 +++++++++++++++++++++
> 4 files changed, 36 insertions(+)
> create mode 100644 package/emlog/Config.in
> create mode 100644 package/emlog/emlog.hash
> create mode 100644 package/emlog/emlog.mk
I guess this is a new version of the emlog patch, right?
If so, a new iteration should be labeled as "PATCH v2" and should carry
a changelog. See
https://buildroot.org/downloads/manual/manual.html#submitting-patches.
This helps us a lot to understand what has changed between the
different iterations of a patch.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] emlog: new package
2015-12-18 13:44 [Buildroot] [PATCH 1/1] emlog: new package Joris Lijssens
2015-12-18 16:07 ` Thomas Petazzoni
@ 2015-12-20 16:06 ` Arnout Vandecappelle
2015-12-21 22:52 ` Thomas Petazzoni
2 siblings, 0 replies; 6+ messages in thread
From: Arnout Vandecappelle @ 2015-12-20 16:06 UTC (permalink / raw)
To: buildroot
On 18-12-15 14:44, Joris Lijssens wrote:
> Signed-off-by: Joris Lijssens <joris.lijssens@gmail.com>
> ---
> package/Config.in | 1 +
> package/emlog/Config.in | 12 ++++++++++++
> package/emlog/emlog.hash | 2 ++
> package/emlog/emlog.mk | 21 +++++++++++++++++++++
> 4 files changed, 36 insertions(+)
> create mode 100644 package/emlog/Config.in
> create mode 100644 package/emlog/emlog.hash
> create mode 100644 package/emlog/emlog.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index c78baac..dfa4d3b 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1515,6 +1515,7 @@ if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
> source "package/debianutils/Config.in"
> endif
> source "package/dsp-tools/Config.in"
> + source "package/emlog/Config.in"
> source "package/ftop/Config.in"
> source "package/getent/Config.in"
> source "package/htop/Config.in"
> diff --git a/package/emlog/Config.in b/package/emlog/Config.in
> new file mode 100644
> index 0000000..85a9ed6
> --- /dev/null
> +++ b/package/emlog/Config.in
> @@ -0,0 +1,12 @@
> +config BR2_PACKAGE_EMLOG
> + bool "emlog"
> + help
> + emlog is a Linux kernel module that makes it easy to access the most
> + recent (and only the most recent) output from a process. It works
> + just like "tail -f" on a log file, except that the storage required
> + never grows. This can be useful in embedded systems where there isn't
> + enough memory or disk space for keeping complete log files, but the
> + most recent debugging messages are sometimes needed (e.g., after an
> + error is observed).
> +
> + https://github.com/nicupavel/emlog
> diff --git a/package/emlog/emlog.hash b/package/emlog/emlog.hash
> new file mode 100644
> index 0000000..ab729f8
> --- /dev/null
> +++ b/package/emlog/emlog.hash
> @@ -0,0 +1,2 @@
> +# Locally calculated
> +sha256 37b03b79684245ddcb33cfff388a7f2d74f465f2e1fce4f661b81726f5ccd595 emlog-0.52.tar.gz
> diff --git a/package/emlog/emlog.mk b/package/emlog/emlog.mk
> new file mode 100644
> index 0000000..d368652
> --- /dev/null
> +++ b/package/emlog/emlog.mk
> @@ -0,0 +1,21 @@
> +################################################################################
> +#
> +# emlog
> +#
> +################################################################################
> +
> +EMLOG_VERSION = 0.52
> +EMLOG_SITE = $(call github,nicupavel,emlog,emlog-$(EMLOG_VERSION))
> +EMLOG_LICENSE = GPLv2
> +EMLOG_LICENSE_FILES = COPYING
> +
> +define EMLOG_BUILD_CMDS
> + $(MAKE) CC="$(TARGET_CC)" CFLAGS="$(TARGET_CFLAGS)" -C $(@D) nbcat
Doesn't $(TARGET_CONFIGURE_OPTS) work here? If not, it's better to explain that
in the commit message.
> +endef
> +
> +define EMLOG_INSTALL_TARGET_CMDS
> + $(INSTALL) -m 0755 $(@D)/nbcat $(TARGET_DIR)/usr/bin
Also here a comment would be good:
# make install tries to strip, so install manually.
Otherwise, looks good to me, so you can add my
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Regards,
Arnout
> +endef
> +
> +$(eval $(kernel-module))
> +$(eval $(generic-package))
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] emlog: new package
2015-12-18 13:44 [Buildroot] [PATCH 1/1] emlog: new package Joris Lijssens
2015-12-18 16:07 ` Thomas Petazzoni
2015-12-20 16:06 ` Arnout Vandecappelle
@ 2015-12-21 22:52 ` Thomas Petazzoni
2 siblings, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2015-12-21 22:52 UTC (permalink / raw)
To: buildroot
Joris,
On Fri, 18 Dec 2015 14:44:58 +0100, Joris Lijssens wrote:
> diff --git a/package/emlog/Config.in b/package/emlog/Config.in
> new file mode 100644
> index 0000000..85a9ed6
> --- /dev/null
> +++ b/package/emlog/Config.in
> @@ -0,0 +1,12 @@
> +config BR2_PACKAGE_EMLOG
> + bool "emlog"
> + help
> + emlog is a Linux kernel module that makes it easy to access the most
> + recent (and only the most recent) output from a process. It works
> + just like "tail -f" on a log file, except that the storage required
> + never grows. This can be useful in embedded systems where there isn't
> + enough memory or disk space for keeping complete log files, but the
> + most recent debugging messages are sometimes needed (e.g., after an
> + error is observed).
> +
> + https://github.com/nicupavel/emlog
I did not spot this during the previous review, and Arnout also didn't
spot it apparently, so maybe I'm missing something.
emlog is a kernel module, so surely it needs the Linux kernel to be
built beforehand. So your package should "depends on BR2_LINUX_KERNEL"
and have "linux" in EMLOG_DEPENDENCIES. Otherwise, I don't see how it
can even build.
Could you look into this, as well as the comments from Arnout, and
resend an updated version of your patch?
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] emlog:new package
@ 2015-12-04 10:22 Joris Lijssens
2015-12-17 21:42 ` Yann E. MORIN
0 siblings, 1 reply; 6+ messages in thread
From: Joris Lijssens @ 2015-12-04 10:22 UTC (permalink / raw)
To: buildroot
Signed-off-by: Joris Lijssens <joris.lijssens@gmail.com>
---
package/Config.in | 1 +
package/emlog/Config.in | 12 ++++++++++++
package/emlog/emlog.hash | 2 ++
package/emlog/emlog.mk | 26 ++++++++++++++++++++++++++
4 files changed, 41 insertions(+)
create mode 100644 package/emlog/Config.in
create mode 100644 package/emlog/emlog.hash
create mode 100644 package/emlog/emlog.mk
diff --git a/package/Config.in b/package/Config.in
index 2bdad01..c862c40 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1499,6 +1499,7 @@ if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
source "package/debianutils/Config.in"
endif
source "package/dsp-tools/Config.in"
+ source "package/emlog/Config.in"
source "package/ftop/Config.in"
source "package/getent/Config.in"
source "package/htop/Config.in"
diff --git a/package/emlog/Config.in b/package/emlog/Config.in
new file mode 100644
index 0000000..85a9ed6
--- /dev/null
+++ b/package/emlog/Config.in
@@ -0,0 +1,12 @@
+config BR2_PACKAGE_EMLOG
+ bool "emlog"
+ help
+ emlog is a Linux kernel module that makes it easy to access the most
+ recent (and only the most recent) output from a process. It works
+ just like "tail -f" on a log file, except that the storage required
+ never grows. This can be useful in embedded systems where there isn't
+ enough memory or disk space for keeping complete log files, but the
+ most recent debugging messages are sometimes needed (e.g., after an
+ error is observed).
+
+ https://github.com/nicupavel/emlog
diff --git a/package/emlog/emlog.hash b/package/emlog/emlog.hash
new file mode 100644
index 0000000..ab729f8
--- /dev/null
+++ b/package/emlog/emlog.hash
@@ -0,0 +1,2 @@
+# Locally calculated
+sha256 37b03b79684245ddcb33cfff388a7f2d74f465f2e1fce4f661b81726f5ccd595 emlog-0.52.tar.gz
diff --git a/package/emlog/emlog.mk b/package/emlog/emlog.mk
new file mode 100644
index 0000000..9264849
--- /dev/null
+++ b/package/emlog/emlog.mk
@@ -0,0 +1,26 @@
+################################################################################
+#
+# emlog
+#
+################################################################################
+
+EMLOG_VERSION = 0.52
+EMLOG_SITE = $(call github,nicupavel,emlog,emlog-$(EMLOG_VERSION))
+EMLOG_LICENSE = GPLv2
+EMLOG_LICENSE_FILES = COPYING
+
+EMLOG_DEPENDENCIES = linux
+
+define EMLOG_BUILD_CMDS
+ $(MAKE) $(LINUX_MAKE_FLAGS) -C $(LINUX_DIR) M=$(@D) modules
+ $(MAKE) CC="$(TARGET_CC)" CFLAGS="$(TARGET_CFLAGS)" -C $(@D) nbcat
+endef
+
+define EMLOG_INSTALL_TARGET_CMDS
+ $(MAKE) $(LINUX_MAKE_FLAGS) -C $(LINUX_DIR) M=$(@D) \
+ INSTALL_MOD_STRIP=1 \
+ modules_install
+ $(INSTALL) -m 0755 $(@D)/nbcat $(TARGET_DIR)/usr/bin
+endef
+
+$(eval $(generic-package))
--
1.8.3.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] emlog:new package
2015-12-04 10:22 [Buildroot] [PATCH 1/1] emlog:new package Joris Lijssens
@ 2015-12-17 21:42 ` Yann E. MORIN
0 siblings, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2015-12-17 21:42 UTC (permalink / raw)
To: buildroot
Joris, All,
On 2015-12-04 11:22 +0100, Joris Lijssens spake thusly:
> Signed-off-by: Joris Lijssens <joris.lijssens@gmail.com>
> ---
[--SNIP--]
> diff --git a/package/emlog/emlog.mk b/package/emlog/emlog.mk
> new file mode 100644
> index 0000000..9264849
> --- /dev/null
> +++ b/package/emlog/emlog.mk
> @@ -0,0 +1,26 @@
> +################################################################################
> +#
> +# emlog
> +#
> +################################################################################
> +
> +EMLOG_VERSION = 0.52
> +EMLOG_SITE = $(call github,nicupavel,emlog,emlog-$(EMLOG_VERSION))
> +EMLOG_LICENSE = GPLv2
> +EMLOG_LICENSE_FILES = COPYING
> +
> +EMLOG_DEPENDENCIES = linux
> +
> +define EMLOG_BUILD_CMDS
> + $(MAKE) $(LINUX_MAKE_FLAGS) -C $(LINUX_DIR) M=$(@D) modules
> + $(MAKE) CC="$(TARGET_CC)" CFLAGS="$(TARGET_CFLAGS)" -C $(@D) nbcat
> +endef
> +
> +define EMLOG_INSTALL_TARGET_CMDS
> + $(MAKE) $(LINUX_MAKE_FLAGS) -C $(LINUX_DIR) M=$(@D) \
> + INSTALL_MOD_STRIP=1 \
> + modules_install
> + $(INSTALL) -m 0755 $(@D)/nbcat $(TARGET_DIR)/usr/bin
> +endef
As far as I can see, this is using the standrad Linux out-of-tree
external module mechanism to build the emlog module. Buildroot has
an infrastructure to help write packages that build a kernel module:
https://buildroot.org/downloads/manual/manual.html#_infrastructure_for_packages_building_kernel_modules
Thomas and I believe emlog should use that kernel-module infra.
You just need to handle the nbcat userland utility with the
generic-package infra.
Care to update and respin, please?
In the meantime, I'm marking this patch as "Changes Requested" in our
Patchwork.
Thanks! :-)
> +$(eval $(generic-package))
> --
> 1.8.3.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-12-21 22:52 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-18 13:44 [Buildroot] [PATCH 1/1] emlog: new package Joris Lijssens
2015-12-18 16:07 ` Thomas Petazzoni
2015-12-20 16:06 ` Arnout Vandecappelle
2015-12-21 22:52 ` Thomas Petazzoni
-- strict thread matches above, loose matches on Subject: below --
2015-12-04 10:22 [Buildroot] [PATCH 1/1] emlog:new package Joris Lijssens
2015-12-17 21:42 ` Yann E. MORIN
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.