* [PATCH] ARM: shmobile: alt: Add QSPI device to DT @ 2015-11-30 6:13 ` Simon Horman 0 siblings, 0 replies; 18+ messages in thread From: Simon Horman @ 2015-11-30 6:13 UTC (permalink / raw) To: linux-arm-kernel Enable the QSPI controller in the alt device tree. Based similar work for the silk board by by Vladimir Barinov and Sergei Shtylyov. Cc: Vladimir Barinov <vladimir.barinov@cogentembedded.com> Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Signed-off-by: Simon Horman <horms+renesas@verge.net.au> --- Testedon top of renesas-devel-20151126-v4.4-rc2. Read /dev/mtd0 with 512K blocks at 6.5Mb/s --- arch/arm/boot/dts/r8a7794-alt.dts | 45 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+) diff --git a/arch/arm/boot/dts/r8a7794-alt.dts b/arch/arm/boot/dts/r8a7794-alt.dts index 767d9224d6cc..0dae87639328 100644 --- a/arch/arm/boot/dts/r8a7794-alt.dts +++ b/arch/arm/boot/dts/r8a7794-alt.dts @@ -138,6 +138,13 @@ status = "okay"; }; +&pfc { + qspi_pins: spi0 { + renesas,groups = "qspi_ctrl", "qspi_data4"; + renesas,function = "qspi"; + }; +}; + ðer { pinctrl-0 = <ðer_pins &phy1_pins>; pinctrl-names = "default"; @@ -197,3 +204,41 @@ status = "okay"; }; + +&qspi { + pinctrl-0 = <&qspi_pins>; + pinctrl-names = "default"; + + status = "okay"; + + flash@0 { + compatible = "spansion,s25fl512s", "jedec,spi-nor"; + reg = <0>; + spi-max-frequency = <30000000>; + spi-tx-bus-width = <4>; + spi-rx-bus-width = <4>; + spi-cpol; + spi-cpha; + m25p,fast-read; + + partitions { + #address-cells = <1>; + #size-cells = <1>; + + partition@0 { + label = "loader"; + reg = <0x00000000 0x00040000>; + read-only; + }; + partition@40000 { + label = "user"; + reg = <0x00040000 0x00400000>; + read-only; + }; + partition@440000 { + label = "flash"; + reg = <0x00440000 0x03bc0000>; + }; + }; + }; +}; -- 2.1.4 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH] ARM: shmobile: alt: Add QSPI device to DT @ 2015-11-30 6:13 ` Simon Horman 0 siblings, 0 replies; 18+ messages in thread From: Simon Horman @ 2015-11-30 6:13 UTC (permalink / raw) To: linux-arm-kernel Enable the QSPI controller in the alt device tree. Based similar work for the silk board by by Vladimir Barinov and Sergei Shtylyov. Cc: Vladimir Barinov <vladimir.barinov@cogentembedded.com> Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Signed-off-by: Simon Horman <horms+renesas@verge.net.au> --- Testedon top of renesas-devel-20151126-v4.4-rc2. Read /dev/mtd0 with 512K blocks at 6.5Mb/s --- arch/arm/boot/dts/r8a7794-alt.dts | 45 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+) diff --git a/arch/arm/boot/dts/r8a7794-alt.dts b/arch/arm/boot/dts/r8a7794-alt.dts index 767d9224d6cc..0dae87639328 100644 --- a/arch/arm/boot/dts/r8a7794-alt.dts +++ b/arch/arm/boot/dts/r8a7794-alt.dts @@ -138,6 +138,13 @@ status = "okay"; }; +&pfc { + qspi_pins: spi0 { + renesas,groups = "qspi_ctrl", "qspi_data4"; + renesas,function = "qspi"; + }; +}; + ðer { pinctrl-0 = <ðer_pins &phy1_pins>; pinctrl-names = "default"; @@ -197,3 +204,41 @@ status = "okay"; }; + +&qspi { + pinctrl-0 = <&qspi_pins>; + pinctrl-names = "default"; + + status = "okay"; + + flash at 0 { + compatible = "spansion,s25fl512s", "jedec,spi-nor"; + reg = <0>; + spi-max-frequency = <30000000>; + spi-tx-bus-width = <4>; + spi-rx-bus-width = <4>; + spi-cpol; + spi-cpha; + m25p,fast-read; + + partitions { + #address-cells = <1>; + #size-cells = <1>; + + partition at 0 { + label = "loader"; + reg = <0x00000000 0x00040000>; + read-only; + }; + partition at 40000 { + label = "user"; + reg = <0x00040000 0x00400000>; + read-only; + }; + partition at 440000 { + label = "flash"; + reg = <0x00440000 0x03bc0000>; + }; + }; + }; +}; -- 2.1.4 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH] ARM: shmobile: alt: Add QSPI device to DT 2015-11-30 6:13 ` Simon Horman @ 2015-11-30 8:34 ` Geert Uytterhoeven -1 siblings, 0 replies; 18+ messages in thread From: Geert Uytterhoeven @ 2015-11-30 8:34 UTC (permalink / raw) To: linux-arm-kernel On Mon, Nov 30, 2015 at 7:13 AM, Simon Horman <horms+renesas@verge.net.au> wrote: > Enable the QSPI controller in the alt device tree. > > Based similar work for the silk board by by Vladimir Barinov and > Sergei Shtylyov. > > Cc: Vladimir Barinov <vladimir.barinov@cogentembedded.com> > Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> Verified against Alt schematics and r8a7794 datasheet. Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> I can't verify the FLASH layout. Note that p.11 of ALT_MiniMonitor_Manual(SPI_Boot)_Rev0.01_e.pdf shows a different FLASH layout for the second and third partition. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH] ARM: shmobile: alt: Add QSPI device to DT @ 2015-11-30 8:34 ` Geert Uytterhoeven 0 siblings, 0 replies; 18+ messages in thread From: Geert Uytterhoeven @ 2015-11-30 8:34 UTC (permalink / raw) To: linux-arm-kernel On Mon, Nov 30, 2015 at 7:13 AM, Simon Horman <horms+renesas@verge.net.au> wrote: > Enable the QSPI controller in the alt device tree. > > Based similar work for the silk board by by Vladimir Barinov and > Sergei Shtylyov. > > Cc: Vladimir Barinov <vladimir.barinov@cogentembedded.com> > Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> Verified against Alt schematics and r8a7794 datasheet. Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> I can't verify the FLASH layout. Note that p.11 of ALT_MiniMonitor_Manual(SPI_Boot)_Rev0.01_e.pdf shows a different FLASH layout for the second and third partition. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] ARM: shmobile: alt: Add QSPI device to DT 2015-11-30 8:34 ` Geert Uytterhoeven @ 2015-12-01 6:41 ` Simon Horman -1 siblings, 0 replies; 18+ messages in thread From: Simon Horman @ 2015-12-01 6:41 UTC (permalink / raw) To: linux-arm-kernel On Mon, Nov 30, 2015 at 09:34:10AM +0100, Geert Uytterhoeven wrote: > On Mon, Nov 30, 2015 at 7:13 AM, Simon Horman > <horms+renesas@verge.net.au> wrote: > > Enable the QSPI controller in the alt device tree. > > > > Based similar work for the silk board by by Vladimir Barinov and > > Sergei Shtylyov. > > > > Cc: Vladimir Barinov <vladimir.barinov@cogentembedded.com> > > Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > Verified against Alt schematics and r8a7794 datasheet. > > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> > > I can't verify the FLASH layout. Note that p.11 of > ALT_MiniMonitor_Manual(SPI_Boot)_Rev0.01_e.pdf shows a different > FLASH layout for the second and third partition. Thanks. I see the following in v1.9.6 of the BSP[1]. Is it the same as the document you referred to above? partition@0 { label = "loader"; reg = <0x00000000 0x00080000>; read-only; }; partition@40000 { label = "user"; reg = <0x00080000 0x00580000>; read-only; }; partition@440000 { label = "flash"; reg = <0x00600000 0x03a00000>; }; [1] https://git.kernel.org/cgit/linux/kernel/git/horms/renesas-backport.git/tree/arch/arm/boot/dts/r8a7794-alt.dts?h=rcar-gen2/v1.9.6&idáacbe074f36d96e901bf5346c50ee51da2ced42#n379 ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH] ARM: shmobile: alt: Add QSPI device to DT @ 2015-12-01 6:41 ` Simon Horman 0 siblings, 0 replies; 18+ messages in thread From: Simon Horman @ 2015-12-01 6:41 UTC (permalink / raw) To: linux-arm-kernel On Mon, Nov 30, 2015 at 09:34:10AM +0100, Geert Uytterhoeven wrote: > On Mon, Nov 30, 2015 at 7:13 AM, Simon Horman > <horms+renesas@verge.net.au> wrote: > > Enable the QSPI controller in the alt device tree. > > > > Based similar work for the silk board by by Vladimir Barinov and > > Sergei Shtylyov. > > > > Cc: Vladimir Barinov <vladimir.barinov@cogentembedded.com> > > Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > Verified against Alt schematics and r8a7794 datasheet. > > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> > > I can't verify the FLASH layout. Note that p.11 of > ALT_MiniMonitor_Manual(SPI_Boot)_Rev0.01_e.pdf shows a different > FLASH layout for the second and third partition. Thanks. I see the following in v1.9.6 of the BSP[1]. Is it the same as the document you referred to above? partition at 0 { label = "loader"; reg = <0x00000000 0x00080000>; read-only; }; partition at 40000 { label = "user"; reg = <0x00080000 0x00580000>; read-only; }; partition at 440000 { label = "flash"; reg = <0x00600000 0x03a00000>; }; [1] https://git.kernel.org/cgit/linux/kernel/git/horms/renesas-backport.git/tree/arch/arm/boot/dts/r8a7794-alt.dts?h=rcar-gen2/v1.9.6&id=e1acbe074f36d96e901bf5346c50ee51da2ced42#n379 ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] ARM: shmobile: alt: Add QSPI device to DT 2015-12-01 6:41 ` Simon Horman @ 2015-12-01 8:06 ` Geert Uytterhoeven -1 siblings, 0 replies; 18+ messages in thread From: Geert Uytterhoeven @ 2015-12-01 8:06 UTC (permalink / raw) To: linux-arm-kernel Hi Simon, On Tue, Dec 1, 2015 at 7:41 AM, Simon Horman <horms@verge.net.au> wrote: > On Mon, Nov 30, 2015 at 09:34:10AM +0100, Geert Uytterhoeven wrote: >> On Mon, Nov 30, 2015 at 7:13 AM, Simon Horman >> <horms+renesas@verge.net.au> wrote: >> > Enable the QSPI controller in the alt device tree. >> > >> > Based similar work for the silk board by by Vladimir Barinov and >> > Sergei Shtylyov. >> > >> > Cc: Vladimir Barinov <vladimir.barinov@cogentembedded.com> >> > Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> >> >> Verified against Alt schematics and r8a7794 datasheet. >> >> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> >> >> I can't verify the FLASH layout. Note that p.11 of >> ALT_MiniMonitor_Manual(SPI_Boot)_Rev0.01_e.pdf shows a different >> FLASH layout for the second and third partition. > > Thanks. I see the following in v1.9.6 of the BSP[1]. Is it > the same as the document you referred to above? > > > partition@0 { > label = "loader"; > reg = <0x00000000 0x00080000>; > read-only; > }; > partition@40000 { > label = "user"; > reg = <0x00080000 0x00580000>; > read-only; > }; > partition@440000 { > label = "flash"; > reg = <0x00600000 0x03a00000>; > }; > > > [1] https://git.kernel.org/cgit/linux/kernel/git/horms/renesas-backport.git/tree/arch/arm/boot/dts/r8a7794-alt.dts?h=rcar-gen2/v1.9.6&idáacbe074f36d96e901bf5346c50ee51da2ced42#n379 No, the document specifies 3 partitions: - SA0: loader program area, 16 KiB, - SA1: System area, 16 KiB, - SA2: User program area, remainder. FWIW, the unit addresses in the device nodes above are not consistent with their reg properties. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH] ARM: shmobile: alt: Add QSPI device to DT @ 2015-12-01 8:06 ` Geert Uytterhoeven 0 siblings, 0 replies; 18+ messages in thread From: Geert Uytterhoeven @ 2015-12-01 8:06 UTC (permalink / raw) To: linux-arm-kernel Hi Simon, On Tue, Dec 1, 2015 at 7:41 AM, Simon Horman <horms@verge.net.au> wrote: > On Mon, Nov 30, 2015 at 09:34:10AM +0100, Geert Uytterhoeven wrote: >> On Mon, Nov 30, 2015 at 7:13 AM, Simon Horman >> <horms+renesas@verge.net.au> wrote: >> > Enable the QSPI controller in the alt device tree. >> > >> > Based similar work for the silk board by by Vladimir Barinov and >> > Sergei Shtylyov. >> > >> > Cc: Vladimir Barinov <vladimir.barinov@cogentembedded.com> >> > Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> >> >> Verified against Alt schematics and r8a7794 datasheet. >> >> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> >> >> I can't verify the FLASH layout. Note that p.11 of >> ALT_MiniMonitor_Manual(SPI_Boot)_Rev0.01_e.pdf shows a different >> FLASH layout for the second and third partition. > > Thanks. I see the following in v1.9.6 of the BSP[1]. Is it > the same as the document you referred to above? > > > partition at 0 { > label = "loader"; > reg = <0x00000000 0x00080000>; > read-only; > }; > partition at 40000 { > label = "user"; > reg = <0x00080000 0x00580000>; > read-only; > }; > partition at 440000 { > label = "flash"; > reg = <0x00600000 0x03a00000>; > }; > > > [1] https://git.kernel.org/cgit/linux/kernel/git/horms/renesas-backport.git/tree/arch/arm/boot/dts/r8a7794-alt.dts?h=rcar-gen2/v1.9.6&id=e1acbe074f36d96e901bf5346c50ee51da2ced42#n379 No, the document specifies 3 partitions: - SA0: loader program area, 16 KiB, - SA1: System area, 16 KiB, - SA2: User program area, remainder. FWIW, the unit addresses in the device nodes above are not consistent with their reg properties. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] ARM: shmobile: alt: Add QSPI device to DT 2015-12-01 8:06 ` Geert Uytterhoeven @ 2015-12-18 2:54 ` Simon Horman -1 siblings, 0 replies; 18+ messages in thread From: Simon Horman @ 2015-12-18 2:54 UTC (permalink / raw) To: linux-arm-kernel On Tue, Dec 01, 2015 at 09:06:17AM +0100, Geert Uytterhoeven wrote: > Hi Simon, > > On Tue, Dec 1, 2015 at 7:41 AM, Simon Horman <horms@verge.net.au> wrote: > > On Mon, Nov 30, 2015 at 09:34:10AM +0100, Geert Uytterhoeven wrote: > >> On Mon, Nov 30, 2015 at 7:13 AM, Simon Horman > >> <horms+renesas@verge.net.au> wrote: > >> > Enable the QSPI controller in the alt device tree. > >> > > >> > Based similar work for the silk board by by Vladimir Barinov and > >> > Sergei Shtylyov. > >> > > >> > Cc: Vladimir Barinov <vladimir.barinov@cogentembedded.com> > >> > Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > >> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > >> > >> Verified against Alt schematics and r8a7794 datasheet. > >> > >> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> > >> > >> I can't verify the FLASH layout. Note that p.11 of > >> ALT_MiniMonitor_Manual(SPI_Boot)_Rev0.01_e.pdf shows a different > >> FLASH layout for the second and third partition. > > > > Thanks. I see the following in v1.9.6 of the BSP[1]. Is it > > the same as the document you referred to above? > > > > > > partition@0 { > > label = "loader"; > > reg = <0x00000000 0x00080000>; > > read-only; > > }; > > partition@40000 { > > label = "user"; > > reg = <0x00080000 0x00580000>; > > read-only; > > }; > > partition@440000 { > > label = "flash"; > > reg = <0x00600000 0x03a00000>; > > }; > > > > > > [1] https://git.kernel.org/cgit/linux/kernel/git/horms/renesas-backport.git/tree/arch/arm/boot/dts/r8a7794-alt.dts?h=rcar-gen2/v1.9.6&idáacbe074f36d96e901bf5346c50ee51da2ced42#n379 > > No, the document specifies 3 partitions: > - SA0: loader program area, 16 KiB, > - SA1: System area, 16 KiB, > - SA2: User program area, remainder. > > FWIW, the unit addresses in the device nodes above are not consistent > with their reg properties. My feeling is that we should follow the documentation. Does this reflect the scheme it describes? partitions { #address-cells = <1>; #size-cells = <1>; partition@0 { label = "loader"; reg = <0x00000000 0x00004000>; read-only; }; partition@4000 { label = "system"; reg = <0x00004000 0x00004000>; read-only; }; partition@8000 { label = "user"; reg = <0x00008000 0x03ff8000>; }; }; ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH] ARM: shmobile: alt: Add QSPI device to DT @ 2015-12-18 2:54 ` Simon Horman 0 siblings, 0 replies; 18+ messages in thread From: Simon Horman @ 2015-12-18 2:54 UTC (permalink / raw) To: linux-arm-kernel On Tue, Dec 01, 2015 at 09:06:17AM +0100, Geert Uytterhoeven wrote: > Hi Simon, > > On Tue, Dec 1, 2015 at 7:41 AM, Simon Horman <horms@verge.net.au> wrote: > > On Mon, Nov 30, 2015 at 09:34:10AM +0100, Geert Uytterhoeven wrote: > >> On Mon, Nov 30, 2015 at 7:13 AM, Simon Horman > >> <horms+renesas@verge.net.au> wrote: > >> > Enable the QSPI controller in the alt device tree. > >> > > >> > Based similar work for the silk board by by Vladimir Barinov and > >> > Sergei Shtylyov. > >> > > >> > Cc: Vladimir Barinov <vladimir.barinov@cogentembedded.com> > >> > Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > >> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > >> > >> Verified against Alt schematics and r8a7794 datasheet. > >> > >> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> > >> > >> I can't verify the FLASH layout. Note that p.11 of > >> ALT_MiniMonitor_Manual(SPI_Boot)_Rev0.01_e.pdf shows a different > >> FLASH layout for the second and third partition. > > > > Thanks. I see the following in v1.9.6 of the BSP[1]. Is it > > the same as the document you referred to above? > > > > > > partition at 0 { > > label = "loader"; > > reg = <0x00000000 0x00080000>; > > read-only; > > }; > > partition at 40000 { > > label = "user"; > > reg = <0x00080000 0x00580000>; > > read-only; > > }; > > partition at 440000 { > > label = "flash"; > > reg = <0x00600000 0x03a00000>; > > }; > > > > > > [1] https://git.kernel.org/cgit/linux/kernel/git/horms/renesas-backport.git/tree/arch/arm/boot/dts/r8a7794-alt.dts?h=rcar-gen2/v1.9.6&id=e1acbe074f36d96e901bf5346c50ee51da2ced42#n379 > > No, the document specifies 3 partitions: > - SA0: loader program area, 16 KiB, > - SA1: System area, 16 KiB, > - SA2: User program area, remainder. > > FWIW, the unit addresses in the device nodes above are not consistent > with their reg properties. My feeling is that we should follow the documentation. Does this reflect the scheme it describes? partitions { #address-cells = <1>; #size-cells = <1>; partition at 0 { label = "loader"; reg = <0x00000000 0x00004000>; read-only; }; partition at 4000 { label = "system"; reg = <0x00004000 0x00004000>; read-only; }; partition at 8000 { label = "user"; reg = <0x00008000 0x03ff8000>; }; }; ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] ARM: shmobile: alt: Add QSPI device to DT 2015-12-18 2:54 ` Simon Horman @ 2015-12-18 10:07 ` Geert Uytterhoeven -1 siblings, 0 replies; 18+ messages in thread From: Geert Uytterhoeven @ 2015-12-18 10:07 UTC (permalink / raw) To: linux-arm-kernel Hi Simon, On Fri, Dec 18, 2015 at 3:54 AM, Simon Horman <horms@verge.net.au> wrote: > On Tue, Dec 01, 2015 at 09:06:17AM +0100, Geert Uytterhoeven wrote: >> On Tue, Dec 1, 2015 at 7:41 AM, Simon Horman <horms@verge.net.au> wrote: >> > On Mon, Nov 30, 2015 at 09:34:10AM +0100, Geert Uytterhoeven wrote: >> >> On Mon, Nov 30, 2015 at 7:13 AM, Simon Horman >> >> <horms+renesas@verge.net.au> wrote: >> >> > Enable the QSPI controller in the alt device tree. >> >> > >> >> > Based similar work for the silk board by by Vladimir Barinov and >> >> > Sergei Shtylyov. >> >> > >> >> > Cc: Vladimir Barinov <vladimir.barinov@cogentembedded.com> >> >> > Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >> >> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> >> >> >> >> Verified against Alt schematics and r8a7794 datasheet. >> >> >> >> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> >> >> >> >> I can't verify the FLASH layout. Note that p.11 of >> >> ALT_MiniMonitor_Manual(SPI_Boot)_Rev0.01_e.pdf shows a different >> >> FLASH layout for the second and third partition. >> > >> > Thanks. I see the following in v1.9.6 of the BSP[1]. Is it >> > the same as the document you referred to above? >> > >> > >> > partition@0 { >> > label = "loader"; >> > reg = <0x00000000 0x00080000>; >> > read-only; >> > }; >> > partition@40000 { >> > label = "user"; >> > reg = <0x00080000 0x00580000>; >> > read-only; >> > }; >> > partition@440000 { >> > label = "flash"; >> > reg = <0x00600000 0x03a00000>; >> > }; >> > >> > >> > [1] https://git.kernel.org/cgit/linux/kernel/git/horms/renesas-backport.git/tree/arch/arm/boot/dts/r8a7794-alt.dts?h=rcar-gen2/v1.9.6&idáacbe074f36d96e901bf5346c50ee51da2ced42#n379 >> >> No, the document specifies 3 partitions: >> - SA0: loader program area, 16 KiB, Sorry, I missed a "Not used" part after that, and started miscounting zeroes on top of that :-( So the loader consumes 16 KiB out of the 256 KiB SA0 partition. >> - SA1: System area, 16 KiB, Should be 256 KiB. >> - SA2: User program area, remainder. >> >> FWIW, the unit addresses in the device nodes above are not consistent >> with their reg properties. > > My feeling is that we should follow the documentation. > Does this reflect the scheme it describes? > > > partitions { > #address-cells = <1>; > #size-cells = <1>; > > partition@0 { > label = "loader"; > reg = <0x00000000 0x00004000>; reg = <0x00000000 0x00040000>; > read-only; > }; > partition@4000 { partition@40000 > label = "system"; > reg = <0x00004000 0x00004000>; reg = <0x00040000 0x00040000>; > read-only; > }; > partition@8000 { partition@80000 > label = "user"; > reg = <0x00008000 0x03ff8000>; reg = <0x00080000 0x03f80000>; > }; > }; I don't have an ALT. Does this match with the actual FLASH contents? Sorry for the wreck on my side. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH] ARM: shmobile: alt: Add QSPI device to DT @ 2015-12-18 10:07 ` Geert Uytterhoeven 0 siblings, 0 replies; 18+ messages in thread From: Geert Uytterhoeven @ 2015-12-18 10:07 UTC (permalink / raw) To: linux-arm-kernel Hi Simon, On Fri, Dec 18, 2015 at 3:54 AM, Simon Horman <horms@verge.net.au> wrote: > On Tue, Dec 01, 2015 at 09:06:17AM +0100, Geert Uytterhoeven wrote: >> On Tue, Dec 1, 2015 at 7:41 AM, Simon Horman <horms@verge.net.au> wrote: >> > On Mon, Nov 30, 2015 at 09:34:10AM +0100, Geert Uytterhoeven wrote: >> >> On Mon, Nov 30, 2015 at 7:13 AM, Simon Horman >> >> <horms+renesas@verge.net.au> wrote: >> >> > Enable the QSPI controller in the alt device tree. >> >> > >> >> > Based similar work for the silk board by by Vladimir Barinov and >> >> > Sergei Shtylyov. >> >> > >> >> > Cc: Vladimir Barinov <vladimir.barinov@cogentembedded.com> >> >> > Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >> >> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> >> >> >> >> Verified against Alt schematics and r8a7794 datasheet. >> >> >> >> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> >> >> >> >> I can't verify the FLASH layout. Note that p.11 of >> >> ALT_MiniMonitor_Manual(SPI_Boot)_Rev0.01_e.pdf shows a different >> >> FLASH layout for the second and third partition. >> > >> > Thanks. I see the following in v1.9.6 of the BSP[1]. Is it >> > the same as the document you referred to above? >> > >> > >> > partition at 0 { >> > label = "loader"; >> > reg = <0x00000000 0x00080000>; >> > read-only; >> > }; >> > partition at 40000 { >> > label = "user"; >> > reg = <0x00080000 0x00580000>; >> > read-only; >> > }; >> > partition at 440000 { >> > label = "flash"; >> > reg = <0x00600000 0x03a00000>; >> > }; >> > >> > >> > [1] https://git.kernel.org/cgit/linux/kernel/git/horms/renesas-backport.git/tree/arch/arm/boot/dts/r8a7794-alt.dts?h=rcar-gen2/v1.9.6&id=e1acbe074f36d96e901bf5346c50ee51da2ced42#n379 >> >> No, the document specifies 3 partitions: >> - SA0: loader program area, 16 KiB, Sorry, I missed a "Not used" part after that, and started miscounting zeroes on top of that :-( So the loader consumes 16 KiB out of the 256 KiB SA0 partition. >> - SA1: System area, 16 KiB, Should be 256 KiB. >> - SA2: User program area, remainder. >> >> FWIW, the unit addresses in the device nodes above are not consistent >> with their reg properties. > > My feeling is that we should follow the documentation. > Does this reflect the scheme it describes? > > > partitions { > #address-cells = <1>; > #size-cells = <1>; > > partition at 0 { > label = "loader"; > reg = <0x00000000 0x00004000>; reg = <0x00000000 0x00040000>; > read-only; > }; > partition at 4000 { partition at 40000 > label = "system"; > reg = <0x00004000 0x00004000>; reg = <0x00040000 0x00040000>; > read-only; > }; > partition at 8000 { partition at 80000 > label = "user"; > reg = <0x00008000 0x03ff8000>; reg = <0x00080000 0x03f80000>; > }; > }; I don't have an ALT. Does this match with the actual FLASH contents? Sorry for the wreck on my side. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] ARM: shmobile: alt: Add QSPI device to DT 2015-12-18 10:07 ` Geert Uytterhoeven @ 2016-01-03 21:07 ` Simon Horman -1 siblings, 0 replies; 18+ messages in thread From: Simon Horman @ 2016-01-03 21:07 UTC (permalink / raw) To: linux-arm-kernel On Fri, Dec 18, 2015 at 11:07:23AM +0100, Geert Uytterhoeven wrote: > Hi Simon, > > On Fri, Dec 18, 2015 at 3:54 AM, Simon Horman <horms@verge.net.au> wrote: > > On Tue, Dec 01, 2015 at 09:06:17AM +0100, Geert Uytterhoeven wrote: > >> On Tue, Dec 1, 2015 at 7:41 AM, Simon Horman <horms@verge.net.au> wrote: > >> > On Mon, Nov 30, 2015 at 09:34:10AM +0100, Geert Uytterhoeven wrote: > >> >> On Mon, Nov 30, 2015 at 7:13 AM, Simon Horman > >> >> <horms+renesas@verge.net.au> wrote: > >> >> > Enable the QSPI controller in the alt device tree. > >> >> > > >> >> > Based similar work for the silk board by by Vladimir Barinov and > >> >> > Sergei Shtylyov. > >> >> > > >> >> > Cc: Vladimir Barinov <vladimir.barinov@cogentembedded.com> > >> >> > Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > >> >> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > >> >> > >> >> Verified against Alt schematics and r8a7794 datasheet. > >> >> > >> >> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> > >> >> > >> >> I can't verify the FLASH layout. Note that p.11 of > >> >> ALT_MiniMonitor_Manual(SPI_Boot)_Rev0.01_e.pdf shows a different > >> >> FLASH layout for the second and third partition. > >> > > >> > Thanks. I see the following in v1.9.6 of the BSP[1]. Is it > >> > the same as the document you referred to above? > >> > > >> > > >> > partition@0 { > >> > label = "loader"; > >> > reg = <0x00000000 0x00080000>; > >> > read-only; > >> > }; > >> > partition@40000 { > >> > label = "user"; > >> > reg = <0x00080000 0x00580000>; > >> > read-only; > >> > }; > >> > partition@440000 { > >> > label = "flash"; > >> > reg = <0x00600000 0x03a00000>; > >> > }; > >> > > >> > > >> > [1] https://git.kernel.org/cgit/linux/kernel/git/horms/renesas-backport.git/tree/arch/arm/boot/dts/r8a7794-alt.dts?h=rcar-gen2/v1.9.6&idáacbe074f36d96e901bf5346c50ee51da2ced42#n379 > >> > >> No, the document specifies 3 partitions: > >> - SA0: loader program area, 16 KiB, > > Sorry, I missed a "Not used" part after that, and started miscounting zeroes > on top of that :-( > > So the loader consumes 16 KiB out of the 256 KiB SA0 partition. > > >> - SA1: System area, 16 KiB, > > Should be 256 KiB. > > >> - SA2: User program area, remainder. > >> > >> FWIW, the unit addresses in the device nodes above are not consistent > >> with their reg properties. > > > > My feeling is that we should follow the documentation. > > Does this reflect the scheme it describes? > > > > > > partitions { > > #address-cells = <1>; > > #size-cells = <1>; > > > > partition@0 { > > label = "loader"; > > reg = <0x00000000 0x00004000>; > > reg = <0x00000000 0x00040000>; > > > read-only; > > }; > > partition@4000 { > > partition@40000 > > > label = "system"; > > reg = <0x00004000 0x00004000>; > > reg = <0x00040000 0x00040000>; > > > read-only; > > }; > > partition@8000 { > > partition@80000 > > > label = "user"; > > reg = <0x00008000 0x03ff8000>; > > reg = <0x00080000 0x03f80000>; > > > }; > > }; > > I don't have an ALT. Does this match with the actual FLASH contents? I'm a little unsure how to verify that. > Sorry for the wreck on my side. No problem. ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH] ARM: shmobile: alt: Add QSPI device to DT @ 2016-01-03 21:07 ` Simon Horman 0 siblings, 0 replies; 18+ messages in thread From: Simon Horman @ 2016-01-03 21:07 UTC (permalink / raw) To: linux-arm-kernel On Fri, Dec 18, 2015 at 11:07:23AM +0100, Geert Uytterhoeven wrote: > Hi Simon, > > On Fri, Dec 18, 2015 at 3:54 AM, Simon Horman <horms@verge.net.au> wrote: > > On Tue, Dec 01, 2015 at 09:06:17AM +0100, Geert Uytterhoeven wrote: > >> On Tue, Dec 1, 2015 at 7:41 AM, Simon Horman <horms@verge.net.au> wrote: > >> > On Mon, Nov 30, 2015 at 09:34:10AM +0100, Geert Uytterhoeven wrote: > >> >> On Mon, Nov 30, 2015 at 7:13 AM, Simon Horman > >> >> <horms+renesas@verge.net.au> wrote: > >> >> > Enable the QSPI controller in the alt device tree. > >> >> > > >> >> > Based similar work for the silk board by by Vladimir Barinov and > >> >> > Sergei Shtylyov. > >> >> > > >> >> > Cc: Vladimir Barinov <vladimir.barinov@cogentembedded.com> > >> >> > Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > >> >> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > >> >> > >> >> Verified against Alt schematics and r8a7794 datasheet. > >> >> > >> >> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> > >> >> > >> >> I can't verify the FLASH layout. Note that p.11 of > >> >> ALT_MiniMonitor_Manual(SPI_Boot)_Rev0.01_e.pdf shows a different > >> >> FLASH layout for the second and third partition. > >> > > >> > Thanks. I see the following in v1.9.6 of the BSP[1]. Is it > >> > the same as the document you referred to above? > >> > > >> > > >> > partition at 0 { > >> > label = "loader"; > >> > reg = <0x00000000 0x00080000>; > >> > read-only; > >> > }; > >> > partition at 40000 { > >> > label = "user"; > >> > reg = <0x00080000 0x00580000>; > >> > read-only; > >> > }; > >> > partition at 440000 { > >> > label = "flash"; > >> > reg = <0x00600000 0x03a00000>; > >> > }; > >> > > >> > > >> > [1] https://git.kernel.org/cgit/linux/kernel/git/horms/renesas-backport.git/tree/arch/arm/boot/dts/r8a7794-alt.dts?h=rcar-gen2/v1.9.6&id=e1acbe074f36d96e901bf5346c50ee51da2ced42#n379 > >> > >> No, the document specifies 3 partitions: > >> - SA0: loader program area, 16 KiB, > > Sorry, I missed a "Not used" part after that, and started miscounting zeroes > on top of that :-( > > So the loader consumes 16 KiB out of the 256 KiB SA0 partition. > > >> - SA1: System area, 16 KiB, > > Should be 256 KiB. > > >> - SA2: User program area, remainder. > >> > >> FWIW, the unit addresses in the device nodes above are not consistent > >> with their reg properties. > > > > My feeling is that we should follow the documentation. > > Does this reflect the scheme it describes? > > > > > > partitions { > > #address-cells = <1>; > > #size-cells = <1>; > > > > partition at 0 { > > label = "loader"; > > reg = <0x00000000 0x00004000>; > > reg = <0x00000000 0x00040000>; > > > read-only; > > }; > > partition at 4000 { > > partition at 40000 > > > label = "system"; > > reg = <0x00004000 0x00004000>; > > reg = <0x00040000 0x00040000>; > > > read-only; > > }; > > partition at 8000 { > > partition at 80000 > > > label = "user"; > > reg = <0x00008000 0x03ff8000>; > > reg = <0x00080000 0x03f80000>; > > > }; > > }; > > I don't have an ALT. Does this match with the actual FLASH contents? I'm a little unsure how to verify that. > Sorry for the wreck on my side. No problem. ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] ARM: shmobile: alt: Add QSPI device to DT 2016-01-03 21:07 ` Simon Horman @ 2016-01-04 8:59 ` Geert Uytterhoeven -1 siblings, 0 replies; 18+ messages in thread From: Geert Uytterhoeven @ 2016-01-04 8:59 UTC (permalink / raw) To: linux-arm-kernel Hi Simon, On Sun, Jan 3, 2016 at 10:07 PM, Simon Horman <horms@verge.net.au> wrote: > On Fri, Dec 18, 2015 at 11:07:23AM +0100, Geert Uytterhoeven wrote: >> On Fri, Dec 18, 2015 at 3:54 AM, Simon Horman <horms@verge.net.au> wrote: >> > On Tue, Dec 01, 2015 at 09:06:17AM +0100, Geert Uytterhoeven wrote: >> >> On Tue, Dec 1, 2015 at 7:41 AM, Simon Horman <horms@verge.net.au> wrote: >> >> > On Mon, Nov 30, 2015 at 09:34:10AM +0100, Geert Uytterhoeven wrote: >> >> >> On Mon, Nov 30, 2015 at 7:13 AM, Simon Horman >> >> >> <horms+renesas@verge.net.au> wrote: >> >> >> > Enable the QSPI controller in the alt device tree. >> >> >> > >> >> >> > Based similar work for the silk board by by Vladimir Barinov and >> >> >> > Sergei Shtylyov. >> >> >> > >> >> >> > Cc: Vladimir Barinov <vladimir.barinov@cogentembedded.com> >> >> >> > Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >> >> >> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> >> >> >> >> >> >> Verified against Alt schematics and r8a7794 datasheet. >> >> >> >> >> >> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> >> >> >> >> >> >> I can't verify the FLASH layout. Note that p.11 of >> >> >> ALT_MiniMonitor_Manual(SPI_Boot)_Rev0.01_e.pdf shows a different >> >> >> FLASH layout for the second and third partition. >> >> > >> >> > Thanks. I see the following in v1.9.6 of the BSP[1]. Is it >> >> > the same as the document you referred to above? >> >> > >> >> > >> >> > partition@0 { >> >> > label = "loader"; >> >> > reg = <0x00000000 0x00080000>; >> >> > read-only; >> >> > }; >> >> > partition@40000 { >> >> > label = "user"; >> >> > reg = <0x00080000 0x00580000>; >> >> > read-only; >> >> > }; >> >> > partition@440000 { >> >> > label = "flash"; >> >> > reg = <0x00600000 0x03a00000>; >> >> > }; >> >> > >> >> > >> >> > [1] https://git.kernel.org/cgit/linux/kernel/git/horms/renesas-backport.git/tree/arch/arm/boot/dts/r8a7794-alt.dts?h=rcar-gen2/v1.9.6&idáacbe074f36d96e901bf5346c50ee51da2ced42#n379 >> >> >> >> No, the document specifies 3 partitions: >> >> - SA0: loader program area, 16 KiB, >> >> Sorry, I missed a "Not used" part after that, and started miscounting zeroes >> on top of that :-( >> >> So the loader consumes 16 KiB out of the 256 KiB SA0 partition. >> >> >> - SA1: System area, 16 KiB, >> >> Should be 256 KiB. >> >> >> - SA2: User program area, remainder. >> >> >> >> FWIW, the unit addresses in the device nodes above are not consistent >> >> with their reg properties. >> > >> > My feeling is that we should follow the documentation. >> > Does this reflect the scheme it describes? >> > >> > >> > partitions { >> > #address-cells = <1>; >> > #size-cells = <1>; >> > >> > partition@0 { >> > label = "loader"; >> > reg = <0x00000000 0x00004000>; >> >> reg = <0x00000000 0x00040000>; >> >> > read-only; >> > }; >> > partition@4000 { >> >> partition@40000 >> >> > label = "system"; >> > reg = <0x00004000 0x00004000>; >> >> reg = <0x00040000 0x00040000>; >> >> > read-only; >> > }; >> > partition@8000 { >> >> partition@80000 >> >> > label = "user"; >> > reg = <0x00008000 0x03ff8000>; >> >> reg = <0x00080000 0x03f80000>; >> >> > }; >> > }; >> >> I don't have an ALT. Does this match with the actual FLASH contents? > > I'm a little unsure how to verify that. Usually the FLASH is empty (all ones) at the end of each partition. Hence "dd if=/dev/mtd0 bs\x16M | hd | less" should report lots of identical lines of data. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH] ARM: shmobile: alt: Add QSPI device to DT @ 2016-01-04 8:59 ` Geert Uytterhoeven 0 siblings, 0 replies; 18+ messages in thread From: Geert Uytterhoeven @ 2016-01-04 8:59 UTC (permalink / raw) To: linux-arm-kernel Hi Simon, On Sun, Jan 3, 2016 at 10:07 PM, Simon Horman <horms@verge.net.au> wrote: > On Fri, Dec 18, 2015 at 11:07:23AM +0100, Geert Uytterhoeven wrote: >> On Fri, Dec 18, 2015 at 3:54 AM, Simon Horman <horms@verge.net.au> wrote: >> > On Tue, Dec 01, 2015 at 09:06:17AM +0100, Geert Uytterhoeven wrote: >> >> On Tue, Dec 1, 2015 at 7:41 AM, Simon Horman <horms@verge.net.au> wrote: >> >> > On Mon, Nov 30, 2015 at 09:34:10AM +0100, Geert Uytterhoeven wrote: >> >> >> On Mon, Nov 30, 2015 at 7:13 AM, Simon Horman >> >> >> <horms+renesas@verge.net.au> wrote: >> >> >> > Enable the QSPI controller in the alt device tree. >> >> >> > >> >> >> > Based similar work for the silk board by by Vladimir Barinov and >> >> >> > Sergei Shtylyov. >> >> >> > >> >> >> > Cc: Vladimir Barinov <vladimir.barinov@cogentembedded.com> >> >> >> > Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >> >> >> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> >> >> >> >> >> >> Verified against Alt schematics and r8a7794 datasheet. >> >> >> >> >> >> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> >> >> >> >> >> >> I can't verify the FLASH layout. Note that p.11 of >> >> >> ALT_MiniMonitor_Manual(SPI_Boot)_Rev0.01_e.pdf shows a different >> >> >> FLASH layout for the second and third partition. >> >> > >> >> > Thanks. I see the following in v1.9.6 of the BSP[1]. Is it >> >> > the same as the document you referred to above? >> >> > >> >> > >> >> > partition at 0 { >> >> > label = "loader"; >> >> > reg = <0x00000000 0x00080000>; >> >> > read-only; >> >> > }; >> >> > partition at 40000 { >> >> > label = "user"; >> >> > reg = <0x00080000 0x00580000>; >> >> > read-only; >> >> > }; >> >> > partition at 440000 { >> >> > label = "flash"; >> >> > reg = <0x00600000 0x03a00000>; >> >> > }; >> >> > >> >> > >> >> > [1] https://git.kernel.org/cgit/linux/kernel/git/horms/renesas-backport.git/tree/arch/arm/boot/dts/r8a7794-alt.dts?h=rcar-gen2/v1.9.6&id=e1acbe074f36d96e901bf5346c50ee51da2ced42#n379 >> >> >> >> No, the document specifies 3 partitions: >> >> - SA0: loader program area, 16 KiB, >> >> Sorry, I missed a "Not used" part after that, and started miscounting zeroes >> on top of that :-( >> >> So the loader consumes 16 KiB out of the 256 KiB SA0 partition. >> >> >> - SA1: System area, 16 KiB, >> >> Should be 256 KiB. >> >> >> - SA2: User program area, remainder. >> >> >> >> FWIW, the unit addresses in the device nodes above are not consistent >> >> with their reg properties. >> > >> > My feeling is that we should follow the documentation. >> > Does this reflect the scheme it describes? >> > >> > >> > partitions { >> > #address-cells = <1>; >> > #size-cells = <1>; >> > >> > partition at 0 { >> > label = "loader"; >> > reg = <0x00000000 0x00004000>; >> >> reg = <0x00000000 0x00040000>; >> >> > read-only; >> > }; >> > partition at 4000 { >> >> partition at 40000 >> >> > label = "system"; >> > reg = <0x00004000 0x00004000>; >> >> reg = <0x00040000 0x00040000>; >> >> > read-only; >> > }; >> > partition at 8000 { >> >> partition at 80000 >> >> > label = "user"; >> > reg = <0x00008000 0x03ff8000>; >> >> reg = <0x00080000 0x03f80000>; >> >> > }; >> > }; >> >> I don't have an ALT. Does this match with the actual FLASH contents? > > I'm a little unsure how to verify that. Usually the FLASH is empty (all ones) at the end of each partition. Hence "dd if=/dev/mtd0 bs=16M | hd | less" should report lots of identical lines of data. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] ARM: shmobile: alt: Add QSPI device to DT 2016-01-04 8:59 ` Geert Uytterhoeven @ 2016-01-04 10:35 ` Simon Horman -1 siblings, 0 replies; 18+ messages in thread From: Simon Horman @ 2016-01-04 10:35 UTC (permalink / raw) To: linux-arm-kernel On Mon, Jan 04, 2016 at 09:59:13AM +0100, Geert Uytterhoeven wrote: > Hi Simon, > > On Sun, Jan 3, 2016 at 10:07 PM, Simon Horman <horms@verge.net.au> wrote: > > On Fri, Dec 18, 2015 at 11:07:23AM +0100, Geert Uytterhoeven wrote: > >> On Fri, Dec 18, 2015 at 3:54 AM, Simon Horman <horms@verge.net.au> wrote: > >> > On Tue, Dec 01, 2015 at 09:06:17AM +0100, Geert Uytterhoeven wrote: > >> >> On Tue, Dec 1, 2015 at 7:41 AM, Simon Horman <horms@verge.net.au> wrote: > >> >> > On Mon, Nov 30, 2015 at 09:34:10AM +0100, Geert Uytterhoeven wrote: > >> >> >> On Mon, Nov 30, 2015 at 7:13 AM, Simon Horman > >> >> >> <horms+renesas@verge.net.au> wrote: > >> >> >> > Enable the QSPI controller in the alt device tree. > >> >> >> > > >> >> >> > Based similar work for the silk board by by Vladimir Barinov and > >> >> >> > Sergei Shtylyov. > >> >> >> > > >> >> >> > Cc: Vladimir Barinov <vladimir.barinov@cogentembedded.com> > >> >> >> > Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > >> >> >> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > >> >> >> > >> >> >> Verified against Alt schematics and r8a7794 datasheet. > >> >> >> > >> >> >> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> > >> >> >> > >> >> >> I can't verify the FLASH layout. Note that p.11 of > >> >> >> ALT_MiniMonitor_Manual(SPI_Boot)_Rev0.01_e.pdf shows a different > >> >> >> FLASH layout for the second and third partition. > >> >> > > >> >> > Thanks. I see the following in v1.9.6 of the BSP[1]. Is it > >> >> > the same as the document you referred to above? > >> >> > > >> >> > > >> >> > partition@0 { > >> >> > label = "loader"; > >> >> > reg = <0x00000000 0x00080000>; > >> >> > read-only; > >> >> > }; > >> >> > partition@40000 { > >> >> > label = "user"; > >> >> > reg = <0x00080000 0x00580000>; > >> >> > read-only; > >> >> > }; > >> >> > partition@440000 { > >> >> > label = "flash"; > >> >> > reg = <0x00600000 0x03a00000>; > >> >> > }; > >> >> > > >> >> > > >> >> > [1] https://git.kernel.org/cgit/linux/kernel/git/horms/renesas-backport.git/tree/arch/arm/boot/dts/r8a7794-alt.dts?h=rcar-gen2/v1.9.6&idáacbe074f36d96e901bf5346c50ee51da2ced42#n379 > >> >> > >> >> No, the document specifies 3 partitions: > >> >> - SA0: loader program area, 16 KiB, > >> > >> Sorry, I missed a "Not used" part after that, and started miscounting zeroes > >> on top of that :-( > >> > >> So the loader consumes 16 KiB out of the 256 KiB SA0 partition. > >> > >> >> - SA1: System area, 16 KiB, > >> > >> Should be 256 KiB. > >> > >> >> - SA2: User program area, remainder. > >> >> > >> >> FWIW, the unit addresses in the device nodes above are not consistent > >> >> with their reg properties. > >> > > >> > My feeling is that we should follow the documentation. > >> > Does this reflect the scheme it describes? > >> > > >> > > >> > partitions { > >> > #address-cells = <1>; > >> > #size-cells = <1>; > >> > > >> > partition@0 { > >> > label = "loader"; > >> > reg = <0x00000000 0x00004000>; > >> > >> reg = <0x00000000 0x00040000>; > >> > >> > read-only; > >> > }; > >> > partition@4000 { > >> > >> partition@40000 > >> > >> > label = "system"; > >> > reg = <0x00004000 0x00004000>; > >> > >> reg = <0x00040000 0x00040000>; > >> > >> > read-only; > >> > }; > >> > partition@8000 { > >> > >> partition@80000 > >> > >> > label = "user"; > >> > reg = <0x00008000 0x03ff8000>; > >> > >> reg = <0x00080000 0x03f80000>; > >> > >> > }; > >> > }; > >> > >> I don't have an ALT. Does this match with the actual FLASH contents? > > > > I'm a little unsure how to verify that. > > Usually the FLASH is empty (all ones) at the end of each partition. > > Hence "dd if=/dev/mtd0 bs\x16M | hd | less" should report lots of > identical lines of > data. Thanks. I do see some non-ones followed by ones at the end of the partition. I will post v2 with the above partitioning scheme. ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH] ARM: shmobile: alt: Add QSPI device to DT @ 2016-01-04 10:35 ` Simon Horman 0 siblings, 0 replies; 18+ messages in thread From: Simon Horman @ 2016-01-04 10:35 UTC (permalink / raw) To: linux-arm-kernel On Mon, Jan 04, 2016 at 09:59:13AM +0100, Geert Uytterhoeven wrote: > Hi Simon, > > On Sun, Jan 3, 2016 at 10:07 PM, Simon Horman <horms@verge.net.au> wrote: > > On Fri, Dec 18, 2015 at 11:07:23AM +0100, Geert Uytterhoeven wrote: > >> On Fri, Dec 18, 2015 at 3:54 AM, Simon Horman <horms@verge.net.au> wrote: > >> > On Tue, Dec 01, 2015 at 09:06:17AM +0100, Geert Uytterhoeven wrote: > >> >> On Tue, Dec 1, 2015 at 7:41 AM, Simon Horman <horms@verge.net.au> wrote: > >> >> > On Mon, Nov 30, 2015 at 09:34:10AM +0100, Geert Uytterhoeven wrote: > >> >> >> On Mon, Nov 30, 2015 at 7:13 AM, Simon Horman > >> >> >> <horms+renesas@verge.net.au> wrote: > >> >> >> > Enable the QSPI controller in the alt device tree. > >> >> >> > > >> >> >> > Based similar work for the silk board by by Vladimir Barinov and > >> >> >> > Sergei Shtylyov. > >> >> >> > > >> >> >> > Cc: Vladimir Barinov <vladimir.barinov@cogentembedded.com> > >> >> >> > Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > >> >> >> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > >> >> >> > >> >> >> Verified against Alt schematics and r8a7794 datasheet. > >> >> >> > >> >> >> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> > >> >> >> > >> >> >> I can't verify the FLASH layout. Note that p.11 of > >> >> >> ALT_MiniMonitor_Manual(SPI_Boot)_Rev0.01_e.pdf shows a different > >> >> >> FLASH layout for the second and third partition. > >> >> > > >> >> > Thanks. I see the following in v1.9.6 of the BSP[1]. Is it > >> >> > the same as the document you referred to above? > >> >> > > >> >> > > >> >> > partition at 0 { > >> >> > label = "loader"; > >> >> > reg = <0x00000000 0x00080000>; > >> >> > read-only; > >> >> > }; > >> >> > partition at 40000 { > >> >> > label = "user"; > >> >> > reg = <0x00080000 0x00580000>; > >> >> > read-only; > >> >> > }; > >> >> > partition at 440000 { > >> >> > label = "flash"; > >> >> > reg = <0x00600000 0x03a00000>; > >> >> > }; > >> >> > > >> >> > > >> >> > [1] https://git.kernel.org/cgit/linux/kernel/git/horms/renesas-backport.git/tree/arch/arm/boot/dts/r8a7794-alt.dts?h=rcar-gen2/v1.9.6&id=e1acbe074f36d96e901bf5346c50ee51da2ced42#n379 > >> >> > >> >> No, the document specifies 3 partitions: > >> >> - SA0: loader program area, 16 KiB, > >> > >> Sorry, I missed a "Not used" part after that, and started miscounting zeroes > >> on top of that :-( > >> > >> So the loader consumes 16 KiB out of the 256 KiB SA0 partition. > >> > >> >> - SA1: System area, 16 KiB, > >> > >> Should be 256 KiB. > >> > >> >> - SA2: User program area, remainder. > >> >> > >> >> FWIW, the unit addresses in the device nodes above are not consistent > >> >> with their reg properties. > >> > > >> > My feeling is that we should follow the documentation. > >> > Does this reflect the scheme it describes? > >> > > >> > > >> > partitions { > >> > #address-cells = <1>; > >> > #size-cells = <1>; > >> > > >> > partition at 0 { > >> > label = "loader"; > >> > reg = <0x00000000 0x00004000>; > >> > >> reg = <0x00000000 0x00040000>; > >> > >> > read-only; > >> > }; > >> > partition at 4000 { > >> > >> partition at 40000 > >> > >> > label = "system"; > >> > reg = <0x00004000 0x00004000>; > >> > >> reg = <0x00040000 0x00040000>; > >> > >> > read-only; > >> > }; > >> > partition at 8000 { > >> > >> partition at 80000 > >> > >> > label = "user"; > >> > reg = <0x00008000 0x03ff8000>; > >> > >> reg = <0x00080000 0x03f80000>; > >> > >> > }; > >> > }; > >> > >> I don't have an ALT. Does this match with the actual FLASH contents? > > > > I'm a little unsure how to verify that. > > Usually the FLASH is empty (all ones) at the end of each partition. > > Hence "dd if=/dev/mtd0 bs=16M | hd | less" should report lots of > identical lines of > data. Thanks. I do see some non-ones followed by ones at the end of the partition. I will post v2 with the above partitioning scheme. ^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2016-01-04 10:35 UTC | newest] Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2015-11-30 6:13 [PATCH] ARM: shmobile: alt: Add QSPI device to DT Simon Horman 2015-11-30 6:13 ` Simon Horman 2015-11-30 8:34 ` Geert Uytterhoeven 2015-11-30 8:34 ` Geert Uytterhoeven 2015-12-01 6:41 ` Simon Horman 2015-12-01 6:41 ` Simon Horman 2015-12-01 8:06 ` Geert Uytterhoeven 2015-12-01 8:06 ` Geert Uytterhoeven 2015-12-18 2:54 ` Simon Horman 2015-12-18 2:54 ` Simon Horman 2015-12-18 10:07 ` Geert Uytterhoeven 2015-12-18 10:07 ` Geert Uytterhoeven 2016-01-03 21:07 ` Simon Horman 2016-01-03 21:07 ` Simon Horman 2016-01-04 8:59 ` Geert Uytterhoeven 2016-01-04 8:59 ` Geert Uytterhoeven 2016-01-04 10:35 ` Simon Horman 2016-01-04 10:35 ` Simon Horman
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.