From: Jaegeuk Kim <jaegeuk@kernel.org> To: Chao Yu <chao2.yu@samsung.com> Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH] f2fs: should unset atomic flag after successful commit Date: Mon, 11 Jan 2016 15:32:19 -0800 [thread overview] Message-ID: <20160111233219.GA32106@jaegeuk.granlibakkenguest> (raw) In-Reply-To: <003601d14c41$4f884190$ee98c4b0$@samsung.com> Hi Chao, On Mon, Jan 11, 2016 at 03:25:11PM +0800, Chao Yu wrote: > Hi Jaegeuk, > > > -----Original Message----- > > From: Jaegeuk Kim [mailto:jaegeuk@kernel.org] > > Sent: Sunday, January 10, 2016 9:10 AM > > To: linux-kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org; > > linux-f2fs-devel@lists.sourceforge.net > > Cc: Jaegeuk Kim > > Subject: [f2fs-dev] [PATCH] f2fs: should unset atomic flag after successful commit > > > > If there is an error during commit, we should keep the flag in order to > > abort it. > > > > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> > > --- > > fs/f2fs/file.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c > > index dfaed51..db0b2cb 100644 > > --- a/fs/f2fs/file.c > > +++ b/fs/f2fs/file.c > > @@ -1374,10 +1374,10 @@ static int f2fs_ioc_commit_atomic_write(struct file *filp) > > return ret; > > > > if (f2fs_is_atomic_file(inode)) { > > - clear_inode_flag(F2FS_I(inode), FI_ATOMIC_FILE); > > It was added in 6282adbf932c ("f2fs: call set_page_dirty to attach i_wb for > cgroup ") to avoid panic in kernel with writeback supported cgroup. We > should keep it here. > > > ret = commit_inmem_pages(inode, false); > > if (ret) > > goto err_out; > > + clear_inode_flag(F2FS_I(inode), FI_ATOMIC_FILE); > > How about setting atomic flag if there occurs an error during committing. Got your point. Thanks, > > Thanks, > > > } > > > > ret = f2fs_sync_file(filp, 0, LLONG_MAX, 0); > > -- > > 2.6.3 > > > > > > ------------------------------------------------------------------------------ > > Site24x7 APM Insight: Get Deep Visibility into Application Performance > > APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month > > Monitor end-to-end web transactions and take corrective actions now > > Troubleshoot faster and improve end-user experience. Signup Now! > > http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140 > > _______________________________________________ > > Linux-f2fs-devel mailing list > > Linux-f2fs-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org> To: Chao Yu <chao2.yu@samsung.com> Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCH] f2fs: should unset atomic flag after successful commit Date: Mon, 11 Jan 2016 15:32:19 -0800 [thread overview] Message-ID: <20160111233219.GA32106@jaegeuk.granlibakkenguest> (raw) In-Reply-To: <003601d14c41$4f884190$ee98c4b0$@samsung.com> Hi Chao, On Mon, Jan 11, 2016 at 03:25:11PM +0800, Chao Yu wrote: > Hi Jaegeuk, > > > -----Original Message----- > > From: Jaegeuk Kim [mailto:jaegeuk@kernel.org] > > Sent: Sunday, January 10, 2016 9:10 AM > > To: linux-kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org; > > linux-f2fs-devel@lists.sourceforge.net > > Cc: Jaegeuk Kim > > Subject: [f2fs-dev] [PATCH] f2fs: should unset atomic flag after successful commit > > > > If there is an error during commit, we should keep the flag in order to > > abort it. > > > > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> > > --- > > fs/f2fs/file.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c > > index dfaed51..db0b2cb 100644 > > --- a/fs/f2fs/file.c > > +++ b/fs/f2fs/file.c > > @@ -1374,10 +1374,10 @@ static int f2fs_ioc_commit_atomic_write(struct file *filp) > > return ret; > > > > if (f2fs_is_atomic_file(inode)) { > > - clear_inode_flag(F2FS_I(inode), FI_ATOMIC_FILE); > > It was added in 6282adbf932c ("f2fs: call set_page_dirty to attach i_wb for > cgroup ") to avoid panic in kernel with writeback supported cgroup. We > should keep it here. > > > ret = commit_inmem_pages(inode, false); > > if (ret) > > goto err_out; > > + clear_inode_flag(F2FS_I(inode), FI_ATOMIC_FILE); > > How about setting atomic flag if there occurs an error during committing. Got your point. Thanks, > > Thanks, > > > } > > > > ret = f2fs_sync_file(filp, 0, LLONG_MAX, 0); > > -- > > 2.6.3 > > > > > > ------------------------------------------------------------------------------ > > Site24x7 APM Insight: Get Deep Visibility into Application Performance > > APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month > > Monitor end-to-end web transactions and take corrective actions now > > Troubleshoot faster and improve end-user experience. Signup Now! > > http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140 > > _______________________________________________ > > Linux-f2fs-devel mailing list > > Linux-f2fs-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
next prev parent reply other threads:[~2016-01-11 23:33 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-01-10 1:10 [PATCH] f2fs: should unset atomic flag after successful commit Jaegeuk Kim 2016-01-11 7:25 ` [f2fs-dev] " Chao Yu 2016-01-11 23:32 ` Jaegeuk Kim [this message] 2016-01-11 23:32 ` Jaegeuk Kim
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160111233219.GA32106@jaegeuk.granlibakkenguest \ --to=jaegeuk@kernel.org \ --cc=chao2.yu@samsung.com \ --cc=linux-f2fs-devel@lists.sourceforge.net \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.